morgan/systemd
1
0
Fork 0
mirror of https://github.com/morgan9e/systemd synced 2026-04-15 08:56:15 +09:00
Code Issues Packages Projects Releases Wiki Activity

network: remove useless loop (#36648)

Browse Source 
In route_metric_can_update() the loop iterates over the metrics, but
skips all indices except for RTAX_MTU.

Replace it with a simple compare.
This commit is contained in:
Matteo Croce
2025-03-08 17:39:09 +01:00
committed by GitHub
parent d9208ff9a4
commit bd0d22c2a5
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/network/networkd-route-metric.c
View File

@@ -75,12 +75,8 @@ bool route_metric_can_update(const RouteMetric *a, const RouteMetric *b, bool ex
if (a->n_metrics != b->n_metrics)
return false;
for (size_t i = 1; i < a->n_metrics; i++) {
if (i != RTAX_MTU)
continue;
if (a->metrics[i] != b->metrics[i])
return false;
}
if (a->n_metrics > RTAX_MTU && a->metrics[RTAX_MTU] != b->metrics[RTAX_MTU])
return false;
return streq_ptr(a->tcp_congestion_control_algo, b->tcp_congestion_control_algo);
}