morgan/systemd
1
0
Fork 0
mirror of https://github.com/morgan9e/systemd synced 2026-04-15 00:47:10 +09:00
Code Issues Packages Projects Releases Wiki Activity

log: add underflow assert guard

Browse Source 
We often use ssize_t in log_error macros, but typically return int
which confuses coverity, as technically there is no guarantee that
int and ssize_t have the same range. Add an assert to enforce it.
This commit is contained in:
Luca Boccassi
2025-10-17 11:27:55 +01:00
committed by Yu Watanabe
parent e9fd2bbfff
commit b62c681b11
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/basic/log.h
View File

@@ -192,15 +192,21 @@ int log_dump_internal(
#if BUILD_MODE_DEVELOPER && !defined(TEST_CODE)
# define ASSERT_NON_ZERO(x) assert((x) != 0)
# define ASSERT_UNDERFLOW(x) assert((x) >= INT_MIN)
#else
# define ASSERT_NON_ZERO(x)
# define ASSERT_UNDERFLOW(x)
#endif
/* We often call log macros with ssize_t instead of int, so check for underflows,
* as ssize_t is not guaranteed to be the same as int, and we usually do
* 'return log_errno...' from functions that return 'int' */
#define log_full_errno(level, error, ...) \
({ \
int _error = (error); \
int64_t _error = (error); \
ASSERT_UNDERFLOW(_error); \
ASSERT_NON_ZERO(_error); \
log_full_errno_zerook(level, _error, __VA_ARGS__); \
log_full_errno_zerook(level, (int)_error, __VA_ARGS__); \
})
#define log_full(level, fmt, ...) \