morgan/systemd
1
0
Fork 0
mirror of https://github.com/morgan9e/systemd synced 2026-04-15 00:47:10 +09:00
Code Issues Packages Projects Releases Wiki Activity

test-execute: Don't make rootfs read-only if we're collecting coverage

Browse Source 
The test needs to be able to write coverage data to the rootfs so don't
make / read-only.
This commit is contained in:
Daan De Meyer
2024-12-03 15:08:11 +01:00
parent 820a9373fc
commit 561a3786b7
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/test/test-execute.c
View File

@@ -1448,8 +1448,10 @@ static int prepare_ns(const char *process_name) {
_cleanup_free_ char *unit_dir = NULL, *build_dir = NULL, *build_dir_mount = NULL;
int ret;
/* Make "/" read-only. */
ASSERT_OK(mount_nofollow_verbose(LOG_DEBUG, NULL, "/", NULL, MS_BIND|MS_REMOUNT|MS_RDONLY, NULL));
const char *coverage = getenv("COVERAGE_BUILD_DIR");
if (!coverage)
/* Make "/" read-only. */
ASSERT_OK(mount_nofollow_verbose(LOG_DEBUG, NULL, "/", NULL, MS_BIND|MS_REMOUNT|MS_RDONLY, NULL));
/* Creating a new user namespace in the above means all MS_SHARED mounts become MS_SLAVE.
* Let's put them back to MS_SHARED here, since that's what we want as defaults. (This will