morgan/systemd
1
0
Fork 0
mirror of https://github.com/morgan9e/systemd synced 2026-04-15 00:47:10 +09:00
Code Issues Packages Projects Releases Wiki Activity

systemd-battery-check: provide more debug logs

Browse Source 
The logs would give no hint about the answer to most interesting question: why
we decided to return true or false from the program. If we find batteries
that are low or uncertain, log at info level.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek
2023-07-29 19:29:33 +02:00
committed by Luca Boccassi
parent 7e5bf8981f
commit 02f7f8aa4f
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/shared/battery-util.c
View File

@@ -254,19 +254,28 @@ int battery_is_discharging_and_low(void) {
level = battery_read_capacity_percentage(dev);
if (level < 0) {
log_device_debug_errno(dev, level, "Battery capacity is unreadable: %m");
unsure = true;
continue;
}
if (level > BATTERY_LOW_CAPACITY_LEVEL) /* Found a charged battery */
if (level > BATTERY_LOW_CAPACITY_LEVEL) { /* Found a charged battery */
log_device_full(dev,
found_low ? LOG_INFO : LOG_DEBUG,
"Found battery with capacity above threshold (%d%% > %d%%).",
level, BATTERY_LOW_CAPACITY_LEVEL);
return false;
}
log_device_info(dev,
"Found battery with capacity below threshold (%d%% <= %d%%).",
level, BATTERY_LOW_CAPACITY_LEVEL);
found_low = true;
}
/* If we found a battery whose state we couldn't read, don't assume we are in low battery state */
if (unsure) {
log_debug("Found battery with unreadable state, assuming not in low battery state.");
log_info("Found battery with unreadable state, assuming not in low battery state.");
return false;
}