Remove the flag that eventually turned to be a no-op (#3050)

docs/flags.md

@@ -38,7 +38,6 @@ If a switch requires a value, you must specify it with an `=` sign; e.g. flag `-
   `--enable-incognito-themes` | Allows themes to change the appearance of Incognito windows.
   `--hide-extensions-menu` | Hides the extensions container. This includes the puzzle piece icon as well as any pinned extensions.
   `--hide-fullscreen-exit-ui` | Hides the "X" that appears when the mouse cursor is moved towards the top of the window in fullscreen mode. Additionally, this hides the "Press F11 to exit full screen" popup.
-  `--hide-sidepanel-button` | Hides the SidePanel Button.
   `--hide-tab-close-buttons` | Hides the close buttons on tabs.
   `--remove-grab-handle` | Removes the reserved empty space in the tabstrip for moving the window.
   `--remove-tabsearch-button` | Removes the tabsearch button from the tabstrip.

patches/extra/ungoogled-chromium/add-flag-for-disabling-link-drag.patch

@@ -1,9 +1,9 @@
 --- a/chrome/browser/ungoogled_flag_entries.h
 +++ b/chrome/browser/ungoogled_flag_entries.h
-@@ -104,4 +104,8 @@
-      "Hide SidePanel Button",
-      "Hides the SidePanel Button. ungoogled-chromium flag.",
-      kOsDesktop, SINGLE_VALUE_TYPE("hide-sidepanel-button")},
+@@ -100,4 +100,8 @@
+      "Disable Sharing Hub",
+      "Disables the sharing hub button. ungoogled-chromium flag.",
+      kOsDesktop, SINGLE_VALUE_TYPE("disable-sharing-hub")},
 +    {"disable-link-drag",
 +     "Disable link drag",
 +     "Prevents dragging of links and selected text. ungoogled-chromium flag.",

patches/extra/ungoogled-chromium/add-flag-for-incognito-themes.patch

@@ -31,7 +31,7 @@
    substitutions["backgroundPosition"] = GetNewTabBackgroundPositionCSS(tp);
 --- a/chrome/browser/ungoogled_flag_entries.h
 +++ b/chrome/browser/ungoogled_flag_entries.h
-@@ -116,4 +116,8 @@
+@@ -112,4 +112,8 @@
       "Hide Fullscreen Exit UI",
       "Hides the \"X\" that appears when the mouse cursor is moved towards the top of the window in fullscreen mode. Additionally, this hides the \"Press F11 to exit full screen\" popup. ungoogled-chromium flag.",
       kOsDesktop, SINGLE_VALUE_TYPE("hide-fullscreen-exit-ui")},

patches/extra/ungoogled-chromium/add-flag-to-hide-extensions-menu.patch

@@ -46,7 +46,7 @@
    if (!HasAnyExtensions())
 --- a/chrome/browser/ungoogled_flag_entries.h
 +++ b/chrome/browser/ungoogled_flag_entries.h
-@@ -108,4 +108,8 @@
+@@ -104,4 +104,8 @@
       "Disable link drag",
       "Prevents dragging of links and selected text. ungoogled-chromium flag.",
       kOsDesktop, FEATURE_VALUE_TYPE(blink::features::kDisableLinkDrag)},

patches/extra/ungoogled-chromium/add-flag-to-hide-fullscreen-exit-ui.patch

@@ -26,7 +26,7 @@
    return !IsRunningInAppMode();
 --- a/chrome/browser/ungoogled_flag_entries.h
 +++ b/chrome/browser/ungoogled_flag_entries.h
-@@ -112,4 +112,8 @@
+@@ -108,4 +108,8 @@
       "Hide Extensions Menu",
       "Hides the extensions container. This includes the puzzle piece icon as well as any pinned extensions. ungoogled-chromium flag.",
       kOsDesktop, SINGLE_VALUE_TYPE("hide-extensions-menu")},

patches/extra/ungoogled-chromium/add-flag-to-hide-side-panel-button.patch

@@ -1,11 +0,0 @@
---- a/chrome/browser/ungoogled_flag_entries.h
-+++ b/chrome/browser/ungoogled_flag_entries.h
-@@ -100,4 +100,8 @@
-      "Disable Sharing Hub",
-      "Disables the sharing hub button. ungoogled-chromium flag.",
-      kOsDesktop, SINGLE_VALUE_TYPE("disable-sharing-hub")},
-+    {"hide-sidepanel-button",
-+     "Hide SidePanel Button",
-+     "Hides the SidePanel Button. ungoogled-chromium flag.",
-+     kOsDesktop, SINGLE_VALUE_TYPE("hide-sidepanel-button")},
- #endif  // CHROME_BROWSER_UNGOOGLED_FLAG_ENTRIES_H_

patches/extra/ungoogled-chromium/add-flag-to-reduce-system-info.patch

@@ -1,6 +1,6 @@
 --- a/chrome/browser/ungoogled_flag_entries.h
 +++ b/chrome/browser/ungoogled_flag_entries.h
-@@ -132,4 +132,8 @@
+@@ -128,4 +128,8 @@
       "Minimal Referrers",
       "Removes all cross-origin referrers and strips same-origin referrers down to the origin. Has lower precedence than remove-cross-origin-referrers. ungoogled-chromium flag.",
       kOsAll, FEATURE_VALUE_TYPE(features::kMinimalReferrers)},

patches/extra/ungoogled-chromium/add-flag-to-remove-client-hints.patch

@@ -1,6 +1,6 @@
 --- a/chrome/browser/ungoogled_flag_entries.h
 +++ b/chrome/browser/ungoogled_flag_entries.h
-@@ -136,4 +136,8 @@
+@@ -132,4 +132,8 @@
       "Reduced System Info",
       "Reduces the amount of system information obatainable through headers and javascript, also causes hardwareConcurrency to respond with two cores. ungoogled-chromium flag.",
       kOsAll, FEATURE_VALUE_TYPE(blink::features::kReducedSystemInfo)},

patches/extra/ungoogled-chromium/add-flags-for-referrer-customization.patch

@@ -1,6 +1,6 @@
 --- a/chrome/browser/ungoogled_flag_entries.h
 +++ b/chrome/browser/ungoogled_flag_entries.h
-@@ -120,4 +120,16 @@
+@@ -116,4 +116,16 @@
       "Enable themes in Incognito mode",
       "Allows themes to override Google's built-in Incognito theming. ungoogled-chromium flag.",
       kOsDesktop, SINGLE_VALUE_TYPE("enable-incognito-themes")},

patches/series

@@ -92,7 +92,6 @@ extra/ungoogled-chromium/disable-remote-optimization-guide.patch
 extra/ungoogled-chromium/add-flag-to-disable-tls-grease.patch
 extra/ungoogled-chromium/add-flag-to-change-http-accept-header.patch
 extra/ungoogled-chromium/add-flag-to-disable-sharing-hub.patch
-extra/ungoogled-chromium/add-flag-to-hide-side-panel-button.patch
 extra/ungoogled-chromium/add-flag-for-disabling-link-drag.patch
 extra/ungoogled-chromium/add-flag-to-hide-extensions-menu.patch
 extra/ungoogled-chromium/add-flag-to-hide-fullscreen-exit-ui.patch