akallabeth
7e486348e9
Merge pull request #12320 from akallabeth/rdpdr-simplify
...
Rdpdr simplify
2026-02-17 16:51:05 +01:00
Armin Novak
cf86ec9ed0
[gdi] fix handling of empty regions
...
Do not abort if an empty update region is found, ignore it.
2026-02-17 16:38:36 +01:00
Armin Novak
d015ba58de
[winpr,collections] fix sign warnings
2026-02-17 16:38:35 +01:00
Armin Novak
d20f9af0e8
[client,sdl] fix single window dynamic screen updates
2026-02-17 16:38:35 +01:00
Armin Novak
5f10ae9599
[channels,rdpdr] fix IRP handling
...
* clean up IRP creation
* Properly handle each IRP, call irp->Complete or irp->Discard only once
for each IRP
* For each channel split IRP handling, one function prepares the data
and a single evaluate function later calls irp->Complete or irp->Discard
2026-02-17 16:38:31 +01:00
Armin Novak
66d84e7f45
[client,sdl] fix a memory leak on startup
2026-02-17 16:14:15 +01:00
akallabeth
1b744c15fe
Merge pull request #12319 from akallabeth/grow-reasonable
...
[allocations] fix growth of preallocated buffers
2026-02-17 15:23:17 +01:00
Armin Novak
118afc0b95
[allocations] fix growth of preallocated buffers
...
* Replace * 2 with * sizeof(WCHAR) for string usages
* Grow streams and other buffers reasonably, e.g. add 128 elements per
try and check for possible overflows
* Add constant postfix to force them to 64bit
2026-02-17 13:54:34 +01:00
akallabeth
50eafef1d7
Merge pull request #12313 from akallabeth/freerdp-api-nodiscard
...
Freerdp api nodiscard
2026-02-17 12:54:27 +01:00
Armin Novak
c4a0565342
[client,x11] fix xf_DeleteSurface error branch
2026-02-17 11:10:16 +01:00
Armin Novak
df64d00a97
[warnings,api] fix -Wunused-result
...
With marking publid API [[nodiscard]] some problematic error checks in
the core library were uncovered. This commit addresses these
shortcomings.
2026-02-17 11:07:08 +01:00
Armin Novak
20a24fe36e
[freerdp,api] mark API functions [[nodiscard]]
...
Mark (most) of the API functions returning a value [[nodiscard]]. This
will assist application developers spotting bad return checks.
2026-02-17 10:23:34 +01:00
akallabeth
fac35c3abb
Merge pull request #12317 from akallabeth/codec-logs
...
NSC Codec fixes
2026-02-17 09:28:16 +01:00
Armin Novak
f3d23da0ae
[codec,nsc] update function docs
...
* add doxygen for functions
* add support for scanline value 0
2026-02-17 09:15:33 +01:00
Armin Novak
169971607c
[codec,nsc] fix use of nsc_process_message
...
the second width/height argument should reflect the destination buffer
pixel size
2026-02-17 08:38:04 +01:00
Armin Novak
24a23e3028
[codec,nsc] deprecate nsc_decompose_message
...
this function is just a wrapper around nsc_process_message with some
wStream handling around it. Since proper length checks are missing
deprecate it completely.
2026-02-17 08:32:39 +01:00
Armin Novak
caf6e7f2ec
[codec,nsc] log decoder function parameter issues
2026-02-17 08:24:20 +01:00
akallabeth
9a382e67a2
Merge pull request #12315 from akallabeth/clear-check-fixup
...
[codec,clear] fix destination checks
2026-02-16 20:10:36 +01:00
Armin Novak
7d8fdce2d0
[codec,clear] fix destination checks
...
check against the correct nDstWidth/nDstHeight
2026-02-16 19:56:55 +01:00
akallabeth
341b52ad96
Merge pull request #12312 from akallabeth/planar-dst-fix
...
[codec,planar] fix missing destination bounds checks
2026-02-16 10:54:54 +01:00
Armin Novak
a0be5cb87d
[codec,planar] fix missing destination bounds checks
2026-02-16 10:00:23 +01:00
akallabeth
a25b90adc2
Merge pull request #12311 from akallabeth/winpr-attr-nodiscard-fkt-ptr
...
Winpr attr nodiscard fkt ptr
2026-02-16 09:32:52 +01:00
Armin Novak
a1c72a2f85
[server,warnings] properly handle function return
2026-02-16 09:18:39 +01:00
Armin Novak
f4b0549c5b
[client,warnings] properly handle function return
2026-02-16 09:18:38 +01:00
Armin Novak
bf99266c2e
[channels,warnings] properly handle function return
2026-02-16 09:18:38 +01:00
Armin Novak
e0e6a7f800
[freerdp,warnings] properly handle function return
2026-02-16 09:18:37 +01:00
Armin Novak
81cf9f6cf0
[winpr,warnings] properly handle function return
2026-02-16 09:18:36 +01:00
Armin Novak
93dc6b8691
[channels,tsmf] fix function misnaming
2026-02-16 09:18:36 +01:00
Armin Novak
13616cc67e
[freerdp,codec] mark function pointers [[nodiscard]]
2026-02-16 09:18:35 +01:00
Armin Novak
9ecfb268fe
[freerdp,client] mark function pointers [[nodiscard]]
2026-02-16 09:18:35 +01:00
Armin Novak
9d199a9735
[freerdp,server] mark function pointers [[nodiscard]]
2026-02-16 09:18:35 +01:00
Armin Novak
775ee2615a
[freerdp,channels] mark function pointers [[nodiscard]]
2026-02-16 09:18:34 +01:00
Armin Novak
6a1cc0f031
[freerdp,api] mark function pointers [[nodiscard]]
2026-02-16 09:18:30 +01:00
Armin Novak
399d92f26e
[winpr] mark function pointers [[nodiscard]]
2026-02-15 23:57:23 +01:00
akallabeth
a9e5642d69
Merge pull request #12310 from akallabeth/clear-fix
...
Clear fix bounds checks
2026-02-15 22:52:43 +01:00
Armin Novak
f4d74c33fd
[codec,nsc] bounds checks and doxygen
...
* Improve doxygen for nsc_process_message
* Improve bounds checks for nsc_process_message
2026-02-15 19:32:38 +01:00
akallabeth
6db1965bb2
Merge pull request #12309 from Wladefant/patch-1
...
[android] Fix invert scrolling default value mismatch
2026-02-15 19:21:27 +01:00
Armin Novak
0746639629
[codec,clear] fix missing destination boundary checks
2026-02-15 19:19:07 +01:00
Armin Novak
361d73bc0e
[core,settings] use WINPR_KBD_TYPE constants
...
To initialize FreeRDP_KeyboardType use WINPR_KBD_TYPE_IBM_ENHANCED
enum constant.
2026-02-15 19:18:54 +01:00
Wladimir Kirjanovs
31346e9024
[android] Fix invert scrolling default value mismatch
...
The `getInvertScrolling()` fallback default was `false`, while
the XML preference in `settings_app_ui.xml` defines `android:defaultValue="true"`.
On a fresh install, if `PreferenceManager.setDefaultValues()` has not yet
persisted the XML defaults into SharedPreferences, the fallback value
`false` is returned instead of the intended `true`. This causes the
"Invert Scrolling" option to appear checked in the UI but not actually
take effect until the user toggles it manually.
Change the fallback from `false` to `true` to match the XML default.
Fixes #12308
2026-02-15 18:25:28 +01:00
akallabeth
2de734ada0
Merge pull request #12306 from akallabeth/scard-pad-fix
...
[utils,smartcard] check stream length on padding
2026-02-15 14:00:25 +01:00
Armin Novak
65d59d3b3c
[utils,smartcard] check stream length on padding
...
When reading optional padding in smartcard channel check if padding is
actually there.
2026-02-15 11:34:59 +01:00
akallabeth
ffea8dd928
Merge pull request #12305 from akallabeth/sdl-monitor-fix
...
[client,sdl] fix move constructor of SdlWindow
2026-02-14 20:42:13 +01:00
Armin Novak
1ac24accf0
[client,sdl] fix move constructor of SdlWindow
2026-02-14 20:35:25 +01:00
akallabeth
0ff34a1124
Merge pull request #12217 from akallabeth/sdl-fs
...
Sdl fullscreen
2026-02-14 12:20:03 +01:00
akallabeth
e0d54eaf42
Merge pull request #12303 from akallabeth/sdl-pointer-fix
...
[client,sdl] improve cursor updates, fix surface sizes
2026-02-14 12:18:35 +01:00
Armin Novak
52cd988410
[client,sdl] fix cursor surface creation
...
* Pass the pixel width and height to SDL_CreateSurface
* Pass display scaled hotspot to SDL_CreateColorCursor
2026-02-14 10:06:12 +01:00
Armin Novak
3503be620a
[client,sdl] log cursor scale
2026-02-14 10:03:01 +01:00
Armin Novak
07bf4e9c10
[client,sdl] improve cursor updates
...
* use std::unique_ptr for temporary SDL_Surface (ease up cleanup)
* better logging of errors (add full surface details)
2026-02-14 10:02:57 +01:00
Armin Novak
1b577a755e
[client,sdl] add toString for SDL_Rect
2026-02-14 09:44:47 +01:00