morgan/FreeRDP
1
0
Fork 0
mirror of https://github.com/morgan9e/FreeRDP synced 2026-04-15 00:44:19 +09:00
Code Issues Packages Projects Releases Wiki Activity

[channels,serial] fix use after free

Browse Source
This commit is contained in:
akallabeth
2026-01-11 09:12:37 +01:00
parent 57c5647d98
commit e99e33aea8
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
channels/serial/client/serial_main.c
View File

@@ -516,17 +516,18 @@ static UINT serial_process_irp(SERIAL_DEVICE* serial, IRP* irp)
static DWORD WINAPI irp_thread_func(LPVOID arg)
{
IRP_THREAD_DATA* data = (IRP_THREAD_DATA*)arg;
UINT error = 0;
WINPR_ASSERT(data);
WINPR_ASSERT(data->serial);
WINPR_ASSERT(data->irp);
/* blocks until the end of the request */
if ((error = serial_process_irp(data->serial, data->irp)))
UINT error = serial_process_irp(data->serial, data->irp);
if (error)
{
WLog_Print(data->serial->log, WLOG_ERROR,
"serial_process_irp failed with error %" PRIu32 "", error);
data->irp->Discard(data->irp);
goto error_out;
}
@@ -539,9 +540,6 @@ error_out:
if (error && data->serial->rdpcontext)
setChannelError(data->serial->rdpcontext, error, "irp_thread_func reported an error");
if (error)
data->irp->Discard(data->irp);
/* NB: At this point, the server might already being reusing
* the CompletionId whereas the thread is not yet
* terminated */