morgan/FreeRDP
1
0
Fork 0
mirror of https://github.com/morgan9e/FreeRDP synced 2026-04-15 00:44:19 +09:00
Code Issues Packages Projects Releases Wiki Activity

[coverity] 1543187 Dereference before null check

Browse Source
This commit is contained in:
akallabeth
2024-04-12 10:35:50 +02:00
committed by akallabeth
parent 1232cdbc6a
commit be4fb7f6dd
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
libfreerdp/core/gateway/tsg.c
View File

@@ -2168,15 +2168,15 @@ fail:
static BOOL TsProxyCloseTunnelWriteRequest(rdpTsg* tsg, const CONTEXT_HANDLE* context)
{
wStream* s = NULL;
rdpRpc* rpc = NULL;
WINPR_ASSERT(tsg);
WINPR_ASSERT(context);
WLog_Print(tsg->log, WLOG_DEBUG, "TsProxyCloseTunnelWriteRequest");
if (!tsg || !tsg->rpc || !context)
return FALSE;
rdpRpc* rpc = tsg->rpc;
WINPR_ASSERT(rpc);
rpc = tsg->rpc;
s = Stream_New(NULL, 20);
wStream* s = Stream_New(NULL, 20);
if (!s)
return FALSE;
@@ -2193,10 +2193,12 @@ fail:
static BOOL TsProxyCloseTunnelReadResponse(wLog* log, const RPC_PDU* pdu, CONTEXT_HANDLE* context)
{
BOOL rc = FALSE;
WLog_Print(log, WLOG_DEBUG, "TsProxyCloseTunnelReadResponse");
if (!pdu || !context)
return FALSE;
WINPR_ASSERT(log);
WINPR_ASSERT(pdu);
WINPR_ASSERT(context);
WLog_Print(log, WLOG_DEBUG, "TsProxyCloseTunnelReadResponse");
if (!Stream_CheckAndLogRequiredLengthWLog(log, pdu->s, 24))
goto fail;