Merge pull request #10621 from akallabeth/warn-fx

Warn fixes

.clang-tidy

@@ -43,7 +43,7 @@ Checks: >
     -cppcoreguidelines-no-malloc,
     -google-readability-braces-around-statements,
     -google-readability-todo,
-    -hicpp-avoid-c_arrays,
+    -hicpp-avoid-c-arrays,
     -hicpp-braces-around-statements,
     -hicpp-no-array-decay,
     -hicpp-no-assembler,

channels/rdpecam/client/CMakeLists.txt

@@ -42,7 +42,7 @@ set(${MODULE_PREFIX}_SRCS
 set(${MODULE_PREFIX}_LIBS
 	freerdp
     winpr
-    ${SWSCALE_LIBRARY}
+    ${SWSCALE_LIBRARIES}
     ${FFMPEG_LIBRARIES}
 )
 

libfreerdp/CMakeLists.txt

@@ -148,7 +148,7 @@ endif(WITH_CAIRO)
 # Prefer SWScale over Cairo, both at the same time are not possible.
 if (WITH_SWSCALE)
 	include_directories(SYSTEM ${SWSCALE_INCLUDE_DIRS})
-	freerdp_library_add(${SWSCALE_LIBRARY})
+	freerdp_library_add(${SWSCALE_LIBRARIES})
 endif()
 if (WITH_CAIRO)
     include_directories(SYSTEM ${CAIRO_INCLUDE_DIR})

libfreerdp/codec/dsp.c

@@ -1531,7 +1531,7 @@ BOOL freerdp_dsp_context_reset(FREERDP_DSP_CONTEXT* WINPR_RESTRICT context,
 #endif
 #if defined(WITH_FAAC)
 
-	if (context->encoder)
+	if (context->common.encoder)
 	{
 		faacEncConfigurationPtr cfg;
 

scripts/bundle-mac-os.sh

@@ -137,6 +137,7 @@ CMAKE_ARGS="-DCMAKE_SKIP_INSTALL_ALL_DEPENDENCY=ON \
 	-DINSTALL_BIN_DIR='$INSTALL/bin' \
 	-DCMAKE_PREFIX_PATH='$INSTALL;$INSTALL/lib;$INSTALL/lib/cmake' \
 	-DCMAKE_IGNORE_PATH='/opt/local;/usr/local;/opt/homebrew;/Library;~/Library'
+	-DCMAKE_IGNORE_PREFIX_PATH='/opt/local;/usr/local;/opt/homebrew;/Library;~/Library'
 	"
 
 if [ ! -d $SRC ];
@@ -278,7 +279,8 @@ cmake -GNinja -Bfreerdp -S"$SCRIPT_PATH/.." \
 	-DWITH_FAAC=ON \
 	-DWITH_INTERNAL_RC4=ON \
 	-DWITH_INTERNAL_MD4=ON \
-	-DWITH_INTERNAL_MD5=ON
+	-DWITH_INTERNAL_MD5=ON \
+    -DCHANNEL_RDPEAR=OFF
 cmake --build freerdp
 cmake --install freerdp
 

server/proxy/pf_server.c

@@ -158,13 +158,23 @@ static BOOL pf_server_get_target_info(rdpContext* context, rdpSettings* settings
 			}
 
 			if (config->TargetUser)
-				freerdp_settings_set_string(settings, FreeRDP_Username, config->TargetUser);
+			{
+				if (!freerdp_settings_set_string(settings, FreeRDP_Username, config->TargetUser))
+					return FALSE;
+			}
 
 			if (config->TargetDomain)
-				freerdp_settings_set_string(settings, FreeRDP_Domain, config->TargetDomain);
+			{
+				if (!freerdp_settings_set_string(settings, FreeRDP_Domain, config->TargetDomain))
+					return FALSE;
+			}
 
 			if (config->TargetPassword)
-				freerdp_settings_set_string(settings, FreeRDP_Password, config->TargetPassword);
+			{
+				if (!freerdp_settings_set_string(settings, FreeRDP_Password,
+				                                 config->TargetPassword))
+					return FALSE;
+			}
 
 			return TRUE;
 		}