morgan/FreeRDP
1
0
Fork 0
mirror of https://github.com/morgan9e/FreeRDP synced 2026-04-15 00:44:19 +09:00
Code Issues Packages Projects Releases Wiki Activity

[core,tcp] check arguments

Browse Source 
transport_bio_buffered_write arguments require more detailed checks.
This commit is contained in:
Armin Novak
2024-12-04 09:52:05 +01:00
committed by akallabeth
parent 35c687a0c4
commit a1ba364d47
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libfreerdp/core/tcp.c
View File

@@ -478,6 +478,8 @@ static int transport_bio_buffered_write(BIO* bio, const char* buf, int num)
WINPR_ASSERT(bio);
WINPR_ASSERT(ptr);
if (num < 0)
return num;
ptr->writeBlocked = FALSE;
BIO_clear_flags(bio, BIO_FLAGS_WRITE);
@@ -485,7 +487,7 @@ static int transport_bio_buffered_write(BIO* bio, const char* buf, int num)
/* we directly append extra bytes in the xmit buffer, this could be prevented
* but for now it makes the code more simple.
*/
if (buf && num && !ringbuffer_write(&ptr->xmitBuffer, (const BYTE*)buf, num))
if (buf && (num > 0) && !ringbuffer_write(&ptr->xmitBuffer, (const BYTE*)buf, (size_t)num))
{
WLog_ERR(TAG, "an error occurred when writing (num: %d)", num);
return -1;