morgan/FreeRDP
1
0
Fork 0
mirror of https://github.com/morgan9e/FreeRDP synced 2026-04-15 00:44:19 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12108 from LeeEirc/patch_peer_list

Browse Source 
[server,proxy] make peer_list access thread-safe and fix leaks
This commit is contained in:
akallabeth
2026-01-08 09:01:05 +01:00
committed by GitHub
parent fa8a31b4e5 aba17d0cf9
commit 9321d09495
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
server/proxy/pf_server.c
View File

@@ -585,7 +585,9 @@ static DWORD WINAPI pf_server_handle_peer(LPVOID arg)
proxyServer* server = (proxyServer*)client->ContextExtra;
WINPR_ASSERT(server);
ArrayList_Lock(server->peer_list);
size_t count = ArrayList_Count(server->peer_list);
ArrayList_Unlock(server->peer_list);
if (!pf_context_init_server_context(client))
goto out_free_peer;
@@ -763,12 +765,19 @@ static BOOL pf_server_start_peer(freerdp_peer* client)
hThread = CreateThread(NULL, 0, pf_server_handle_peer, args, CREATE_SUSPENDED, NULL);
if (!hThread)
{
free(args);
return FALSE;
}
args->thread = hThread;
if (!ArrayList_Append(server->peer_list, hThread))
ArrayList_Lock(server->peer_list);
const BOOL appended = ArrayList_Append(server->peer_list, hThread);
ArrayList_Unlock(server->peer_list);
if (!appended)
{
(void)CloseHandle(hThread);
free(args);
return FALSE;
}