morgan/FreeRDP
1
0
Fork 0
mirror of https://github.com/morgan9e/FreeRDP synced 2026-04-15 00:44:19 +09:00
Code Issues Packages Projects Releases Wiki Activity

[server,proxy] fix plausibility checks in pf_config_get_uint32

Browse Source
This commit is contained in:
Armin Novak
2024-09-18 11:29:11 +02:00
parent 7b8ddb89c7
commit 65f6541f67
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
server/proxy/pf_config.c
View File

@@ -155,12 +155,9 @@ static BOOL pf_config_get_uint16(wIniFile* ini, const char* section, const char*
static BOOL pf_config_get_uint32(wIniFile* ini, const char* section, const char* key,
UINT32* result, BOOL required)
{
int val = 0;
const char* strval = NULL;
WINPR_ASSERT(result);
strval = IniFile_GetKeyValueString(ini, section, key);
const char* strval = IniFile_GetKeyValueString(ini, section, key);
if (!strval)
{
if (required)
@@ -168,8 +165,8 @@ static BOOL pf_config_get_uint32(wIniFile* ini, const char* section, const char*
return !required;
}
val = IniFile_GetKeyValueInt(ini, section, key);
if ((val < 0) || (val > INT32_MAX))
const int val = IniFile_GetKeyValueInt(ini, section, key);
if (val < 0)
{
WLog_ERR(TAG, "invalid value %d for key '%s.%s'.", val, section, key);
return FALSE;