morgan/FreeRDP
1
0
Fork 0
mirror of https://github.com/morgan9e/FreeRDP synced 2026-04-15 08:54:38 +09:00
Code Issues Packages Projects Releases Wiki Activity

[core,transport] use allocated streams

Browse Source 
in transport we end up in a race condition, so do not use the stream
pool for send packets.
This commit is contained in:
akallabeth
2025-02-27 17:39:23 +01:00
parent ec030e8255
commit 504e87600c
1 changed files with 7 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
libfreerdp/core/transport.c
View File

@@ -147,22 +147,11 @@ static void transport_ssl_cb(const SSL* ssl, int where, int ret)
}
}
wStream* transport_send_stream_init(rdpTransport* transport, size_t size)
wStream* transport_send_stream_init(WINPR_ATTR_UNUSED rdpTransport* transport, size_t size)
{
WINPR_ASSERT(transport);
wStream* s = StreamPool_Take(transport->ReceivePool, size);
if (!s)
return NULL;
if (!Stream_EnsureCapacity(s, size))
{
Stream_Release(s);
return NULL;
}
Stream_SetPosition(s, 0);
return s;
return Stream_New(NULL, size);
}
BOOL transport_attach(rdpTransport* transport, int sockfd)
@@ -1447,9 +1436,12 @@ int transport_check_fds(rdpTransport* transport)
}
received = transport->ReceiveBuffer;
if (!(transport->ReceiveBuffer = StreamPool_Take(transport->ReceivePool, 0)))
transport->ReceiveBuffer = StreamPool_Take(transport->ReceivePool, 0);
if (!transport->ReceiveBuffer)
{
Stream_Release(received);
return -1;
}
/**
* status: