morgan/FreeRDP
1
0
Fork 0
mirror of https://github.com/morgan9e/FreeRDP synced 2026-04-15 00:44:19 +09:00
Code Issues Packages Projects Releases Wiki Activity

Ignore INVALID_HANDLE_VALUE during clang scanbuild runs.

Browse Source 
The value INVALID_HANDLE_VALUE could in theory be a valid memory address,
so the analyzer is confused and thinks either we have a memroy leak
or we try to free a fixed address.
This commit is contained in:
Armin Novak
2019-02-21 12:20:25 +01:00
parent 41d382569c
commit 32e5407b43
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
winpr/libwinpr/handle/handle.h
View File

@@ -123,9 +123,16 @@ static INLINE BOOL winpr_Handle_GetInfo(HANDLE handle, ULONG* pType, WINPR_HANDL
{
WINPR_HANDLE* wHandle;
if (handle == NULL || handle == INVALID_HANDLE_VALUE)
if (handle == NULL)
return FALSE;
/* INVALID_HANDLE_VALUE is an invalid value for every handle, but it
* confuses the clang scanbuild analyzer. */
#ifndef __clang_analyzer__
if (handle == INVALID_HANDLE_VALUE)
return FALSE;
#endif
wHandle = (WINPR_HANDLE*) handle;
*pType = wHandle->Type;