Commit Graph

3238 Commits

Author SHA1 Message Date
Armin Novak
df64d00a97 [warnings,api] fix -Wunused-result
With marking publid API [[nodiscard]] some problematic error checks in
the core library were uncovered. This commit addresses these
shortcomings.
2026-02-17 11:07:08 +01:00
Armin Novak
bf99266c2e [channels,warnings] properly handle function return 2026-02-16 09:18:38 +01:00
Armin Novak
93dc6b8691 [channels,tsmf] fix function misnaming 2026-02-16 09:18:36 +01:00
Armin Novak
775ee2615a [freerdp,channels] mark function pointers [[nodiscard]] 2026-02-16 09:18:34 +01:00
Armin Novak
6a1cc0f031 [freerdp,api] mark function pointers [[nodiscard]] 2026-02-16 09:18:30 +01:00
Armin Novak
eb0b74a908 [channels,rdpecam] fix sign warnings 2026-02-13 12:17:47 +01:00
Armin Novak
5c682eee86 [channels,video] make channel less verbose
The channel did spam the log with frame updates, remove that message in
the hot path.
2026-02-11 17:02:41 +01:00
Armin Novak
fff62ff919 [channels,rdpecam] fix integer types and warnings 2026-02-10 19:07:10 +01:00
Armin Novak
e3981d8f02 [channels,rdpecam] fix integer types and warnings 2026-02-10 17:02:15 +01:00
Armin Novak
f3ab7b65b9 [channels,rdpear] fix uninitialized variable warnings 2026-02-10 16:56:48 +01:00
Armin Novak
0fefdd1274 [channels,audin|rdpsnd] fix enum cast warnings 2026-02-10 15:53:06 +01:00
akallabeth
cb3fb59a89 Merge pull request #12285 from akallabeth/pulse-name
Use application details for names
2026-02-10 12:18:25 +01:00
Armin Novak
0a4122fb27 [channels,drive] name volume with freerdp_getApplicationDetailsString 2026-02-10 11:20:13 +01:00
Armin Novak
3df54a3e79 [channels,tsmf] use freerdp_getApplicationDetailsString
Name pulse source/sinc properly
2026-02-10 11:20:12 +01:00
Armin Novak
5f410772b6 [channels,printer] use freerdp_getApplicationDetailsString
Use proper vendor/product name for job name
2026-02-10 11:20:08 +01:00
Armin Novak
1ebc39f22f [channels,rdpsnd] use freerdp_getApplicationDetailsString
Use proper vendor/product name for pulse sinc.
2026-02-09 19:55:52 +01:00
Armin Novak
4104567d7c [channels,audin] use freerdp_getApplicationDetailsString
Use proper vendor/product name for pulse sinc.
2026-02-09 19:55:52 +01:00
Armin Novak
2e3b77e28a [channels,rdpgfx] check available stream length 2026-02-09 13:18:51 +01:00
akallabeth
55a9161ecb [channels,rdpecam] fix sws context checks 2026-02-08 09:16:33 +01:00
akallabeth
7ba57d23bb Merge pull request #12195 from akallabeth/rdpei-fix
[channels,rdpei] add RDPINPUT_CONTACT_FLAG_UP
2026-01-28 10:37:04 +01:00
Armin Novak
0c87a5dd65 [channels,rdpei] add RDPINPUT_CONTACT_FLAG_UP
When iterating over the list of contacts add a RDPINPUT_CONTACT_FLAG_UP
contact to the list of events to send.
2026-01-28 10:16:58 +01:00
akallabeth
afa6851dc8 [channel,rdpsnd] only clean up thread before free
rdpsnd channel usually has multiple instances (static, dynamic, ...) so
ensure only to terminate the handler thread when the channel is actually
closed for good.
2026-01-28 09:49:36 +01:00
akallabeth
067524438a [channels,rdpecam] fix PROPERTY_DESCRIPTION parsing
* The Capabilities field is a mask, so allow combination of all valid
  values.
* Adjust header to hold a mask
* Use enum to define constants for parsed values
2026-01-28 08:42:08 +01:00
akallabeth
24f71fd3d4 [channels,disp] improve log message
log all monitor details of the layout sent over the display channel.
2026-01-27 12:14:05 +01:00
Armin Novak
cb7f295bc7 [channels,drdynvc] check pointer before reset 2026-01-27 08:58:41 +01:00
akallabeth
076a8386a6 Merge pull request #12186 from akallabeth/error-handling-fixes
Error handling fixes
2026-01-26 17:05:19 +01:00
akallabeth
b9c23252f1 [channels,urbdrc] fix msusb_msingerface_free
declare before use in WINPR_ATTR_MALLOC
2026-01-26 16:52:30 +01:00
akallabeth
538620e1bb [channels] mark all WINPR_ATTR_MALLOC also nodiscard 2026-01-26 13:22:27 +01:00
akallabeth
3f163cee9c [warnings] fix unused result warnings 2026-01-26 13:22:24 +01:00
akallabeth
d9ca272dce [channels,ainput] lock context when updating listener 2026-01-26 12:09:05 +01:00
akallabeth
d676518809 [channels,urbdrc] do not free MsConfig on failure
let the channel handle it later.
2026-01-26 11:55:44 +01:00
akallabeth
9af6f3a4af [channels,urbdrc] mark functions with attr-malloc 2026-01-26 11:55:17 +01:00
akallabeth
fc665ef9ef [channel,urbdrc] check if interface is valid 2026-01-26 11:45:55 +01:00
akallabeth
414f701464 [channels,urbdrc] cancel all usb transfers on channel close 2026-01-26 11:26:48 +01:00
akallabeth
2d563a50be [channels,urbdrc] ensure InterfaceNumber is within range 2026-01-26 11:26:46 +01:00
akallabeth
f3ab1a1613 [channels,rdpecam] ensure all streams are stopped
When closing the channel ensure there are no more streams running.
2026-01-26 11:26:45 +01:00
akallabeth
d2d4f44931 [channels,rdpecam] ensure sws context size matches 2026-01-26 11:26:44 +01:00
akallabeth
622bb7b440 [channels,rdpsnd] terminate thread before free
Ensure that the optional rdpsnd thread is terminated and the message
queue freed up before releasing the channel context memory
2026-01-26 11:26:41 +01:00
akallabeth
026b81ae58 [channels,audin] reset audin->format
Whenever the underlying structure changes reset the pointer to NULL
2026-01-26 11:09:58 +01:00
akallabeth
1c5c742231 [channels,audin] fix audin_server_recv_formats cleanup 2026-01-26 11:09:56 +01:00
akallabeth
f039d35032 [channels] replace casts by proper return addresses
Use the base structs return address instead of a derived one so the data
types match.
2026-01-26 11:09:54 +01:00
akallabeth
ec4c4ee5a3 [channels,rdpei] refactor variable names 2026-01-26 11:09:53 +01:00
akallabeth
e02e052f66 [channels,drdynvc] reset channel_callback before close
The channel_callback usually frees up the memory of the callback. To
ensure that there is no access to any of the data structures in it
invalidate the pointer used to access it before a free.
2026-01-26 11:09:51 +01:00
akallabeth
e05ab04f67 [channels,video] measure times in ns
measure all times normalized to [ns]
2026-01-25 17:37:45 +01:00
akallabeth
eb83f339b4 [channels,rdpdr] flag definition and stringify
* Use a enum to define RDPDR_DTYP_* constants
* Add public API freerdp_device_type_string for stringify
* Add WINPR_ATTR_NODISCARD in rdpdr_utils.h
2026-01-25 09:15:05 +01:00
akallabeth
af784d01c6 [channels,rdpei] lock full update, not only parts 2026-01-23 16:37:39 +01:00
Armin Novak
43e3b862af [warnings] fix initialization skip warnings 2026-01-21 16:41:26 +01:00
Armin Novak
2e6af8159d Revert "Fix dead lock in smartcard"
This reverts commit 649f7deee4.
2026-01-21 13:22:36 +01:00
akallabeth
84d3d99338 [clang-tidy] clean up code warnings 2026-01-19 13:05:26 +01:00
akallabeth
fb8efd45f2 [c,format] fix format string and review warnings 2026-01-16 13:36:14 +01:00