Commit Graph

6333 Commits

Author SHA1 Message Date
akallabeth
ba8fd2ada5 [cmake] force configuration options
limit multiconfiguration options to supported types
2024-12-05 09:36:23 +01:00
Armin Novak
5a7621bfa3 [core,freerdp] fix automatic reconnect after auth
In freerdp_connect do an automatic reconnect if we failed with a
FREERDP_ERROR_CONNECT_TRANSPORT_FAILED
This way we can prevent connection disconnects if the remote was
disconnected due to timeout (e.g. Auth-Dialog was open for a long time)
2024-12-04 15:49:47 +01:00
David Fort
f0f830f3e9 Cleanup freerdp_settings_set_pointer_len_
Instead of doing convertions to SSIZE_T for the key length id, use FreeRDP_UINT32_UNUSED
when a pointer has no associated len key.
2024-12-04 13:45:39 +01:00
Martin Fleisz
fb52b02487 Merge pull request #10894 from akallabeth/unify-simd-detection
[CMake,simd] unify WITH_SSE2, WITH_AVX2, WITH_NEON
2024-12-04 09:05:52 +01:00
akallabeth
c2beba472e Merge pull request #10905 from akallabeth/monitor-check-verbose
Monitor check verbose
2024-12-03 13:34:38 +01:00
akallabeth
646cacca0e [core,settings] add instructions on fail
Add bug reporting instructions for failing monitor configurations
2024-12-03 13:06:29 +01:00
akallabeth
d48cd481e7 [core,settings] dump monitor configuration to log 2024-12-03 13:00:54 +01:00
akallabeth
b4976163cd [CMake,simd] unify WITH_SSE2, WITH_AVX2, WITH_NEON
* Add new CMake option WITH_SIMD to enable best available instruction
  type
* Unify simd related defines in single header
2024-12-03 11:54:36 +01:00
akallabeth
6d0381e36e [core,transport] fix reading of data
in transport_default_read_pdu only try to read the remaining PDU bytes
if we did not already complete that. Calling transport_read_layer_bytes
with a length of 0 returns 0 whereas every other value returns 1 for
success.
2024-12-03 08:48:18 +01:00
akallabeth
def00a32be [core,settings] add testcases 2024-12-02 21:01:28 +01:00
akallabeth
49f1689496 [core,settings] verbose output on monitor layout failure 2024-12-02 21:01:25 +01:00
Joan Torres
d284d024b6 [core,rdstls] fix rdstls parsing
When parsing the rdstls PDU, don't set the stream position at the end.

To know the pduLength is enough getting the last field length and the
stream position.

This fixes transport_read_layer_bytes failing because it was
getting on toRead = 0.
2024-12-02 17:42:31 +01:00
akallabeth
f7e5e6507b Merge pull request #10895 from akallabeth/cmake-format
Cmake format
2024-11-28 14:52:19 +01:00
Armin Novak
601249115f [codespell] fix spelling mistakes 2024-11-28 11:52:22 +01:00
akallabeth
faae38120c [cmake,format] reformat all cmake files 2024-11-27 20:41:48 +01:00
akallabeth
47c95aa799 Merge pull request #10877 from akallabeth/websocket-simplify
[core,gateway] refactor websocket support
2024-11-25 14:37:39 +01:00
akallabeth
ae3160174f [core,fastpath] fix bulk max size
the type is UINT16 so the maximum size can only be UINT16_MAX
2024-11-22 11:00:57 +01:00
akallabeth
1977338a32 [core,orders] fix update_write_brush
* Fix calls, the fieldFlags need to be masked
* Fix implementation, ensure the size is correct and abort on failures
2024-11-22 11:00:54 +01:00
akallabeth
64f4acdd2f [core,gdi] improve range asserts
use WINPR_ASSERT_AT to pinpoint location of call of checker function
2024-11-22 11:00:48 +01:00
akallabeth
0dc709a64d implicit-int-conversion 2024-11-22 11:00:45 +01:00
akallabeth
841151c456 implicit-int-conversion 2024-11-22 11:00:42 +01:00
akallabeth
8e7637ce1b implicit-int-conversion 2024-11-22 11:00:39 +01:00
Armin Novak
4cbdd2c176 [core,gateway] refactor websocket support
* Unify read/write functions
* Unify websocket_context setup/teardown/reset
2024-11-21 16:36:39 +01:00
Armin Novak
2c461d0ea9 [core,freerdp] log state if preconnect fails 2024-11-21 16:34:50 +01:00
akallabeth
b5f95e0f87 [codespell] fix spelling mistakes 2024-11-21 11:28:06 +01:00
akallabeth
f1e4b30507 clang-format after spellcheck changes 2024-11-21 09:53:00 +01:00
stephanebill
4f2afa8c47 spell check with codespell 2024-11-20 16:53:40 -05:00
akallabeth
38dab4b2ab [utils,test] fix invalid format string 2024-11-19 17:56:45 +01:00
akallabeth
4dff4ad762 [core,client] fix freerdp_channels_get_id_by_name
return 0 in case of a failure. Fixes #10863
2024-11-15 16:17:53 +01:00
cbr-rc
7db06cc359 do not always return FALSE when gdi is NULL 2024-11-14 17:27:10 +01:00
Martin Fleisz
16789a181a [core]: Fix some issues with RAIL window state order logging
This commit fixes following issues when logging window state orders:

- Always print Window and Owner Ids as integer numbers
- Log all window styles (including extended styles)
- Log window title (very useful to identify the window in the log)
2024-11-14 10:19:43 +01:00
akallabeth
43e471938b Merge pull request #10843 from akallabeth/cleanups3
Cleanups3
2024-11-12 17:52:55 +01:00
akallabeth
387147bb4e [codec,xcrush] fix a regression with xcrush_generate_output 2024-11-12 17:14:52 +01:00
akallabeth
db07add07a [deprecation] replace all usages of sprintf 2024-11-12 16:46:11 +01:00
akallabeth
08839a11de [utils,passphrase] NULL checks 2024-11-12 16:46:04 +01:00
akallabeth
7f27e168b3 [emu,scard] flag allocator with nolint
The allocator keeps an internal list of allocated contexts. No manual
free required.
2024-11-12 16:46:01 +01:00
akallabeth
78acedb40e [warnigns] fix Wshorten-64-to-32 2024-11-11 10:22:37 +01:00
Martin Fleisz
1520d94d33 Merge pull request #10797 from akallabeth/warn-fixes
Warn fixes
2024-11-07 13:50:51 +01:00
Martin Fleisz
c7486fc47b Merge pull request #10801 from akallabeth/cleanups
Cleanups
2024-11-07 13:03:36 +01:00
akallabeth
7e7ea3e688 [core,settings] WINPR_ATTR_MALLOC for alloc_array 2024-11-07 11:46:50 +01:00
akallabeth
315ab17984 [core,rdstls] use less verbose logging
the rdstls_recv function is called with possibly incomplete data, do not
log length check failures
2024-11-06 20:41:01 +01:00
akallabeth
ec9b5c33bc [core,rdstls] do silent password check
In rdstls_parse_pdu_data_type do not use logging stream functions. This
function might be called with incomplete data so avoid spamming the log.
2024-11-05 17:50:47 +01:00
Vic Lee
ce604a5a81 [core,primitive] fix rgb primitive copy without conversion. 2024-11-04 17:53:59 +08:00
akallabeth
1b177eeda9 [core,security] fix assertion
The assert for the buffer size required too many bytes in the output
buffer.
2024-10-31 13:11:57 +01:00
akallabeth
a58a390726 [gdi,shape] fix logically dead code 2024-10-31 11:42:34 +01:00
akallabeth
7f44ef8114 [cache,glyph] eliminate logically dead code 2024-10-31 11:42:31 +01:00
akallabeth
4ec28e1f82 [warnings] fix -Wimplicit-int-conversion 2024-10-31 11:42:29 +01:00
akallabeth
dcf5a8e28c [warnings] fix -Wswitch-default 2024-10-31 11:42:24 +01:00
akallabeth
6b6ae5fa9d [utils,helpers] revert removed define
the define was conditionally unused. guard it now so it does not show up
as unused
2024-10-31 08:51:55 +01:00
akallabeth
dc76879e0b [warnings] fix some compiler warnings
* fix compiler warnings found in a lot of places
* add missing enum type for clipboard channel
* mark deallocator for winpr image function
2024-10-30 16:12:20 +01:00