akallabeth
bcdc86714c
[c,printf] fix wlog format string to match arguments
2026-01-16 11:39:32 +01:00
akallabeth
d60045ae1a
[chanels,various] fix VirtualChannelEntryEx parameter types
2026-01-13 17:11:27 +01:00
Armin Novak
9d48802831
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:32 +01:00
akallabeth
74648eb3a9
[c,standard] use C99 inline
2025-09-26 11:29:26 +02:00
Armin Novak
c7c7874bf0
[channels,cliprdr] improve casts
2025-08-18 14:11:50 +02:00
akallabeth
65f18983ed
[warnings] Fix format string errors
...
* Fix casts of format string arguments (%p requires void*)
* Fix format string to match type of arguments
2025-08-13 15:09:48 +02:00
akallabeth
e7224ff559
[channels,client] log server format list
2025-04-02 12:16:56 +02:00
Armin Novak
4192dbee55
[channels,cliprdr] improve logging of formats sent
2025-03-19 12:49:10 +01:00
akallabeth
38a006839f
[channels,cliprdr] improve logging
...
* use a dynamic logger
* log clipboard formats announced by server
2025-03-14 08:48:59 +01:00
Armin Novak
c79f080e8d
[warnings] improve array bound checks
2025-03-12 15:04:38 +01:00
Armin Novak
8fb49b0abe
[warnings] fix coverity warnings
2025-03-12 13:44:59 +01:00
akallabeth
054275bd5d
[warnings] fix sign and narrowing issues
2025-03-10 19:19:28 +01:00
akallabeth
2b7d7356c1
[channels,warnings] fix -Wunused-parameter
2025-02-13 15:53:56 +01:00
David Fort
88229dca51
Fix calls of Stream_EnsureCapacity
...
There were various places where Stream_EnsureCapacity was called instead of the
expected Stream_EnsureRemainingCapacity. When the stream position is set to 0 the
2 calls are equivalent, but we had various places where it was not always the case.
2025-01-13 14:49:18 +01:00
akallabeth
be3ba1c425
[warnings,channels] fix integer casts
2024-12-25 13:29:07 +01:00
akallabeth
ac9cf26bce
[cmake] fix define_channel_options
...
* fix usage of default value
* fix defaults of channels
* unify to single CMake function define_channel_options
2024-12-17 16:29:32 +01:00
akallabeth
83f2f21ad3
[warnigns] fix lots of bugprone warnings
...
* update-settings-tests: properly cast types in getter/setter
* wtypes: fix PHANDLE definition
* wStream: fix INT64 write function warnings
* Simplify HANDLE copy in channels, just assign after proper cast
2024-12-06 09:15:48 +01:00
akallabeth
faae38120c
[cmake,format] reformat all cmake files
2024-11-27 20:41:48 +01:00
stephanebill
4f2afa8c47
spell check with codespell
2024-11-20 16:53:40 -05:00
akallabeth
78acedb40e
[warnigns] fix Wshorten-64-to-32
2024-11-11 10:22:37 +01:00
akallabeth
dcf5a8e28c
[warnings] fix -Wswitch-default
2024-10-31 11:42:24 +01:00
akallabeth
dc76879e0b
[warnings] fix some compiler warnings
...
* fix compiler warnings found in a lot of places
* add missing enum type for clipboard channel
* mark deallocator for winpr image function
2024-10-30 16:12:20 +01:00
akallabeth
04a8bcd8a5
[channels,cliprdr] make global strings arrays
2024-10-01 13:05:43 +02:00
akallabeth
72350e2587
[channels,cliprdr] log clipboard format requested
2024-10-01 13:05:27 +02:00
akallabeth
11b7633dc0
[channels] use Stream_BufferAs
...
For WTSVirtualChannelRead and WTSVirtualChannelWrite use Stream_BufferAs
to cast to correct type.
2024-10-01 10:28:13 +02:00
akallabeth
8ddb678639
[channels,cliprdr] fix server side send routine
2024-10-01 10:16:18 +02:00
akallabeth
586f40631f
[warnings] fix shorten-64-to-32
2024-09-17 16:13:48 +02:00
akallabeth
965d231e49
[return checks] fix use of CloseHandle
2024-09-16 08:22:31 +02:00
akallabeth
7d67b8e204
[return checks] fix use of SetEvent
2024-09-16 06:47:58 +02:00
akallabeth
8b6091a007
[winpr,wtsapi] improve API usage
...
* Mark WTSVirtualChannelOpen and WTSVirtualChannelOpenEx with
WINPR_ATTR_MALLOC to enforce compiler checks for resource cleanup
* Fix unused result warnings, use the result or cast to (void) where not
requierd
2024-09-14 21:29:31 +02:00
akallabeth
c9b0c9ecd5
[warnings] remove unused variables
2024-09-12 10:08:10 +02:00
akallabeth
15456e1ee1
[warnings] fix implicit widening conversion
2024-08-29 10:47:20 +02:00
akallabeth
1d33095500
[warnings] fix cert-err33-c
...
Fix unused return values, cast to void if on purpose
2024-08-29 10:19:27 +02:00
akallabeth
1e19ccd76d
[channels,cliprdr] refactor cliprdr_packet_format_list_new
...
* Simplify function
* Add missing arguments for ASCII names
2024-08-14 09:19:51 +02:00
David Fort
6e2cc358ba
cliprdr: fix message of error code log
2024-08-13 15:08:30 +02:00
Armin Novak
83b253dc84
[channels,cliprdr] fix cliprdr_packet_format_list_new
...
* Fix length calculations
* Fix format name write, skip empty strings
2024-08-12 13:23:33 +02:00
Armin Novak
1b2533674b
[channels,cliprdr] stringify logged values
2024-07-17 11:27:51 +02:00
akallabeth
23229859d7
[channel,cliprdr] warn on invalid msgFlags in requests
2024-05-16 18:27:38 +02:00
akallabeth
4236f46b33
[coverity] 1543262 Resource leak
2024-04-12 09:45:09 +02:00
Ilya Shipitsin
822537be0e
channels/cliprdr/client/cliprdr_main.c: fix resource leak
...
found by coverity
655 if (Stream_Write_UTF16_String_From_UTF8(s, tmpDirCharLen - 1, tempDirectory->szTempDir,
656 ARRAYSIZE(tempDirectory->szTempDir), TRUE) < 0)
CID 424748: (#1 of 1): Resource leak (RESOURCE_LEAK)
9. leaked_storage: Variable s going out of scope leaks the storage it points to.
657 return ERROR_INTERNAL_ERROR;
658 /* Path must be 260 UTF16 characters with '\0' termination.
659 * ensure this here */
2024-04-08 11:39:20 +02:00
akallabeth
9a7d30d174
[clang,tidy] fix a few warnings
2024-02-27 14:15:43 +01:00
akallabeth
d7ebec5a65
[tidy] move loop variable declaration to loop
2024-02-22 12:31:50 +01:00
akallabeth
0e44b2c674
[clang-tidy] clang-analyzer-unix.Malloc
2024-02-15 11:49:16 +01:00
akallabeth
0ba995655d
[clang-tidy] cppcoreguidelines-init-variables
2024-02-15 11:49:16 +01:00
Raphaël ZHOU
ad7b41c997
(clipboard) Make sure there is always a Client Format List PUD after a Client Clipboard Capabilities PDU.
2023-11-09 11:40:00 +01:00
akallabeth
bb5345c60e
[freerdp,api] add FREERDP_ENTRY_POINT
...
C requires prototypes or compilers will complain about them missing. Our
library entry points do not have such, therefore add the macro
FREERDP_ENTRY_POINT which declares the function prototype automatically
before the function.
2023-08-25 14:36:05 +02:00
akallabeth
41bd8bd3fb
[various] fix integer conversions
2023-08-04 15:07:56 +02:00
Pascal Nowack
b8c2b6abd7
channels/cliprdr: Fix writing incorrect PDU type for unlock PDUs
2023-07-20 11:36:11 +02:00
Martin Fleisz
622a2a8df0
misc: More int to BOOL conversion fixes
...
This is a follow up to #9129 .
This PR fixes some problematic `int` to `BOOL` conversions that might
cause overflows when checking for bit flags.
2023-07-04 09:45:20 +02:00
Martin Fleisz
3b9a19e993
cliprdr: Fix an issue with file format filtering on Windows
...
This PR fixes an issue caused by clipboard format filtering which
discarded all formats but `FileGroupDescriptorW` to enable clipboard
file transfer. However at least on windows we also need `FileContents`
to be placed in the clipboard to make file transfer work correctly.
The PR also unifies list filtering into a single functions instead of
having two different functions.
2023-06-14 17:14:14 +02:00
