akallabeth
6d541c8691
[warnings] eliminate dead code
2025-03-04 09:53:05 +01:00
akallabeth
7bfb8bc576
[core,orders] add sanity checks
...
Check coordinates of polygon for out of range and abort if detected.
2025-02-14 13:22:48 +01:00
akallabeth
74cd8d8fe0
[freerdp,warnings] fix -Wunused-parameter
2025-02-13 15:53:54 +01:00
Armin Novak
0e006e31fe
[warnings] fix sign conversion
2025-02-12 12:52:29 +01:00
akallabeth
4013b3132b
[clang,tidy] fix sign warnings
2025-02-10 13:11:16 +01:00
akallabeth
9e7e84c9ff
[core,orders] fix update_read_delta
2025-02-07 21:19:55 +01:00
akallabeth
cc934795e4
[warnings] fix integer casting
...
* use asserting casts to detect overflows or sign conversions
* code cleanup for issues uncovered by casts
2025-01-01 12:58:34 +01:00
akallabeth
1977338a32
[core,orders] fix update_write_brush
...
* Fix calls, the fieldFlags need to be masked
* Fix implementation, ensure the size is correct and abort on failures
2024-11-22 11:00:54 +01:00
akallabeth
64f4acdd2f
[core,gdi] improve range asserts
...
use WINPR_ASSERT_AT to pinpoint location of call of checker function
2024-11-22 11:00:48 +01:00
akallabeth
841151c456
implicit-int-conversion
2024-11-22 11:00:42 +01:00
akallabeth
78acedb40e
[warnigns] fix Wshorten-64-to-32
2024-11-11 10:22:37 +01:00
akallabeth
4ec28e1f82
[warnings] fix -Wimplicit-int-conversion
2024-10-31 11:42:29 +01:00
akallabeth
dcf5a8e28c
[warnings] fix -Wswitch-default
2024-10-31 11:42:24 +01:00
akallabeth
5f86284663
[core,orders] fix update_write_coord
...
* Add value range checks
* Add proper log message
* Add failure return
2024-10-25 11:48:14 +02:00
akallabeth
cc6850bf21
[warnings] fix format nonliteral
...
add pragma to suppress format nonliteral warnings where appropriate
2024-09-12 09:08:53 +02:00
akallabeth
36c3184a0f
[warnings] fix clang-tidy issues in libfreerdp
2024-08-29 15:34:22 +02:00
akallabeth
15456e1ee1
[warnings] fix implicit widening conversion
2024-08-29 10:47:20 +02:00
akallabeth
1d33095500
[warnings] fix cert-err33-c
...
Fix unused return values, cast to void if on purpose
2024-08-29 10:19:27 +02:00
akallabeth
5b4e39fd7e
[core,orders] shift unsigned value
...
The delta value read is signed, but the operations are done on an
unsigned.
2024-04-22 11:02:04 +02:00
Armin Novak
28e9094f08
[gcc] fix missing malloc warning macros
...
* Add missing WINPR_ATTR_MALLOC
* Add missing WINPR_PRAGMA_DIAG_IGNORED_MISMATCHED_DEALLOC
2024-04-17 18:47:16 +02:00
akallabeth
d7ebec5a65
[tidy] move loop variable declaration to loop
2024-02-22 12:31:50 +01:00
akallabeth
0ba995655d
[clang-tidy] cppcoreguidelines-init-variables
2024-02-15 11:49:16 +01:00
akallabeth
207def5c56
[clang-tidy] readability-isolate-declaration
2024-02-15 11:49:16 +01:00
akallabeth
ba8cf8cf21
[build] fix Wmismatched-deallocator warnings
...
With custom malloc function attributes the fail path in the _New
functions produces warnings due to allocator mismatches. Silence them.
2024-02-05 08:16:55 +01:00
akallabeth
cd4d77af86
[settings] add deprecation warnings
...
direct struct access to rdpSettings now produces warnings if not
explicitly deactiaved by defining FREERDP_SETTINGS_INTERNAL_USE
2023-11-24 14:54:56 +01:00
akallabeth
1163cc4d5c
[core] add internal settings.h include
2023-11-24 14:54:56 +01:00
akallabeth
7746c8f4ae
[core,orders] fix #9402 polyline order processing
2023-09-21 10:00:19 +02:00
Armin Novak
5f8f69512b
[core,orders] fix reading order number field
...
the field for delta rectangles/points/... are only transmitted if they
changed from the previous order of the same type. So keep the original
value and update only if a new one is read.
2023-09-04 12:24:57 +02:00
Armin Novak
12e6bbe13b
[core,orders] log order fields not in packet
2023-09-04 11:32:35 +02:00
Armin Novak
1a1f422d79
[core,orders] unify delta point buffer allocation
2023-09-04 11:32:35 +02:00
Armin Novak
36b58c0688
[core,orders] abort if required filed is not found
2023-09-04 11:32:35 +02:00
Armin Novak
618102b28f
[core,orders] update log message
2023-09-04 11:32:35 +02:00
Armin Novak
1bbed81041
[core,orders] fix checks for multi opaque rect
2023-08-28 13:07:28 +02:00
akallabeth
e51a5b33fb
[core,orders] fix undefined variable, unify log strings
2023-08-03 13:54:03 +02:00
ehdgks0627
2496037f03
Standardize failure messages for order functions
2023-08-03 13:54:03 +02:00
ehdgks0627
105ce6c56b
Update error message when update_read* function failed
2023-08-03 13:54:03 +02:00
Armin Novak
970f0c54e8
[stream] use const correct Stream_Pointer access
2023-06-08 08:09:33 +02:00
akallabeth
075506f6c8
[winpr,stream] use new Stream_CheckAndLogRequiredLength*
2023-01-25 14:27:32 +01:00
akallabeth
bc8b4ade1c
reformatted
2022-06-23 08:48:39 +02:00
akallabeth
6fd71fe737
Eliminate Dead nested assignment warnings
2022-04-28 12:37:19 +02:00
akallabeth
ec699f6c75
scanbuild fixes
2022-04-28 12:37:19 +02:00
akallabeth
73cdcdfe09
Logging and parser fixes ( #7796 )
...
* Fixed remdesk settings pointer
* Fixed sign warnings in display_write_monitor_layout_pdu
* Use freerdp_abort_connect_context and freerdp_shall_disconnect_context
* Added and updates settings
* info assert/dynamic timezone
* mcs assert/log/flags
* Fixed and added assertions for wStream
* Unified stream length checks
* Added new function to check for lenght and log
* Replace all usages with this new function
* Cleaned up PER, added parser logging
* Cleaned up BER, added parser logging
* log messages
* Modified Stream_CheckAndLogRequiredLengthEx
* Allow custom format and options
* Add Stream_CheckAndLogRequiredLengthExVa for prepared va_list
* Improved Stream_CheckAndLogRequiredLength
* Now have log level adjustable
* Added function equivalents for existing logger
* Added a backtrace in case of a failure is detected
* Fixed public API input checks
2022-04-19 14:29:17 +02:00
Armin Novak
4d03d7c0bf
Freerdp remove #ifdef HAVE_CONFIG_H
2022-03-03 11:26:48 +01:00
Armin Novak
b2ad47a809
Reorganized FreeRDP headers
2022-03-03 11:26:48 +01:00
Armin Novak
504336f796
Removed internal members of rdpPrimaryUpdate from API header
2022-01-18 11:24:23 +01:00
Armin Novak
3006c973c4
Removed internal members of rdpAltSecUpdate from API header
2022-01-18 11:24:23 +01:00
Armin Novak
d210ac5e33
Removed internal members of rdpUpdate from API header
2022-01-18 11:24:23 +01:00
akallabeth
3ccb96d52f
Fixed #7350 : Warnings with Stream_StaticInit
...
* Properly initialize the stream buffer
* Add Stream_StaticConstInit accepting a const buffer
* Modify API to return a pointer to the stream initialized
2021-10-14 12:11:16 +02:00
akallabeth
217e0caa18
Bitmap update fix ( #7349 )
...
* Added checks for bitmap width and heigth values
Data received from the server might have invalid values for bitmap
with or height. Abort parsing if such a value is found.
Reported by Sunglin from the Knownsec 404 team & 0103 sec team
* Added checks for glyph width & height
2021-10-12 12:26:22 +02:00
akallabeth
7b7e2d6f32
Prefer constant division over multiplication for length checks
2021-09-21 08:55:22 +02:00
