Commit Graph

7028 Commits

Author SHA1 Message Date
Armin Novak
8a24443ed6 [nodiscard] fix wrong attribute position 2026-02-24 16:10:11 +01:00
Armin Novak
a5751dfe07 [utils,signal] rename header, avoid warnings 2026-02-24 11:03:45 +01:00
Armin Novak
16a8d2bbe5 [utils,signal] fix compiler warnings 2026-02-24 09:38:59 +01:00
Armin Novak
546908ebeb [utils,signal] fix missing function declaration 2026-02-24 09:05:42 +01:00
akallabeth
86d8bf840d Merge pull request #12340 from akallabeth/smartcard-stop-fix
Smartcard stop fix
2026-02-23 17:06:12 +01:00
Armin Novak
c3c9a723e0 [core,gateway] fix rdg_pkt_type_to_string 2026-02-23 11:28:37 +01:00
Armin Novak
3d8bcd1c71 [core,gateway] parse [MS-TSGU] 2.2.10.5 HTTP_CHANNEL_RESPONSE_OPTIONAL Structure
just to avoid warnings about incompletely parsed packets. Currently
unused as no UDP support is implemented.
2026-02-23 11:10:18 +01:00
Armin Novak
1dde0b3eeb [codec,progressive] refine progressive decoding
Refinement of 1a7a4c508c that might
produce glitches.
2026-02-20 17:45:18 +01:00
Armin Novak
042d0dfd77 [channel,smartcard] fix logging issues 2026-02-20 12:04:57 +01:00
Armin Novak
33a8b879eb [utils,smartcard] stop context thread on cancel all
When cancelling all smartcard context related operations also trigger
smartcard_call_context_signal_stop to terminate all related threads.
2026-02-20 10:04:41 +01:00
Armin Novak
e8099c493d [utils,signal] implement windows handlers 2026-02-19 22:27:14 +01:00
Armin Novak
a1ebab4192 [utils,signal] split handlers per platform 2026-02-19 22:27:11 +01:00
Armin Novak
e05252cdea [codec,dsp] fix duplicate NULL checks 2026-02-18 13:24:50 +01:00
Armin Novak
72c4c14918 [gdi,shape] fix gdi_FillRect checks 2026-02-18 13:23:47 +01:00
Armin Novak
ab1675f2cb [gdi,graphics] fix gdi_Glyph_BeginDraw return checks 2026-02-18 13:15:56 +01:00
Armin Novak
cf86ec9ed0 [gdi] fix handling of empty regions
Do not abort if an empty update region is found, ignore it.
2026-02-17 16:38:36 +01:00
akallabeth
1b744c15fe Merge pull request #12319 from akallabeth/grow-reasonable
[allocations] fix growth of preallocated buffers
2026-02-17 15:23:17 +01:00
Armin Novak
118afc0b95 [allocations] fix growth of preallocated buffers
* Replace * 2 with * sizeof(WCHAR) for string usages
* Grow streams and other buffers reasonably, e.g. add 128 elements per
  try and check for possible overflows
* Add constant postfix to force them to 64bit
2026-02-17 13:54:34 +01:00
Armin Novak
df64d00a97 [warnings,api] fix -Wunused-result
With marking publid API [[nodiscard]] some problematic error checks in
the core library were uncovered. This commit addresses these
shortcomings.
2026-02-17 11:07:08 +01:00
Armin Novak
f3d23da0ae [codec,nsc] update function docs
* add doxygen for functions
* add support for scanline value 0
2026-02-17 09:15:33 +01:00
Armin Novak
169971607c [codec,nsc] fix use of nsc_process_message
the second width/height argument should reflect the destination buffer
pixel size
2026-02-17 08:38:04 +01:00
Armin Novak
24a23e3028 [codec,nsc] deprecate nsc_decompose_message
this function is just a wrapper around nsc_process_message with some
wStream handling around it. Since proper length checks are missing
deprecate it completely.
2026-02-17 08:32:39 +01:00
Armin Novak
caf6e7f2ec [codec,nsc] log decoder function parameter issues 2026-02-17 08:24:20 +01:00
Armin Novak
7d8fdce2d0 [codec,clear] fix destination checks
check against the correct nDstWidth/nDstHeight
2026-02-16 19:56:55 +01:00
Armin Novak
a0be5cb87d [codec,planar] fix missing destination bounds checks 2026-02-16 10:00:23 +01:00
akallabeth
a25b90adc2 Merge pull request #12311 from akallabeth/winpr-attr-nodiscard-fkt-ptr
Winpr attr nodiscard fkt ptr
2026-02-16 09:32:52 +01:00
Armin Novak
e0e6a7f800 [freerdp,warnings] properly handle function return 2026-02-16 09:18:37 +01:00
Armin Novak
13616cc67e [freerdp,codec] mark function pointers [[nodiscard]] 2026-02-16 09:18:35 +01:00
Armin Novak
f4d74c33fd [codec,nsc] bounds checks and doxygen
* Improve doxygen for nsc_process_message
* Improve bounds checks for nsc_process_message
2026-02-15 19:32:38 +01:00
Armin Novak
0746639629 [codec,clear] fix missing destination boundary checks 2026-02-15 19:19:07 +01:00
Armin Novak
361d73bc0e [core,settings] use WINPR_KBD_TYPE constants
To initialize FreeRDP_KeyboardType use WINPR_KBD_TYPE_IBM_ENHANCED
enum constant.
2026-02-15 19:18:54 +01:00
Armin Novak
65d59d3b3c [utils,smartcard] check stream length on padding
When reading optional padding in smartcard channel check if padding is
actually there.
2026-02-15 11:34:59 +01:00
Armin Novak
f5e20403d6 [codec,color] fix input length checks
* check cbBitsMask meets expected length
* Add logging for length failures
2026-02-13 19:39:21 +01:00
Armin Novak
9903e234e4 [core,gateway] fix sign warnings from tsg 2026-02-13 12:16:17 +01:00
Armin Novak
f0ee9d7b6f [core,test] fix use after free 2026-02-13 09:25:55 +01:00
Armin Novak
ccb79eb4d0 [core,test] make TestUtils verbose
* Add logging to TestUtils
2026-02-11 17:02:37 +01:00
Armin Novak
4542715e37 [core,test] Add definitions for TestUtils
The unit test needs some variables defined, ensure they are.
2026-02-11 16:46:48 +01:00
Armin Novak
1defc14055 [core,test] fix missing WITH_RESOURCE_VERSIONING 2026-02-11 09:56:55 +01:00
Armin Novak
f805a57b9d [utils,heplers] fix freerdp_getApplicationDetailsVersion 2026-02-10 19:27:44 +01:00
Armin Novak
e3981d8f02 [channels,rdpecam] fix integer types and warnings 2026-02-10 17:02:15 +01:00
Armin Novak
8d395b942b [primitives,test] replace sscanf 2026-02-10 16:56:49 +01:00
Armin Novak
af6e0e6241 [codec,test] replace fscanf in unit test 2026-02-10 16:38:19 +01:00
Armin Novak
e6252d191d [utils,http] replace sscanf 2026-02-10 16:38:15 +01:00
Armin Novak
79498a0d15 [common,assistance] remove extra braces 2026-02-10 15:53:04 +01:00
Armin Novak
82dbf58296 [core,settings] initialize settings with application details 2026-02-10 11:20:14 +01:00
Armin Novak
d9e81aed22 [core,smartcardlogon] use freerdp_getApplicationDetailsString 2026-02-10 11:20:13 +01:00
Armin Novak
baf31336a8 [utils,helpers] add freerdp_getApplicationDetailsString 2026-02-09 19:55:48 +01:00
Martin Fleisz
e4794883d1 Merge pull request #12283 from akallabeth/gw-relax
[core,gateway] relax TSG parsing
2026-02-09 10:40:30 +01:00
Armin Novak
5f958d5edf [core,gateway] relax TSG parsing
* Relax 2.2.9.2.1.5 TSG_PACKET_RESPONSE::responseDataLen checks, ignore
  padding data.
* Add stringification for TSG version caps
* Add log messages for caps
2026-02-09 10:19:36 +01:00
akallabeth
043179f916 [core,test] add utils tests
Add unit tests for getter/setter of freerdp_setApplicationDetails
2026-01-29 22:47:47 +01:00