Armin Novak
4e4f84d33d
[libfreerdp] mark internal functions [[nodiscard]]
2026-02-24 11:54:00 +01:00
Armin Novak
1dde0b3eeb
[codec,progressive] refine progressive decoding
...
Refinement of 1a7a4c508c that might
produce glitches.
2026-02-20 17:45:18 +01:00
Armin Novak
e05252cdea
[codec,dsp] fix duplicate NULL checks
2026-02-18 13:24:50 +01:00
Armin Novak
df64d00a97
[warnings,api] fix -Wunused-result
...
With marking publid API [[nodiscard]] some problematic error checks in
the core library were uncovered. This commit addresses these
shortcomings.
2026-02-17 11:07:08 +01:00
Armin Novak
f3d23da0ae
[codec,nsc] update function docs
...
* add doxygen for functions
* add support for scanline value 0
2026-02-17 09:15:33 +01:00
Armin Novak
169971607c
[codec,nsc] fix use of nsc_process_message
...
the second width/height argument should reflect the destination buffer
pixel size
2026-02-17 08:38:04 +01:00
Armin Novak
24a23e3028
[codec,nsc] deprecate nsc_decompose_message
...
this function is just a wrapper around nsc_process_message with some
wStream handling around it. Since proper length checks are missing
deprecate it completely.
2026-02-17 08:32:39 +01:00
Armin Novak
caf6e7f2ec
[codec,nsc] log decoder function parameter issues
2026-02-17 08:24:20 +01:00
Armin Novak
7d8fdce2d0
[codec,clear] fix destination checks
...
check against the correct nDstWidth/nDstHeight
2026-02-16 19:56:55 +01:00
Armin Novak
a0be5cb87d
[codec,planar] fix missing destination bounds checks
2026-02-16 10:00:23 +01:00
akallabeth
a25b90adc2
Merge pull request #12311 from akallabeth/winpr-attr-nodiscard-fkt-ptr
...
Winpr attr nodiscard fkt ptr
2026-02-16 09:32:52 +01:00
Armin Novak
e0e6a7f800
[freerdp,warnings] properly handle function return
2026-02-16 09:18:37 +01:00
Armin Novak
13616cc67e
[freerdp,codec] mark function pointers [[nodiscard]]
2026-02-16 09:18:35 +01:00
Armin Novak
f4d74c33fd
[codec,nsc] bounds checks and doxygen
...
* Improve doxygen for nsc_process_message
* Improve bounds checks for nsc_process_message
2026-02-15 19:32:38 +01:00
Armin Novak
0746639629
[codec,clear] fix missing destination boundary checks
2026-02-15 19:19:07 +01:00
Armin Novak
f5e20403d6
[codec,color] fix input length checks
...
* check cbBitsMask meets expected length
* Add logging for length failures
2026-02-13 19:39:21 +01:00
Armin Novak
af6e0e6241
[codec,test] replace fscanf in unit test
2026-02-10 16:38:19 +01:00
Armin Novak
39e33d9e9d
[utils,helpers] add application details getter/setter
...
* Allow an application to set a vendor/product/version namespace to search
for configuration files/settings/...
* Replace all FREERDP_VENDOR_STRING and similar macros with these
getters.
2026-01-29 22:47:45 +01:00
akallabeth
7990eec166
[freerdp] mark all WINPR_ATTR_MALLOC also nodiscard
2026-01-26 13:39:39 +01:00
akallabeth
84d3d99338
[clang-tidy] clean up code warnings
2026-01-19 13:05:26 +01:00
akallabeth
fb8efd45f2
[c,format] fix format string and review warnings
2026-01-16 13:36:14 +01:00
akallabeth
93952b87c3
[warnings,format] fix format string warnings
2026-01-16 13:22:45 +01:00
akallabeth
90f62bd353
Merge pull request #12150 from akallabeth/wlog-printf
...
Wlog printf format string checks
2026-01-16 13:01:55 +01:00
akallabeth
243ecf804b
[codec,clear] check clear_decomress glyphData
...
Check destination coordinates and lengths against the actual sizes. Log
every truncation accordingly
2026-01-16 12:22:46 +01:00
akallabeth
3bc1eeb4f6
[codec,color] add freerdp_glyph_convert_ex
...
The function freerdp_glyph_convert does not check input buffer length,
deprecate it and provide a replacement that does properly check.
2026-01-16 12:09:26 +01:00
akallabeth
e7b3365078
[c,printf] fix wlog format string to match arguments
2026-01-16 11:41:00 +01:00
akallabeth
b7b4af9d29
[c,printf] fix wlog format string to match arguments
2026-01-16 11:40:57 +01:00
akallabeth
0925a105f7
[c,printf] fix wlog format string to match arguments
2026-01-16 11:40:55 +01:00
akallabeth
56adce5914
[c,printf] fix wlog format string to match arguments
2026-01-16 11:40:52 +01:00
akallabeth
1bab198a2e
[codec,planar] fix decoder length checks
2026-01-15 13:45:34 +01:00
akallabeth
f8688b57f6
[codec,clear] fix off by one length check
2026-01-15 13:45:32 +01:00
akallabeth
25102b432f
[codec,clear] fix missing length checks
2026-01-15 13:45:29 +01:00
akallabeth
c4391827d7
[codec,clear] fix clear_resize_buffer checks
2026-01-15 13:45:27 +01:00
akallabeth
1a7a4c508c
[codec,progressive] fix progressive_rfx_upgrade_block
...
do not shift negative values, apply sign after shift.
2026-01-14 19:25:46 +01:00
Armin Novak
9b29f73392
[codec,yuv] fix Wimplicit-int-enum-cast warnings
2026-01-14 10:40:16 +01:00
Armin Novak
b1cbaaa9fb
[codec,dsp] fix Wimplicit-int-enum-cast warnings
2026-01-14 10:38:41 +01:00
akallabeth
0f7e40c1e5
[codec,dsp] fix sign warnings
2026-01-09 09:38:05 +01:00
akallabeth
5d781b1fce
[codec,h264] fix return types and range checks
...
* use proper enum return values for ffmpeg related functions
* add value range checks for H264_CONTEXT_OPTION_RATECONTROL
* fix various return values
2026-01-09 09:24:41 +01:00
Armin Novak
3a250af8f5
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:36 +01:00
Armin Novak
32e831506b
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:36 +01:00
Armin Novak
465b5e3ac8
[codec,nsc] split nsc_encode_next_rgba
...
Split function into smaller subfunctions handling one color format each.
2026-01-08 11:07:39 +01:00
Armin Novak
fe21afb9ae
[codec,xcrush] fix div/0 warning
2026-01-07 15:59:38 +01:00
akallabeth
48475aba72
[codec,ffmpeg] 8.0 dropped AV_PROFILE_AAC_MAIN
...
replace with AV_PROFILE_AAC_LOW which is supported by all aac
encoders/decoders
2025-11-18 21:07:27 +01:00
eduar-hte
387fa0201a
[codec,yuv] Align width and height for AVC444 decoding to 32
...
- Windows seems to be aligning to 32 in current versions of RDP, which
can be noticed in non-standard resolutions (that are not multiple of
32 after aligning to 16).
- 16-byte alignment was initially introduced in commit 8adc2ba
2025-10-14 20:01:17 +00:00
akallabeth
eae2e03adf
[codec,ffmpeg] fix missing const argument
2025-10-06 08:43:15 +02:00
Frieder Hannenheim
137268b8d7
dsp_ffmpeg: fix latency buildup during resampling
2025-10-02 15:12:01 +02:00
Armin Novak
8735c50e2f
[codec,interleaved] add some unit tests
...
* Create a unit test framework to allow compaing some input data to
expected output data
* Add a couple of test cases for encoder and decoder
* Add expected output data (of current implementation) to detect changes
in later iterations
2025-09-30 14:09:15 +02:00
Armin Novak
5fed3f4cfc
[codec,bitmap] fix sign of buffer
...
* Use a uint8_t buffer to avoid issues with casting to/from signed
* Refactor bitmap codec
2025-09-30 14:07:24 +02:00
Armin Novak
4aceae4666
[codec,color] Add from string method for PIXEL_FORMAT
...
* Add FreeRDPGetColorFromatFromName to get a PIXEL_FORMAT from a given
string.
* Add a unit test to ensure FreeRDPGetColorFromatFromName and
FreeRDPGetColorFormatName work as expected
2025-09-30 13:17:26 +02:00
akallabeth
74648eb3a9
[c,standard] use C99 inline
2025-09-26 11:29:26 +02:00