Commit Graph

604 Commits

Author SHA1 Message Date
Armin Novak
e6fca2c021 [winpr,stream] Fix Stream_SetPosition return checks 2026-03-02 11:37:20 +01:00
Armin Novak
92ab55c5e1 [winpr,stream] Add Stream_ResetPosition
A helper function that does not require return checks, in contrast to
Stream_SetPosition, which might fail.
2026-03-01 06:11:59 +01:00
Armin Novak
2c0c55dc46 [c23,channels] replace NULL with nullptr 2026-02-26 13:43:54 +01:00
Armin Novak
e58819830a [c23] simplify boolean checks 2026-02-26 11:51:05 +01:00
Armin Novak
48267edf2f [winpr] add WINPR_C_ARRAY_INIT
since C23 allows c++ style initializing replace direct use with this
macro
2026-02-25 19:23:08 +01:00
Armin Novak
e9723d1b61 [attributes] update attribute definitions
* support C++
* support C23
* replace __inline et al with C11 inline
2026-02-25 11:51:11 +01:00
Armin Novak
df64d00a97 [warnings,api] fix -Wunused-result
With marking publid API [[nodiscard]] some problematic error checks in
the core library were uncovered. This commit addresses these
shortcomings.
2026-02-17 11:07:08 +01:00
Armin Novak
0fefdd1274 [channels,audin|rdpsnd] fix enum cast warnings 2026-02-10 15:53:06 +01:00
Armin Novak
1ebc39f22f [channels,rdpsnd] use freerdp_getApplicationDetailsString
Use proper vendor/product name for pulse sinc.
2026-02-09 19:55:52 +01:00
akallabeth
afa6851dc8 [channel,rdpsnd] only clean up thread before free
rdpsnd channel usually has multiple instances (static, dynamic, ...) so
ensure only to terminate the handler thread when the channel is actually
closed for good.
2026-01-28 09:49:36 +01:00
akallabeth
622bb7b440 [channels,rdpsnd] terminate thread before free
Ensure that the optional rdpsnd thread is terminated and the message
queue freed up before releasing the channel context memory
2026-01-26 11:26:41 +01:00
akallabeth
fb8efd45f2 [c,format] fix format string and review warnings 2026-01-16 13:36:14 +01:00
akallabeth
50082f3b9f [c,printf] fix wlog format string to match arguments 2026-01-16 11:40:09 +01:00
akallabeth
f8141ac253 [c,printf] fix wlog format string to match arguments 2026-01-16 11:40:07 +01:00
akallabeth
d60045ae1a [chanels,various] fix VirtualChannelEntryEx parameter types 2026-01-13 17:11:27 +01:00
Armin Novak
59ad546d87 [clang,warnings] fix Wjump-misses-init 2026-01-08 11:32:34 +01:00
akallabeth
25b5b38d32 [CMake,client] add pkg-config dependencies 2025-09-11 07:17:52 +02:00
Armin Novak
4707b465cd [warnings] eliminate unused 2025-08-20 11:54:28 +02:00
akallabeth
65f18983ed [warnings] Fix format string errors
* Fix casts of format string arguments (%p requires void*)
* Fix format string to match type of arguments
2025-08-13 15:09:48 +02:00
Mark Nauwelaerts
3a4ead2e6c [rdpsnd/client] add parameters to pulse snd device plugin
... to specify pulseaudio client name and stream name
2025-04-24 21:41:06 +02:00
Armin Novak
1517d4681f [cmake] fix channel properties 2025-03-26 14:08:18 +01:00
akallabeth
cb8176d2e7 [channels,rdpsnd] fix warnings, add new fields
* Fix warnings in client and server channels
* Add some data read from packets to exported fields of RdpsndServerContext
2025-03-07 10:10:02 +01:00
akallabeth
6d541c8691 [warnings] eliminate dead code 2025-03-04 09:53:05 +01:00
akallabeth
7f68447de9 [channels,rdpsnd] fix android build warnings 2025-02-22 19:36:01 +01:00
akallabeth
12764b1ebe [warnings,android] fix build warnings 2025-02-22 15:22:01 +01:00
akallabeth
2b7d7356c1 [channels,warnings] fix -Wunused-parameter 2025-02-13 15:53:56 +01:00
akallabeth
93b8e17c91 [channels,rdpsnd] fix memory leak 2025-01-13 09:14:59 +01:00
akallabeth
be3ba1c425 [warnings,channels] fix integer casts 2024-12-25 13:29:07 +01:00
akallabeth
ac9cf26bce [cmake] fix define_channel_options
* fix usage of default value
* fix defaults of channels
* unify to single CMake function define_channel_options
2024-12-17 16:29:32 +01:00
akallabeth
83f2f21ad3 [warnigns] fix lots of bugprone warnings
* update-settings-tests: properly cast types in getter/setter
* wtypes: fix PHANDLE definition
* wStream: fix INT64 write function warnings
* Simplify HANDLE copy in channels, just assign after proper cast
2024-12-06 09:15:48 +01:00
akallabeth
faae38120c [cmake,format] reformat all cmake files 2024-11-27 20:41:48 +01:00
stephanebill
4f2afa8c47 spell check with codespell 2024-11-20 16:53:40 -05:00
akallabeth
78acedb40e [warnigns] fix Wshorten-64-to-32 2024-11-11 10:22:37 +01:00
akallabeth
dcf5a8e28c [warnings] fix -Wswitch-default 2024-10-31 11:42:24 +01:00
akallabeth
8b3f807a0a [warnings] fix format warnings 2024-10-17 20:47:29 +02:00
Martin Fleisz
966ddd13df Merge pull request #10694 from akallabeth/qa-fixes
Qa fixes
2024-10-03 13:09:06 +02:00
akallabeth
cfc37caeb8 [cmake] cleaning_configure_file
add a wrapper to automatically add generated files to clean target
2024-10-02 23:28:08 +02:00
akallabeth
ee81bb017b [warnings] fix assign enum
* add missing value for rdpecam
* use an integer for a badly designed API
2024-10-01 13:05:30 +02:00
akallabeth
574742bae8 [warnings] annotate readability-non-const-parameter 2024-10-01 13:05:19 +02:00
akallabeth
11b7633dc0 [channels] use Stream_BufferAs
For WTSVirtualChannelRead and WTSVirtualChannelWrite use Stream_BufferAs
to cast to correct type.
2024-10-01 10:28:13 +02:00
akallabeth
55177e0e46 [channels,rdpsnd] remove dead code 2024-10-01 10:18:48 +02:00
akallabeth
4b60f0651c [channels] Fix PulseAudio assertions/NULL checks 2024-09-23 12:01:13 +02:00
akallabeth
ae3330d63d [codec,dsp] reorganize experimental codecs
* Remove ALAW/µULAW from sound channels
* Make everything except PCM and AAC experimental
2024-09-23 12:01:11 +02:00
akallabeth
586f40631f [warnings] fix shorten-64-to-32 2024-09-17 16:13:48 +02:00
akallabeth
bb242b9a89 [return checks] fix use of WaitForSingleObject 2024-09-16 08:22:37 +02:00
akallabeth
965d231e49 [return checks] fix use of CloseHandle 2024-09-16 08:22:31 +02:00
akallabeth
7d67b8e204 [return checks] fix use of SetEvent 2024-09-16 06:47:58 +02:00
akallabeth
8b6091a007 [winpr,wtsapi] improve API usage
* Mark WTSVirtualChannelOpen and WTSVirtualChannelOpenEx with
  WINPR_ATTR_MALLOC to enforce compiler checks for resource cleanup
* Fix unused result warnings, use the result or cast to (void) where not
  requierd
2024-09-14 21:29:31 +02:00
akallabeth
31ef07ead7 [warnings] fix tautological unsigned zero compare 2024-09-11 20:50:30 +02:00
akallabeth
245afb706c [function pointers] unify casts with macro 2024-09-04 20:06:45 +02:00