7086 Commits

Author SHA1 Message Date
Armin Novak
e6252d191d [utils,http] replace sscanf 2026-02-10 16:38:15 +01:00
Armin Novak
79498a0d15 [common,assistance] remove extra braces 2026-02-10 15:53:04 +01:00
Armin Novak
82dbf58296 [core,settings] initialize settings with application details 2026-02-10 11:20:14 +01:00
Armin Novak
d9e81aed22 [core,smartcardlogon] use freerdp_getApplicationDetailsString 2026-02-10 11:20:13 +01:00
Armin Novak
baf31336a8 [utils,helpers] add freerdp_getApplicationDetailsString 2026-02-09 19:55:48 +01:00
Martin Fleisz
e4794883d1 Merge pull request #12283 from akallabeth/gw-relax
[core,gateway] relax TSG parsing
2026-02-09 10:40:30 +01:00
Armin Novak
5f958d5edf [core,gateway] relax TSG parsing
* Relax 2.2.9.2.1.5 TSG_PACKET_RESPONSE::responseDataLen checks, ignore
  padding data.
* Add stringification for TSG version caps
* Add log messages for caps
2026-02-09 10:19:36 +01:00
akallabeth
043179f916 [core,test] add utils tests
Add unit tests for getter/setter of freerdp_setApplicationDetails
2026-01-29 22:47:47 +01:00
Armin Novak
39e33d9e9d [utils,helpers] add application details getter/setter
* Allow an application to set a vendor/product/version namespace to search
  for configuration files/settings/...
* Replace all FREERDP_VENDOR_STRING and similar macros with these
  getters.
2026-01-29 22:47:45 +01:00
akallabeth
fe7c5ab7e9 [core,settings] improve rdpMonitor log
stringify the orientation value in the log message.
2026-01-29 22:06:34 +01:00
Jonas Ådahl
4ea803134e peer: Disconnect if Logon() returned FALSE
Returning FALSE implies the client was not authorized, but it does not
have any real impact on the connection, other than setting the
authorized field.

Change this by disconnecting the client if a Logon() callback returned
that a client was not authorized.
2026-01-27 19:39:42 +01:00
Armin Novak
92fde0f6b3 [gdi] add additional checks for a valid rdpGdi
some client implementations do not properly set up the gdi, so abort
gracefully.
2026-01-27 15:07:10 +01:00
akallabeth
076a8386a6 Merge pull request #12186 from akallabeth/error-handling-fixes
Error handling fixes
2026-01-26 17:05:19 +01:00
akallabeth
7990eec166 [freerdp] mark all WINPR_ATTR_MALLOC also nodiscard 2026-01-26 13:39:39 +01:00
akallabeth
3f163cee9c [warnings] fix unused result warnings 2026-01-26 13:22:24 +01:00
akallabeth
ec4c4ee5a3 [channels,rdpei] refactor variable names 2026-01-26 11:09:53 +01:00
akallabeth
5013b28e8b Merge pull request #12171 from jadahl/wip/ntlm-kerberos-package-info
Add support for querying SECPKG_ATTR_PACKAGE_INFO to NTLM and Kerberos
2026-01-25 17:04:48 +01:00
akallabeth
eb83f339b4 [channels,rdpdr] flag definition and stringify
* Use a enum to define RDPDR_DTYP_* constants
* Add public API freerdp_device_type_string for stringify
* Add WINPR_ATTR_NODISCARD in rdpdr_utils.h
2026-01-25 09:15:05 +01:00
akallabeth
09ae30a0f9 [core,settings] define OrderSupport flags and stringify
* Define OrderSupportFlags as enum
* Add public API stringify function
2026-01-25 09:14:59 +01:00
akallabeth
6673e8a86f [core,utils] add freerdp_input_touch_state_string
* Add freerdp_input_touch_state_string
* Remove duplicate from xfreerdp
2026-01-25 09:00:03 +01:00
akallabeth
a8ca59e290 [channels,disp] Unify definitions and add stringify
* Unify FreeRDP_DesktopRotationFlags definitions (needed in settings
  and display channel)
* Add stringify function for the flags
2026-01-25 08:55:58 +01:00
akallabeth
dde93d1aa2 [utils,signal] unregister signal handler on termination 2026-01-23 22:20:56 +01:00
Jonas Ådahl
e6aa564bd7 Add freerdp_nla_FreeContextBuffer()
This function should be used to free certain buffers retrieved using
freerdp_nla_QueryContextAttributes(). It fetches the right vfunc table
to call into, which typically ends up in sspi_FreeContextBuffer() in
sspi_winpr.c.

This is needed to allow querying the PackageInfo attribute.
2026-01-22 12:50:24 +01:00
Armin Novak
43e3b862af [warnings] fix initialization skip warnings 2026-01-21 16:41:26 +01:00
Armin Novak
01e1f1b595 [crypto] deprecate er and der modules
These are unused and not well tested, mark them deprecated to announce
removal once FreeRDP 4 is released.
2026-01-21 16:41:25 +01:00
Armin Novak
c9d1e371d2 [gateway,tsg] fix unused variable warning 2026-01-21 13:19:56 +01:00
Armin Novak
ea00e5ea4d [gateway,tsg] fix idleTimeout parsing 2026-01-21 12:55:25 +01:00
Armin Novak
9c2e50408a [gateway,tsg] log if unparsed data is detected 2026-01-21 12:55:25 +01:00
Armin Novak
de4109b0a7 [gateway,rdg] log unparsed data if detected 2026-01-21 12:55:24 +01:00
akallabeth
8a53798049 [core,freerdp] eliminate uninitialized warning 2026-01-20 17:15:13 +01:00
akallabeth
4794296e4f Merge pull request #12162 from jadahl/wip/server-kerberos-auth-identity
Allow querying auth identity with kerberos when running as a server
2026-01-20 16:26:38 +01:00
Jonas Ådahl
f93564bb69 Handle querying nla context attributes via the transport
When running as a server, the rdpContext struct doesn't have a rdpNla
instance, so for freerdp_nla_QueryContextAttributes() to work, it has to
use the rdpNla instance from the transport. Note that this instance is
only valid during authentication, though thus usable from the Logon
callback.
2026-01-20 16:04:25 +01:00
akallabeth
36ae046685 [gateway,tsg] fix TSG_PACKET_RESPONSE parsing
* Fix parsing to conform to [MS-TSGU] 2.2.9.2.1.5 TSG_PACKET_RESPONSE
* Deactivate TSG_NAP_CAPABILITY_QUAR_SOH (simplifies parsing)
* Add proper logging for expected parser violations
2026-01-20 14:58:46 +01:00
akallabeth
4d44e3c097 [core,info] fix missing NULL check 2026-01-19 20:11:44 +01:00
akallabeth
84d3d99338 [clang-tidy] clean up code warnings 2026-01-19 13:05:26 +01:00
akallabeth
52106a2672 [cache,offscreen] invalidate bitmap before free
First ensure the bitmap is no longer used for drawing before calling the
free function.
2026-01-19 08:59:05 +01:00
akallabeth
b86369beb7 [core,tcp] fix freerdp_tcp_connect_timeout size type 2026-01-16 13:47:25 +01:00
akallabeth
fb8efd45f2 [c,format] fix format string and review warnings 2026-01-16 13:36:14 +01:00
akallabeth
832da09b3e [utils,rdpdr] force constant to unsigned 2026-01-16 13:22:48 +01:00
akallabeth
93952b87c3 [warnings,format] fix format string warnings 2026-01-16 13:22:45 +01:00
akallabeth
90f62bd353 Merge pull request #12150 from akallabeth/wlog-printf
Wlog printf format string checks
2026-01-16 13:01:55 +01:00
akallabeth
243ecf804b [codec,clear] check clear_decomress glyphData
Check destination coordinates and lengths against the actual sizes. Log
every truncation accordingly
2026-01-16 12:22:46 +01:00
akallabeth
9f0eb3b7d4 [gdi,graphics] Use freerdp_glyph_convert_ex 2026-01-16 12:09:29 +01:00
akallabeth
3bc1eeb4f6 [codec,color] add freerdp_glyph_convert_ex
The function freerdp_glyph_convert does not check input buffer length,
deprecate it and provide a replacement that does properly check.
2026-01-16 12:09:26 +01:00
akallabeth
a1f2ea503e [cmake,format] fix source code formatting 2026-01-16 11:47:25 +01:00
akallabeth
acb9363349 [c,printf] fix wlog format string to match arguments 2026-01-16 11:42:24 +01:00
akallabeth
4098ee0739 [c,printf] fix wlog format string to match arguments 2026-01-16 11:42:21 +01:00
akallabeth
a6c2be446c [c,printf] fix wlog format string to match arguments 2026-01-16 11:42:17 +01:00
akallabeth
c23f83b970 [c,printf] fix wlog format string to match arguments 2026-01-16 11:42:15 +01:00
akallabeth
a2af4ff0f5 [c,printf] fix wlog format string to match arguments 2026-01-16 11:42:13 +01:00