Armin Novak
a098084d04
[core,nla] fix Wimplicit-int-enum-cast warnings
2026-01-14 10:39:13 +01:00
Armin Novak
47dfe2c6e6
[core,autodetect] fix Wimplicit-int-enum-cast warnings
2026-01-14 10:38:58 +01:00
akallabeth
085f4e9705
[core,client] fix SVC channel init calls
...
Ensure correct types are passed and returned.
2026-01-13 17:11:24 +01:00
akallabeth
d8810c2b65
[core,orders] fix brush update decoding
2026-01-13 07:52:56 +01:00
akallabeth
1ed5e53c3b
[core,gcc] fix integer promotion issue
2026-01-12 11:37:34 +01:00
akallabeth
11ca842135
[core,gateway] ignore unknown http headers
2026-01-10 07:55:52 +01:00
akallabeth
720de91336
[core,gateway] refactor http_response_parse_header_field
...
Ensure there are no NULL dereferences
2026-01-09 11:56:06 +01:00
akallabeth
4819742644
[core,tcp] freerdp_host_connect fix double free
...
let freerdp_host_connect clean up resources, get_next_addrinfo only
flags success or error
2026-01-09 11:56:04 +01:00
akallabeth
a46d813ca9
[core,tcp] fix freerdp_vsock_connect socket leaks
2026-01-09 11:56:01 +01:00
akallabeth
ef93393152
[core,nla] add value range checks
...
When reading a enum value from network, first check the value range and
abort with a log message if an invalid value is found
2026-01-09 09:38:03 +01:00
akallabeth
f87cb28a44
[core,gateway] add rts value range checks
...
When reading a enum value from network, first check the value range and
abort with a log message if an invalid value is found
2026-01-09 09:38:00 +01:00
akallabeth
9b733b7d23
[core,mcs] fix mcs_read_domain_mcspdu_header
...
add value range checks for MCSPDU and set to DomainMCSPDU_invalid if
an invalid value is found.
2026-01-09 09:24:49 +01:00
akallabeth
541b6a90ae
[core,rdp] fix various return values
...
The return value type did not match declaration
2026-01-09 09:24:46 +01:00
akallabeth
db7b00da2a
[core,input] fix SyncEventFlag2Str
...
Use uint32_t as parameter instead of enum KBD_SYNC_FLAGS, the value
might be outside of the enum range.
2026-01-09 09:24:43 +01:00
akallabeth
9fc9181473
[core,codecs] fix freerdp_codec_id_to_str
...
Use UINT32 as argument instead of enum RDP_CODEC_ID as the value might
be an invalid value in the enum.
2026-01-09 09:24:31 +01:00
Armin Novak
164dfef442
[warnings] fix signed/unsigned compare warnings
2026-01-09 09:24:19 +01:00
akallabeth
df26d30c84
[core,gateway] fix WINPR_CIPHER_TYPE initial value
2026-01-09 09:24:12 +01:00
Ondrej Holy
72585691fd
[core,tcp] Fix PreferIPv6OverIPv4 fallback to IPv4 addresses
...
Currently, when the `FreeRDP_PreferIPv6OverIPv4` option is `TRUE` and
the `getaddrinfo` function returns IPv4 addresses before IPv6 addresses,
the code tries all IPv6 addresses, but it doesn't try any IPv4 address.
This happens because the `get_next_addrinfo` function skips to the first
IPv6 address, but never goes back to try IPv4 addresses that appeared
earlier in the list. Let's fix this by reordering the address list
first when the `PreferIPv6OverIPv4` option is `TRUE`.
Co-Authored-By: Claude <noreply@anthropic.com >
Related: https://github.com/FreeRDP/FreeRDP/issues/5335
2026-01-08 16:36:37 +01:00
Ondrej Holy
0bdd8da099
[core,tcp] Don't ignore connect errors
...
The `freerdp_tcp_connect_timeout` function doesn't fail currently in the
case of connection failure (e.g. destination unreachable). It fails only
in the case of the `WSAECONNRESET` error. That seems to be regression from
the refactoring made by commit e6c23cb5 . Let's use again the recommended
`getsockopt` function with the `SO_ERROR` argument to check for errors and
fail for all kinds of errors. The nice side-effect is that FreeRDP now
fails with "Failed to connect" instead of "Broken pipe" error.
Co-Authored-By: Claude <noreply@anthropic.com >
Related: https://github.com/FreeRDP/FreeRDP/issues/5335
2026-01-08 16:36:37 +01:00
Ondrej Holy
bd67348eb3
[core,tcp] Try next DNS entry on connect failure
...
FreeRDP still fails to connect when first DNS entry is unreachable. The
commit 4286a4c doesn't fix that unfortunately. It tries to create a socket
for all DNS entries until the socket is created, but it doesn't verify
that it is actually possible to connect to that socket. Let's call also
the `freerdp_tcp_connect_timeout` function for all the entries until success.
Co-Authored-By: Claude <noreply@anthropic.com >
Related: https://github.com/FreeRDP/FreeRDP/issues/5335
2026-01-08 16:36:37 +01:00
Armin Novak
e65d488a51
[core,tcp] refactor freerdp_tcp_default_connect
2026-01-08 16:36:37 +01:00
Armin Novak
90eae383ee
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:47 +01:00
Armin Novak
7b8bbd7fd9
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:47 +01:00
Armin Novak
c307aa23c8
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:47 +01:00
Armin Novak
a63165939d
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:47 +01:00
Armin Novak
385e697f34
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:40 +01:00
Armin Novak
c173891d78
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:40 +01:00
Armin Novak
e935146e07
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:40 +01:00
Armin Novak
8ba3babc09
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:40 +01:00
Armin Novak
fe63c0a362
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:40 +01:00
Armin Novak
bc76a09d3b
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:40 +01:00
Armin Novak
4047139905
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:40 +01:00
Armin Novak
97c435d5ed
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:39 +01:00
Armin Novak
5985bda2b0
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:39 +01:00
Armin Novak
ab75b85531
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:39 +01:00
Armin Novak
40704c5213
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:39 +01:00
Armin Novak
d93e09e942
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:39 +01:00
Armin Novak
f7c0bdca6a
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:39 +01:00
Armin Novak
9272d8b255
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:38 +01:00
Armin Novak
d22df6c6e5
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:38 +01:00
Armin Novak
ad80c7a719
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:38 +01:00
Armin Novak
5224c35fe0
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:38 +01:00
Armin Novak
38d1eaf0b0
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:38 +01:00
Armin Novak
2f3c9aff3c
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:37 +01:00
Armin Novak
6e5993c768
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:37 +01:00
Armin Novak
383255409e
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:37 +01:00
Armin Novak
c607056f93
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:37 +01:00
Armin Novak
a177d4af39
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:37 +01:00
Armin Novak
af8c75f196
[core] fix nonstring warnings
...
Initialize variables as arrays to avoid nonstring warnings with gcc >=
15 and clang
2026-01-08 09:43:22 +01:00
Armin Novak
3e6dda95c2
[core,mcs] replace rdpTransport pointer with rdpContext
...
Only keep pointers to rdpContext so updates/changes to rdpTransport are
not leading to dangling pointers
2026-01-08 09:24:32 +01:00