361 Commits

Author SHA1 Message Date
Armin Novak
5c510af477 [c23,freerdp] replace NULL with nullptr 2026-02-26 15:06:27 +01:00
Armin Novak
0531803808 [warnings] make function declaration names consistent
Use the same parameter names for declaration and implementation.
2026-02-26 10:35:25 +01:00
Armin Novak
48267edf2f [winpr] add WINPR_C_ARRAY_INIT
since C23 allows c++ style initializing replace direct use with this
macro
2026-02-25 19:23:08 +01:00
Armin Novak
361d73bc0e [core,settings] use WINPR_KBD_TYPE constants
To initialize FreeRDP_KeyboardType use WINPR_KBD_TYPE_IBM_ENHANCED
enum constant.
2026-02-15 19:18:54 +01:00
Armin Novak
82dbf58296 [core,settings] initialize settings with application details 2026-02-10 11:20:14 +01:00
Armin Novak
39e33d9e9d [utils,helpers] add application details getter/setter
* Allow an application to set a vendor/product/version namespace to search
  for configuration files/settings/...
* Replace all FREERDP_VENDOR_STRING and similar macros with these
  getters.
2026-01-29 22:47:45 +01:00
akallabeth
fe7c5ab7e9 [core,settings] improve rdpMonitor log
stringify the orientation value in the log message.
2026-01-29 22:06:34 +01:00
akallabeth
7990eec166 [freerdp] mark all WINPR_ATTR_MALLOC also nodiscard 2026-01-26 13:39:39 +01:00
akallabeth
614330ae8b [c,printf] fix wlog format string to match arguments 2026-01-16 11:41:45 +01:00
Armin Novak
4047139905 [clang,warnings] fix Wjump-misses-init 2026-01-08 11:32:40 +01:00
akallabeth
c8698a1b9c [core,settings] add new keys for gateway
Add missing settings:
* FreeRDP_GatewayHttpReferer
* FreeRDP_GatewayHttpUserAgent
* FreeRDP_GatewayHttpMsUserAgent
2025-10-28 11:13:52 +01:00
akallabeth
28527513b0 [core,settings] do not check for NULL
TargetNet* values might be NULL on copy, do not assert them.
2025-09-15 15:15:00 +02:00
David Fort
503416b532 settings: remove duplicate setting of GatewayAvdScope 2025-09-05 09:25:34 +02:00
akallabeth
e52d024071 [core,settings] unify config path determination 2025-08-29 10:53:26 +02:00
akallabeth
83ffa524e9 [core,settings] fix ReceivedCapabilities reset 2025-08-26 12:09:09 +02:00
akallabeth
ec8f2b5dde [common,settings] force reallocation on caps copy 2025-07-01 09:49:44 +02:00
akallabeth
419ad81aa7 Revert "[core,settings] default MonitorIds size to MonitorDefArray size"
This reverts commit 90a737d48f.

The array is initially empty. Only via command line option or RDP file
setting it will be populated.

Any use by a client later on requires the client to initialize the array
according to its needs
2025-06-23 11:01:55 +02:00
Armin Novak
90a737d48f [core,settings] default MonitorIds size to MonitorDefArray size 2025-06-11 10:14:15 +02:00
akallabeth
6168a7bfd1 [client,common] make all azure settings configurable 2025-06-10 16:30:06 +02:00
gpotter2
9fce51d7ee Add FreeRDP_RestrictedAdminModeSupported for server-side 2025-05-05 20:15:31 +02:00
akallabeth
06564e4bc2 [core,settings] fix freerdp_device_collection_add
* Assert usage of DeviceArray, ensure returned values are != NULL if
  within DeviceCount
* Only reset newly allocated DeviceArray members on resize
2025-04-25 10:21:37 +02:00
Armin Novak
a4c4bad132 [common,settings] new settings (de)serialization API
* Add rdpKey to PEM conversion
* Modify WINPR_JSON_Version to return -1 if not supported
* Add rdpSettings serialize and deserialize functions
2025-04-22 12:00:48 +02:00
Armin Novak
e92f0170e4 [core,settings] handle empty OrderSupport and received capabilities 2025-04-15 16:09:46 +02:00
akallabeth
87dbdae34b [core,settings] enforce OrderSupportFlags
After client preConnect callback and server peer initialize ensure that
the OrderSupportFlags are consistent with the other settings
2025-04-04 12:02:57 +02:00
Martin Fleisz
db7ac382c1 core: Default display channel to ON
Default dynamic resolution support to enabled as it is specified by the
MS RDP settings here: https://learn.microsoft.com/en-us/azure/virtual-desktop/rdp-properties#dynamic-resolution
2025-03-10 12:45:07 +01:00
akallabeth
74cd8d8fe0 [freerdp,warnings] fix -Wunused-parameter 2025-02-13 15:53:54 +01:00
akallabeth
567887fbb0 [core,settings] Fix MONITOR_DEF settings
* Make FreeRDP_MonitorLocalShiftX and FreeRDP_MonitorLocalShiftY signed
* Add function freerdp_settings_set_monitor_def_array_sorted to proplery
  align the MONITOR_DEF array according to RDP requirements
2025-01-19 15:30:56 +01:00
akallabeth
733f1abebd [core,settings] ensure MonitorDefArray exists
in freerdp_settings_enforce_monitor_exists ensure the array has a valid
size before trying to set a value.
2024-12-19 16:10:20 +01:00
akallabeth
91ae892f91 [winpr,sysinfo] fix use of GetComputerNameExA
The buffer must be large enough to hold MAX_COMPUTERNAME_LENGTH
characters, so the buffer needs to be of size MAX_COMPUTERNAME_LENGTH +
1 or larger to hold the '\0' terminated string.
2024-12-16 17:11:54 +01:00
akallabeth
1b6fb6fd41 [core,settings] fix initialization of ComputerName 2024-12-16 08:20:22 +01:00
akallabeth
e375556d07 [winpr,sysinfo] fix GetComputerNameA
* Trunctate to at most MAX_COMPUTERNAME_LENGTH characters
* Fix usage of function
2024-12-15 18:09:15 +01:00
akallabeth
9909ae2eb4 [core,settings] fix missing setting copy 2024-12-12 15:49:11 +01:00
David Fort
369b6d0244 Refactor settings copy
The patch refactors a bit all the copy of settings of type pointer that must have
the blob duplicated when settings are cloned.
2024-12-12 14:53:42 +01:00
akallabeth
c0a1697a1c [core,settings] copy FreeRDP_RedirectionGuid 2024-12-12 12:09:31 +01:00
akallabeth
f25be351b1 [core,gateway] Make tenantid use optional 2024-12-10 15:13:16 +01:00
Armin Novak
f17c1830b7 [aad,avx] improve AzureAD support
* New setting GatewayAzureActiveDirectory to fetch wellknown from
* Clean up command line arguments, rename to make function better
  understandable
2024-12-10 15:12:41 +01:00
akallabeth
1905117465 [core,aad] unify client id
* use a setting to make it configurable
2024-12-10 15:12:32 +01:00
akallabeth
83f2f21ad3 [warnigns] fix lots of bugprone warnings
* update-settings-tests: properly cast types in getter/setter
* wtypes: fix PHANDLE definition
* wStream: fix INT64 write function warnings
* Simplify HANDLE copy in channels, just assign after proper cast
2024-12-06 09:15:48 +01:00
David Fort
f0f830f3e9 Cleanup freerdp_settings_set_pointer_len_
Instead of doing convertions to SSIZE_T for the key length id, use FreeRDP_UINT32_UNUSED
when a pointer has no associated len key.
2024-12-04 13:45:39 +01:00
akallabeth
646cacca0e [core,settings] add instructions on fail
Add bug reporting instructions for failing monitor configurations
2024-12-03 13:06:29 +01:00
akallabeth
d48cd481e7 [core,settings] dump monitor configuration to log 2024-12-03 13:00:54 +01:00
akallabeth
49f1689496 [core,settings] verbose output on monitor layout failure 2024-12-02 21:01:25 +01:00
akallabeth
f1e4b30507 clang-format after spellcheck changes 2024-11-21 09:53:00 +01:00
stephanebill
4f2afa8c47 spell check with codespell 2024-11-20 16:53:40 -05:00
Martin Fleisz
c7486fc47b Merge pull request #10801 from akallabeth/cleanups
Cleanups
2024-11-07 13:03:36 +01:00
akallabeth
7e7ea3e688 [core,settings] WINPR_ATTR_MALLOC for alloc_array 2024-11-07 11:46:50 +01:00
akallabeth
4ec28e1f82 [warnings] fix -Wimplicit-int-conversion 2024-10-31 11:42:29 +01:00
akallabeth
dcf5a8e28c [warnings] fix -Wswitch-default 2024-10-31 11:42:24 +01:00
akallabeth
392a085728 [core,settings] enforce fullscreen monitor requirements
* Monitor must start at 0/0
* Monitor must be primary
2024-10-24 11:32:10 +02:00
akallabeth
401f81683c [core,settings] fake monitor in window mode
RDP requires sending monitor information to the server. If we are in
windowed mode fake that information with the windows size
2024-10-24 11:32:03 +02:00