Armin Novak
4475e21b7e
[codec,rfx] return nullptr if input parameters are invalid
...
rfx_encode_messages maxDataSize must be > 1024 or the function will
fail. Add a check to abort early if this is the case.
while this is a usage error, it is helpful to have proper error handling
in the function as well.
2026-03-03 09:30:33 +01:00
Armin Novak
35831303ea
[various] add proper return checks
2026-03-02 18:32:38 +01:00
Armin Novak
5c510af477
[c23,freerdp] replace NULL with nullptr
2026-02-26 15:06:27 +01:00
Armin Novak
0531803808
[warnings] make function declaration names consistent
...
Use the same parameter names for declaration and implementation.
2026-02-26 10:35:25 +01:00
Armin Novak
48267edf2f
[winpr] add WINPR_C_ARRAY_INIT
...
since C23 allows c++ style initializing replace direct use with this
macro
2026-02-25 19:23:08 +01:00
Armin Novak
4e4f84d33d
[libfreerdp] mark internal functions [[nodiscard]]
2026-02-24 11:54:00 +01:00
Armin Novak
df64d00a97
[warnings,api] fix -Wunused-result
...
With marking publid API [[nodiscard]] some problematic error checks in
the core library were uncovered. This commit addresses these
shortcomings.
2026-02-17 11:07:08 +01:00
Armin Novak
39e33d9e9d
[utils,helpers] add application details getter/setter
...
* Allow an application to set a vendor/product/version namespace to search
for configuration files/settings/...
* Replace all FREERDP_VENDOR_STRING and similar macros with these
getters.
2026-01-29 22:47:45 +01:00
Armin Novak
3a250af8f5
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:36 +01:00
akallabeth
74648eb3a9
[c,standard] use C99 inline
2025-09-26 11:29:26 +02:00
Armin Novak
00968fd6e6
[codec] use default threadpool
2025-09-03 16:22:41 +02:00
akallabeth
65f18983ed
[warnings] Fix format string errors
...
* Fix casts of format string arguments (%p requires void*)
* Fix format string to match type of arguments
2025-08-13 15:09:48 +02:00
akallabeth
dfdd9f4fe1
[codec,rfx] fix invalid region calculation
2025-04-10 20:46:18 +02:00
akallabeth
1fe0ca41e1
[warnings] fix missing integer casts
2025-03-11 13:20:19 +01:00
akallabeth
054275bd5d
[warnings] fix sign and narrowing issues
2025-03-10 19:19:28 +01:00
akallabeth
74cd8d8fe0
[freerdp,warnings] fix -Wunused-parameter
2025-02-13 15:53:54 +01:00
akallabeth
8232c845a7
[codec,rfx] fix a rectangle leak
2025-01-13 09:15:02 +01:00
akallabeth
ac4be9b941
[codec,rfx] fix region leak
2025-01-12 15:13:13 +01:00
akallabeth
cc934795e4
[warnings] fix integer casting
...
* use asserting casts to detect overflows or sign conversions
* code cleanup for issues uncovered by casts
2025-01-01 12:58:34 +01:00
akallabeth
83f2f21ad3
[warnigns] fix lots of bugprone warnings
...
* update-settings-tests: properly cast types in getter/setter
* wtypes: fix PHANDLE definition
* wStream: fix INT64 write function warnings
* Simplify HANDLE copy in channels, just assign after proper cast
2024-12-06 09:15:48 +01:00
stephanebill
4f2afa8c47
spell check with codespell
2024-11-20 16:53:40 -05:00
akallabeth
78acedb40e
[warnigns] fix Wshorten-64-to-32
2024-11-11 10:22:37 +01:00
akallabeth
384cd284d8
[warnings] use WINPR_CAST_CONST_AWAY
...
on locations that require (ugly) const to non const casts usw
WINPR_CAST_CONST_AWAY to do proper compiler specific casts to avoid
warnings
2024-09-11 23:41:50 +02:00
akallabeth
9c9d74e920
[warnings] fix redundant casts
2024-08-29 12:03:09 +02:00
akallabeth
15456e1ee1
[warnings] fix implicit widening conversion
2024-08-29 10:47:20 +02:00
akallabeth
2ee987e665
[cmake,codec] refactor codec
...
* move sse and neon implementations to own subdirectories
* add stubs for missing optimizations (with log messages)
2024-06-11 12:16:20 +02:00
akallabeth
4b93a9fffa
[codec,rfx] inline and restrict
2024-06-03 17:54:21 +02:00
akallabeth
1b3f3a0408
[codec,color] expose freerdp_image_copy (no)overlap
...
expose functions for overlapping and non overlapping images to use
directly
2024-05-23 14:48:36 +02:00
Armin Novak
28e9094f08
[gcc] fix missing malloc warning macros
...
* Add missing WINPR_ATTR_MALLOC
* Add missing WINPR_PRAGMA_DIAG_IGNORED_MISMATCHED_DEALLOC
2024-04-17 18:47:16 +02:00
akallabeth
bcf189b6b3
[codec,rfx] explicitly cast return
...
cast to avoid compilation issues with incompatible-pointer-types
2024-03-18 13:27:32 +01:00
akallabeth
d7ebec5a65
[tidy] move loop variable declaration to loop
2024-02-22 12:31:50 +01:00
akallabeth
f69e1fe697
[clang-tidy] readability-duplicate-include
2024-02-15 11:49:16 +01:00
akallabeth
0ba995655d
[clang-tidy] cppcoreguidelines-init-variables
2024-02-15 11:49:16 +01:00
akallabeth
207def5c56
[clang-tidy] readability-isolate-declaration
2024-02-15 11:49:16 +01:00
akallabeth
8be124b4a2
[codec,rfx] revert removal of rfx_message_get_frame_idx
2023-10-10 19:35:27 +02:00
akallabeth
a41360e3b0
[codec,rfx] added missing RFX encoder API calls
2023-10-07 21:26:27 +02:00
liuxiaojun
6e5f74e462
optimize idwt extrapolate decoder with neon
2023-08-22 10:54:48 +02:00
Armin Novak
e204fc8be5
[coded,rfx] check indices are within range
...
reported by @pwn2carr
2023-08-21 11:41:06 +02:00
Armin Novak
1ca6362498
[codec,rfx] free content of currentMessage on fail
2023-08-21 11:39:40 +02:00
akallabeth
63a2f65618
[codec,rfx] fix possible out of bound read
...
Allows malicious servers to crash FreeRDP based clients
reported by @pwn2carr
2023-08-04 15:09:59 +02:00
ehdgks0627
d04ba8d6ef
Correct typos and formatting errors in format strings
...
In several files, fixed typos in format strings that were causing unexpected output and formatting issues.
2023-07-28 15:34:46 +02:00
Armin Novak
32b9eeb3c0
[winpr,sysinfo] deprecage GetVersionInfoEx
...
the function is deprecated under windows, so deprecate it in WinPR too
and remove/replace usage
2023-07-28 13:42:12 +02:00
Armin Novak
b1dee0f56c
[codec,rfx] fix sign warnings
2023-07-27 21:05:43 +02:00
Vic Lee
5fffaf6cd2
[codec,rfx] missing palette setting api.
2023-06-27 08:54:54 +02:00
akallabeth
6121ace62a
[codec,rfx] unify tile allocation
2023-06-12 16:32:23 +02:00
akallabeth
93d8a93556
[codec,rfx] assert rfx_write_tile arguments
...
Ensure that in all paths the function arguments are valid.
2023-06-12 16:32:23 +02:00
Armin Novak
a4c6b36a19
[build] fix memory sanitizer stack frame warnings
2023-06-07 09:14:45 +02:00
Armin Novak
f66110c611
[codec,rfx] refactor API
...
* Hide implementation details
* Add missing getter/setter
2023-04-05 20:41:42 +02:00
Armin Novak
a86218c761
[codec,rfx] fix numTile update
...
ensure there are enough tiles allocated before setting
2023-04-05 20:41:42 +02:00
Armin Novak
2285d912eb
[codec,rfx] add more assertions
2023-04-05 20:41:42 +02:00