Armin Novak
b724ba546d
[checks,return] fix various unchecked return values
2026-03-03 09:40:27 +01:00
Armin Novak
23fc8778cb
[channels,usb] fix possible deadlock
...
newly introduced error handling did lead to a deadlock. refactor to
avoid this.
2026-03-03 09:30:33 +01:00
Armin Novak
e6fca2c021
[winpr,stream] Fix Stream_SetPosition return checks
2026-03-02 11:37:20 +01:00
Armin Novak
92ab55c5e1
[winpr,stream] Add Stream_ResetPosition
...
A helper function that does not require return checks, in contrast to
Stream_SetPosition, which might fail.
2026-03-01 06:11:59 +01:00
Armin Novak
2c0c55dc46
[c23,channels] replace NULL with nullptr
2026-02-26 13:43:54 +01:00
Armin Novak
e58819830a
[c23] simplify boolean checks
2026-02-26 11:51:05 +01:00
Armin Novak
0531803808
[warnings] make function declaration names consistent
...
Use the same parameter names for declaration and implementation.
2026-02-26 10:35:25 +01:00
Armin Novak
48267edf2f
[winpr] add WINPR_C_ARRAY_INIT
...
since C23 allows c++ style initializing replace direct use with this
macro
2026-02-25 19:23:08 +01:00
Armin Novak
f14096d468
[channels] mark functions [[nodiscard]]
2026-02-24 11:31:57 +01:00
Armin Novak
98f37bdf8c
[channel,urbdrc] fix warnings
2026-02-20 10:04:37 +01:00
Armin Novak
0890f24ebc
[channel,usb] fix message parsing and creation
...
* 2.2.10.3 TS_URB_SELECT_INTERFACE_RESULT was generated incorrect
* 2.2.9.4 TS_URB_PIPE_REQUEST OutputBuffer check was wrong
2026-02-19 20:22:23 +01:00
Armin Novak
118afc0b95
[allocations] fix growth of preallocated buffers
...
* Replace * 2 with * sizeof(WCHAR) for string usages
* Grow streams and other buffers reasonably, e.g. add 128 elements per
try and check for possible overflows
* Add constant postfix to force them to 64bit
2026-02-17 13:54:34 +01:00
Armin Novak
bf99266c2e
[channels,warnings] properly handle function return
2026-02-16 09:18:38 +01:00
Armin Novak
775ee2615a
[freerdp,channels] mark function pointers [[nodiscard]]
2026-02-16 09:18:34 +01:00
akallabeth
076a8386a6
Merge pull request #12186 from akallabeth/error-handling-fixes
...
Error handling fixes
2026-01-26 17:05:19 +01:00
akallabeth
b9c23252f1
[channels,urbdrc] fix msusb_msingerface_free
...
declare before use in WINPR_ATTR_MALLOC
2026-01-26 16:52:30 +01:00
akallabeth
538620e1bb
[channels] mark all WINPR_ATTR_MALLOC also nodiscard
2026-01-26 13:22:27 +01:00
akallabeth
d676518809
[channels,urbdrc] do not free MsConfig on failure
...
let the channel handle it later.
2026-01-26 11:55:44 +01:00
akallabeth
9af6f3a4af
[channels,urbdrc] mark functions with attr-malloc
2026-01-26 11:55:17 +01:00
akallabeth
fc665ef9ef
[channel,urbdrc] check if interface is valid
2026-01-26 11:45:55 +01:00
akallabeth
414f701464
[channels,urbdrc] cancel all usb transfers on channel close
2026-01-26 11:26:48 +01:00
akallabeth
2d563a50be
[channels,urbdrc] ensure InterfaceNumber is within range
2026-01-26 11:26:46 +01:00
akallabeth
4dcc231ab7
[c,printf] fix wlog format string to match arguments
2026-01-16 11:40:28 +01:00
akallabeth
a12a92abf8
[c,printf] fix wlog format string to match arguments
2026-01-16 11:40:26 +01:00
akallabeth
7b7e6de8fe
[channels,urbdrc] check interface indices before use
2026-01-10 09:01:34 +01:00
Armin Novak
185dbe4847
[clang,warnings] fix Wjump-misses-init
2026-01-08 11:32:34 +01:00
Armin Novak
902aee4df1
[c++,compat] rename variables clashing with c++ keywords
2026-01-08 09:24:31 +01:00
akallabeth
25b5b38d32
[CMake,client] add pkg-config dependencies
2025-09-11 07:17:52 +02:00
akallabeth
65f18983ed
[warnings] Fix format string errors
...
* Fix casts of format string arguments (%p requires void*)
* Fix format string to match type of arguments
2025-08-13 15:09:48 +02:00
Armin Novak
1517d4681f
[cmake] fix channel properties
2025-03-26 14:08:18 +01:00
akallabeth
1a5ba989e8
[warnings] fixed integer casts
2025-03-11 17:23:58 +01:00
akallabeth
2b26cf74e0
[channels,urbdrc] fix possible leak in error branch
2025-03-11 08:59:14 +01:00
akallabeth
726616c54c
[channels,urbdrc] refactor send routines
2025-03-08 19:44:42 +01:00
akallabeth
94cd8b6b2a
[channels,urbdrc] add helper functions for shared header
2025-03-07 16:27:41 +01:00
akallabeth
0c25452c59
[channels,urbdrc] msusb const corrections
2025-03-07 16:27:13 +01:00
akallabeth
114f4c2a3a
[channel,urbdrc] fix and refactor code
2025-03-07 11:47:23 +01:00
akallabeth
8795ca181a
[channel,urbdrc] add some missing checks
2025-03-07 10:16:22 +01:00
akallabeth
1cbafe1d53
[channels,ubdrc] add some more failure logging
2025-03-07 09:20:00 +01:00
akallabeth
dd92d719d1
[channels,urbdrc] check InterfaceId for RIM_EXCHANGE_CAPABILITY_REQUEST
2025-03-05 23:48:51 +01:00
akallabeth
bd1c781b88
[warnings] address new warnings on ci
2025-02-18 20:06:35 +01:00
akallabeth
28ff8c9538
[channel,urbdrc] fix urbdrc_udevman_register_devices
...
* properly check return values
* return proper error codes
2025-02-17 04:35:35 +01:00
akallabeth
2b7d7356c1
[channels,warnings] fix -Wunused-parameter
2025-02-13 15:53:56 +01:00
Armin Novak
0e006e31fe
[warnings] fix sign conversion
2025-02-12 12:52:29 +01:00
akallabeth
f71a588172
[channel,urbdrc] fix libusb return code checks
2025-02-11 09:01:56 +01:00
akallabeth
628995421d
[channels,urbdrc] fix undeclared variable
2024-12-30 18:41:11 +01:00
akallabeth
be3ba1c425
[warnings,channels] fix integer casts
2024-12-25 13:29:07 +01:00
akallabeth
ac9cf26bce
[cmake] fix define_channel_options
...
* fix usage of default value
* fix defaults of channels
* unify to single CMake function define_channel_options
2024-12-17 16:29:32 +01:00
akallabeth
83f2f21ad3
[warnigns] fix lots of bugprone warnings
...
* update-settings-tests: properly cast types in getter/setter
* wtypes: fix PHANDLE definition
* wStream: fix INT64 write function warnings
* Simplify HANDLE copy in channels, just assign after proper cast
2024-12-06 09:15:48 +01:00
akallabeth
faae38120c
[cmake,format] reformat all cmake files
2024-11-27 20:41:48 +01:00
akallabeth
f084389cd7
[channels,urbdrc] fix enum-enum conversion
...
* fix integer type of port, use uint8_t
* cast enum values to uint8_t (enum values are used as constants here
and multiple different ones are mixed together which provokes this
warning)
2024-11-22 11:00:08 +01:00
