diff --git a/.github/workflows/clang-tidy-post.yml b/.github/workflows/clang-tidy-post.yml index c79c3ed9f..5cea57f9e 100644 --- a/.github/workflows/clang-tidy-post.yml +++ b/.github/workflows/clang-tidy-post.yml @@ -9,7 +9,7 @@ on: permissions: pull-requests: write issues: write - repository: read + checks: write jobs: build: diff --git a/libfreerdp/core/peer.c b/libfreerdp/core/peer.c index fba928183..c083a87ec 100644 --- a/libfreerdp/core/peer.c +++ b/libfreerdp/core/peer.c @@ -1456,7 +1456,10 @@ freerdp_peer* freerdp_peer_new(int sockfd) option_len = sizeof(option_value); if (sockfd >= 0) - setsockopt(sockfd, IPPROTO_TCP, TCP_NODELAY, (void*)&option_value, option_len); + { + if (setsockopt(sockfd, IPPROTO_TCP, TCP_NODELAY, (void*)&option_value, option_len) < 0) + goto fail; + } if (client) { @@ -1487,6 +1490,10 @@ freerdp_peer* freerdp_peer_new(int sockfd) } return client; + +fail: + freerdp_peer_free(client); + return NULL; } void freerdp_peer_free(freerdp_peer* client) diff --git a/libfreerdp/core/proxy.c b/libfreerdp/core/proxy.c index ecb9b349e..15d8802f0 100644 --- a/libfreerdp/core/proxy.c +++ b/libfreerdp/core/proxy.c @@ -306,7 +306,8 @@ void proxy_read_environment(rdpSettings* settings, char* envname) WLog_INFO(TAG, "deactivating proxy: %s [%s=%s]", freerdp_settings_get_string(settings, FreeRDP_ServerHostname), envname, env); - freerdp_settings_set_uint32(settings, FreeRDP_ProxyType, PROXY_TYPE_NONE); + if (!freerdp_settings_set_uint32(settings, FreeRDP_ProxyType, PROXY_TYPE_NONE)) + WLog_WARN(TAG, "failed to set FreeRDP_ProxyType=PROXY_TYPE_NONE"); } } else