morgan/FreeRDP
1
0
Fork 0
mirror of https://github.com/morgan9e/FreeRDP synced 2026-04-15 00:44:19 +09:00
Code Issues Packages Projects Releases Wiki Activity

[winpr,sspi] fix missing return check

Browse Source
This commit is contained in:
Armin Novak
2026-03-03 08:50:26 +01:00
parent eba2bf463c
commit d34f41a30b
1 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
winpr/libwinpr/sspi/NTLM/ntlm.c
View File

@@ -391,8 +391,12 @@ static SECURITY_STATUS SEC_ENTRY ntlm_AcquireCredentialsHandleW(
{ {
UINT32 identityFlags = sspi_GetAuthIdentityFlags(pAuthData); UINT32 identityFlags = sspi_GetAuthIdentityFlags(pAuthData);
sspi_CopyAuthIdentity(&(credentials->identity), if (sspi_CopyAuthIdentity(&(credentials->identity),
(const SEC_WINNT_AUTH_IDENTITY_INFO*)pAuthData); (const SEC_WINNT_AUTH_IDENTITY_INFO*)pAuthData) < 0)
{
sspi_CredentialsFree(credentials);
return SEC_E_INVALID_PARAMETER;
}
if (identityFlags & SEC_WINNT_AUTH_IDENTITY_EXTENDED) if (identityFlags & SEC_WINNT_AUTH_IDENTITY_EXTENDED)
settings = (((SEC_WINNT_AUTH_IDENTITY_WINPR*)pAuthData)->ntlmSettings); settings = (((SEC_WINNT_AUTH_IDENTITY_WINPR*)pAuthData)->ntlmSettings);
@@ -1233,7 +1237,14 @@ static SECURITY_STATUS SEC_ENTRY ntlm_DecryptMessage(PCtxtHandle phContext, PSec
/* Decrypt message using with RC4, result overwrites original buffer */ /* Decrypt message using with RC4, result overwrites original buffer */
if (context->confidentiality) if (context->confidentiality)
winpr_RC4_Update(context->RecvRc4Seal, length, (BYTE*)data, (BYTE*)data_buffer->pvBuffer); {
if (!winpr_RC4_Update(context->RecvRc4Seal, length, (BYTE*)data,
(BYTE*)data_buffer->pvBuffer))
{
free(data);
return SEC_E_INSUFFICIENT_MEMORY;
}
}
else else
CopyMemory(data_buffer->pvBuffer, data, length); CopyMemory(data_buffer->pvBuffer, data, length);