From be8f70998aaa8ed783a0ea926e8832df79a136a1 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Thu, 15 Nov 2018 01:51:44 +0500 Subject: [PATCH 1/2] remove not needed check PVS analyzer: A part of conditional expression is always true: bWaitAll. --- winpr/libwinpr/synch/wait.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/winpr/libwinpr/synch/wait.c b/winpr/libwinpr/synch/wait.c index 5ec584646..da7548799 100644 --- a/winpr/libwinpr/synch/wait.c +++ b/winpr/libwinpr/synch/wait.c @@ -547,7 +547,7 @@ DWORD WaitForMultipleObjects(DWORD nCount, const HANDLE* lpHandles, BOOL bWaitAl if (!bWaitAll) return (WAIT_OBJECT_0 + index); - if (bWaitAll && (signalled >= nCount)) + if (signalled >= nCount) return (WAIT_OBJECT_0); signal_handled = TRUE; From 77323d6f1d637831351ba676ca30224f16a31f02 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Thu, 15 Nov 2018 01:54:39 +0500 Subject: [PATCH 2/2] remove not needed check PVS analyzer: A part of conditional expression is always true: DomainMatch. --- winpr/libwinpr/utils/sam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/winpr/libwinpr/utils/sam.c b/winpr/libwinpr/utils/sam.c index 04e06f900..05831c227 100644 --- a/winpr/libwinpr/utils/sam.c +++ b/winpr/libwinpr/utils/sam.c @@ -405,7 +405,7 @@ WINPR_SAM_ENTRY* SamLookupUserW(WINPR_SAM* sam, LPWSTR User, UINT32 UserLength, free(EntryUser); - if (UserMatch && DomainMatch) + if (UserMatch) { Found = TRUE; break;