From 914ac31cbf94d87c1247bf721600cad3de287a2c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc-Andr=C3=A9=20Moreau?= Date: Mon, 22 Apr 2013 08:33:41 -0400 Subject: [PATCH] xfreerdp: fail differently if no hostname is given --- client/X11/xf_interface.c | 8 ++++++++ client/common/cmdline.c | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/client/X11/xf_interface.c b/client/X11/xf_interface.c index 3d27a5b49..521c6b8b8 100644 --- a/client/X11/xf_interface.c +++ b/client/X11/xf_interface.c @@ -1428,6 +1428,14 @@ int freerdp_client_global_uninit() int freerdp_client_start(xfInfo* xfi) { + rdpSettings* settings = xfi->settings; + + if (!settings->ServerHostname) + { + fprintf(stderr, "error: server hostname was not specified with /v:[:port]\n"); + return -1; + } + xfi->thread = CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE) xf_thread, (void*) xfi->instance, 0, NULL); return 0; diff --git a/client/common/cmdline.c b/client/common/cmdline.c index dc5e6a681..5451d3158 100644 --- a/client/common/cmdline.c +++ b/client/common/cmdline.c @@ -992,8 +992,8 @@ int freerdp_client_parse_command_line_arguments(int argc, char** argv, rdpSettin if (!settings->ConnectionFile && !(arg->Flags & COMMAND_LINE_VALUE_PRESENT)) { - fprintf(stderr, "error: server hostname was not specified with /v:[:port]\n"); - return COMMAND_LINE_ERROR_MISSING_ARGUMENT; + //fprintf(stderr, "error: server hostname was not specified with /v:[:port]\n"); + //return COMMAND_LINE_ERROR_MISSING_ARGUMENT; } arg = args;