From 147f7a2adb467413c1703d752df4e0e26e2618cb Mon Sep 17 00:00:00 2001
From: Mads Kiilerich <mads@kiilerich.com>
Date: Wed, 21 Mar 2012 20:46:37 +0100
Subject: [PATCH 1/5] cmake: default to build shared libs - don't enforce it

--HG--
extra : rebase_source : 7b731d1a90169a22dda6bb9506ce41a01e98f29a
---
 CMakeLists.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index c62494732..a37f75d42 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -49,8 +49,8 @@ if(NOT CMAKE_BUILD_TYPE)
    set(CMAKE_BUILD_TYPE "Release")
 endif()
 
-# build shared libs
-if(NOT BUILD_SHARED_LIBS)
+# Default to build shared libs
+if(NOT DEFINED BUILD_SHARED_LIBS)
     set(BUILD_SHARED_LIBS ON)
 endif()
 

From 5c718a3948d9b87b2c9ea2f0a1575610779d8da6 Mon Sep 17 00:00:00 2001
From: Mads Kiilerich <mads@kiilerich.com>
Date: Wed, 21 Mar 2012 20:46:57 +0100
Subject: [PATCH 2/5] types.h: windows can have stdbool.h too but still don't
 like "typedef int boolean"

--HG--
extra : rebase_source : f472822b40a21f4c375782c3c71bcfbdde672207
---
 include/freerdp/types.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/freerdp/types.h b/include/freerdp/types.h
index feed3fd49..0934fa7f0 100644
--- a/include/freerdp/types.h
+++ b/include/freerdp/types.h
@@ -69,7 +69,11 @@ typedef signed long long sint64;
 
 #include <stdbool.h>
 
+#ifdef _WIN32
+#define boolean BOOLEAN
+#else
 typedef int boolean;
+#endif
 
 #else
 
@@ -89,7 +93,7 @@ typedef int boolean;
 
 #endif /* __bool_true_false_are_defined */
 
-#else
+#else /* ifdef __cplusplus */
 
 #ifndef true
 #define true	1

From dc32388e506f6bc14dca5acc7891ae6d40608d09 Mon Sep 17 00:00:00 2001
From: Mads Kiilerich <mads@kiilerich.com>
Date: Wed, 21 Mar 2012 23:13:35 +0100
Subject: [PATCH 3/5] reduce the use of windows.h in header files

--HG--
extra : rebase_source : 3d15968fcc5255e99a7343aeef2b2a79d71c6704
---
 include/freerdp/utils/tcp.h | 1 -
 include/freerdp/window.h    | 4 ----
 libfreerdp-utils/tcp.c      | 6 +++++-
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/include/freerdp/utils/tcp.h b/include/freerdp/utils/tcp.h
index 28c8a3f46..cad44dad7 100644
--- a/include/freerdp/utils/tcp.h
+++ b/include/freerdp/utils/tcp.h
@@ -22,7 +22,6 @@
 
 #include <freerdp/api.h>
 #include <freerdp/types.h>
-#include <freerdp/utils/windows.h>
 
 FREERDP_API int freerdp_tcp_connect(const char* hostname, int port);
 FREERDP_API int freerdp_tcp_read(int sockfd, uint8* data, int length);
diff --git a/include/freerdp/window.h b/include/freerdp/window.h
index 4eff0e692..3a4fcf098 100644
--- a/include/freerdp/window.h
+++ b/include/freerdp/window.h
@@ -22,10 +22,6 @@
 
 #include <freerdp/types.h>
 
-#ifdef _WIN32
-#include <windows.h>
-#endif
-
 /* Window Order Header Flags */
 #define WINDOW_ORDER_TYPE_WINDOW			0x01000000
 #define WINDOW_ORDER_TYPE_NOTIFY			0x02000000
diff --git a/libfreerdp-utils/tcp.c b/libfreerdp-utils/tcp.c
index b530c0213..695855d15 100644
--- a/libfreerdp-utils/tcp.c
+++ b/libfreerdp-utils/tcp.c
@@ -28,6 +28,7 @@
 #include <fcntl.h>
 
 #ifndef _WIN32
+
 #include <netdb.h>
 #include <unistd.h>
 #include <sys/ioctl.h>
@@ -42,13 +43,16 @@
 #endif
 #endif
 
-#else
+#else /* ifdef _WIN32 */
+
+#include <freerdp/utils/windows.h>
 #define SHUT_RDWR SD_BOTH
 #define close(_fd) closesocket(_fd)
 #endif
 
 #ifndef MSG_NOSIGNAL
 #define MSG_NOSIGNAL 0
+
 #endif
 
 int freerdp_tcp_connect(const char* hostname, int port)

From 2d68abd97d96e1629651454d1439f6aeb8cb4fea Mon Sep 17 00:00:00 2001
From: Mads Kiilerich <mads@kiilerich.com>
Date: Wed, 21 Mar 2012 23:15:46 +0100
Subject: [PATCH 4/5] cmake: don't try to detect OpenSSL if OPENSSL_INCLUDE_DIR
 and OPENSSL_LIBRARIES are defined

--HG--
extra : rebase_source : fee9366943406e93964821a1991f1ac0c03983e5
---
 CMakeLists.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index a37f75d42..c539ca2ca 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -100,7 +100,9 @@ check_include_files(inttypes.h HAVE_INTTYPES_H)
 check_struct_has_member("struct tm" tm_gmtoff time.h HAVE_TM_GMTOFF)
 
 # Libraries that we have a hard dependency on
+if(NOT DEFINED OPENSSL_INCLUDE_DIR OR NOT DEFINED OPENSSL_LIBRARIES)
 find_required_package(OpenSSL)
+endif()
 
 # Mac OS X
 if(APPLE)

From 528422b1fac81d2504f2f79817215f257e84a2c2 Mon Sep 17 00:00:00 2001
From: Mads Kiilerich <mads@kiilerich.com>
Date: Wed, 21 Mar 2012 23:15:46 +0100
Subject: [PATCH 5/5] util windows.h: include winsock2.h before windows.h

That seems to be the right way to do it ...
---
 include/freerdp/utils/windows.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/freerdp/utils/windows.h b/include/freerdp/utils/windows.h
index 1555db70c..ecf95f66f 100644
--- a/include/freerdp/utils/windows.h
+++ b/include/freerdp/utils/windows.h
@@ -28,8 +28,8 @@
 #define WIN32_LEAN_AND_MEAN
 #endif
 
-#include <windows.h>
 #include <winsock2.h>
+#include <windows.h>
 #include <ws2tcpip.h>
 
 #endif