morgan/FreeRDP
1
0
Fork 0
mirror of https://github.com/morgan9e/FreeRDP synced 2026-04-15 00:44:19 +09:00
Code Issues Packages Projects Releases Wiki Activity

Prefer constant division over multiplication for length checks

Browse Source
This commit is contained in:
akallabeth
2021-09-21 08:01:51 +02:00
committed by akallabeth
parent 6547db2f17
commit 7b7e2d6f32
16 changed files with 31 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
channels/encomsp/client/encomsp_main.c
View File

@@ -100,7 +100,7 @@ static UINT encomsp_read_unicode_string(wStream* s, ENCOMSP_UNICODE_STRING* str)
return ERROR_INVALID_DATA;
}
if (Stream_GetRemainingLength(s) < (size_t)(str->cchString * 2))
if (Stream_GetRemainingLength(s) / sizeof(WCHAR) < str->cchString)
{
WLog_ERR(TAG, "Not enough data!");
return ERROR_INVALID_DATA;