morgan/FreeRDP
1
0
Fork 0
mirror of https://github.com/morgan9e/FreeRDP synced 2026-04-15 00:44:19 +09:00
Code Issues Packages Projects Releases Wiki Activity

[common,settings] add comments for compat entries

Browse Source
This commit is contained in:
akallabeth
2025-02-14 09:09:19 +01:00
parent b223b0318b
commit 761c62f754
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libfreerdp/common/settings_getters.c
View File

@@ -2002,9 +2002,11 @@ UINT32 freerdp_settings_get_uint32(WINPR_ATTR_UNUSED const rdpSettings* settings
case FreeRDP_VCFlags: case FreeRDP_VCFlags:
return settings->VCFlags; return settings->VCFlags;
// API Compatibility section, remove with FreeRDP 4.x
case (FreeRDP_Settings_Keys_UInt32)FreeRDP_MonitorLocalShiftX: case (FreeRDP_Settings_Keys_UInt32)FreeRDP_MonitorLocalShiftX:
return (UINT32)settings->MonitorLocalShiftX; return (UINT32)settings->MonitorLocalShiftX;
// API Compatibility section, remove with FreeRDP 4.x
case (FreeRDP_Settings_Keys_UInt32)FreeRDP_MonitorLocalShiftY: case (FreeRDP_Settings_Keys_UInt32)FreeRDP_MonitorLocalShiftY:
return (UINT32)settings->MonitorLocalShiftY; return (UINT32)settings->MonitorLocalShiftY;
@@ -2529,10 +2531,12 @@ BOOL freerdp_settings_set_uint32(WINPR_ATTR_UNUSED rdpSettings* settings,
settings->VCFlags = cnv.c; settings->VCFlags = cnv.c;
break; break;
// API Compatibility section, remove with FreeRDP 4.x
case FreeRDP_MonitorLocalShiftX: case FreeRDP_MonitorLocalShiftX:
settings->MonitorLocalShiftX = (int32_t)cnv.c; settings->MonitorLocalShiftX = (int32_t)cnv.c;
break; break;
// API Compatibility section, remove with FreeRDP 4.x
case FreeRDP_MonitorLocalShiftY: case FreeRDP_MonitorLocalShiftY:
settings->MonitorLocalShiftY = (int32_t)cnv.c; settings->MonitorLocalShiftY = (int32_t)cnv.c;
break; break;

2
tools/update-settings-tests
View File

@@ -104,6 +104,7 @@ def write_getter_body(f, values, ret, keys, isPointer, compat_values, typestr, e
for i in range(len(compat_values)): for i in range(len(compat_values)):
val = compat_values[i] val = compat_values[i]
cast = '(' + entry_type + ')' cast = '(' + entry_type + ')'
f.write('\t\t// API Compatibility section, remove with FreeRDP 4.x\n')
write_getter_case(f, val, cast, typestr) write_getter_case(f, val, cast, typestr)
f.write('\t\tdefault:\n') f.write('\t\tdefault:\n')
f.write('\t\t\tWLog_ERR(TAG, "Invalid key index %" PRIuz " [%s|%s]", id, freerdp_settings_get_name_for_key(id), freerdp_settings_get_type_name_for_key(id));\n') f.write('\t\t\tWLog_ERR(TAG, "Invalid key index %" PRIuz " [%s|%s]", id, freerdp_settings_get_name_for_key(id), freerdp_settings_get_type_name_for_key(id));\n')
@@ -218,6 +219,7 @@ def write_setter(f, entry_dict, entry_type, entry_name, postfix, compat_dict):
if compat_values: if compat_values:
for val in compat_values: for val in compat_values:
cast = '(int32_t)' cast = '(int32_t)'
f.write('\t\t// API Compatibility section, remove with FreeRDP 4.x\n')
write_setter_case(f, val, postfix, isPointer, cast) write_setter_case(f, val, postfix, isPointer, cast)
f.write('\t\tdefault:\n') f.write('\t\tdefault:\n')
f.write('\t\t\tWLog_ERR(TAG, "Invalid key index %" PRIuz " [%s|%s]", id, freerdp_settings_get_name_for_key(id), freerdp_settings_get_type_name_for_key(id));\n') f.write('\t\t\tWLog_ERR(TAG, "Invalid key index %" PRIuz " [%s|%s]", id, freerdp_settings_get_name_for_key(id), freerdp_settings_get_type_name_for_key(id));\n')