diff --git a/libfreerdp/cache/bitmap.c b/libfreerdp/cache/bitmap.c index 2b0992a2d..96607444e 100644 --- a/libfreerdp/cache/bitmap.c +++ b/libfreerdp/cache/bitmap.c @@ -475,7 +475,8 @@ fail: return NULL; } -void free_bitmap_update(rdpContext* context, BITMAP_UPDATE* pointer) +void free_bitmap_update(WINPR_ATTR_UNUSED rdpContext* context, + WINPR_ATTR_UNUSED BITMAP_UPDATE* pointer) { if (!pointer) return; @@ -534,7 +535,7 @@ fail: return NULL; } -void free_cache_bitmap_order(rdpContext* context, CACHE_BITMAP_ORDER* order) +void free_cache_bitmap_order(WINPR_ATTR_UNUSED rdpContext* context, CACHE_BITMAP_ORDER* order) { if (order) free(order->bitmapDataStream); @@ -571,7 +572,8 @@ fail: return NULL; } -void free_cache_bitmap_v2_order(rdpContext* context, CACHE_BITMAP_V2_ORDER* order) +void free_cache_bitmap_v2_order(WINPR_ATTR_UNUSED rdpContext* context, + WINPR_ATTR_UNUSED CACHE_BITMAP_V2_ORDER* order) { if (order) free(order->bitmapDataStream); @@ -608,7 +610,7 @@ fail: return NULL; } -void free_cache_bitmap_v3_order(rdpContext* context, CACHE_BITMAP_V3_ORDER* order) +void free_cache_bitmap_v3_order(WINPR_ATTR_UNUSED rdpContext* context, CACHE_BITMAP_V3_ORDER* order) { if (order) free(order->bitmapData.data); diff --git a/libfreerdp/cache/cache.c b/libfreerdp/cache/cache.c index 162d86100..8269b8467 100644 --- a/libfreerdp/cache/cache.c +++ b/libfreerdp/cache/cache.c @@ -113,7 +113,8 @@ fail: return NULL; } -void free_cache_color_table_order(rdpContext* context, CACHE_COLOR_TABLE_ORDER* order) +void free_cache_color_table_order(WINPR_ATTR_UNUSED rdpContext* context, + CACHE_COLOR_TABLE_ORDER* order) { free(order); } @@ -144,7 +145,7 @@ fail: return NULL; } -void free_surface_bits_command(rdpContext* context, SURFACE_BITS_COMMAND* order) +void free_surface_bits_command(WINPR_ATTR_UNUSED rdpContext* context, SURFACE_BITS_COMMAND* order) { if (order) free(order->bmp.bitmapData); diff --git a/libfreerdp/cache/glyph.c b/libfreerdp/cache/glyph.c index 54d91eeea..03bffb20e 100644 --- a/libfreerdp/cache/glyph.c +++ b/libfreerdp/cache/glyph.c @@ -806,7 +806,7 @@ fail: return NULL; } -void free_cache_glyph_order(rdpContext* context, CACHE_GLYPH_ORDER* glyph) +void free_cache_glyph_order(WINPR_ATTR_UNUSED rdpContext* context, CACHE_GLYPH_ORDER* glyph) { if (glyph) { @@ -869,7 +869,7 @@ fail: return NULL; } -void free_cache_glyph_v2_order(rdpContext* context, CACHE_GLYPH_V2_ORDER* glyph) +void free_cache_glyph_v2_order(WINPR_ATTR_UNUSED rdpContext* context, CACHE_GLYPH_V2_ORDER* glyph) { if (glyph) { diff --git a/libfreerdp/cache/palette.c b/libfreerdp/cache/palette.c index 8a99abcd3..017d40fef 100644 --- a/libfreerdp/cache/palette.c +++ b/libfreerdp/cache/palette.c @@ -119,7 +119,7 @@ void palette_cache_free(rdpPaletteCache* paletteCache) } } -void free_palette_update(rdpContext* context, PALETTE_UPDATE* pointer) +void free_palette_update(WINPR_ATTR_UNUSED rdpContext* context, PALETTE_UPDATE* pointer) { free(pointer); } diff --git a/libfreerdp/cache/pointer.c b/libfreerdp/cache/pointer.c index d5be0d543..91b8fc555 100644 --- a/libfreerdp/cache/pointer.c +++ b/libfreerdp/cache/pointer.c @@ -523,7 +523,7 @@ fail: return NULL; } -void free_pointer_new_update(rdpContext* context, POINTER_NEW_UPDATE* pointer) +void free_pointer_new_update(WINPR_ATTR_UNUSED rdpContext* context, POINTER_NEW_UPDATE* pointer) { if (!pointer) return; diff --git a/libfreerdp/codec/bitmap.c b/libfreerdp/codec/bitmap.c index 9853ba174..0c32cbc2e 100644 --- a/libfreerdp/codec/bitmap.c +++ b/libfreerdp/codec/bitmap.c @@ -465,9 +465,10 @@ static INLINE UINT16 out_from_count_3(UINT16 in_count, wStream* WINPR_RESTRICT i } while (0) static INLINE SSIZE_T freerdp_bitmap_compress_24(const void* WINPR_RESTRICT srcData, UINT32 width, - UINT32 height, wStream* WINPR_RESTRICT s, - UINT32 byte_limit, UINT32 start_line, - wStream* WINPR_RESTRICT temp_s, UINT32 e) + WINPR_ATTR_UNUSED UINT32 height, + wStream* WINPR_RESTRICT s, UINT32 byte_limit, + UINT32 start_line, wStream* WINPR_RESTRICT temp_s, + UINT32 e) { int8_t fom_mask[8192] = { 0 }; /* good for up to 64K bitmap */ SSIZE_T lines_sent = 0; @@ -774,8 +775,9 @@ static INLINE SSIZE_T freerdp_bitmap_compress_24(const void* WINPR_RESTRICT srcD } static INLINE SSIZE_T freerdp_bitmap_compress_16(const void* WINPR_RESTRICT srcData, UINT32 width, - UINT32 height, wStream* WINPR_RESTRICT s, - UINT32 bpp, UINT32 byte_limit, UINT32 start_line, + WINPR_ATTR_UNUSED UINT32 height, + wStream* WINPR_RESTRICT s, UINT32 bpp, + UINT32 byte_limit, UINT32 start_line, wStream* WINPR_RESTRICT temp_s, UINT32 e) { int8_t fom_mask[8192] = { 0 }; /* good for up to 64K bitmap */ diff --git a/libfreerdp/codec/clear.c b/libfreerdp/codec/clear.c index b0813937d..b9b86d102 100644 --- a/libfreerdp/codec/clear.c +++ b/libfreerdp/codec/clear.c @@ -1150,8 +1150,11 @@ fail: return rc; } -int clear_compress(CLEAR_CONTEXT* WINPR_RESTRICT clear, const BYTE* WINPR_RESTRICT pSrcData, - UINT32 SrcSize, BYTE** WINPR_RESTRICT ppDstData, UINT32* WINPR_RESTRICT pDstSize) +int clear_compress(WINPR_ATTR_UNUSED CLEAR_CONTEXT* WINPR_RESTRICT clear, + WINPR_ATTR_UNUSED const BYTE* WINPR_RESTRICT pSrcData, + WINPR_ATTR_UNUSED UINT32 SrcSize, + WINPR_ATTR_UNUSED BYTE** WINPR_RESTRICT ppDstData, + WINPR_ATTR_UNUSED UINT32* WINPR_RESTRICT pDstSize) { WLog_ERR(TAG, "TODO: not implemented!"); return 1; diff --git a/libfreerdp/codec/dsp.c b/libfreerdp/codec/dsp.c index c5f5949a9..31d30e8e2 100644 --- a/libfreerdp/codec/dsp.c +++ b/libfreerdp/codec/dsp.c @@ -1460,7 +1460,7 @@ BOOL freerdp_dsp_supports_format(const AUDIO_FORMAT* WINPR_RESTRICT format, BOOL BOOL freerdp_dsp_context_reset(FREERDP_DSP_CONTEXT* WINPR_RESTRICT context, const AUDIO_FORMAT* WINPR_RESTRICT targetFormat, - UINT32 FramesPerPacket) + WINPR_ATTR_UNUSED UINT32 FramesPerPacket) { #if defined(WITH_FDK_AAC) WINPR_ASSERT(targetFormat); diff --git a/libfreerdp/codec/dsp_ffmpeg.c b/libfreerdp/codec/dsp_ffmpeg.c index c3c7cf39b..f907f2724 100644 --- a/libfreerdp/codec/dsp_ffmpeg.c +++ b/libfreerdp/codec/dsp_ffmpeg.c @@ -60,7 +60,7 @@ struct S_FREERDP_DSP_CONTEXT #endif }; -static BOOL ffmpeg_codec_is_filtered(enum AVCodecID id, BOOL encoder) +static BOOL ffmpeg_codec_is_filtered(enum AVCodecID id, WINPR_ATTR_UNUSED BOOL encoder) { switch (id) { diff --git a/libfreerdp/codec/h264.c b/libfreerdp/codec/h264.c index 352c3939e..fde9217f5 100644 --- a/libfreerdp/codec/h264.c +++ b/libfreerdp/codec/h264.c @@ -109,8 +109,9 @@ BOOL avc420_ensure_buffer(H264_CONTEXT* h264, UINT32 stride, UINT32 width, UINT3 } INT32 avc420_decompress(H264_CONTEXT* h264, const BYTE* pSrcData, UINT32 SrcSize, BYTE* pDstData, - DWORD DstFormat, UINT32 nDstStep, UINT32 nDstWidth, UINT32 nDstHeight, - const RECTANGLE_16* regionRects, UINT32 numRegionRects) + DWORD DstFormat, UINT32 nDstStep, WINPR_ATTR_UNUSED UINT32 nDstWidth, + WINPR_ATTR_UNUSED UINT32 nDstHeight, const RECTANGLE_16* regionRects, + UINT32 numRegionRects) { int status = 0; const BYTE* pYUVData[3]; @@ -511,8 +512,8 @@ fail: static BOOL avc444_process_rects(H264_CONTEXT* h264, const BYTE* pSrcData, UINT32 SrcSize, BYTE* pDstData, UINT32 DstFormat, UINT32 nDstStep, - UINT32 nDstWidth, UINT32 nDstHeight, const RECTANGLE_16* rects, - UINT32 nrRects, avc444_frame_type type) + WINPR_ATTR_UNUSED UINT32 nDstWidth, UINT32 nDstHeight, + const RECTANGLE_16* rects, UINT32 nrRects, avc444_frame_type type) { const BYTE* pYUVData[3]; BYTE* pYUVDstData[3]; @@ -640,7 +641,9 @@ INT32 avc444_decompress(H264_CONTEXT* h264, BYTE op, const RECTANGLE_16* regionR static INIT_ONCE subsystems_once = INIT_ONCE_STATIC_INIT; static const H264_CONTEXT_SUBSYSTEM* subSystems[MAX_SUBSYSTEMS] = { 0 }; -static BOOL CALLBACK h264_register_subsystems(PINIT_ONCE once, PVOID param, PVOID* context) +static BOOL CALLBACK h264_register_subsystems(WINPR_ATTR_UNUSED PINIT_ONCE once, + WINPR_ATTR_UNUSED PVOID param, + WINPR_ATTR_UNUSED PVOID* context) { int i = 0; diff --git a/libfreerdp/codec/interleaved.c b/libfreerdp/codec/interleaved.c index 804a9253f..58ca7a59e 100644 --- a/libfreerdp/codec/interleaved.c +++ b/libfreerdp/codec/interleaved.c @@ -377,7 +377,8 @@ static INLINE UINT32 ExtractRunLength(UINT32 code, const BYTE* pbOrderHdr, const #define ensure_capacity(start, end, size, base) \ ensure_capacity_((start), (end), (size), (base), __func__, __FILE__, __LINE__) static INLINE BOOL ensure_capacity_(const BYTE* start, const BYTE* end, size_t size, size_t base, - const char* fkt, const char* file, size_t line) + const char* fkt, WINPR_ATTR_UNUSED const char* file, + size_t line) { const size_t available = (uintptr_t)end - (uintptr_t)start; const BOOL rc = available >= size * base; @@ -717,7 +718,7 @@ BOOL bitmap_interleaved_context_reset(BITMAP_INTERLEAVED_CONTEXT* WINPR_RESTRICT return TRUE; } -BITMAP_INTERLEAVED_CONTEXT* bitmap_interleaved_context_new(BOOL Compressor) +BITMAP_INTERLEAVED_CONTEXT* bitmap_interleaved_context_new(WINPR_ATTR_UNUSED BOOL Compressor) { BITMAP_INTERLEAVED_CONTEXT* interleaved = NULL; interleaved = (BITMAP_INTERLEAVED_CONTEXT*)winpr_aligned_recalloc( diff --git a/libfreerdp/codec/jpeg.c b/libfreerdp/codec/jpeg.c index 65c8d281e..3eaac55bb 100644 --- a/libfreerdp/codec/jpeg.c +++ b/libfreerdp/codec/jpeg.c @@ -56,8 +56,11 @@ fail: #else -BOOL jpeg_decompress(const BYTE* input, BYTE* output, int width, int height, int size, int bpp) +BOOL jpeg_decompress(WINPR_ATTR_UNUSED const BYTE* input, WINPR_ATTR_UNUSED BYTE* output, + WINPR_ATTR_UNUSED int width, WINPR_ATTR_UNUSED int height, + WINPR_ATTR_UNUSED int size, WINPR_ATTR_UNUSED int bpp) { + WLog_ERR("TODO", "TODO: implement"); return 0; } diff --git a/libfreerdp/codec/neon/nsc_neon.c b/libfreerdp/codec/neon/nsc_neon.c index ca5474891..68ca09606 100644 --- a/libfreerdp/codec/neon/nsc_neon.c +++ b/libfreerdp/codec/neon/nsc_neon.c @@ -32,7 +32,7 @@ #define TAG FREERDP_TAG("codec.nsc.neon") #endif -void nsc_init_neon_int(NSC_CONTEXT* WINPR_RESTRICT context) +void nsc_init_neon_int(WINPR_ATTR_UNUSED NSC_CONTEXT* WINPR_RESTRICT context) { #if defined(NEON_INTRINSICS_ENABLED) WLog_WARN(TAG, "TODO: Implement neon optimized version of this function"); diff --git a/libfreerdp/codec/nsc.c b/libfreerdp/codec/nsc.c index 3e7f39eee..73febae07 100644 --- a/libfreerdp/codec/nsc.c +++ b/libfreerdp/codec/nsc.c @@ -433,7 +433,8 @@ BOOL nsc_context_set_parameters(NSC_CONTEXT* WINPR_RESTRICT context, NSC_PARAMET BOOL nsc_process_message(NSC_CONTEXT* WINPR_RESTRICT context, UINT16 bpp, UINT32 width, UINT32 height, const BYTE* data, UINT32 length, BYTE* WINPR_RESTRICT pDstData, UINT32 DstFormat, UINT32 nDstStride, - UINT32 nXDst, UINT32 nYDst, UINT32 nWidth, UINT32 nHeight, UINT32 flip) + UINT32 nXDst, UINT32 nYDst, UINT32 nWidth, + WINPR_ATTR_UNUSED UINT32 nHeight, UINT32 flip) { wStream* s = NULL; wStream sbuffer = { 0 }; diff --git a/libfreerdp/codec/nsc_encode.c b/libfreerdp/codec/nsc_encode.c index 26645695b..101b805b1 100644 --- a/libfreerdp/codec/nsc_encode.c +++ b/libfreerdp/codec/nsc_encode.c @@ -444,8 +444,8 @@ static UINT32 nsc_compute_byte_count(NSC_CONTEXT* WINPR_RESTRICT context, return maxPlaneSize; } -BOOL nsc_write_message(NSC_CONTEXT* WINPR_RESTRICT context, wStream* WINPR_RESTRICT s, - const NSC_MESSAGE* WINPR_RESTRICT message) +BOOL nsc_write_message(WINPR_ATTR_UNUSED NSC_CONTEXT* WINPR_RESTRICT context, + wStream* WINPR_RESTRICT s, const NSC_MESSAGE* WINPR_RESTRICT message) { UINT32 totalPlaneByteCount = 0; totalPlaneByteCount = message->LumaPlaneByteCount + message->OrangeChromaPlaneByteCount + diff --git a/libfreerdp/codec/progressive.c b/libfreerdp/codec/progressive.c index b6a010f11..8c6b2823f 100644 --- a/libfreerdp/codec/progressive.c +++ b/libfreerdp/codec/progressive.c @@ -871,11 +871,13 @@ static INLINE void progressive_rfx_decode_block(const primitives_t* prims, prims->lShiftC_16s_inplace(buffer, shift, length); } -static INLINE int progressive_rfx_decode_component( - PROGRESSIVE_CONTEXT* WINPR_RESTRICT progressive, - const RFX_COMPONENT_CODEC_QUANT* WINPR_RESTRICT shift, const BYTE* WINPR_RESTRICT data, - UINT32 length, INT16* WINPR_RESTRICT buffer, INT16* WINPR_RESTRICT current, - INT16* WINPR_RESTRICT sign, BOOL coeffDiff, BOOL subbandDiff, BOOL extrapolate) +static INLINE int +progressive_rfx_decode_component(PROGRESSIVE_CONTEXT* WINPR_RESTRICT progressive, + const RFX_COMPONENT_CODEC_QUANT* WINPR_RESTRICT shift, + const BYTE* WINPR_RESTRICT data, UINT32 length, + INT16* WINPR_RESTRICT buffer, INT16* WINPR_RESTRICT current, + INT16* WINPR_RESTRICT sign, BOOL coeffDiff, + WINPR_ATTR_UNUSED BOOL subbandDiff, BOOL extrapolate) { int status = 0; const primitives_t* prims = primitives_get(); @@ -1179,7 +1181,8 @@ progressive_rfx_upgrade_state_finish(RFX_PROGRESSIVE_UPGRADE_STATE* WINPR_RESTRI static INLINE int progressive_rfx_upgrade_block(RFX_PROGRESSIVE_UPGRADE_STATE* WINPR_RESTRICT state, INT16* WINPR_RESTRICT buffer, INT16* WINPR_RESTRICT sign, UINT32 length, - UINT32 shift, UINT32 bitPos, UINT32 numBits) + UINT32 shift, WINPR_ATTR_UNUSED UINT32 bitPos, + UINT32 numBits) { if (!numBits) return 1; @@ -1236,15 +1239,14 @@ static INLINE int progressive_rfx_upgrade_block(RFX_PROGRESSIVE_UPGRADE_STATE* W return 1; } -static INLINE int -progressive_rfx_upgrade_component(PROGRESSIVE_CONTEXT* WINPR_RESTRICT progressive, - const RFX_COMPONENT_CODEC_QUANT* WINPR_RESTRICT shift, - const RFX_COMPONENT_CODEC_QUANT* WINPR_RESTRICT bitPos, - const RFX_COMPONENT_CODEC_QUANT* WINPR_RESTRICT numBits, - INT16* WINPR_RESTRICT buffer, INT16* WINPR_RESTRICT current, - INT16* WINPR_RESTRICT sign, const BYTE* WINPR_RESTRICT srlData, - UINT32 srlLen, const BYTE* WINPR_RESTRICT rawData, UINT32 rawLen, - BOOL coeffDiff, BOOL subbandDiff, BOOL extrapolate) +static INLINE int progressive_rfx_upgrade_component( + PROGRESSIVE_CONTEXT* WINPR_RESTRICT progressive, + const RFX_COMPONENT_CODEC_QUANT* WINPR_RESTRICT shift, + const RFX_COMPONENT_CODEC_QUANT* WINPR_RESTRICT bitPos, + const RFX_COMPONENT_CODEC_QUANT* WINPR_RESTRICT numBits, INT16* WINPR_RESTRICT buffer, + INT16* WINPR_RESTRICT current, INT16* WINPR_RESTRICT sign, const BYTE* WINPR_RESTRICT srlData, + UINT32 srlLen, const BYTE* WINPR_RESTRICT rawData, UINT32 rawLen, BOOL coeffDiff, + WINPR_ATTR_UNUSED BOOL subbandDiff, BOOL extrapolate) { int rc = 0; UINT32 aRawLen = 0; @@ -1515,7 +1517,7 @@ static INLINE BOOL progressive_tile_read_upgrade( PROGRESSIVE_CONTEXT* WINPR_RESTRICT progressive, wStream* WINPR_RESTRICT s, UINT16 blockType, UINT32 blockLen, PROGRESSIVE_SURFACE_CONTEXT* WINPR_RESTRICT surface, PROGRESSIVE_BLOCK_REGION* WINPR_RESTRICT region, - const PROGRESSIVE_BLOCK_CONTEXT* WINPR_RESTRICT context) + WINPR_ATTR_UNUSED const PROGRESSIVE_BLOCK_CONTEXT* WINPR_RESTRICT context) { RFX_PROGRESSIVE_TILE tile = { 0 }; const size_t expect = 20; @@ -1589,12 +1591,11 @@ static INLINE BOOL progressive_tile_read_upgrade( return progressive_surface_tile_replace(surface, region, &tile, TRUE); } -static INLINE BOOL progressive_tile_read(PROGRESSIVE_CONTEXT* WINPR_RESTRICT progressive, - BOOL simple, wStream* WINPR_RESTRICT s, UINT16 blockType, - UINT32 blockLen, - PROGRESSIVE_SURFACE_CONTEXT* WINPR_RESTRICT surface, - PROGRESSIVE_BLOCK_REGION* WINPR_RESTRICT region, - const PROGRESSIVE_BLOCK_CONTEXT* WINPR_RESTRICT context) +static INLINE BOOL progressive_tile_read( + PROGRESSIVE_CONTEXT* WINPR_RESTRICT progressive, BOOL simple, wStream* WINPR_RESTRICT s, + UINT16 blockType, UINT32 blockLen, PROGRESSIVE_SURFACE_CONTEXT* WINPR_RESTRICT surface, + PROGRESSIVE_BLOCK_REGION* WINPR_RESTRICT region, + WINPR_ATTR_UNUSED const PROGRESSIVE_BLOCK_CONTEXT* WINPR_RESTRICT context) { RFX_PROGRESSIVE_TILE tile = { 0 }; size_t expect = simple ? 16 : 17; diff --git a/libfreerdp/codec/rfx.c b/libfreerdp/codec/rfx.c index 0d5ecabff..bf215d21e 100644 --- a/libfreerdp/codec/rfx.c +++ b/libfreerdp/codec/rfx.c @@ -640,10 +640,9 @@ static INLINE BOOL rfx_process_message_context(RFX_CONTEXT* WINPR_RESTRICT conte return TRUE; } -static INLINE BOOL rfx_process_message_frame_begin(RFX_CONTEXT* WINPR_RESTRICT context, - RFX_MESSAGE* WINPR_RESTRICT message, - wStream* WINPR_RESTRICT s, - UINT16* WINPR_RESTRICT pExpectedBlockType) +static INLINE BOOL rfx_process_message_frame_begin( + RFX_CONTEXT* WINPR_RESTRICT context, WINPR_ATTR_UNUSED RFX_MESSAGE* WINPR_RESTRICT message, + wStream* WINPR_RESTRICT s, UINT16* WINPR_RESTRICT pExpectedBlockType) { UINT32 frameIdx = 0; UINT16 numRegions = 0; @@ -673,10 +672,9 @@ static INLINE BOOL rfx_process_message_frame_begin(RFX_CONTEXT* WINPR_RESTRICT c return TRUE; } -static INLINE BOOL rfx_process_message_frame_end(RFX_CONTEXT* WINPR_RESTRICT context, - RFX_MESSAGE* WINPR_RESTRICT message, - wStream* WINPR_RESTRICT s, - UINT16* WINPR_RESTRICT pExpectedBlockType) +static INLINE BOOL rfx_process_message_frame_end( + RFX_CONTEXT* WINPR_RESTRICT context, WINPR_ATTR_UNUSED RFX_MESSAGE* WINPR_RESTRICT message, + WINPR_ATTR_UNUSED wStream* WINPR_RESTRICT s, UINT16* WINPR_RESTRICT pExpectedBlockType) { WINPR_ASSERT(context); WINPR_ASSERT(context->priv); @@ -802,8 +800,9 @@ typedef struct RFX_CONTEXT* context; } RFX_TILE_PROCESS_WORK_PARAM; -static INLINE void CALLBACK rfx_process_message_tile_work_callback(PTP_CALLBACK_INSTANCE instance, - void* context, PTP_WORK work) +static INLINE void CALLBACK +rfx_process_message_tile_work_callback(WINPR_ATTR_UNUSED PTP_CALLBACK_INSTANCE instance, + void* context, WINPR_ATTR_UNUSED PTP_WORK work) { RFX_TILE_PROCESS_WORK_PARAM* param = (RFX_TILE_PROCESS_WORK_PARAM*)context; WINPR_ASSERT(param); @@ -1470,8 +1469,9 @@ static INLINE void rfx_update_context_properties(RFX_CONTEXT* WINPR_RESTRICT con context->properties = properties; } -static INLINE void rfx_write_message_sync(const RFX_CONTEXT* WINPR_RESTRICT context, - wStream* WINPR_RESTRICT s) +static INLINE void +rfx_write_message_sync(WINPR_ATTR_UNUSED const RFX_CONTEXT* WINPR_RESTRICT context, + WINPR_ATTR_UNUSED wStream* WINPR_RESTRICT s) { WINPR_ASSERT(context); @@ -1481,8 +1481,9 @@ static INLINE void rfx_write_message_sync(const RFX_CONTEXT* WINPR_RESTRICT cont Stream_Write_UINT16(s, WF_VERSION_1_0); /* version (2 bytes) */ } -static INLINE void rfx_write_message_codec_versions(const RFX_CONTEXT* WINPR_RESTRICT context, - wStream* WINPR_RESTRICT s) +static INLINE void +rfx_write_message_codec_versions(WINPR_ATTR_UNUSED const RFX_CONTEXT* WINPR_RESTRICT context, + wStream* WINPR_RESTRICT s) { WINPR_ASSERT(context); @@ -1578,8 +1579,9 @@ struct S_RFX_TILE_COMPOSE_WORK_PARAM RFX_CONTEXT* context; }; -static INLINE void CALLBACK rfx_compose_message_tile_work_callback(PTP_CALLBACK_INSTANCE instance, - void* context, PTP_WORK work) +static INLINE void CALLBACK +rfx_compose_message_tile_work_callback(WINPR_ATTR_UNUSED PTP_CALLBACK_INSTANCE instance, + void* context, WINPR_ATTR_UNUSED PTP_WORK work) { RFX_TILE_COMPOSE_WORK_PARAM* param = (RFX_TILE_COMPOSE_WORK_PARAM*)context; WINPR_ASSERT(param); @@ -2092,9 +2094,9 @@ static INLINE BOOL rfx_write_message_tileset(RFX_CONTEXT* WINPR_RESTRICT context return TRUE; } -static INLINE BOOL rfx_write_message_frame_begin(RFX_CONTEXT* WINPR_RESTRICT context, - wStream* WINPR_RESTRICT s, - const RFX_MESSAGE* WINPR_RESTRICT message) +static INLINE BOOL +rfx_write_message_frame_begin(WINPR_ATTR_UNUSED RFX_CONTEXT* WINPR_RESTRICT context, + wStream* WINPR_RESTRICT s, const RFX_MESSAGE* WINPR_RESTRICT message) { WINPR_ASSERT(context); WINPR_ASSERT(message); @@ -2111,7 +2113,7 @@ static INLINE BOOL rfx_write_message_frame_begin(RFX_CONTEXT* WINPR_RESTRICT con return TRUE; } -static INLINE BOOL rfx_write_message_region(RFX_CONTEXT* WINPR_RESTRICT context, +static INLINE BOOL rfx_write_message_region(WINPR_ATTR_UNUSED RFX_CONTEXT* WINPR_RESTRICT context, wStream* WINPR_RESTRICT s, const RFX_MESSAGE* WINPR_RESTRICT message) { @@ -2149,9 +2151,9 @@ static INLINE BOOL rfx_write_message_region(RFX_CONTEXT* WINPR_RESTRICT context, return TRUE; } -static INLINE BOOL rfx_write_message_frame_end(RFX_CONTEXT* WINPR_RESTRICT context, - wStream* WINPR_RESTRICT s, - const RFX_MESSAGE* WINPR_RESTRICT message) +static INLINE BOOL rfx_write_message_frame_end( + WINPR_ATTR_UNUSED RFX_CONTEXT* WINPR_RESTRICT context, wStream* WINPR_RESTRICT s, + WINPR_ATTR_UNUSED const RFX_MESSAGE* WINPR_RESTRICT message) { WINPR_ASSERT(context); WINPR_ASSERT(message); @@ -2232,7 +2234,7 @@ UINT32 rfx_message_get_frame_idx(const RFX_MESSAGE* WINPR_RESTRICT message) return message->frameIdx; } -static INLINE BOOL rfx_write_progressive_wb_sync(RFX_CONTEXT* WINPR_RESTRICT rfx, +static INLINE BOOL rfx_write_progressive_wb_sync(WINPR_ATTR_UNUSED RFX_CONTEXT* WINPR_RESTRICT rfx, wStream* WINPR_RESTRICT s) { const UINT32 blockLen = 12; @@ -2249,8 +2251,8 @@ static INLINE BOOL rfx_write_progressive_wb_sync(RFX_CONTEXT* WINPR_RESTRICT rfx return TRUE; } -static INLINE BOOL rfx_write_progressive_wb_context(RFX_CONTEXT* WINPR_RESTRICT rfx, - wStream* WINPR_RESTRICT s) +static INLINE BOOL rfx_write_progressive_wb_context( + WINPR_ATTR_UNUSED RFX_CONTEXT* WINPR_RESTRICT rfx, wStream* WINPR_RESTRICT s) { const UINT32 blockLen = 10; WINPR_ASSERT(rfx); @@ -2346,9 +2348,9 @@ static INLINE BOOL rfx_write_progressive_region(RFX_CONTEXT* WINPR_RESTRICT rfx, return (used == blockLen); } -static INLINE BOOL rfx_write_progressive_frame_begin(RFX_CONTEXT* WINPR_RESTRICT rfx, - wStream* WINPR_RESTRICT s, - const RFX_MESSAGE* WINPR_RESTRICT msg) +static INLINE BOOL +rfx_write_progressive_frame_begin(WINPR_ATTR_UNUSED RFX_CONTEXT* WINPR_RESTRICT rfx, + wStream* WINPR_RESTRICT s, const RFX_MESSAGE* WINPR_RESTRICT msg) { const UINT32 blockLen = 12; WINPR_ASSERT(rfx); @@ -2366,8 +2368,8 @@ static INLINE BOOL rfx_write_progressive_frame_begin(RFX_CONTEXT* WINPR_RESTRICT return TRUE; } -static INLINE BOOL rfx_write_progressive_frame_end(RFX_CONTEXT* WINPR_RESTRICT rfx, - wStream* WINPR_RESTRICT s) +static INLINE BOOL rfx_write_progressive_frame_end( + WINPR_ATTR_UNUSED RFX_CONTEXT* WINPR_RESTRICT rfx, wStream* WINPR_RESTRICT s) { const UINT32 blockLen = 6; WINPR_ASSERT(rfx); @@ -2382,9 +2384,9 @@ static INLINE BOOL rfx_write_progressive_frame_end(RFX_CONTEXT* WINPR_RESTRICT r return TRUE; } -static INLINE BOOL rfx_write_progressive_tile_simple(RFX_CONTEXT* WINPR_RESTRICT rfx, - wStream* WINPR_RESTRICT s, - const RFX_TILE* WINPR_RESTRICT tile) +static INLINE BOOL +rfx_write_progressive_tile_simple(WINPR_ATTR_UNUSED RFX_CONTEXT* WINPR_RESTRICT rfx, + wStream* WINPR_RESTRICT s, const RFX_TILE* WINPR_RESTRICT tile) { UINT32 blockLen = 0; WINPR_ASSERT(rfx); diff --git a/libfreerdp/codec/zgfx.c b/libfreerdp/codec/zgfx.c index 0310218b5..3d957c33d 100644 --- a/libfreerdp/codec/zgfx.c +++ b/libfreerdp/codec/zgfx.c @@ -416,7 +416,7 @@ static INLINE BOOL zgfx_append(ZGFX_CONTEXT* WINPR_RESTRICT zgfx, int zgfx_decompress(ZGFX_CONTEXT* WINPR_RESTRICT zgfx, const BYTE* WINPR_RESTRICT pSrcData, UINT32 SrcSize, BYTE** WINPR_RESTRICT ppDstData, - UINT32* WINPR_RESTRICT pDstSize, UINT32 flags) + UINT32* WINPR_RESTRICT pDstSize, WINPR_ATTR_UNUSED UINT32 flags) { int status = -1; BYTE descriptor = 0; @@ -498,9 +498,9 @@ fail: return status; } -static BOOL zgfx_compress_segment(ZGFX_CONTEXT* WINPR_RESTRICT zgfx, wStream* WINPR_RESTRICT s, - const BYTE* WINPR_RESTRICT pSrcData, UINT32 SrcSize, - UINT32* WINPR_RESTRICT pFlags) +static BOOL zgfx_compress_segment(WINPR_ATTR_UNUSED ZGFX_CONTEXT* WINPR_RESTRICT zgfx, + wStream* WINPR_RESTRICT s, const BYTE* WINPR_RESTRICT pSrcData, + UINT32 SrcSize, UINT32* WINPR_RESTRICT pFlags) { /* FIXME: Currently compression not implemented. Just copy the raw source */ if (!Stream_EnsureRemainingCapacity(s, SrcSize + 1)) @@ -618,7 +618,7 @@ int zgfx_compress(ZGFX_CONTEXT* WINPR_RESTRICT zgfx, const BYTE* WINPR_RESTRICT return status; } -void zgfx_context_reset(ZGFX_CONTEXT* WINPR_RESTRICT zgfx, BOOL flush) +void zgfx_context_reset(ZGFX_CONTEXT* WINPR_RESTRICT zgfx, WINPR_ATTR_UNUSED BOOL flush) { zgfx->HistoryIndex = 0; } diff --git a/libfreerdp/common/addin.c b/libfreerdp/common/addin.c index d15fb1ff4..5cfe369f4 100644 --- a/libfreerdp/common/addin.c +++ b/libfreerdp/common/addin.c @@ -369,7 +369,8 @@ PVIRTUALCHANNELENTRY freerdp_load_dynamic_channel_addin_entry(LPCSTR pszName, LP static FREERDP_LOAD_CHANNEL_ADDIN_ENTRY_FN freerdp_load_static_channel_addin_entry = NULL; -int freerdp_register_addin_provider(FREERDP_LOAD_CHANNEL_ADDIN_ENTRY_FN provider, DWORD dwFlags) +int freerdp_register_addin_provider(FREERDP_LOAD_CHANNEL_ADDIN_ENTRY_FN provider, + WINPR_ATTR_UNUSED DWORD dwFlags) { freerdp_load_static_channel_addin_entry = provider; return 0; diff --git a/libfreerdp/common/assistance.c b/libfreerdp/common/assistance.c index 02d56b7fd..dfdfff890 100644 --- a/libfreerdp/common/assistance.c +++ b/libfreerdp/common/assistance.c @@ -675,7 +675,7 @@ static BOOL freerdp_assistance_parse_all_elements_of(rdpAssistanceFile* file, ch } static BOOL freerdp_assistance_parse_all_elements_of_l(rdpAssistanceFile* file, char* data, - size_t len) + WINPR_ATTR_UNUSED size_t len) { UINT32 p = 0; const char* n = NULL; @@ -803,7 +803,7 @@ char* freerdp_assistance_construct_expert_blob(const char* name, const char* pas return ExpertBlob; } -char* freerdp_assistance_generate_pass_stub(DWORD flags) +char* freerdp_assistance_generate_pass_stub(WINPR_ATTR_UNUSED DWORD flags) { UINT32 nums[14]; char* passStub = NULL; diff --git a/libfreerdp/core/autodetect.c b/libfreerdp/core/autodetect.c index 9b49f4bd5..71da0886c 100644 --- a/libfreerdp/core/autodetect.c +++ b/libfreerdp/core/autodetect.c @@ -130,7 +130,8 @@ static const char* autodetect_request_type_to_string_buffer(UINT32 requestType, } static BOOL autodetect_send_rtt_measure_request(rdpAutoDetect* autodetect, - RDP_TRANSPORT_TYPE transport, UINT16 sequenceNumber) + WINPR_ATTR_UNUSED RDP_TRANSPORT_TYPE transport, + UINT16 sequenceNumber) { UINT16 requestType = 0; wStream* s = NULL; @@ -179,7 +180,7 @@ static BOOL autodetect_send_rtt_measure_response(rdpAutoDetect* autodetect, UINT } static BOOL autodetect_send_bandwidth_measure_start(rdpAutoDetect* autodetect, - RDP_TRANSPORT_TYPE transport, + WINPR_ATTR_UNUSED RDP_TRANSPORT_TYPE transport, UINT16 sequenceNumber) { UINT16 requestType = 0; @@ -206,9 +207,10 @@ static BOOL autodetect_send_bandwidth_measure_start(rdpAutoDetect* autodetect, return rdp_send_message_channel_pdu(autodetect->context->rdp, s, SEC_AUTODETECT_REQ); } -static BOOL autodetect_send_bandwidth_measure_payload(rdpAutoDetect* autodetect, - RDP_TRANSPORT_TYPE transport, - UINT16 sequenceNumber, UINT16 payloadLength) +static BOOL +autodetect_send_bandwidth_measure_payload(rdpAutoDetect* autodetect, + WINPR_ATTR_UNUSED RDP_TRANSPORT_TYPE transport, + UINT16 sequenceNumber, UINT16 payloadLength) { wStream* s = NULL; @@ -246,7 +248,7 @@ static BOOL autodetect_send_bandwidth_measure_payload(rdpAutoDetect* autodetect, } static BOOL autodetect_send_bandwidth_measure_stop(rdpAutoDetect* autodetect, - RDP_TRANSPORT_TYPE transport, + WINPR_ATTR_UNUSED RDP_TRANSPORT_TYPE transport, UINT16 sequenceNumber, UINT16 payloadLength) { UINT16 requestType = 0; @@ -354,7 +356,8 @@ static BOOL autodetect_send_bandwidth_measure_results(rdpAutoDetect* autodetect, return rdp_send_message_channel_pdu(autodetect->context->rdp, s, SEC_AUTODETECT_RSP); } -static BOOL autodetect_send_netchar_result(rdpAutoDetect* autodetect, RDP_TRANSPORT_TYPE transport, +static BOOL autodetect_send_netchar_result(rdpAutoDetect* autodetect, + WINPR_ATTR_UNUSED RDP_TRANSPORT_TYPE transport, UINT16 sequenceNumber, const rdpNetworkCharacteristicsResult* result) { @@ -436,7 +439,8 @@ autodetect_on_connect_time_auto_detect_progress_default(rdpAutoDetect* autodetec } static BOOL autodetect_recv_rtt_measure_request(rdpAutoDetect* autodetect, - RDP_TRANSPORT_TYPE transport, wStream* s, + WINPR_ATTR_UNUSED RDP_TRANSPORT_TYPE transport, + WINPR_ATTR_UNUSED wStream* s, const AUTODETECT_REQ_PDU* autodetectReqPdu) { WINPR_ASSERT(autodetect); @@ -457,7 +461,8 @@ static BOOL autodetect_recv_rtt_measure_request(rdpAutoDetect* autodetect, } static BOOL autodetect_recv_rtt_measure_response(rdpAutoDetect* autodetect, - RDP_TRANSPORT_TYPE transport, wStream* s, + RDP_TRANSPORT_TYPE transport, + WINPR_ATTR_UNUSED wStream* s, const AUTODETECT_RSP_PDU* autodetectRspPdu) { BOOL success = TRUE; @@ -489,7 +494,8 @@ static BOOL autodetect_recv_rtt_measure_response(rdpAutoDetect* autodetect, } static BOOL autodetect_recv_bandwidth_measure_start(rdpAutoDetect* autodetect, - RDP_TRANSPORT_TYPE transport, wStream* s, + WINPR_ATTR_UNUSED RDP_TRANSPORT_TYPE transport, + WINPR_ATTR_UNUSED wStream* s, const AUTODETECT_REQ_PDU* autodetectReqPdu) { WINPR_ASSERT(autodetect); @@ -519,9 +525,10 @@ static BOOL autodetect_recv_bandwidth_measure_start(rdpAutoDetect* autodetect, return TRUE; } -static BOOL autodetect_recv_bandwidth_measure_payload(rdpAutoDetect* autodetect, - RDP_TRANSPORT_TYPE transport, wStream* s, - const AUTODETECT_REQ_PDU* autodetectReqPdu) +static BOOL +autodetect_recv_bandwidth_measure_payload(rdpAutoDetect* autodetect, + WINPR_ATTR_UNUSED RDP_TRANSPORT_TYPE transport, + wStream* s, const AUTODETECT_REQ_PDU* autodetectReqPdu) { UINT16 payloadLength = 0; diff --git a/libfreerdp/core/capabilities.c b/libfreerdp/core/capabilities.c index d0c27e4f6..35665de27 100644 --- a/libfreerdp/core/capabilities.c +++ b/libfreerdp/core/capabilities.c @@ -792,7 +792,8 @@ static BOOL rdp_print_order_capability_set(wStream* s) } #endif -static BOOL rdp_apply_bitmap_cache_capability_set(rdpSettings* settings, const rdpSettings* src) +static BOOL rdp_apply_bitmap_cache_capability_set(WINPR_ATTR_UNUSED rdpSettings* settings, + WINPR_ATTR_UNUSED const rdpSettings* src) { WINPR_ASSERT(settings); WINPR_ASSERT(src); @@ -913,7 +914,8 @@ static BOOL rdp_print_bitmap_cache_capability_set(wStream* s) } #endif -static BOOL rdp_apply_control_capability_set(rdpSettings* settings, const rdpSettings* src) +static BOOL rdp_apply_control_capability_set(WINPR_ATTR_UNUSED rdpSettings* settings, + WINPR_ATTR_UNUSED const rdpSettings* src) { WINPR_ASSERT(settings); WINPR_ASSERT(src); @@ -982,8 +984,8 @@ static BOOL rdp_print_control_capability_set(wStream* s) } #endif -static BOOL rdp_apply_window_activation_capability_set(rdpSettings* settings, - const rdpSettings* src) +static BOOL rdp_apply_window_activation_capability_set(WINPR_ATTR_UNUSED rdpSettings* settings, + WINPR_ATTR_UNUSED const rdpSettings* src) { WINPR_ASSERT(settings); WINPR_ASSERT(src); @@ -1164,7 +1166,8 @@ static BOOL rdp_print_pointer_capability_set(wStream* s) } #endif -static BOOL rdp_apply_share_capability_set(rdpSettings* settings, const rdpSettings* src) +static BOOL rdp_apply_share_capability_set(WINPR_ATTR_UNUSED rdpSettings* settings, + WINPR_ATTR_UNUSED const rdpSettings* src) { WINPR_ASSERT(settings); WINPR_ASSERT(src); @@ -1227,7 +1230,8 @@ static BOOL rdp_print_share_capability_set(wStream* s) } #endif -static BOOL rdp_apply_color_cache_capability_set(rdpSettings* settings, const rdpSettings* src) +static BOOL rdp_apply_color_cache_capability_set(WINPR_ATTR_UNUSED rdpSettings* settings, + WINPR_ATTR_UNUSED const rdpSettings* src) { WINPR_ASSERT(settings); WINPR_ASSERT(src); @@ -1531,7 +1535,8 @@ static BOOL rdp_print_input_capability_set(wStream* s) } #endif -static BOOL rdp_apply_font_capability_set(rdpSettings* settings, const rdpSettings* src) +static BOOL rdp_apply_font_capability_set(WINPR_ATTR_UNUSED rdpSettings* settings, + WINPR_ATTR_UNUSED const rdpSettings* src) { WINPR_ASSERT(settings); WINPR_ASSERT(src); diff --git a/libfreerdp/core/client.c b/libfreerdp/core/client.c index b83f7e9d2..66c8b083b 100644 --- a/libfreerdp/core/client.c +++ b/libfreerdp/core/client.c @@ -131,7 +131,9 @@ static void channel_queue_free(void* obj) channel_queue_message_free(msg); } -static BOOL CALLBACK init_channel_handles_table(PINIT_ONCE once, PVOID param, PVOID* context) +static BOOL CALLBACK init_channel_handles_table(WINPR_ATTR_UNUSED PINIT_ONCE once, + WINPR_ATTR_UNUSED PVOID param, + WINPR_ATTR_UNUSED PVOID* context) { g_ChannelHandles = HashTable_New(TRUE); return TRUE; @@ -276,7 +278,7 @@ static UINT freerdp_drdynvc_on_channel_detached(DrdynvcClientContext* context, c return status; } -void freerdp_channels_register_instance(rdpChannels* channels, freerdp* instance) +void freerdp_channels_register_instance(WINPR_ATTR_UNUSED rdpChannels* channels, freerdp* instance) { /* store instance in TLS so future VirtualChannelInit calls can use it */ g_Instance = instance; @@ -705,8 +707,9 @@ static BOOL freerdp_channels_process_sync(rdpChannels* channels, freerdp* instan * called only from main thread */ #if defined(WITH_FREERDP_DEPRECATED) -BOOL freerdp_channels_get_fds(rdpChannels* channels, freerdp* instance, void** read_fds, - int* read_count, void** write_fds, int* write_count) +BOOL freerdp_channels_get_fds(rdpChannels* channels, WINPR_ATTR_UNUSED freerdp* instance, + void** read_fds, int* read_count, WINPR_ATTR_UNUSED void** write_fds, + WINPR_ATTR_UNUSED int* write_count) { void* pfd = NULL; pfd = GetEventWaitObject(MessageQueue_Event(channels->queue)); @@ -1382,7 +1385,7 @@ static BOOL freerdp_channels_is_loaded_ex(rdpChannels* channels, PVIRTUALCHANNEL return FALSE; } -int freerdp_channels_client_load(rdpChannels* channels, rdpSettings* settings, +int freerdp_channels_client_load(rdpChannels* channels, WINPR_ATTR_UNUSED rdpSettings* settings, PVIRTUALCHANNELENTRY entry, void* data) { int status = 0; @@ -1435,7 +1438,7 @@ int freerdp_channels_client_load(rdpChannels* channels, rdpSettings* settings, return 0; } -int freerdp_channels_client_load_ex(rdpChannels* channels, rdpSettings* settings, +int freerdp_channels_client_load_ex(rdpChannels* channels, WINPR_ATTR_UNUSED rdpSettings* settings, PVIRTUALCHANNELENTRYEX entryEx, void* data) { int status = 0; diff --git a/libfreerdp/core/connection.c b/libfreerdp/core/connection.c index 71c1060fb..0cab2dc02 100644 --- a/libfreerdp/core/connection.c +++ b/libfreerdp/core/connection.c @@ -2133,7 +2133,7 @@ BOOL rdp_channels_from_mcs(rdpSettings* settings, const rdpRdp* rdp) * 1. send the CONFIRM_ACTIVE PDU to the server * 2. register callbacks, the server can now start sending stuff */ -state_run_t rdp_client_connect_confirm_active(rdpRdp* rdp, wStream* s) +state_run_t rdp_client_connect_confirm_active(rdpRdp* rdp, WINPR_ATTR_UNUSED wStream* s) { WINPR_ASSERT(rdp); WINPR_ASSERT(rdp->settings); diff --git a/libfreerdp/core/fastpath.c b/libfreerdp/core/fastpath.c index dbf7d0fc6..77f7ae316 100644 --- a/libfreerdp/core/fastpath.c +++ b/libfreerdp/core/fastpath.c @@ -333,7 +333,7 @@ static BOOL fastpath_recv_update_common(rdpFastPath* fastpath, wStream* s) return rc; } -static BOOL fastpath_recv_update_synchronize(rdpFastPath* fastpath, wStream* s) +static BOOL fastpath_recv_update_synchronize(WINPR_ATTR_UNUSED rdpFastPath* fastpath, wStream* s) { /* server 2008 can send invalid synchronize packet with missing padding, so don't return FALSE even if the packet is invalid */ @@ -704,7 +704,8 @@ static BOOL fastpath_recv_input_event_scancode(rdpFastPath* fastpath, wStream* s return IFCALLRESULT(TRUE, input->KeyboardEvent, input, flags, code); } -static BOOL fastpath_recv_input_event_mouse(rdpFastPath* fastpath, wStream* s, BYTE eventFlags) +static BOOL fastpath_recv_input_event_mouse(rdpFastPath* fastpath, wStream* s, + WINPR_ATTR_UNUSED BYTE eventFlags) { rdpInput* input = NULL; UINT16 pointerFlags = 0; @@ -726,7 +727,8 @@ static BOOL fastpath_recv_input_event_mouse(rdpFastPath* fastpath, wStream* s, B return IFCALLRESULT(TRUE, input->MouseEvent, input, pointerFlags, xPos, yPos); } -static BOOL fastpath_recv_input_event_relmouse(rdpFastPath* fastpath, wStream* s, BYTE eventFlags) +static BOOL fastpath_recv_input_event_relmouse(rdpFastPath* fastpath, wStream* s, + WINPR_ATTR_UNUSED BYTE eventFlags) { rdpInput* input = NULL; UINT16 pointerFlags = 0; @@ -759,7 +761,8 @@ static BOOL fastpath_recv_input_event_relmouse(rdpFastPath* fastpath, wStream* s return IFCALLRESULT(TRUE, input->RelMouseEvent, input, pointerFlags, xDelta, yDelta); } -static BOOL fastpath_recv_input_event_qoe(rdpFastPath* fastpath, wStream* s, BYTE eventFlags) +static BOOL fastpath_recv_input_event_qoe(rdpFastPath* fastpath, wStream* s, + WINPR_ATTR_UNUSED BYTE eventFlags) { WINPR_ASSERT(fastpath); WINPR_ASSERT(fastpath->rdp); @@ -787,7 +790,8 @@ static BOOL fastpath_recv_input_event_qoe(rdpFastPath* fastpath, wStream* s, BYT return IFCALLRESULT(TRUE, input->QoEEvent, input, timestampMS); } -static BOOL fastpath_recv_input_event_mousex(rdpFastPath* fastpath, wStream* s, BYTE eventFlags) +static BOOL fastpath_recv_input_event_mousex(rdpFastPath* fastpath, wStream* s, + WINPR_ATTR_UNUSED BYTE eventFlags) { rdpInput* input = NULL; UINT16 pointerFlags = 0; @@ -821,7 +825,8 @@ static BOOL fastpath_recv_input_event_mousex(rdpFastPath* fastpath, wStream* s, return IFCALLRESULT(TRUE, input->ExtendedMouseEvent, input, pointerFlags, xPos, yPos); } -static BOOL fastpath_recv_input_event_sync(rdpFastPath* fastpath, wStream* s, BYTE eventFlags) +static BOOL fastpath_recv_input_event_sync(rdpFastPath* fastpath, WINPR_ATTR_UNUSED wStream* s, + BYTE eventFlags) { rdpInput* input = NULL; @@ -1155,7 +1160,7 @@ wStream* fastpath_update_pdu_init(rdpFastPath* fastpath) return transport_send_stream_init(fastpath->rdp->transport, FASTPATH_MAX_PACKET_SIZE); } -wStream* fastpath_update_pdu_init_new(rdpFastPath* fastpath) +wStream* fastpath_update_pdu_init_new(WINPR_ATTR_UNUSED rdpFastPath* fastpath) { wStream* s = NULL; s = Stream_New(NULL, FASTPATH_MAX_PACKET_SIZE); diff --git a/libfreerdp/core/freerdp.c b/libfreerdp/core/freerdp.c index 594a1a2b8..68e33f94c 100644 --- a/libfreerdp/core/freerdp.c +++ b/libfreerdp/core/freerdp.c @@ -318,7 +318,8 @@ BOOL freerdp_abort_connect_context(rdpContext* context) } #if defined(WITH_FREERDP_DEPRECATED) -BOOL freerdp_get_fds(freerdp* instance, void** rfds, int* rcount, void** wfds, int* wcount) +BOOL freerdp_get_fds(freerdp* instance, void** rfds, int* rcount, WINPR_ATTR_UNUSED void** wfds, + WINPR_ATTR_UNUSED int* wcount) { rdpRdp* rdp = NULL; diff --git a/libfreerdp/core/gateway/rts.c b/libfreerdp/core/gateway/rts.c index 3d7904089..123014e43 100644 --- a/libfreerdp/core/gateway/rts.c +++ b/libfreerdp/core/gateway/rts.c @@ -1234,7 +1234,7 @@ static BOOL rts_write_pdu_header(wStream* s, const rpcconn_rts_hdr_t* header) return TRUE; } -static BOOL rts_receive_window_size_command_read(rdpRpc* rpc, wStream* buffer, +static BOOL rts_receive_window_size_command_read(WINPR_ATTR_UNUSED rdpRpc* rpc, wStream* buffer, UINT64* ReceiveWindowSize) { WINPR_ASSERT(rpc); @@ -1320,7 +1320,7 @@ static BOOL rts_flow_control_ack_command_write(wStream* s, UINT32 BytesReceived, return TRUE; } -static BOOL rts_connection_timeout_command_read(rdpRpc* rpc, wStream* buffer, +static BOOL rts_connection_timeout_command_read(WINPR_ATTR_UNUSED rdpRpc* rpc, wStream* buffer, UINT64* ConnectionTimeout) { WINPR_ASSERT(rpc); @@ -1379,7 +1379,7 @@ static BOOL rts_client_keepalive_command_write(wStream* s, UINT32 ClientKeepaliv return TRUE; } -static BOOL rts_version_command_read(rdpRpc* rpc, wStream* buffer) +static BOOL rts_version_command_read(WINPR_ATTR_UNUSED rdpRpc* rpc, wStream* buffer) { WINPR_ASSERT(rpc); WINPR_ASSERT(buffer); @@ -1468,7 +1468,8 @@ static BOOL rts_association_group_id_command_write(wStream* s, const BYTE* Assoc return TRUE; } -static int rts_destination_command_read(rdpRpc* rpc, wStream* buffer, UINT32* Destination) +static int rts_destination_command_read(WINPR_ATTR_UNUSED rdpRpc* rpc, wStream* buffer, + UINT32* Destination) { UINT32 val = 0; WINPR_ASSERT(rpc); @@ -2181,7 +2182,7 @@ static int rts_recv_OUT_R1_A2_pdu(rdpRpc* rpc, wStream* buffer) return 1; } -static int rts_recv_OUT_R2_A6_pdu(rdpRpc* rpc, wStream* buffer) +static int rts_recv_OUT_R2_A6_pdu(rdpRpc* rpc, WINPR_ATTR_UNUSED wStream* buffer) { int status = 0; RpcVirtualConnection* connection = NULL; @@ -2216,7 +2217,7 @@ static int rts_recv_OUT_R2_A6_pdu(rdpRpc* rpc, wStream* buffer) return 1; } -static int rts_recv_OUT_R2_B3_pdu(rdpRpc* rpc, wStream* buffer) +static int rts_recv_OUT_R2_B3_pdu(rdpRpc* rpc, WINPR_ATTR_UNUSED wStream* buffer) { RpcVirtualConnection* connection = NULL; diff --git a/libfreerdp/core/gateway/tsg.c b/libfreerdp/core/gateway/tsg.c index 45b5e3d68..4613d88af 100644 --- a/libfreerdp/core/gateway/tsg.c +++ b/libfreerdp/core/gateway/tsg.c @@ -326,7 +326,8 @@ static BOOL TsProxyReadTunnelContext(wLog* log, wStream* s, CONTEXT_HANDLE* tunn return TRUE; } -static BOOL TsProxyWriteTunnelContext(wLog* log, wStream* s, const CONTEXT_HANDLE* tunnelContext) +static BOOL TsProxyWriteTunnelContext(WINPR_ATTR_UNUSED wLog* log, wStream* s, + const CONTEXT_HANDLE* tunnelContext) { if (!Stream_EnsureRemainingCapacity(s, 20)) return FALSE; @@ -337,7 +338,8 @@ static BOOL TsProxyWriteTunnelContext(wLog* log, wStream* s, const CONTEXT_HANDL return TRUE; } -static BOOL tsg_ndr_pointer_write(wLog* log, wStream* s, UINT32* index, DWORD length) +static BOOL tsg_ndr_pointer_write(WINPR_ATTR_UNUSED wLog* log, wStream* s, UINT32* index, + DWORD length) { WINPR_ASSERT(index); const UINT32 ndrPtr = 0x20000 + (*index) * 4; @@ -393,7 +395,8 @@ static BOOL tsg_ndr_pointer_read(wLog* log, wStream* s, UINT32* index, UINT32* p return TRUE; } -static BOOL tsg_ndr_write_string(wLog* log, wStream* s, const WCHAR* str, size_t length) +static BOOL tsg_ndr_write_string(WINPR_ATTR_UNUSED wLog* log, wStream* s, const WCHAR* str, + size_t length) { if (!Stream_EnsureRemainingCapacity(s, 12 + length) || (length > UINT32_MAX)) return FALSE; @@ -469,7 +472,8 @@ static BOOL tsg_ndr_read_packet_header(wLog* log, wStream* s, TSG_PACKET_HEADER* return TRUE; } -static BOOL tsg_ndr_write_packet_header(wLog* log, wStream* s, const TSG_PACKET_HEADER* header) +static BOOL tsg_ndr_write_packet_header(WINPR_ATTR_UNUSED wLog* log, wStream* s, + const TSG_PACKET_HEADER* header) { WINPR_ASSERT(header); if (!Stream_EnsureRemainingCapacity(s, 2 * sizeof(UINT16))) @@ -489,7 +493,8 @@ static BOOL tsg_ndr_read_nap(wLog* log, wStream* s, TSG_CAPABILITY_NAP* nap) return TRUE; } -static BOOL tsg_ndr_write_nap(wLog* log, wStream* s, const TSG_CAPABILITY_NAP* nap) +static BOOL tsg_ndr_write_nap(WINPR_ATTR_UNUSED wLog* log, wStream* s, + const TSG_CAPABILITY_NAP* nap) { WINPR_ASSERT(nap); diff --git a/libfreerdp/core/gcc.c b/libfreerdp/core/gcc.c index 55d3edfe8..17e04d94f 100644 --- a/libfreerdp/core/gcc.c +++ b/libfreerdp/core/gcc.c @@ -1117,7 +1117,7 @@ static BOOL updateEarlyClientCaps(rdpSettings* settings, UINT32 earlyCapabilityF } static BOOL updateEarlyServerCaps(rdpSettings* settings, UINT32 earlyCapabilityFlags, - UINT32 connectionType) + WINPR_ATTR_UNUSED UINT32 connectionType) { WINPR_ASSERT(settings); diff --git a/libfreerdp/core/mcs.c b/libfreerdp/core/mcs.c index 8866caf6d..0bdf8b350 100644 --- a/libfreerdp/core/mcs.c +++ b/libfreerdp/core/mcs.c @@ -1010,7 +1010,7 @@ out: * @param s stream */ -BOOL mcs_recv_erect_domain_request(rdpMcs* mcs, wStream* s) +BOOL mcs_recv_erect_domain_request(WINPR_ATTR_UNUSED rdpMcs* mcs, wStream* s) { UINT16 length = 0; UINT32 subHeight = 0; @@ -1243,7 +1243,7 @@ BOOL mcs_send_channel_join_request(rdpMcs* mcs, UINT16 channelId) * @param mcs mcs module */ -BOOL mcs_recv_channel_join_confirm(rdpMcs* mcs, wStream* s, UINT16* channelId) +BOOL mcs_recv_channel_join_confirm(WINPR_ATTR_UNUSED rdpMcs* mcs, wStream* s, UINT16* channelId) { UINT16 length = 0; BYTE result = 0; @@ -1312,7 +1312,7 @@ fail: * @param mcs mcs module */ -BOOL mcs_recv_disconnect_provider_ultimatum(rdpMcs* mcs, wStream* s, int* reason) +BOOL mcs_recv_disconnect_provider_ultimatum(WINPR_ATTR_UNUSED rdpMcs* mcs, wStream* s, int* reason) { BYTE b1 = 0; BYTE b2 = 0; diff --git a/libfreerdp/core/multitransport.c b/libfreerdp/core/multitransport.c index b45579e5c..a9f055790 100644 --- a/libfreerdp/core/multitransport.c +++ b/libfreerdp/core/multitransport.c @@ -185,15 +185,17 @@ state_run_t multitransport_recv_response(rdpMultitransport* multi, wStream* s) return IFCALLRESULT(STATE_RUN_SUCCESS, multi->MtResponse, multi, requestId, hr); } -static state_run_t multitransport_no_udp(rdpMultitransport* multi, UINT32 reqId, UINT16 reqProto, - const BYTE* cookie) +static state_run_t multitransport_no_udp(rdpMultitransport* multi, UINT32 reqId, + WINPR_ATTR_UNUSED UINT16 reqProto, + WINPR_ATTR_UNUSED const BYTE* cookie) { return multitransport_client_send_response(multi, reqId, E_ABORT) ? STATE_RUN_SUCCESS : STATE_RUN_FAILED; } -static state_run_t multitransport_server_handle_response(rdpMultitransport* multi, UINT32 reqId, - UINT32 hrResponse) +static state_run_t multitransport_server_handle_response(rdpMultitransport* multi, + WINPR_ATTR_UNUSED UINT32 reqId, + WINPR_ATTR_UNUSED UINT32 hrResponse) { rdpRdp* rdp = multi->rdp; @@ -203,7 +205,7 @@ static state_run_t multitransport_server_handle_response(rdpMultitransport* mult return STATE_RUN_CONTINUE; } -rdpMultitransport* multitransport_new(rdpRdp* rdp, UINT16 protocol) +rdpMultitransport* multitransport_new(rdpRdp* rdp, WINPR_ATTR_UNUSED UINT16 protocol) { WINPR_ASSERT(rdp); diff --git a/libfreerdp/core/nego.c b/libfreerdp/core/nego.c index bff57f3ec..28f1f62e1 100644 --- a/libfreerdp/core/nego.c +++ b/libfreerdp/core/nego.c @@ -780,7 +780,7 @@ BOOL nego_recv_response(rdpNego* nego) * @return \b 0 for success, \b -1 for failure */ -int nego_recv(rdpTransport* transport, wStream* s, void* extra) +int nego_recv(WINPR_ATTR_UNUSED rdpTransport* transport, wStream* s, void* extra) { BYTE li = 0; BYTE type = 0; @@ -1160,7 +1160,7 @@ fail: return rc; } -static BOOL nego_process_correlation_info(rdpNego* nego, wStream* s) +static BOOL nego_process_correlation_info(WINPR_ATTR_UNUSED rdpNego* nego, wStream* s) { UINT8 type = 0; UINT8 flags = 0; diff --git a/libfreerdp/core/nla.c b/libfreerdp/core/nla.c index a7a0a0228..40091316c 100644 --- a/libfreerdp/core/nla.c +++ b/libfreerdp/core/nla.c @@ -1153,7 +1153,8 @@ static BOOL nla_read_TSCspDataDetail(WinPrAsn1Decoder* dec, rdpSettings* setting return set_creds_octetstring_to_settings(dec, 4, TRUE, FreeRDP_CspName, settings); } -static BOOL nla_read_KERB_TICKET_LOGON(rdpNla* nla, wStream* s, KERB_TICKET_LOGON* ticket) +static BOOL nla_read_KERB_TICKET_LOGON(WINPR_ATTR_UNUSED rdpNla* nla, wStream* s, + KERB_TICKET_LOGON* ticket) { WINPR_ASSERT(nla); @@ -1202,7 +1203,7 @@ typedef enum RCG_TYPE_NTLM } RemoteGuardPackageCredType; -static BOOL nla_read_TSRemoteGuardPackageCred(rdpNla* nla, WinPrAsn1Decoder* dec, +static BOOL nla_read_TSRemoteGuardPackageCred(WINPR_ATTR_UNUSED rdpNla* nla, WinPrAsn1Decoder* dec, RemoteGuardPackageCredType* credsType, wStream* payload) { diff --git a/libfreerdp/core/orders.c b/libfreerdp/core/orders.c index bb2d3dc1c..8f4702255 100644 --- a/libfreerdp/core/orders.c +++ b/libfreerdp/core/orders.c @@ -47,24 +47,27 @@ /* Exposed type definitions in public headers have the wrong type. * assert to the correct types internally to trigger the ci checkers on wrong data passed */ #define get_checked_uint16(value) get_checked_uint16_int((value), __FILE__, __func__, __LINE__) -static inline UINT16 get_checked_uint16_int(UINT32 value, const char* file, const char* fkt, - size_t line) +static inline UINT16 get_checked_uint16_int(UINT32 value, WINPR_ATTR_UNUSED const char* file, + WINPR_ATTR_UNUSED const char* fkt, + WINPR_ATTR_UNUSED size_t line) { WINPR_ASSERT_AT(value <= UINT16_MAX, file, fkt, line); return (UINT16)value; } #define get_checked_uint8(value) get_checked_uint8_int((value), __FILE__, __func__, __LINE__) -static inline UINT8 get_checked_uint8_int(UINT32 value, const char* file, const char* fkt, - size_t line) +static inline UINT8 get_checked_uint8_int(UINT32 value, WINPR_ATTR_UNUSED const char* file, + WINPR_ATTR_UNUSED const char* fkt, + WINPR_ATTR_UNUSED size_t line) { WINPR_ASSERT_AT(value <= UINT8_MAX, file, fkt, line); return (UINT8)value; } #define get_checked_int16(value) get_checked_int16_int((value), __FILE__, __func__, __LINE__) -static inline INT16 get_checked_int16_int(INT32 value, const char* file, const char* fkt, - size_t line) +static inline INT16 get_checked_int16_int(INT32 value, WINPR_ATTR_UNUSED const char* file, + WINPR_ATTR_UNUSED const char* fkt, + WINPR_ATTR_UNUSED size_t line) { WINPR_ASSERT_AT(value <= INT16_MAX, file, fkt, line); WINPR_ASSERT_AT(value >= INT16_MIN, file, fkt, line); @@ -73,8 +76,10 @@ static inline INT16 get_checked_int16_int(INT32 value, const char* file, const c #define gdi_rob3_code_string_checked(value) \ gdi_rob3_code_string_checked_int((value), __FILE__, __func__, __LINE__) -static inline const char* gdi_rob3_code_string_checked_int(UINT32 rob, const char* file, - const char* fkt, size_t line) +static inline const char* gdi_rob3_code_string_checked_int(UINT32 rob, + WINPR_ATTR_UNUSED const char* file, + WINPR_ATTR_UNUSED const char* fkt, + WINPR_ATTR_UNUSED size_t line) { WINPR_ASSERT_AT((rob) <= UINT8_MAX, file, fkt, line); return gdi_rop3_code_string((BYTE)rob); @@ -82,8 +87,9 @@ static inline const char* gdi_rob3_code_string_checked_int(UINT32 rob, const cha #define gdi_rop3_code_checked(value) \ gdi_rop3_code_checked_int((value), __FILE__, __func__, __LINE__) -static inline DWORD gdi_rop3_code_checked_int(UINT32 code, const char* file, const char* fkt, - size_t line) +static inline DWORD gdi_rop3_code_checked_int(UINT32 code, WINPR_ATTR_UNUSED const char* file, + WINPR_ATTR_UNUSED const char* fkt, + WINPR_ATTR_UNUSED size_t line) { WINPR_ASSERT_AT(code <= UINT8_MAX, file, fkt, line); return gdi_rop3_code((UINT8)code); @@ -1089,7 +1095,7 @@ static INLINE BOOL update_read_delta_rects(wStream* s, DELTA_RECT* rectangles, c } static INLINE BOOL update_read_delta_points(wStream* s, DELTA_POINT** points, UINT32 number, - INT16 x, INT16 y) + WINPR_ATTR_UNUSED INT16 x, WINPR_ATTR_UNUSED INT16 y) { BYTE flags = 0; BYTE* zeroBits = NULL; @@ -2677,7 +2683,7 @@ fail: } size_t update_approximate_cache_bitmap_v3_order(CACHE_BITMAP_V3_ORDER* cache_bitmap_v3, - UINT16* flags) + WINPR_ATTR_UNUSED UINT16* flags) { BITMAP_DATA_EX* bitmapData = &cache_bitmap_v3->bitmapData; return 64 + bitmapData->length; @@ -2717,7 +2723,7 @@ BOOL update_write_cache_bitmap_v3_order(wStream* s, CACHE_BITMAP_V3_ORDER* cache WINPR_ATTR_MALLOC(free_cache_color_table_order, 2) static CACHE_COLOR_TABLE_ORDER* update_read_cache_color_table_order(rdpUpdate* update, wStream* s, - UINT16 flags) + WINPR_ATTR_UNUSED UINT16 flags) { UINT32* colorTable = NULL; CACHE_COLOR_TABLE_ORDER* cache_color_table = calloc(1, sizeof(CACHE_COLOR_TABLE_ORDER)); @@ -3034,11 +3040,13 @@ static BOOL update_decompress_brush(wStream* s, BYTE* output, size_t outSize, BY return TRUE; } -static BOOL update_compress_brush(wStream* s, const BYTE* input, BYTE bpp) +static BOOL update_compress_brush(WINPR_ATTR_UNUSED wStream* s, WINPR_ATTR_UNUSED const BYTE* input, + WINPR_ATTR_UNUSED BYTE bpp) { return FALSE; } -static CACHE_BRUSH_ORDER* update_read_cache_brush_order(rdpUpdate* update, wStream* s, UINT16 flags) +static CACHE_BRUSH_ORDER* update_read_cache_brush_order(rdpUpdate* update, wStream* s, + WINPR_ATTR_UNUSED UINT16 flags) { BOOL rc = 0; BYTE iBitmapFormat = 0; @@ -3315,7 +3323,8 @@ static BOOL update_read_switch_surface_order(wStream* s, SWITCH_SURFACE_ORDER* s Stream_Read_UINT16(s, switch_surface->bitmapId); /* bitmapId (2 bytes) */ return TRUE; } -size_t update_approximate_switch_surface_order(const SWITCH_SURFACE_ORDER* switch_surface) +size_t update_approximate_switch_surface_order( + WINPR_ATTR_UNUSED const SWITCH_SURFACE_ORDER* switch_surface) { return 2; } @@ -3515,7 +3524,8 @@ static BOOL update_read_field_flags(wStream* s, UINT32* fieldFlags, BYTE flags, return TRUE; } -BOOL update_write_field_flags(wStream* s, UINT32 fieldFlags, BYTE flags, BYTE fieldBytes) +BOOL update_write_field_flags(wStream* s, UINT32 fieldFlags, WINPR_ATTR_UNUSED BYTE flags, + BYTE fieldBytes) { BYTE byte = 0; @@ -4054,7 +4064,7 @@ static BOOL update_recv_primary_order(rdpUpdate* update, wStream* s, BYTE flags) return rc; } -static BOOL update_recv_secondary_order(rdpUpdate* update, wStream* s, BYTE flags) +static BOOL update_recv_secondary_order(rdpUpdate* update, wStream* s, WINPR_ATTR_UNUSED BYTE flags) { BOOL rc = FALSE; size_t start = 0; diff --git a/libfreerdp/core/peer.c b/libfreerdp/core/peer.c index 67807d92c..5be3df7ab 100644 --- a/libfreerdp/core/peer.c +++ b/libfreerdp/core/peer.c @@ -108,7 +108,8 @@ static HANDLE freerdp_peer_virtual_channel_open(freerdp_peer* client, const char return (HANDLE)peerChannel; } -static BOOL freerdp_peer_virtual_channel_close(freerdp_peer* client, HANDLE hChannel) +static BOOL freerdp_peer_virtual_channel_close(WINPR_ATTR_UNUSED freerdp_peer* client, + HANDLE hChannel) { rdpMcsChannel* mcsChannel = NULL; rdpPeerChannel* peerChannel = NULL; @@ -202,7 +203,8 @@ static int freerdp_peer_virtual_channel_write(freerdp_peer* client, HANDLE hChan return 1; } -static void* freerdp_peer_virtual_channel_get_data(freerdp_peer* client, HANDLE hChannel) +static void* freerdp_peer_virtual_channel_get_data(WINPR_ATTR_UNUSED freerdp_peer* client, + HANDLE hChannel) { rdpPeerChannel* peerChannel = (rdpPeerChannel*)hChannel; @@ -213,7 +215,8 @@ static void* freerdp_peer_virtual_channel_get_data(freerdp_peer* client, HANDLE return peerChannel->extra; } -static int freerdp_peer_virtual_channel_set_data(freerdp_peer* client, HANDLE hChannel, void* data) +static int freerdp_peer_virtual_channel_set_data(WINPR_ATTR_UNUSED freerdp_peer* client, + HANDLE hChannel, void* data) { rdpPeerChannel* peerChannel = (rdpPeerChannel*)hChannel; @@ -330,7 +333,8 @@ static BOOL freerdp_peer_check_fds(freerdp_peer* peer) return TRUE; } -static state_run_t peer_recv_data_pdu(freerdp_peer* client, wStream* s, UINT16 totalLength) +static state_run_t peer_recv_data_pdu(freerdp_peer* client, wStream* s, + WINPR_ATTR_UNUSED UINT16 totalLength) { BYTE type = 0; UINT16 length = 0; @@ -781,7 +785,8 @@ static state_run_t rdp_peer_handle_state_active(freerdp_peer* client) return ret; } -static state_run_t peer_recv_callback_internal(rdpTransport* transport, wStream* s, void* extra) +static state_run_t peer_recv_callback_internal(WINPR_ATTR_UNUSED rdpTransport* transport, + wStream* s, void* extra) { UINT32 SelectedProtocol = 0; freerdp_peer* client = (freerdp_peer*)extra; @@ -1296,7 +1301,8 @@ static BOOL freerdp_peer_has_more_to_read(freerdp_peer* peer) return transport_have_more_bytes_to_read(peer->context->rdp->transport); } -static LicenseCallbackResult freerdp_peer_nolicense(freerdp_peer* peer, wStream* s) +static LicenseCallbackResult freerdp_peer_nolicense(freerdp_peer* peer, + WINPR_ATTR_UNUSED wStream* s) { rdpRdp* rdp = NULL; diff --git a/libfreerdp/core/rdp.c b/libfreerdp/core/rdp.c index 26ee0d1c8..cd792cc64 100644 --- a/libfreerdp/core/rdp.c +++ b/libfreerdp/core/rdp.c @@ -973,7 +973,8 @@ fail: return rc; } -static BOOL rdp_recv_server_shutdown_denied_pdu(rdpRdp* rdp, wStream* s) +static BOOL rdp_recv_server_shutdown_denied_pdu(WINPR_ATTR_UNUSED rdpRdp* rdp, + WINPR_ATTR_UNUSED wStream* s) { return TRUE; } @@ -1851,7 +1852,8 @@ static state_run_t rdp_client_exchange_monitor_layout(rdpRdp* rdp, wStream* s) return status; } -static state_run_t rdp_recv_callback_int(rdpTransport* transport, wStream* s, void* extra) +static state_run_t rdp_recv_callback_int(WINPR_ATTR_UNUSED rdpTransport* transport, wStream* s, + void* extra) { state_run_t status = STATE_RUN_SUCCESS; rdpRdp* rdp = (rdpRdp*)extra; @@ -2797,7 +2799,7 @@ static BOOL parse_on_off_option(const char* value) #define STR(x) #x -static BOOL option_is_runtime_checks(wLog* log, const char* tok) +static BOOL option_is_runtime_checks(WINPR_ATTR_UNUSED wLog* log, const char* tok) { const char* experimental[] = { STR(WITH_VERBOSE_WINPR_ASSERT) }; for (size_t x = 0; x < ARRAYSIZE(experimental); x++) @@ -2811,7 +2813,7 @@ static BOOL option_is_runtime_checks(wLog* log, const char* tok) return FALSE; } -static BOOL option_is_experimental(wLog* log, const char* tok) +static BOOL option_is_experimental(WINPR_ATTR_UNUSED wLog* log, const char* tok) { const char* experimental[] = { STR(WITH_DSP_EXPERIMENTAL), STR(WITH_VAAPI) }; for (size_t x = 0; x < ARRAYSIZE(experimental); x++) diff --git a/libfreerdp/core/rdstls.c b/libfreerdp/core/rdstls.c index 247f63914..cc26c6090 100644 --- a/libfreerdp/core/rdstls.c +++ b/libfreerdp/core/rdstls.c @@ -218,7 +218,7 @@ static BOOL rdstls_set_state(rdpRdstls* rdstls, RDSTLS_STATE state) return rc; } -static BOOL rdstls_write_capabilities(rdpRdstls* rdstls, wStream* s) +static BOOL rdstls_write_capabilities(WINPR_ATTR_UNUSED rdpRdstls* rdstls, wStream* s) { if (!Stream_EnsureRemainingCapacity(s, 6)) return FALSE; @@ -304,7 +304,8 @@ static BOOL rdstls_write_authentication_request_with_password(rdpRdstls* rdstls, return TRUE; } -static BOOL rdstls_write_authentication_request_with_cookie(rdpRdstls* rdstls, wStream* s) +static BOOL rdstls_write_authentication_request_with_cookie(WINPR_ATTR_UNUSED rdpRdstls* rdstls, + WINPR_ATTR_UNUSED wStream* s) { // TODO return FALSE; @@ -351,7 +352,7 @@ static BOOL rdstls_process_capabilities(rdpRdstls* rdstls, wStream* s) return TRUE; } -static BOOL rdstls_read_unicode_string(wLog* log, wStream* s, char** str) +static BOOL rdstls_read_unicode_string(WINPR_ATTR_UNUSED wLog* log, wStream* s, char** str) { UINT16 length = 0; @@ -378,7 +379,8 @@ static BOOL rdstls_read_unicode_string(wLog* log, wStream* s, char** str) return TRUE; } -static BOOL rdstls_read_data(wLog* log, wStream* s, UINT16* pLength, const BYTE** pData) +static BOOL rdstls_read_data(WINPR_ATTR_UNUSED wLog* log, wStream* s, UINT16* pLength, + const BYTE** pData) { UINT16 length = 0; @@ -511,7 +513,8 @@ fail: return rc; } -static BOOL rdstls_process_authentication_request_with_cookie(rdpRdstls* rdstls, wStream* s) +static BOOL rdstls_process_authentication_request_with_cookie(WINPR_ATTR_UNUSED rdpRdstls* rdstls, + WINPR_ATTR_UNUSED wStream* s) { // TODO return FALSE; @@ -605,7 +608,7 @@ static BOOL rdstls_process_authentication_response(rdpRdstls* rdstls, wStream* s return TRUE; } -static BOOL rdstls_send(rdpTransport* transport, wStream* s, void* extra) +static BOOL rdstls_send(WINPR_ATTR_UNUSED rdpTransport* transport, wStream* s, void* extra) { rdpRdstls* rdstls = (rdpRdstls*)extra; rdpSettings* settings = NULL; @@ -663,7 +666,7 @@ static BOOL rdstls_send(rdpTransport* transport, wStream* s, void* extra) return TRUE; } -static int rdstls_recv(rdpTransport* transport, wStream* s, void* extra) +static int rdstls_recv(WINPR_ATTR_UNUSED rdpTransport* transport, wStream* s, void* extra) { UINT16 version = 0; UINT16 pduType = 0; diff --git a/libfreerdp/core/redirection.c b/libfreerdp/core/redirection.c index 286976929..57d1f056a 100644 --- a/libfreerdp/core/redirection.c +++ b/libfreerdp/core/redirection.c @@ -215,8 +215,8 @@ static BOOL rdp_redirection_write_data(wStream* s, size_t length, const void* da return TRUE; } -static BOOL rdp_redirection_write_base64_wchar(UINT32 flag, wStream* s, size_t length, - const void* data) +static BOOL rdp_redirection_write_base64_wchar(WINPR_ATTR_UNUSED UINT32 flag, wStream* s, + size_t length, const void* data) { BOOL rc = FALSE; @@ -933,7 +933,7 @@ void redirection_free(rdpRedirection* redirection) } } -static SSIZE_T redir_write_string(UINT32 flag, wStream* s, const char* str) +static SSIZE_T redir_write_string(WINPR_ATTR_UNUSED UINT32 flag, wStream* s, const char* str) { const size_t length = (strlen(str) + 1); if (!Stream_EnsureRemainingCapacity(s, 4ull + length * sizeof(WCHAR))) @@ -946,7 +946,8 @@ static SSIZE_T redir_write_string(UINT32 flag, wStream* s, const char* str) return (SSIZE_T)(Stream_GetPosition(s) - pos); } -static BOOL redir_write_data(UINT32 flag, wStream* s, UINT32 length, const BYTE* data) +static BOOL redir_write_data(WINPR_ATTR_UNUSED UINT32 flag, wStream* s, UINT32 length, + const BYTE* data) { if (!Stream_EnsureRemainingCapacity(s, 4ull + length)) return FALSE; diff --git a/libfreerdp/core/security.c b/libfreerdp/core/security.c index 5a92c241d..af67bd737 100644 --- a/libfreerdp/core/security.c +++ b/libfreerdp/core/security.c @@ -201,17 +201,16 @@ BOOL security_session_key_blob(const BYTE* master_secret, size_t master_len, client_len, server_random, server_len, &output[32], out_len - 32); } -void security_mac_salt_key(const BYTE* session_key_blob, size_t session_len, - const BYTE* client_random, size_t client_len, const BYTE* server_random, - size_t server_len, BYTE* output, size_t out_len) +void security_mac_salt_key(const BYTE* session_key_blob, WINPR_ATTR_UNUSED size_t session_len, + WINPR_ATTR_UNUSED const BYTE* client_random, + WINPR_ATTR_UNUSED size_t client_len, + WINPR_ATTR_UNUSED const BYTE* server_random, + WINPR_ATTR_UNUSED size_t server_len, BYTE* output, + WINPR_ATTR_UNUSED size_t out_len) { /* MacSaltKey = First128Bits(SessionKeyBlob) */ WINPR_ASSERT(out_len >= 16); WINPR_ASSERT(session_len >= 16); - WINPR_UNUSED(client_random); - WINPR_UNUSED(client_len); - WINPR_UNUSED(server_random); - WINPR_UNUSED(server_len); memcpy(output, session_key_blob, 16); } @@ -293,7 +292,7 @@ BOOL security_licensing_encryption_key(const BYTE* session_key_blob, size_t sess output, out_len); } -static void security_UINT32_le(BYTE* output, size_t out_len, UINT32 value) +static void security_UINT32_le(BYTE* output, WINPR_ATTR_UNUSED size_t out_len, UINT32 value) { WINPR_ASSERT(output); WINPR_ASSERT(out_len >= 4); @@ -390,6 +389,8 @@ BOOL security_mac_signature(rdpRdp* rdp, const BYTE* data, UINT32 length, BYTE* WINPR_ASSERT(data || (length == 0)); WINPR_ASSERT(output); WINPR_ASSERT(out_len >= 8); + if (out_len < 8) + return FALSE; security_UINT32_le(length_le, sizeof(length_le), length); /* length must be little-endian */ @@ -459,6 +460,8 @@ BOOL security_salted_mac_signature(rdpRdp* rdp, const BYTE* data, UINT32 length, WINPR_ASSERT(data || (length == 0)); WINPR_ASSERT(output); WINPR_ASSERT(out_len >= 8); + if (out_len < 8) + return FALSE; security_UINT32_le(length_le, sizeof(length_le), length); /* length must be little-endian */ @@ -565,7 +568,8 @@ static BOOL security_X(const BYTE* master_secret, size_t master_len, const BYTE* out_len - 32); } -static void fips_expand_key_bits(const BYTE* in, size_t in_len, BYTE* out, size_t out_len) +static void fips_expand_key_bits(const BYTE* in, WINPR_ATTR_UNUSED size_t in_len, BYTE* out, + WINPR_ATTR_UNUSED size_t out_len) { BYTE buf[21] = { 0 }; @@ -896,7 +900,8 @@ BOOL security_hmac_signature(const BYTE* data, size_t length, BYTE* output, size WINPR_ASSERT(rdp); WINPR_ASSERT(output); - WINPR_ASSERT(out_len >= 8); + if (out_len < 8) + return FALSE; security_UINT32_le(use_count_le, sizeof(use_count_le), rdp->encrypt_use_count); diff --git a/libfreerdp/core/server.c b/libfreerdp/core/server.c index 7e664c393..895a6d703 100644 --- a/libfreerdp/core/server.c +++ b/libfreerdp/core/server.c @@ -878,63 +878,91 @@ INT64 WTSChannelGetOptions(freerdp_peer* client, UINT16 channel_id) return (INT64)channel->options; } -BOOL WINAPI FreeRDP_WTSStartRemoteControlSessionW(LPWSTR pTargetServerName, ULONG TargetLogonId, - BYTE HotkeyVk, USHORT HotkeyModifiers) +BOOL WINAPI FreeRDP_WTSStartRemoteControlSessionW(WINPR_ATTR_UNUSED LPWSTR pTargetServerName, + WINPR_ATTR_UNUSED ULONG TargetLogonId, + WINPR_ATTR_UNUSED BYTE HotkeyVk, + WINPR_ATTR_UNUSED USHORT HotkeyModifiers) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSStartRemoteControlSessionA(LPSTR pTargetServerName, ULONG TargetLogonId, - BYTE HotkeyVk, USHORT HotkeyModifiers) +BOOL WINAPI FreeRDP_WTSStartRemoteControlSessionA(WINPR_ATTR_UNUSED LPSTR pTargetServerName, + WINPR_ATTR_UNUSED ULONG TargetLogonId, + WINPR_ATTR_UNUSED BYTE HotkeyVk, + WINPR_ATTR_UNUSED USHORT HotkeyModifiers) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSStartRemoteControlSessionExW(LPWSTR pTargetServerName, ULONG TargetLogonId, - BYTE HotkeyVk, USHORT HotkeyModifiers, - DWORD flags) +BOOL WINAPI FreeRDP_WTSStartRemoteControlSessionExW(WINPR_ATTR_UNUSED LPWSTR pTargetServerName, + WINPR_ATTR_UNUSED ULONG TargetLogonId, + WINPR_ATTR_UNUSED BYTE HotkeyVk, + WINPR_ATTR_UNUSED USHORT HotkeyModifiers, + WINPR_ATTR_UNUSED DWORD flags) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSStartRemoteControlSessionExA(LPSTR pTargetServerName, ULONG TargetLogonId, - BYTE HotkeyVk, USHORT HotkeyModifiers, - DWORD flags) +BOOL WINAPI FreeRDP_WTSStartRemoteControlSessionExA(WINPR_ATTR_UNUSED LPSTR pTargetServerName, + WINPR_ATTR_UNUSED ULONG TargetLogonId, + WINPR_ATTR_UNUSED BYTE HotkeyVk, + WINPR_ATTR_UNUSED USHORT HotkeyModifiers, + WINPR_ATTR_UNUSED DWORD flags) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSStopRemoteControlSession(ULONG LogonId) +BOOL WINAPI FreeRDP_WTSStopRemoteControlSession(WINPR_ATTR_UNUSED ULONG LogonId) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSConnectSessionW(ULONG LogonId, ULONG TargetLogonId, PWSTR pPassword, - BOOL bWait) +BOOL WINAPI FreeRDP_WTSConnectSessionW(WINPR_ATTR_UNUSED ULONG LogonId, + WINPR_ATTR_UNUSED ULONG TargetLogonId, + WINPR_ATTR_UNUSED PWSTR pPassword, + WINPR_ATTR_UNUSED BOOL bWait) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSConnectSessionA(ULONG LogonId, ULONG TargetLogonId, PSTR pPassword, - BOOL bWait) +BOOL WINAPI FreeRDP_WTSConnectSessionA(WINPR_ATTR_UNUSED ULONG LogonId, + WINPR_ATTR_UNUSED ULONG TargetLogonId, + WINPR_ATTR_UNUSED PSTR pPassword, + WINPR_ATTR_UNUSED BOOL bWait) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSEnumerateServersW(LPWSTR pDomainName, DWORD Reserved, DWORD Version, - PWTS_SERVER_INFOW* ppServerInfo, DWORD* pCount) +BOOL WINAPI FreeRDP_WTSEnumerateServersW(WINPR_ATTR_UNUSED LPWSTR pDomainName, + WINPR_ATTR_UNUSED DWORD Reserved, + WINPR_ATTR_UNUSED DWORD Version, + WINPR_ATTR_UNUSED PWTS_SERVER_INFOW* ppServerInfo, + WINPR_ATTR_UNUSED DWORD* pCount) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSEnumerateServersA(LPSTR pDomainName, DWORD Reserved, DWORD Version, - PWTS_SERVER_INFOA* ppServerInfo, DWORD* pCount) +BOOL WINAPI FreeRDP_WTSEnumerateServersA(WINPR_ATTR_UNUSED LPSTR pDomainName, + WINPR_ATTR_UNUSED DWORD Reserved, + WINPR_ATTR_UNUSED DWORD Version, + WINPR_ATTR_UNUSED PWTS_SERVER_INFOA* ppServerInfo, + WINPR_ATTR_UNUSED DWORD* pCount) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -HANDLE WINAPI FreeRDP_WTSOpenServerW(LPWSTR pServerName) +HANDLE WINAPI FreeRDP_WTSOpenServerW(WINPR_ATTR_UNUSED LPWSTR pServerName) { + WLog_ERR("TODO", "TODO: implement"); return INVALID_HANDLE_VALUE; } @@ -1056,8 +1084,9 @@ error_vcm_alloc: return INVALID_HANDLE_VALUE; } -HANDLE WINAPI FreeRDP_WTSOpenServerExW(LPWSTR pServerName) +HANDLE WINAPI FreeRDP_WTSOpenServerExW(WINPR_ATTR_UNUSED LPWSTR pServerName) { + WLog_ERR("TODO", "TODO: implement"); return INVALID_HANDLE_VALUE; } @@ -1088,55 +1117,85 @@ VOID WINAPI FreeRDP_WTSCloseServer(HANDLE hServer) } } -BOOL WINAPI FreeRDP_WTSEnumerateSessionsW(HANDLE hServer, DWORD Reserved, DWORD Version, - PWTS_SESSION_INFOW* ppSessionInfo, DWORD* pCount) +BOOL WINAPI FreeRDP_WTSEnumerateSessionsW(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED DWORD Reserved, + WINPR_ATTR_UNUSED DWORD Version, + WINPR_ATTR_UNUSED PWTS_SESSION_INFOW* ppSessionInfo, + WINPR_ATTR_UNUSED DWORD* pCount) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSEnumerateSessionsA(HANDLE hServer, DWORD Reserved, DWORD Version, - PWTS_SESSION_INFOA* ppSessionInfo, DWORD* pCount) +BOOL WINAPI FreeRDP_WTSEnumerateSessionsA(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED DWORD Reserved, + WINPR_ATTR_UNUSED DWORD Version, + WINPR_ATTR_UNUSED PWTS_SESSION_INFOA* ppSessionInfo, + WINPR_ATTR_UNUSED DWORD* pCount) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSEnumerateSessionsExW(HANDLE hServer, DWORD* pLevel, DWORD Filter, - PWTS_SESSION_INFO_1W* ppSessionInfo, DWORD* pCount) +BOOL WINAPI FreeRDP_WTSEnumerateSessionsExW(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED DWORD* pLevel, + WINPR_ATTR_UNUSED DWORD Filter, + WINPR_ATTR_UNUSED PWTS_SESSION_INFO_1W* ppSessionInfo, + WINPR_ATTR_UNUSED DWORD* pCount) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSEnumerateSessionsExA(HANDLE hServer, DWORD* pLevel, DWORD Filter, - PWTS_SESSION_INFO_1A* ppSessionInfo, DWORD* pCount) +BOOL WINAPI FreeRDP_WTSEnumerateSessionsExA(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED DWORD* pLevel, + WINPR_ATTR_UNUSED DWORD Filter, + WINPR_ATTR_UNUSED PWTS_SESSION_INFO_1A* ppSessionInfo, + WINPR_ATTR_UNUSED DWORD* pCount) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSEnumerateProcessesW(HANDLE hServer, DWORD Reserved, DWORD Version, - PWTS_PROCESS_INFOW* ppProcessInfo, DWORD* pCount) +BOOL WINAPI FreeRDP_WTSEnumerateProcessesW(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED DWORD Reserved, + WINPR_ATTR_UNUSED DWORD Version, + WINPR_ATTR_UNUSED PWTS_PROCESS_INFOW* ppProcessInfo, + WINPR_ATTR_UNUSED DWORD* pCount) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSEnumerateProcessesA(HANDLE hServer, DWORD Reserved, DWORD Version, - PWTS_PROCESS_INFOA* ppProcessInfo, DWORD* pCount) +BOOL WINAPI FreeRDP_WTSEnumerateProcessesA(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED DWORD Reserved, + WINPR_ATTR_UNUSED DWORD Version, + WINPR_ATTR_UNUSED PWTS_PROCESS_INFOA* ppProcessInfo, + WINPR_ATTR_UNUSED DWORD* pCount) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSTerminateProcess(HANDLE hServer, DWORD ProcessId, DWORD ExitCode) +BOOL WINAPI FreeRDP_WTSTerminateProcess(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED DWORD ProcessId, + WINPR_ATTR_UNUSED DWORD ExitCode) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSQuerySessionInformationW(HANDLE hServer, DWORD SessionId, - WTS_INFO_CLASS WTSInfoClass, LPWSTR* ppBuffer, - DWORD* pBytesReturned) +BOOL WINAPI FreeRDP_WTSQuerySessionInformationW(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED DWORD SessionId, + WINPR_ATTR_UNUSED WTS_INFO_CLASS WTSInfoClass, + WINPR_ATTR_UNUSED LPWSTR* ppBuffer, + WINPR_ATTR_UNUSED DWORD* pBytesReturned) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSQuerySessionInformationA(HANDLE hServer, DWORD SessionId, +BOOL WINAPI FreeRDP_WTSQuerySessionInformationA(HANDLE hServer, WINPR_ATTR_UNUSED DWORD SessionId, WTS_INFO_CLASS WTSInfoClass, LPSTR* ppBuffer, DWORD* pBytesReturned) { @@ -1168,65 +1227,96 @@ BOOL WINAPI FreeRDP_WTSQuerySessionInformationA(HANDLE hServer, DWORD SessionId, return FALSE; } -BOOL WINAPI FreeRDP_WTSQueryUserConfigW(LPWSTR pServerName, LPWSTR pUserName, - WTS_CONFIG_CLASS WTSConfigClass, LPWSTR* ppBuffer, - DWORD* pBytesReturned) +BOOL WINAPI FreeRDP_WTSQueryUserConfigW(WINPR_ATTR_UNUSED LPWSTR pServerName, + WINPR_ATTR_UNUSED LPWSTR pUserName, + WINPR_ATTR_UNUSED WTS_CONFIG_CLASS WTSConfigClass, + WINPR_ATTR_UNUSED LPWSTR* ppBuffer, + WINPR_ATTR_UNUSED DWORD* pBytesReturned) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSQueryUserConfigA(LPSTR pServerName, LPSTR pUserName, - WTS_CONFIG_CLASS WTSConfigClass, LPSTR* ppBuffer, - DWORD* pBytesReturned) +BOOL WINAPI FreeRDP_WTSQueryUserConfigA(WINPR_ATTR_UNUSED LPSTR pServerName, + WINPR_ATTR_UNUSED LPSTR pUserName, + WINPR_ATTR_UNUSED WTS_CONFIG_CLASS WTSConfigClass, + WINPR_ATTR_UNUSED LPSTR* ppBuffer, + WINPR_ATTR_UNUSED DWORD* pBytesReturned) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSSetUserConfigW(LPWSTR pServerName, LPWSTR pUserName, - WTS_CONFIG_CLASS WTSConfigClass, LPWSTR pBuffer, - DWORD DataLength) +BOOL WINAPI FreeRDP_WTSSetUserConfigW(WINPR_ATTR_UNUSED LPWSTR pServerName, + WINPR_ATTR_UNUSED LPWSTR pUserName, + WINPR_ATTR_UNUSED WTS_CONFIG_CLASS WTSConfigClass, + WINPR_ATTR_UNUSED LPWSTR pBuffer, + WINPR_ATTR_UNUSED DWORD DataLength) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSSetUserConfigA(LPSTR pServerName, LPSTR pUserName, - WTS_CONFIG_CLASS WTSConfigClass, LPSTR pBuffer, - DWORD DataLength) +BOOL WINAPI FreeRDP_WTSSetUserConfigA(WINPR_ATTR_UNUSED LPSTR pServerName, + WINPR_ATTR_UNUSED LPSTR pUserName, + WINPR_ATTR_UNUSED WTS_CONFIG_CLASS WTSConfigClass, + WINPR_ATTR_UNUSED LPSTR pBuffer, + WINPR_ATTR_UNUSED DWORD DataLength) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSSendMessageW(HANDLE hServer, DWORD SessionId, LPWSTR pTitle, - DWORD TitleLength, LPWSTR pMessage, DWORD MessageLength, - DWORD Style, DWORD Timeout, DWORD* pResponse, BOOL bWait) +BOOL WINAPI +FreeRDP_WTSSendMessageW(WINPR_ATTR_UNUSED HANDLE hServer, WINPR_ATTR_UNUSED DWORD SessionId, + WINPR_ATTR_UNUSED LPWSTR pTitle, WINPR_ATTR_UNUSED DWORD TitleLength, + WINPR_ATTR_UNUSED LPWSTR pMessage, WINPR_ATTR_UNUSED DWORD MessageLength, + WINPR_ATTR_UNUSED DWORD Style, WINPR_ATTR_UNUSED DWORD Timeout, + WINPR_ATTR_UNUSED DWORD* pResponse, WINPR_ATTR_UNUSED BOOL bWait) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSSendMessageA(HANDLE hServer, DWORD SessionId, LPSTR pTitle, - DWORD TitleLength, LPSTR pMessage, DWORD MessageLength, - DWORD Style, DWORD Timeout, DWORD* pResponse, BOOL bWait) +BOOL WINAPI +FreeRDP_WTSSendMessageA(WINPR_ATTR_UNUSED HANDLE hServer, WINPR_ATTR_UNUSED DWORD SessionId, + WINPR_ATTR_UNUSED LPSTR pTitle, WINPR_ATTR_UNUSED DWORD TitleLength, + WINPR_ATTR_UNUSED LPSTR pMessage, WINPR_ATTR_UNUSED DWORD MessageLength, + WINPR_ATTR_UNUSED DWORD Style, WINPR_ATTR_UNUSED DWORD Timeout, + WINPR_ATTR_UNUSED DWORD* pResponse, WINPR_ATTR_UNUSED BOOL bWait) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSDisconnectSession(HANDLE hServer, DWORD SessionId, BOOL bWait) +BOOL WINAPI FreeRDP_WTSDisconnectSession(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED DWORD SessionId, + WINPR_ATTR_UNUSED BOOL bWait) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSLogoffSession(HANDLE hServer, DWORD SessionId, BOOL bWait) +BOOL WINAPI FreeRDP_WTSLogoffSession(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED DWORD SessionId, + WINPR_ATTR_UNUSED BOOL bWait) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSShutdownSystem(HANDLE hServer, DWORD ShutdownFlag) +BOOL WINAPI FreeRDP_WTSShutdownSystem(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED DWORD ShutdownFlag) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSWaitSystemEvent(HANDLE hServer, DWORD EventMask, DWORD* pEventFlags) +BOOL WINAPI FreeRDP_WTSWaitSystemEvent(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED DWORD EventMask, + WINPR_ATTR_UNUSED DWORD* pEventFlags) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } @@ -1267,7 +1357,8 @@ fail: return NULL; } -HANDLE WINAPI FreeRDP_WTSVirtualChannelOpen(HANDLE hServer, DWORD SessionId, LPSTR pVirtualName) +HANDLE WINAPI FreeRDP_WTSVirtualChannelOpen(HANDLE hServer, WINPR_ATTR_UNUSED DWORD SessionId, + LPSTR pVirtualName) { size_t length = 0; rdpMcs* mcs = NULL; @@ -1502,8 +1593,8 @@ BOOL WINAPI FreeRDP_WTSVirtualChannelClose(HANDLE hChannelHandle) return ret; } -BOOL WINAPI FreeRDP_WTSVirtualChannelRead(HANDLE hChannelHandle, ULONG TimeOut, PCHAR Buffer, - ULONG BufferSize, PULONG pBytesRead) +BOOL WINAPI FreeRDP_WTSVirtualChannelRead(HANDLE hChannelHandle, WINPR_ATTR_UNUSED ULONG TimeOut, + PCHAR Buffer, ULONG BufferSize, PULONG pBytesRead) { BYTE* buffer = NULL; wMessage message = { 0 }; @@ -1646,13 +1737,15 @@ fail: return ret; } -BOOL WINAPI FreeRDP_WTSVirtualChannelPurgeInput(HANDLE hChannelHandle) +BOOL WINAPI FreeRDP_WTSVirtualChannelPurgeInput(WINPR_ATTR_UNUSED HANDLE hChannelHandle) { + WLog_ERR("TODO", "TODO: implement"); return TRUE; } -BOOL WINAPI FreeRDP_WTSVirtualChannelPurgeOutput(HANDLE hChannelHandle) +BOOL WINAPI FreeRDP_WTSVirtualChannelPurgeOutput(WINPR_ATTR_UNUSED HANDLE hChannelHandle) { + WLog_ERR("TODO", "TODO: implement"); return TRUE; } @@ -1785,152 +1878,215 @@ VOID WINAPI FreeRDP_WTSFreeMemory(PVOID pMemory) free(pMemory); } -BOOL WINAPI FreeRDP_WTSFreeMemoryExW(WTS_TYPE_CLASS WTSTypeClass, PVOID pMemory, - ULONG NumberOfEntries) +BOOL WINAPI FreeRDP_WTSFreeMemoryExW(WINPR_ATTR_UNUSED WTS_TYPE_CLASS WTSTypeClass, + WINPR_ATTR_UNUSED PVOID pMemory, + WINPR_ATTR_UNUSED ULONG NumberOfEntries) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSFreeMemoryExA(WTS_TYPE_CLASS WTSTypeClass, PVOID pMemory, - ULONG NumberOfEntries) +BOOL WINAPI FreeRDP_WTSFreeMemoryExA(WINPR_ATTR_UNUSED WTS_TYPE_CLASS WTSTypeClass, + WINPR_ATTR_UNUSED PVOID pMemory, + WINPR_ATTR_UNUSED ULONG NumberOfEntries) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSRegisterSessionNotification(HWND hWnd, DWORD dwFlags) +BOOL WINAPI FreeRDP_WTSRegisterSessionNotification(WINPR_ATTR_UNUSED HWND hWnd, + WINPR_ATTR_UNUSED DWORD dwFlags) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSUnRegisterSessionNotification(HWND hWnd) +BOOL WINAPI FreeRDP_WTSUnRegisterSessionNotification(WINPR_ATTR_UNUSED HWND hWnd) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSRegisterSessionNotificationEx(HANDLE hServer, HWND hWnd, DWORD dwFlags) +BOOL WINAPI FreeRDP_WTSRegisterSessionNotificationEx(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED HWND hWnd, + WINPR_ATTR_UNUSED DWORD dwFlags) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSUnRegisterSessionNotificationEx(HANDLE hServer, HWND hWnd) +BOOL WINAPI FreeRDP_WTSUnRegisterSessionNotificationEx(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED HWND hWnd) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSQueryUserToken(ULONG SessionId, PHANDLE phToken) +BOOL WINAPI FreeRDP_WTSQueryUserToken(WINPR_ATTR_UNUSED ULONG SessionId, + WINPR_ATTR_UNUSED PHANDLE phToken) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSEnumerateProcessesExW(HANDLE hServer, DWORD* pLevel, DWORD SessionId, - LPWSTR* ppProcessInfo, DWORD* pCount) +BOOL WINAPI FreeRDP_WTSEnumerateProcessesExW(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED DWORD* pLevel, + WINPR_ATTR_UNUSED DWORD SessionId, + WINPR_ATTR_UNUSED LPWSTR* ppProcessInfo, + WINPR_ATTR_UNUSED DWORD* pCount) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSEnumerateProcessesExA(HANDLE hServer, DWORD* pLevel, DWORD SessionId, - LPSTR* ppProcessInfo, DWORD* pCount) +BOOL WINAPI FreeRDP_WTSEnumerateProcessesExA(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED DWORD* pLevel, + WINPR_ATTR_UNUSED DWORD SessionId, + WINPR_ATTR_UNUSED LPSTR* ppProcessInfo, + WINPR_ATTR_UNUSED DWORD* pCount) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSEnumerateListenersW(HANDLE hServer, PVOID pReserved, DWORD Reserved, - PWTSLISTENERNAMEW pListeners, DWORD* pCount) +BOOL WINAPI FreeRDP_WTSEnumerateListenersW(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED PVOID pReserved, + WINPR_ATTR_UNUSED DWORD Reserved, + WINPR_ATTR_UNUSED PWTSLISTENERNAMEW pListeners, + WINPR_ATTR_UNUSED DWORD* pCount) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSEnumerateListenersA(HANDLE hServer, PVOID pReserved, DWORD Reserved, - PWTSLISTENERNAMEA pListeners, DWORD* pCount) +BOOL WINAPI FreeRDP_WTSEnumerateListenersA(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED PVOID pReserved, + WINPR_ATTR_UNUSED DWORD Reserved, + WINPR_ATTR_UNUSED PWTSLISTENERNAMEA pListeners, + WINPR_ATTR_UNUSED DWORD* pCount) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSQueryListenerConfigW(HANDLE hServer, PVOID pReserved, DWORD Reserved, - LPWSTR pListenerName, PWTSLISTENERCONFIGW pBuffer) +BOOL WINAPI FreeRDP_WTSQueryListenerConfigW(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED PVOID pReserved, + WINPR_ATTR_UNUSED DWORD Reserved, + WINPR_ATTR_UNUSED LPWSTR pListenerName, + WINPR_ATTR_UNUSED PWTSLISTENERCONFIGW pBuffer) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSQueryListenerConfigA(HANDLE hServer, PVOID pReserved, DWORD Reserved, - LPSTR pListenerName, PWTSLISTENERCONFIGA pBuffer) +BOOL WINAPI FreeRDP_WTSQueryListenerConfigA(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED PVOID pReserved, + WINPR_ATTR_UNUSED DWORD Reserved, + WINPR_ATTR_UNUSED LPSTR pListenerName, + WINPR_ATTR_UNUSED PWTSLISTENERCONFIGA pBuffer) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSCreateListenerW(HANDLE hServer, PVOID pReserved, DWORD Reserved, - LPWSTR pListenerName, PWTSLISTENERCONFIGW pBuffer, - DWORD flag) +BOOL WINAPI FreeRDP_WTSCreateListenerW(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED PVOID pReserved, + WINPR_ATTR_UNUSED DWORD Reserved, + WINPR_ATTR_UNUSED LPWSTR pListenerName, + WINPR_ATTR_UNUSED PWTSLISTENERCONFIGW pBuffer, + WINPR_ATTR_UNUSED DWORD flag) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSCreateListenerA(HANDLE hServer, PVOID pReserved, DWORD Reserved, - LPSTR pListenerName, PWTSLISTENERCONFIGA pBuffer, DWORD flag) +BOOL WINAPI FreeRDP_WTSCreateListenerA(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED PVOID pReserved, + WINPR_ATTR_UNUSED DWORD Reserved, + WINPR_ATTR_UNUSED LPSTR pListenerName, + WINPR_ATTR_UNUSED PWTSLISTENERCONFIGA pBuffer, + WINPR_ATTR_UNUSED DWORD flag) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSSetListenerSecurityW(HANDLE hServer, PVOID pReserved, DWORD Reserved, - LPWSTR pListenerName, - SECURITY_INFORMATION SecurityInformation, - PSECURITY_DESCRIPTOR pSecurityDescriptor) +BOOL WINAPI FreeRDP_WTSSetListenerSecurityW( + WINPR_ATTR_UNUSED HANDLE hServer, WINPR_ATTR_UNUSED PVOID pReserved, + WINPR_ATTR_UNUSED DWORD Reserved, WINPR_ATTR_UNUSED LPWSTR pListenerName, + WINPR_ATTR_UNUSED SECURITY_INFORMATION SecurityInformation, + WINPR_ATTR_UNUSED PSECURITY_DESCRIPTOR pSecurityDescriptor) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSSetListenerSecurityA(HANDLE hServer, PVOID pReserved, DWORD Reserved, - LPSTR pListenerName, - SECURITY_INFORMATION SecurityInformation, - PSECURITY_DESCRIPTOR pSecurityDescriptor) +BOOL WINAPI FreeRDP_WTSSetListenerSecurityA( + WINPR_ATTR_UNUSED HANDLE hServer, WINPR_ATTR_UNUSED PVOID pReserved, + WINPR_ATTR_UNUSED DWORD Reserved, WINPR_ATTR_UNUSED LPSTR pListenerName, + WINPR_ATTR_UNUSED SECURITY_INFORMATION SecurityInformation, + WINPR_ATTR_UNUSED PSECURITY_DESCRIPTOR pSecurityDescriptor) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSGetListenerSecurityW(HANDLE hServer, PVOID pReserved, DWORD Reserved, - LPWSTR pListenerName, - SECURITY_INFORMATION SecurityInformation, - PSECURITY_DESCRIPTOR pSecurityDescriptor, DWORD nLength, - LPDWORD lpnLengthNeeded) +BOOL WINAPI FreeRDP_WTSGetListenerSecurityW( + WINPR_ATTR_UNUSED HANDLE hServer, WINPR_ATTR_UNUSED PVOID pReserved, + WINPR_ATTR_UNUSED DWORD Reserved, WINPR_ATTR_UNUSED LPWSTR pListenerName, + WINPR_ATTR_UNUSED SECURITY_INFORMATION SecurityInformation, + WINPR_ATTR_UNUSED PSECURITY_DESCRIPTOR pSecurityDescriptor, WINPR_ATTR_UNUSED DWORD nLength, + WINPR_ATTR_UNUSED LPDWORD lpnLengthNeeded) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSGetListenerSecurityA(HANDLE hServer, PVOID pReserved, DWORD Reserved, - LPSTR pListenerName, - SECURITY_INFORMATION SecurityInformation, - PSECURITY_DESCRIPTOR pSecurityDescriptor, DWORD nLength, - LPDWORD lpnLengthNeeded) +BOOL WINAPI FreeRDP_WTSGetListenerSecurityA( + WINPR_ATTR_UNUSED HANDLE hServer, WINPR_ATTR_UNUSED PVOID pReserved, + WINPR_ATTR_UNUSED DWORD Reserved, WINPR_ATTR_UNUSED LPSTR pListenerName, + WINPR_ATTR_UNUSED SECURITY_INFORMATION SecurityInformation, + WINPR_ATTR_UNUSED PSECURITY_DESCRIPTOR pSecurityDescriptor, WINPR_ATTR_UNUSED DWORD nLength, + WINPR_ATTR_UNUSED LPDWORD lpnLengthNeeded) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL CDECL FreeRDP_WTSEnableChildSessions(BOOL bEnable) +BOOL CDECL FreeRDP_WTSEnableChildSessions(WINPR_ATTR_UNUSED BOOL bEnable) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL CDECL FreeRDP_WTSIsChildSessionsEnabled(PBOOL pbEnabled) +BOOL CDECL FreeRDP_WTSIsChildSessionsEnabled(WINPR_ATTR_UNUSED PBOOL pbEnabled) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL CDECL FreeRDP_WTSGetChildSessionId(PULONG pSessionId) +BOOL CDECL FreeRDP_WTSGetChildSessionId(WINPR_ATTR_UNUSED PULONG pSessionId) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } DWORD WINAPI FreeRDP_WTSGetActiveConsoleSessionId(void) { + WLog_ERR("TODO", "TODO: implement"); return 0xFFFFFFFF; } -BOOL WINAPI FreeRDP_WTSLogoffUser(HANDLE hServer) +BOOL WINAPI FreeRDP_WTSLogoffUser(WINPR_ATTR_UNUSED HANDLE hServer) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } -BOOL WINAPI FreeRDP_WTSLogonUser(HANDLE hServer, LPCSTR username, LPCSTR password, LPCSTR domain) +BOOL WINAPI FreeRDP_WTSLogonUser(WINPR_ATTR_UNUSED HANDLE hServer, + WINPR_ATTR_UNUSED LPCSTR username, + WINPR_ATTR_UNUSED LPCSTR password, WINPR_ATTR_UNUSED LPCSTR domain) { + WLog_ERR("TODO", "TODO: implement"); return FALSE; } diff --git a/libfreerdp/core/settings.c b/libfreerdp/core/settings.c index d01f57aff..81088f7df 100644 --- a/libfreerdp/core/settings.c +++ b/libfreerdp/core/settings.c @@ -1635,8 +1635,9 @@ BOOL identity_set_from_smartcard_hash(SEC_WINNT_AUTH_IDENTITY_W* identity, const rdpSettings* settings, FreeRDP_Settings_Keys_String userId, FreeRDP_Settings_Keys_String domainId, - FreeRDP_Settings_Keys_String pwdId, const BYTE* certSha1, - size_t sha1len) + FreeRDP_Settings_Keys_String pwdId, + WINPR_ATTR_UNUSED const BYTE* certSha1, + WINPR_ATTR_UNUSED size_t sha1len) { #ifdef _WIN32 CERT_CREDENTIAL_INFO certInfo = { sizeof(CERT_CREDENTIAL_INFO), { 0 } }; diff --git a/libfreerdp/core/smartcardlogon.c b/libfreerdp/core/smartcardlogon.c index 74ba8cfd3..d4a057350 100644 --- a/libfreerdp/core/smartcardlogon.c +++ b/libfreerdp/core/smartcardlogon.c @@ -381,10 +381,10 @@ out: } #endif /* _WIN32 */ -static BOOL list_provider_keys(const rdpSettings* settings, NCRYPT_PROV_HANDLE provider, - LPCWSTR csp, LPCWSTR scope, const char* userFilter, - const char* domainFilter, SmartcardCertInfo*** pcerts, - size_t* pcount) +static BOOL list_provider_keys(WINPR_ATTR_UNUSED const rdpSettings* settings, + NCRYPT_PROV_HANDLE provider, LPCWSTR csp, LPCWSTR scope, + const char* userFilter, const char* domainFilter, + SmartcardCertInfo*** pcerts, size_t* pcount) { BOOL ret = FALSE; NCryptKeyName* keyName = NULL; diff --git a/libfreerdp/core/streamdump.c b/libfreerdp/core/streamdump.c index 4ae571642..4c21ae225 100644 --- a/libfreerdp/core/streamdump.c +++ b/libfreerdp/core/streamdump.c @@ -376,8 +376,11 @@ static int stream_dump_replay_transport_read(rdpTransport* transport, wStream* s return 1; } -static int stream_dump_replay_transport_tcp_connect(rdpContext* context, rdpSettings* settings, - const char* hostname, int port, DWORD timeout) +static int stream_dump_replay_transport_tcp_connect(WINPR_ATTR_UNUSED rdpContext* context, + WINPR_ATTR_UNUSED rdpSettings* settings, + WINPR_ATTR_UNUSED const char* hostname, + WINPR_ATTR_UNUSED int port, + WINPR_ATTR_UNUSED DWORD timeout) { WINPR_ASSERT(context); WINPR_ASSERT(settings); @@ -386,9 +389,9 @@ static int stream_dump_replay_transport_tcp_connect(rdpContext* context, rdpSett return 42; } -static rdpTransportLayer* stream_dump_replay_transport_connect_layer(rdpTransport* transport, - const char* hostname, int port, - DWORD timeout) +static rdpTransportLayer* stream_dump_replay_transport_connect_layer( + WINPR_ATTR_UNUSED rdpTransport* transport, WINPR_ATTR_UNUSED const char* hostname, + WINPR_ATTR_UNUSED int port, WINPR_ATTR_UNUSED DWORD timeout) { WINPR_ASSERT(transport); WINPR_ASSERT(hostname); @@ -396,13 +399,13 @@ static rdpTransportLayer* stream_dump_replay_transport_connect_layer(rdpTranspor return NULL; } -static BOOL stream_dump_replay_transport_tls_connect(rdpTransport* transport) +static BOOL stream_dump_replay_transport_tls_connect(WINPR_ATTR_UNUSED rdpTransport* transport) { WINPR_ASSERT(transport); return TRUE; } -static BOOL stream_dump_replay_transport_accept(rdpTransport* transport) +static BOOL stream_dump_replay_transport_accept(WINPR_ATTR_UNUSED rdpTransport* transport) { WINPR_ASSERT(transport); return TRUE; diff --git a/libfreerdp/core/tcp.c b/libfreerdp/core/tcp.c index 52af82d89..c6ae8d6d4 100644 --- a/libfreerdp/core/tcp.c +++ b/libfreerdp/core/tcp.c @@ -103,8 +103,10 @@ typedef struct static int transport_bio_simple_init(BIO* bio, SOCKET socket, int shutdown); static int transport_bio_simple_uninit(BIO* bio); -static long transport_bio_simple_callback(BIO* bio, int mode, const char* argp, int argi, long argl, - long ret) +static long transport_bio_simple_callback(WINPR_ATTR_UNUSED BIO* bio, WINPR_ATTR_UNUSED int mode, + WINPR_ATTR_UNUSED const char* argp, + WINPR_ATTR_UNUSED int argi, WINPR_ATTR_UNUSED long argl, + WINPR_ATTR_UNUSED long ret) { return 1; } @@ -178,12 +180,13 @@ static int transport_bio_simple_read(BIO* bio, char* buf, int size) return -1; } -static int transport_bio_simple_puts(BIO* bio, const char* str) +static int transport_bio_simple_puts(WINPR_ATTR_UNUSED BIO* bio, WINPR_ATTR_UNUSED const char* str) { return 1; } -static int transport_bio_simple_gets(BIO* bio, char* str, int size) +static int transport_bio_simple_gets(WINPR_ATTR_UNUSED BIO* bio, WINPR_ATTR_UNUSED char* str, + WINPR_ATTR_UNUSED int size) { return 1; } @@ -461,8 +464,10 @@ typedef struct RingBuffer xmitBuffer; } WINPR_BIO_BUFFERED_SOCKET; -static long transport_bio_buffered_callback(BIO* bio, int mode, const char* argp, int argi, - long argl, long ret) +static long transport_bio_buffered_callback(WINPR_ATTR_UNUSED BIO* bio, WINPR_ATTR_UNUSED int mode, + WINPR_ATTR_UNUSED const char* argp, + WINPR_ATTR_UNUSED int argi, WINPR_ATTR_UNUSED long argl, + WINPR_ATTR_UNUSED long ret) { return 1; } @@ -567,12 +572,14 @@ out: return status; } -static int transport_bio_buffered_puts(BIO* bio, const char* str) +static int transport_bio_buffered_puts(WINPR_ATTR_UNUSED BIO* bio, + WINPR_ATTR_UNUSED const char* str) { return 1; } -static int transport_bio_buffered_gets(BIO* bio, char* str, int size) +static int transport_bio_buffered_gets(WINPR_ATTR_UNUSED BIO* bio, WINPR_ATTR_UNUSED char* str, + WINPR_ATTR_UNUSED int size) { return 1; } @@ -900,7 +907,7 @@ static void peer_free(t_peer* peer) } static int freerdp_tcp_connect_multi(rdpContext* context, char** hostnames, const UINT32* ports, - UINT32 count, UINT16 port, UINT32 timeout) + UINT32 count, UINT16 port, WINPR_ATTR_UNUSED UINT32 timeout) { UINT32 sindex = count; SOCKET sockfd = INVALID_SOCKET; diff --git a/libfreerdp/core/transport.c b/libfreerdp/core/transport.c index ade66fc08..07b669d23 100644 --- a/libfreerdp/core/transport.c +++ b/libfreerdp/core/transport.c @@ -740,8 +740,9 @@ fail: #define WLog_ERR_BIO(transport, biofunc, bio) \ transport_bio_error_log(transport, biofunc, bio, __FILE__, __func__, __LINE__) -static void transport_bio_error_log(rdpTransport* transport, LPCSTR biofunc, BIO* bio, LPCSTR file, - LPCSTR func, DWORD line) +static void transport_bio_error_log(rdpTransport* transport, LPCSTR biofunc, + WINPR_ATTR_UNUSED BIO* bio, LPCSTR file, LPCSTR func, + DWORD line) { unsigned long sslerr = 0; int saveerrno = 0; @@ -1908,7 +1909,8 @@ void transport_set_early_user_auth_mode(rdpTransport* transport, BOOL EUAMode) WLog_Print(transport->log, WLOG_DEBUG, "Early User Auth Mode: %s", EUAMode ? "on" : "off"); } -rdpTransportLayer* transport_layer_new(rdpTransport* transport, size_t contextSize) +rdpTransportLayer* transport_layer_new(WINPR_ATTR_UNUSED rdpTransport* transport, + size_t contextSize) { rdpTransportLayer* layer = (rdpTransportLayer*)calloc(1, sizeof(rdpTransportLayer)); if (!layer) @@ -1983,12 +1985,13 @@ static int transport_layer_bio_read(BIO* bio, char* buf, int size) return status; } -static int transport_layer_bio_puts(BIO* bio, const char* str) +static int transport_layer_bio_puts(WINPR_ATTR_UNUSED BIO* bio, WINPR_ATTR_UNUSED const char* str) { return 1; } -static int transport_layer_bio_gets(BIO* bio, char* str, int size) +static int transport_layer_bio_gets(WINPR_ATTR_UNUSED BIO* bio, WINPR_ATTR_UNUSED char* str, + WINPR_ATTR_UNUSED int size) { return 1; } diff --git a/libfreerdp/core/update.c b/libfreerdp/core/update.c index 50c6477e0..9726d28e2 100644 --- a/libfreerdp/core/update.c +++ b/libfreerdp/core/update.c @@ -2737,8 +2737,9 @@ static BOOL update_send_window_update(rdpContext* context, const WINDOW_ORDER_IN return update_send_new_or_existing_window(context, orderInfo, stateOrder); } -static UINT16 update_calculate_window_icon_order(const WINDOW_ORDER_INFO* orderInfo, - const WINDOW_ICON_ORDER* iconOrder) +static UINT16 +update_calculate_window_icon_order(WINPR_ATTR_UNUSED const WINDOW_ORDER_INFO* orderInfo, + const WINDOW_ICON_ORDER* iconOrder) { UINT16 orderSize = 23; diff --git a/libfreerdp/core/utils.c b/libfreerdp/core/utils.c index 233d45ae1..1c3ff93a6 100644 --- a/libfreerdp/core/utils.c +++ b/libfreerdp/core/utils.c @@ -374,7 +374,7 @@ static BOOL disable_port(rdpSettings* settings) return remove_rdpdr_type(settings, RDPDR_DTYP_PARALLEL); } -static BOOL disable_pnp(rdpSettings* settings) +static BOOL disable_pnp(WINPR_ATTR_UNUSED rdpSettings* settings) { // TODO(akallabeth): [MS-RDPEPNP] related stuff is disabled. return TRUE; diff --git a/libfreerdp/core/window.c b/libfreerdp/core/window.c index 752fca352..6f4ca7394 100644 --- a/libfreerdp/core/window.c +++ b/libfreerdp/core/window.c @@ -508,7 +508,8 @@ static BOOL update_read_window_cached_icon_order(wStream* s, WINDOW_ORDER_INFO* s, &window_cached_icon->cachedIcon); /* cachedIcon (CACHED_ICON_INFO) */ } -static void update_read_window_delete_order(wStream* s, WINDOW_ORDER_INFO* orderInfo) +static void update_read_window_delete_order(WINPR_ATTR_UNUSED wStream* s, + WINPR_ATTR_UNUSED WINDOW_ORDER_INFO* orderInfo) { /* window deletion event */ } @@ -939,7 +940,9 @@ static BOOL update_read_notification_icon_state_order(wStream* s, WINDOW_ORDER_I return TRUE; } -static void update_read_notification_icon_delete_order(wStream* s, WINDOW_ORDER_INFO* orderInfo) +static void +update_read_notification_icon_delete_order(WINPR_ATTR_UNUSED wStream* s, + WINPR_ATTR_UNUSED WINDOW_ORDER_INFO* orderInfo) { /* notification icon deletion event */ } @@ -1040,7 +1043,8 @@ static BOOL update_read_desktop_actively_monitored_order(wStream* s, WINDOW_ORDE return TRUE; } -static void update_read_desktop_non_monitored_order(wStream* s, WINDOW_ORDER_INFO* orderInfo) +static void update_read_desktop_non_monitored_order(WINPR_ATTR_UNUSED wStream* s, + WINPR_ATTR_UNUSED WINDOW_ORDER_INFO* orderInfo) { /* non-monitored desktop notification event */ } diff --git a/libfreerdp/crypto/ber.c b/libfreerdp/crypto/ber.c index 7e3324b67..044b91ba4 100644 --- a/libfreerdp/crypto/ber.c +++ b/libfreerdp/crypto/ber.c @@ -351,7 +351,7 @@ BOOL ber_read_enumerated(wStream* s, BYTE* enumerated, BYTE count) return TRUE; } -void ber_write_enumerated(wStream* s, BYTE enumerated, BYTE count) +void ber_write_enumerated(wStream* s, BYTE enumerated, WINPR_ATTR_UNUSED BYTE count) { ber_write_universal_tag(s, BER_TAG_ENUMERATED, FALSE); ber_write_length(s, 1); diff --git a/libfreerdp/crypto/certificate.c b/libfreerdp/crypto/certificate.c index 5bd31f492..93be2a13f 100644 --- a/libfreerdp/crypto/certificate.c +++ b/libfreerdp/crypto/certificate.c @@ -639,7 +639,8 @@ fail: return rc; } -static BOOL certificate_process_server_public_key(rdpCertificate* cert, wStream* s, UINT32 length) +static BOOL certificate_process_server_public_key(rdpCertificate* cert, wStream* s, + WINPR_ATTR_UNUSED UINT32 length) { char magic[sizeof(rsa_magic)] = { 0 }; UINT32 keylen = 0; diff --git a/libfreerdp/crypto/er.c b/libfreerdp/crypto/er.c index 61e3beb20..d22c1d7d8 100644 --- a/libfreerdp/crypto/er.c +++ b/libfreerdp/crypto/er.c @@ -261,7 +261,7 @@ BOOL er_read_enumerated(wStream* s, BYTE* enumerated, BYTE count) return TRUE; } -void er_write_enumerated(wStream* s, BYTE enumerated, BYTE count, BOOL flag) +void er_write_enumerated(wStream* s, BYTE enumerated, WINPR_ATTR_UNUSED BYTE count, BOOL flag) { er_write_universal_tag(s, ER_TAG_ENUMERATED, FALSE); er_write_length(s, 1, flag); diff --git a/libfreerdp/crypto/per.c b/libfreerdp/crypto/per.c index 924742334..6cbc95288 100644 --- a/libfreerdp/crypto/per.c +++ b/libfreerdp/crypto/per.c @@ -380,7 +380,7 @@ BOOL per_read_enumerated(wStream* s, BYTE* enumerated, BYTE count) * @return \b TRUE for success, \b FALSE otherwise */ -BOOL per_write_enumerated(wStream* s, BYTE enumerated, BYTE count) +BOOL per_write_enumerated(wStream* s, BYTE enumerated, WINPR_ATTR_UNUSED BYTE count) { if (!Stream_EnsureRemainingCapacity(s, 1)) return FALSE; diff --git a/libfreerdp/crypto/tls.c b/libfreerdp/crypto/tls.c index 86901eb0a..8c2b28d44 100644 --- a/libfreerdp/crypto/tls.c +++ b/libfreerdp/crypto/tls.c @@ -258,7 +258,8 @@ static int bio_rdp_tls_puts(BIO* bio, const char* str) return BIO_write(bio, str, (int)size); } -static int bio_rdp_tls_gets(BIO* bio, char* str, int size) +static int bio_rdp_tls_gets(WINPR_ATTR_UNUSED BIO* bio, WINPR_ATTR_UNUSED char* str, + WINPR_ATTR_UNUSED int size) { return 1; } @@ -708,7 +709,9 @@ out_free: static INIT_ONCE secrets_file_idx_once = INIT_ONCE_STATIC_INIT; static int secrets_file_idx = -1; -static BOOL CALLBACK secrets_file_init_cb(PINIT_ONCE once, PVOID param, PVOID* context) +static BOOL CALLBACK secrets_file_init_cb(WINPR_ATTR_UNUSED PINIT_ONCE once, + WINPR_ATTR_UNUSED PVOID param, + WINPR_ATTR_UNUSED PVOID* context) { secrets_file_idx = SSL_get_ex_new_index(0, NULL, NULL, NULL, NULL); @@ -839,7 +842,8 @@ static BOOL tls_prepare(rdpTls* tls, BIO* underlying, SSL_METHOD* method, int op return TRUE; } -static void adjustSslOptions(int* options) // NOLINT(readability-non-const-parameter) +static void +adjustSslOptions(WINPR_ATTR_UNUSED int* options) // NOLINT(readability-non-const-parameter) { WINPR_ASSERT(options); #if OPENSSL_VERSION_NUMBER < 0x10100000L || defined(LIBRESSL_VERSION_NUMBER) @@ -2017,7 +2021,8 @@ void tls_print_new_certificate_warn(rdpCertificateStore* store, const char* host free(path); } -void tls_print_certificate_error(rdpCertificateStore* store, rdpCertificateData* stored_data, +void tls_print_certificate_error(rdpCertificateStore* store, + WINPR_ATTR_UNUSED rdpCertificateData* stored_data, const char* hostname, UINT16 port, const char* fingerprint) { char* path = freerdp_certificate_store_get_cert_path(store, hostname, port); diff --git a/libfreerdp/emu/scard/smartcard_emulate.c b/libfreerdp/emu/scard/smartcard_emulate.c index 08de623bb..bb613c33b 100644 --- a/libfreerdp/emu/scard/smartcard_emulate.c +++ b/libfreerdp/emu/scard/smartcard_emulate.c @@ -1680,8 +1680,9 @@ LONG WINAPI Emulate_SCardConnectW(SmartcardEmulationContext* smartcard, SCARDCON } LONG WINAPI Emulate_SCardReconnect(SmartcardEmulationContext* smartcard, SCARDHANDLE hCard, - DWORD dwShareMode, DWORD dwPreferredProtocols, - DWORD dwInitialization, LPDWORD pdwActiveProtocol) + DWORD dwShareMode, WINPR_ATTR_UNUSED DWORD dwPreferredProtocols, + WINPR_ATTR_UNUSED DWORD dwInitialization, + LPDWORD pdwActiveProtocol) { LONG status = scard_handle_valid(smartcard, hCard); diff --git a/libfreerdp/gdi/gdi.c b/libfreerdp/gdi/gdi.c index c4cc361af..eb6cda54d 100644 --- a/libfreerdp/gdi/gdi.c +++ b/libfreerdp/gdi/gdi.c @@ -325,8 +325,9 @@ static const BYTE GDI_BS_HATCHED_PATTERNS[] = { }; #define gdi_rop3_code_checked(code) gdi_rop3_code_checked_int((code), __FILE__, __func__, __LINE__) -static inline DWORD gdi_rop3_code_checked_int(UINT32 code, const char* file, const char* fkt, - size_t line) +static inline DWORD gdi_rop3_code_checked_int(UINT32 code, WINPR_ATTR_UNUSED const char* file, + WINPR_ATTR_UNUSED const char* fkt, + WINPR_ATTR_UNUSED size_t line) { WINPR_ASSERT_AT(code <= UINT8_MAX, file, fkt, line); return gdi_rop3_code((UINT8)code); @@ -969,31 +970,36 @@ out_fail: return ret; } -static BOOL gdi_polygon_sc(rdpContext* context, const POLYGON_SC_ORDER* polygon_sc) +static BOOL gdi_polygon_sc(WINPR_ATTR_UNUSED rdpContext* context, + WINPR_ATTR_UNUSED const POLYGON_SC_ORDER* polygon_sc) { WLog_WARN(TAG, "not implemented"); return FALSE; } -static BOOL gdi_polygon_cb(rdpContext* context, POLYGON_CB_ORDER* polygon_cb) +static BOOL gdi_polygon_cb(WINPR_ATTR_UNUSED rdpContext* context, + WINPR_ATTR_UNUSED POLYGON_CB_ORDER* polygon_cb) { WLog_WARN(TAG, "not implemented"); return FALSE; } -static BOOL gdi_ellipse_sc(rdpContext* context, const ELLIPSE_SC_ORDER* ellipse_sc) +static BOOL gdi_ellipse_sc(WINPR_ATTR_UNUSED rdpContext* context, + WINPR_ATTR_UNUSED const ELLIPSE_SC_ORDER* ellipse_sc) { WLog_WARN(TAG, "not implemented"); return FALSE; } -static BOOL gdi_ellipse_cb(rdpContext* context, const ELLIPSE_CB_ORDER* ellipse_cb) +static BOOL gdi_ellipse_cb(WINPR_ATTR_UNUSED rdpContext* context, + WINPR_ATTR_UNUSED const ELLIPSE_CB_ORDER* ellipse_cb) { WLog_WARN(TAG, "not implemented"); return FALSE; } -static BOOL gdi_frame_marker(rdpContext* context, const FRAME_MARKER_ORDER* frameMarker) +static BOOL gdi_frame_marker(WINPR_ATTR_UNUSED rdpContext* context, + WINPR_ATTR_UNUSED const FRAME_MARKER_ORDER* frameMarker) { return TRUE; } diff --git a/libfreerdp/gdi/gfx.c b/libfreerdp/gdi/gfx.c index ad8ee2fdb..c07db50f3 100644 --- a/libfreerdp/gdi/gfx.c +++ b/libfreerdp/gdi/gfx.c @@ -317,7 +317,8 @@ static UINT gdi_call_update_surfaces(RdpgfxClientContext* context) * * @return 0 on success, otherwise a Win32 error code */ -static UINT gdi_EndFrame(RdpgfxClientContext* context, const RDPGFX_END_FRAME_PDU* endFrame) +static UINT gdi_EndFrame(RdpgfxClientContext* context, + WINPR_ATTR_UNUSED const RDPGFX_END_FRAME_PDU* endFrame) { WINPR_ASSERT(context); WINPR_ASSERT(endFrame); diff --git a/libfreerdp/gdi/graphics.c b/libfreerdp/gdi/graphics.c index e9ed622eb..889eb95a1 100644 --- a/libfreerdp/gdi/graphics.c +++ b/libfreerdp/gdi/graphics.c @@ -103,7 +103,7 @@ static BOOL gdi_Bitmap_New(rdpContext* context, rdpBitmap* bitmap) return TRUE; } -static void gdi_Bitmap_Free(rdpContext* context, rdpBitmap* bitmap) +static void gdi_Bitmap_Free(WINPR_ATTR_UNUSED rdpContext* context, rdpBitmap* bitmap) { gdiBitmap* gdi_bitmap = (gdiBitmap*)bitmap; @@ -305,7 +305,7 @@ static BOOL gdi_Glyph_New(rdpContext* context, rdpGlyph* glyph) return TRUE; } -static void gdi_Glyph_Free(rdpContext* context, rdpGlyph* glyph) +static void gdi_Glyph_Free(WINPR_ATTR_UNUSED rdpContext* context, rdpGlyph* glyph) { gdiGlyph* gdi_glyph = NULL; gdi_glyph = (gdiGlyph*)glyph; @@ -428,8 +428,10 @@ static BOOL gdi_Glyph_BeginDraw(rdpContext* context, INT32 x, INT32 y, INT32 wid return TRUE; } -static BOOL gdi_Glyph_EndDraw(rdpContext* context, INT32 x, INT32 y, INT32 width, INT32 height, - UINT32 bgcolor, UINT32 fgcolor) +static BOOL gdi_Glyph_EndDraw(rdpContext* context, WINPR_ATTR_UNUSED INT32 x, + WINPR_ATTR_UNUSED INT32 y, WINPR_ATTR_UNUSED INT32 width, + WINPR_ATTR_UNUSED INT32 height, WINPR_ATTR_UNUSED UINT32 bgcolor, + WINPR_ATTR_UNUSED UINT32 fgcolor) { rdpGdi* gdi = NULL; diff --git a/libfreerdp/gdi/shape.c b/libfreerdp/gdi/shape.c index 2a906b77b..848fe0801 100644 --- a/libfreerdp/gdi/shape.c +++ b/libfreerdp/gdi/shape.c @@ -241,7 +241,8 @@ BOOL gdi_FillRect(HGDI_DC hdc, const HGDI_RECT rect, HGDI_BRUSH hbr) * @param nCount number of points * @return nonzero if successful, 0 otherwise */ -BOOL gdi_Polygon(HGDI_DC hdc, GDI_POINT* lpPoints, int nCount) +BOOL gdi_Polygon(WINPR_ATTR_UNUSED HGDI_DC hdc, WINPR_ATTR_UNUSED GDI_POINT* lpPoints, + WINPR_ATTR_UNUSED int nCount) { WLog_ERR(TAG, "Not implemented!"); return FALSE; @@ -256,7 +257,8 @@ BOOL gdi_Polygon(HGDI_DC hdc, GDI_POINT* lpPoints, int nCount) * @param nCount count of number of points in lpPolyCounts * @return nonzero if successful, 0 otherwise */ -BOOL gdi_PolyPolygon(HGDI_DC hdc, GDI_POINT* lpPoints, int* lpPolyCounts, int nCount) +BOOL gdi_PolyPolygon(WINPR_ATTR_UNUSED HGDI_DC hdc, WINPR_ATTR_UNUSED GDI_POINT* lpPoints, + WINPR_ATTR_UNUSED int* lpPolyCounts, WINPR_ATTR_UNUSED int nCount) { WLog_ERR(TAG, "Not implemented!"); return FALSE; diff --git a/libfreerdp/gdi/video.c b/libfreerdp/gdi/video.c index 83932ec76..b12705b04 100644 --- a/libfreerdp/gdi/video.c +++ b/libfreerdp/gdi/video.c @@ -52,8 +52,8 @@ void gdi_video_geometry_uninit(rdpGdi* gdi, GeometryClientContext* geom) WINPR_UNUSED(geom); } -static VideoSurface* gdiVideoCreateSurface(VideoClientContext* video, UINT32 x, UINT32 y, - UINT32 width, UINT32 height) +static VideoSurface* gdiVideoCreateSurface(WINPR_ATTR_UNUSED VideoClientContext* video, UINT32 x, + UINT32 y, UINT32 width, UINT32 height) { return VideoClient_CreateCommonContext(sizeof(VideoSurface), x, y, width, height); } @@ -139,7 +139,7 @@ void gdi_video_control_init(rdpGdi* gdi, VideoClientContext* video) video->setGeometry(video, gdi->geometry); } -void gdi_video_control_uninit(rdpGdi* gdi, VideoClientContext* video) +void gdi_video_control_uninit(rdpGdi* gdi, WINPR_ATTR_UNUSED VideoClientContext* video) { WINPR_ASSERT(gdi); gdi->video = NULL; @@ -159,14 +159,14 @@ static void gdi_video_timer(void* context, const TimerEventArgs* timer) gdi->video->timer(gdi->video, timer->now); } -void gdi_video_data_init(rdpGdi* gdi, VideoClientContext* video) +void gdi_video_data_init(rdpGdi* gdi, WINPR_ATTR_UNUSED VideoClientContext* video) { WINPR_ASSERT(gdi); WINPR_ASSERT(gdi->context); PubSub_SubscribeTimer(gdi->context->pubSub, gdi_video_timer); } -void gdi_video_data_uninit(rdpGdi* gdi, VideoClientContext* context) +void gdi_video_data_uninit(rdpGdi* gdi, WINPR_ATTR_UNUSED VideoClientContext* context) { WINPR_ASSERT(gdi); WINPR_ASSERT(gdi->context); diff --git a/libfreerdp/locale/keyboard.c b/libfreerdp/locale/keyboard.c index ad46683c0..61c75671b 100644 --- a/libfreerdp/locale/keyboard.c +++ b/libfreerdp/locale/keyboard.c @@ -263,7 +263,7 @@ static int freerdp_detect_keyboard(DWORD* keyboardLayoutId) return 0; } -static int freerdp_keyboard_init_apple(const DWORD* keyboardLayoutId, +static int freerdp_keyboard_init_apple(WINPR_ATTR_UNUSED const DWORD* keyboardLayoutId, DWORD* x11_keycode_to_rdp_scancode, size_t count) { WINPR_ASSERT(x11_keycode_to_rdp_scancode); @@ -281,7 +281,7 @@ static int freerdp_keyboard_init_apple(const DWORD* keyboardLayoutId, return 0; } -static int freerdp_keyboard_init_x11_evdev(const DWORD* keyboardLayoutId, +static int freerdp_keyboard_init_x11_evdev(WINPR_ATTR_UNUSED const DWORD* keyboardLayoutId, DWORD* x11_keycode_to_rdp_scancode, size_t count) { WINPR_ASSERT(keyboardLayoutId); diff --git a/libfreerdp/locale/keyboard_xkbfile.c b/libfreerdp/locale/keyboard_xkbfile.c index be7d119aa..cb165a7ce 100644 --- a/libfreerdp/locale/keyboard_xkbfile.c +++ b/libfreerdp/locale/keyboard_xkbfile.c @@ -433,7 +433,7 @@ static int xkb_cmp(const void* pva, const void* pvb) static BOOL try_add(size_t offset, const char* xkb_keyname, DWORD* x11_keycode_to_rdp_scancode, - size_t count) + WINPR_ATTR_UNUSED size_t count) { static BOOL initialized = FALSE; static XKB_KEY_NAME_SCANCODE copy[ARRAYSIZE(XKB_KEY_NAME_SCANCODE_TABLE)] = { 0 }; diff --git a/libfreerdp/primitives/prim_YUV.c b/libfreerdp/primitives/prim_YUV.c index 802284f21..fefd1a405 100644 --- a/libfreerdp/primitives/prim_YUV.c +++ b/libfreerdp/primitives/prim_YUV.c @@ -171,7 +171,8 @@ static inline pstatus_t general_ChromaV1ToYUV444(const BYTE* WINPR_RESTRICT pSrc static inline pstatus_t general_ChromaV2ToYUV444(const BYTE* WINPR_RESTRICT pSrc[3], const UINT32 srcStep[3], UINT32 nTotalWidth, - UINT32 nTotalHeight, BYTE* WINPR_RESTRICT pDst[3], + WINPR_ATTR_UNUSED UINT32 nTotalHeight, + BYTE* WINPR_RESTRICT pDst[3], const UINT32 dstStep[3], const RECTANGLE_16* WINPR_RESTRICT roi) { diff --git a/libfreerdp/primitives/prim_copy.c b/libfreerdp/primitives/prim_copy.c index 2c33805f9..27b472d5d 100644 --- a/libfreerdp/primitives/prim_copy.c +++ b/libfreerdp/primitives/prim_copy.c @@ -257,9 +257,9 @@ pstatus_t generic_image_copy_no_overlap_convert( pstatus_t generic_image_copy_no_overlap_memcpy( BYTE* WINPR_RESTRICT pDstData, DWORD DstFormat, UINT32 nDstStep, UINT32 nXDst, UINT32 nYDst, UINT32 nWidth, UINT32 nHeight, const BYTE* WINPR_RESTRICT pSrcData, DWORD SrcFormat, - UINT32 nSrcStep, UINT32 nXSrc, UINT32 nYSrc, const gdiPalette* WINPR_RESTRICT palette, - SSIZE_T srcVMultiplier, SSIZE_T srcVOffset, SSIZE_T dstVMultiplier, SSIZE_T dstVOffset, - UINT32 flags) + UINT32 nSrcStep, UINT32 nXSrc, UINT32 nYSrc, + WINPR_ATTR_UNUSED const gdiPalette* WINPR_RESTRICT palette, SSIZE_T srcVMultiplier, + SSIZE_T srcVOffset, SSIZE_T dstVMultiplier, SSIZE_T dstVOffset, WINPR_ATTR_UNUSED UINT32 flags) { const SSIZE_T dstByte = FreeRDPGetBytesPerPixel(DstFormat); const SSIZE_T srcByte = FreeRDPGetBytesPerPixel(SrcFormat); diff --git a/libfreerdp/primitives/sse/prim_YUV_sse4.1.c b/libfreerdp/primitives/sse/prim_YUV_sse4.1.c index e0e77cd7c..511224a44 100644 --- a/libfreerdp/primitives/sse/prim_YUV_sse4.1.c +++ b/libfreerdp/primitives/sse/prim_YUV_sse4.1.c @@ -464,7 +464,7 @@ static inline pstatus_t sse41_YUV444ToRGB_8u_P3AC4R_BGRX_DOUBLE_ROW( static inline void BGRX_fillRGB_single(size_t offset, BYTE* WINPR_RESTRICT pRGB, const BYTE* WINPR_RESTRICT pY, const BYTE* WINPR_RESTRICT pU, - const BYTE* WINPR_RESTRICT pV, BOOL filter) + const BYTE* WINPR_RESTRICT pV, WINPR_ATTR_UNUSED BOOL filter) { WINPR_ASSERT(pRGB); WINPR_ASSERT(pY); @@ -1021,10 +1021,10 @@ static INLINE void sse41_RGBToAVC444YUV_BGRX_DOUBLE_ROW( b7, width); } -static pstatus_t sse41_RGBToAVC444YUV_BGRX(const BYTE* WINPR_RESTRICT pSrc, UINT32 srcFormat, - UINT32 srcStep, BYTE* WINPR_RESTRICT pDst1[], - const UINT32 dst1Step[], BYTE* WINPR_RESTRICT pDst2[], - const UINT32 dst2Step[], +static pstatus_t sse41_RGBToAVC444YUV_BGRX(const BYTE* WINPR_RESTRICT pSrc, + WINPR_ATTR_UNUSED UINT32 srcFormat, UINT32 srcStep, + BYTE* WINPR_RESTRICT pDst1[], const UINT32 dst1Step[], + BYTE* WINPR_RESTRICT pDst2[], const UINT32 dst2Step[], const prim_size_t* WINPR_RESTRICT roi) { if (roi->height < 1 || roi->width < 1) @@ -1347,10 +1347,10 @@ static INLINE void sse41_RGBToAVC444YUVv2_BGRX_DOUBLE_ROW( uChromaDst2, vChromaDst1, vChromaDst2, width); } -static pstatus_t sse41_RGBToAVC444YUVv2_BGRX(const BYTE* WINPR_RESTRICT pSrc, UINT32 srcFormat, - UINT32 srcStep, BYTE* WINPR_RESTRICT pDst1[], - const UINT32 dst1Step[], BYTE* WINPR_RESTRICT pDst2[], - const UINT32 dst2Step[], +static pstatus_t sse41_RGBToAVC444YUVv2_BGRX(const BYTE* WINPR_RESTRICT pSrc, + WINPR_ATTR_UNUSED UINT32 srcFormat, UINT32 srcStep, + BYTE* WINPR_RESTRICT pDst1[], const UINT32 dst1Step[], + BYTE* WINPR_RESTRICT pDst2[], const UINT32 dst2Step[], const prim_size_t* WINPR_RESTRICT roi) { if (roi->height < 1 || roi->width < 1) @@ -1603,7 +1603,7 @@ static pstatus_t sse41_ChromaV1ToYUV444(const BYTE* WINPR_RESTRICT pSrcRaw[3], } static pstatus_t sse41_ChromaV2ToYUV444(const BYTE* WINPR_RESTRICT pSrc[3], const UINT32 srcStep[3], - UINT32 nTotalWidth, UINT32 nTotalHeight, + UINT32 nTotalWidth, WINPR_ATTR_UNUSED UINT32 nTotalHeight, BYTE* WINPR_RESTRICT pDst[3], const UINT32 dstStep[3], const RECTANGLE_16* WINPR_RESTRICT roi) { diff --git a/libfreerdp/primitives/sse/prim_colors_sse2.c b/libfreerdp/primitives/sse/prim_colors_sse2.c index 9ffc1ebac..18434c6b3 100644 --- a/libfreerdp/primitives/sse/prim_colors_sse2.c +++ b/libfreerdp/primitives/sse/prim_colors_sse2.c @@ -222,8 +222,9 @@ sse2_yCbCrToRGB_16s16s_P3P3(const INT16* WINPR_RESTRICT pSrc[3], int srcStep, /*---------------------------------------------------------------------------*/ static pstatus_t -sse2_yCbCrToRGB_16s8u_P3AC4R_BGRX(const INT16* WINPR_RESTRICT pSrc[3], UINT32 srcStep, - BYTE* WINPR_RESTRICT pDst, UINT32 dstStep, +sse2_yCbCrToRGB_16s8u_P3AC4R_BGRX(const INT16* WINPR_RESTRICT pSrc[3], + WINPR_ATTR_UNUSED UINT32 srcStep, BYTE* WINPR_RESTRICT pDst, + UINT32 dstStep, const prim_size_t* WINPR_RESTRICT roi) /* region of interest */ { const __m128i zero = _mm_setzero_si128(); @@ -407,8 +408,9 @@ sse2_yCbCrToRGB_16s8u_P3AC4R_BGRX(const INT16* WINPR_RESTRICT pSrc[3], UINT32 sr /*---------------------------------------------------------------------------*/ static pstatus_t -sse2_yCbCrToRGB_16s8u_P3AC4R_RGBX(const INT16* WINPR_RESTRICT pSrc[3], UINT32 srcStep, - BYTE* WINPR_RESTRICT pDst, UINT32 dstStep, +sse2_yCbCrToRGB_16s8u_P3AC4R_RGBX(const INT16* WINPR_RESTRICT pSrc[3], + WINPR_ATTR_UNUSED UINT32 srcStep, BYTE* WINPR_RESTRICT pDst, + UINT32 dstStep, const prim_size_t* WINPR_RESTRICT roi) /* region of interest */ { const __m128i zero = _mm_setzero_si128(); diff --git a/libfreerdp/utils/passphrase.c b/libfreerdp/utils/passphrase.c index d48abec59..fe6a58119 100644 --- a/libfreerdp/utils/passphrase.c +++ b/libfreerdp/utils/passphrase.c @@ -119,7 +119,7 @@ static int wait_for_fd(int fd, int timeout) return status; } -static void replace_char(char* buffer, size_t buffer_len, const char* toreplace) +static void replace_char(char* buffer, WINPR_ATTR_UNUSED size_t buffer_len, const char* toreplace) { while (*toreplace != '\0') { diff --git a/libfreerdp/utils/smartcard_call.c b/libfreerdp/utils/smartcard_call.c index d210d5e15..f312f93c4 100644 --- a/libfreerdp/utils/smartcard_call.c +++ b/libfreerdp/utils/smartcard_call.c @@ -139,7 +139,8 @@ static LONG smartcard_EstablishContext_Call(scard_call_context* smartcard, wStre return ret.ReturnCode; } -static LONG smartcard_ReleaseContext_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_ReleaseContext_Call(scard_call_context* smartcard, + WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { Long_Return ret = { 0 }; @@ -161,7 +162,8 @@ static LONG smartcard_ReleaseContext_Call(scard_call_context* smartcard, wStream return ret.ReturnCode; } -static LONG smartcard_IsValidContext_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_IsValidContext_Call(scard_call_context* smartcard, + WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { Long_Return ret = { 0 }; @@ -428,7 +430,8 @@ static LONG smartcard_ListReadersW_Call(scard_call_context* smartcard, wStream* return ret.ReturnCode; } -static LONG smartcard_IntroduceReaderGroupA_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_IntroduceReaderGroupA_Call(scard_call_context* smartcard, + WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { Long_Return ret = { 0 }; @@ -445,7 +448,8 @@ static LONG smartcard_IntroduceReaderGroupA_Call(scard_call_context* smartcard, return ret.ReturnCode; } -static LONG smartcard_IntroduceReaderGroupW_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_IntroduceReaderGroupW_Call(scard_call_context* smartcard, + WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { Long_Return ret = { 0 }; @@ -462,7 +466,8 @@ static LONG smartcard_IntroduceReaderGroupW_Call(scard_call_context* smartcard, return ret.ReturnCode; } -static LONG smartcard_IntroduceReaderA_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_IntroduceReaderA_Call(scard_call_context* smartcard, + WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { Long_Return ret = { 0 }; @@ -480,7 +485,8 @@ static LONG smartcard_IntroduceReaderA_Call(scard_call_context* smartcard, wStre return ret.ReturnCode; } -static LONG smartcard_IntroduceReaderW_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_IntroduceReaderW_Call(scard_call_context* smartcard, + WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { Long_Return ret = { 0 }; @@ -498,7 +504,8 @@ static LONG smartcard_IntroduceReaderW_Call(scard_call_context* smartcard, wStre return ret.ReturnCode; } -static LONG smartcard_ForgetReaderA_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_ForgetReaderA_Call(scard_call_context* smartcard, + WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { Long_Return ret = { 0 }; @@ -515,7 +522,8 @@ static LONG smartcard_ForgetReaderA_Call(scard_call_context* smartcard, wStream* return ret.ReturnCode; } -static LONG smartcard_ForgetReaderW_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_ForgetReaderW_Call(scard_call_context* smartcard, + WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { Long_Return ret = { 0 }; @@ -532,7 +540,8 @@ static LONG smartcard_ForgetReaderW_Call(scard_call_context* smartcard, wStream* return ret.ReturnCode; } -static LONG smartcard_AddReaderToGroupA_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_AddReaderToGroupA_Call(scard_call_context* smartcard, + WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { Long_Return ret = { 0 }; @@ -550,7 +559,8 @@ static LONG smartcard_AddReaderToGroupA_Call(scard_call_context* smartcard, wStr return ret.ReturnCode; } -static LONG smartcard_AddReaderToGroupW_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_AddReaderToGroupW_Call(scard_call_context* smartcard, + WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { Long_Return ret = { 0 }; @@ -568,7 +578,8 @@ static LONG smartcard_AddReaderToGroupW_Call(scard_call_context* smartcard, wStr return ret.ReturnCode; } -static LONG smartcard_RemoveReaderFromGroupA_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_RemoveReaderFromGroupA_Call(scard_call_context* smartcard, + WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { Long_Return ret = { 0 }; @@ -586,7 +597,8 @@ static LONG smartcard_RemoveReaderFromGroupA_Call(scard_call_context* smartcard, return ret.ReturnCode; } -static LONG smartcard_RemoveReaderFromGroupW_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_RemoveReaderFromGroupW_Call(scard_call_context* smartcard, + WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { Long_Return ret = { 0 }; @@ -777,7 +789,8 @@ static LONG smartcard_ReadCacheW_Call(scard_call_context* smartcard, wStream* ou return ret.ReturnCode; } -static LONG smartcard_WriteCacheA_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_WriteCacheA_Call(scard_call_context* smartcard, + WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { Long_Return ret = { 0 }; @@ -797,7 +810,8 @@ static LONG smartcard_WriteCacheA_Call(scard_call_context* smartcard, wStream* o return ret.ReturnCode; } -static LONG smartcard_WriteCacheW_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_WriteCacheW_Call(scard_call_context* smartcard, + WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { Long_Return ret = { 0 }; @@ -1026,7 +1040,7 @@ fail: return ret.ReturnCode; } -static LONG smartcard_Cancel_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_Cancel_Call(scard_call_context* smartcard, WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { Long_Return ret = { 0 }; @@ -1136,7 +1150,7 @@ static LONG smartcard_Reconnect_Call(scard_call_context* smartcard, wStream* out return ret.ReturnCode; } -static LONG smartcard_Disconnect_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_Disconnect_Call(scard_call_context* smartcard, WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { Long_Return ret = { 0 }; @@ -1155,7 +1169,8 @@ static LONG smartcard_Disconnect_Call(scard_call_context* smartcard, wStream* ou return ret.ReturnCode; } -static LONG smartcard_BeginTransaction_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_BeginTransaction_Call(scard_call_context* smartcard, + WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { Long_Return ret = { 0 }; @@ -1170,7 +1185,8 @@ static LONG smartcard_BeginTransaction_Call(scard_call_context* smartcard, wStre return ret.ReturnCode; } -static LONG smartcard_EndTransaction_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_EndTransaction_Call(scard_call_context* smartcard, + WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { Long_Return ret = { 0 }; @@ -1441,7 +1457,7 @@ static LONG smartcard_GetAttrib_Call(scard_call_context* smartcard, wStream* out return status; } -static LONG smartcard_SetAttrib_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_SetAttrib_Call(scard_call_context* smartcard, WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { Long_Return ret = { 0 }; @@ -1461,7 +1477,8 @@ static LONG smartcard_SetAttrib_Call(scard_call_context* smartcard, wStream* out return ret.ReturnCode; } -static LONG smartcard_AccessStartedEvent_Call(scard_call_context* smartcard, wStream* out, +static LONG smartcard_AccessStartedEvent_Call(scard_call_context* smartcard, + WINPR_ATTR_UNUSED wStream* out, SMARTCARD_OPERATION* operation) { LONG status = SCARD_S_SUCCESS; diff --git a/libfreerdp/utils/smartcard_pack.c b/libfreerdp/utils/smartcard_pack.c index c64f4b207..e4e0096b7 100644 --- a/libfreerdp/utils/smartcard_pack.c +++ b/libfreerdp/utils/smartcard_pack.c @@ -1717,7 +1717,7 @@ LONG smartcard_pack_redir_scard_context(wStream* s, const REDIR_SCARDCONTEXT* co return SCARD_S_SUCCESS; } -LONG smartcard_unpack_redir_scard_context_ref(wStream* s, UINT32 pbContextNdrPtr, +LONG smartcard_unpack_redir_scard_context_ref(wStream* s, WINPR_ATTR_UNUSED UINT32 pbContextNdrPtr, REDIR_SCARDCONTEXT* context) { UINT32 length = 0;