From 74306c93cbd4e036e7251c922caaf5f0941d4c16 Mon Sep 17 00:00:00 2001
From: Ted Gould <ted@gould.cx>
Date: Thu, 6 Sep 2012 22:11:01 -0500
Subject: [PATCH] Makes parsing of values off of stdin more robust by
 initializing the buffers initial and checking the returns from scanf.  Also,
 provides for a null domain by using '.' to make it easier to pipe values into
 xfreerdp.

---
 libfreerdp/utils/args.c | 34 +++++++++++++++++++++-------------
 1 file changed, 21 insertions(+), 13 deletions(-)

diff --git a/libfreerdp/utils/args.c b/libfreerdp/utils/args.c
index 75f0cb5a8..74e62da82 100644
--- a/libfreerdp/utils/args.c
+++ b/libfreerdp/utils/args.c
@@ -871,34 +871,42 @@ int freerdp_parse_args(rdpSettings* settings, int argc, char** argv,
 		/* username */
 		if (NULL == settings->username) {
 			char input[512];
+			input[0] = '\0';
 			printf("username: ");
-			scanf("%511s", input);
-			settings->username = xstrdup(input);
+			if (scanf("%511s", input) > 0) {
+				settings->username = xstrdup(input);
+			}
 		}
 		/* password */
 		if (NULL == settings->password) {
-			settings->password = xmalloc(512 * sizeof(char));
-			if (isatty(STDIN_FILENO))
-				freerdp_passphrase_read("password: ", settings->password, 512, settings->from_stdin);
-			else
-			{
-				printf("password: ");
-				scanf("%511s", settings->password);
+			char input[512];
+			input[0] = '\0';
+			printf("password: ");
+			if (scanf("%511s", input) > 0) {
+				settings->password = xstrdup(input);
 			}
 		}
 		/* domain */
 		if (NULL == settings->domain) {
 			char input[512];
+			input[0] = '\0';
 			printf("domain (control-D to skip): ");
-			scanf("%511s", input);
-			settings->domain = xstrdup(input);
+			if (scanf("%511s", input) > 0) {
+				/* Try to catch the cases where the string is NULL-ish right
+				   at the get go */
+				if (input[0] != '\0' || (input[0] == ' ' && input[1] == '\0')) {
+					settings->domain = xstrdup(input);
+				}
+			}
 		}
 		/* hostname */
 		if (NULL == settings->hostname) {
 			char input[512];
+			input[0] = '\0';
 			printf("hostname: ");
-			scanf("%511s", input);
-			freerdp_parse_hostname(settings, input);
+			if (scanf("%511s", input) > 0) {
+				freerdp_parse_hostname(settings, input);
+			}
 		}
 	}