From 5635edd6915581a8f26e9c57abdde271e2026ebf Mon Sep 17 00:00:00 2001 From: akallabeth Date: Mon, 9 Dec 2024 10:40:49 +0100 Subject: [PATCH] [winpr,bcrypt] add unit test test define WCHAR strings for even length and '\0' termination --- winpr/libwinpr/bcrypt/CMakeLists.txt | 4 + winpr/libwinpr/bcrypt/test/CMakeLists.txt | 21 +++ winpr/libwinpr/bcrypt/test/TestBCryptDefine.c | 129 ++++++++++++++++++ 3 files changed, 154 insertions(+) create mode 100644 winpr/libwinpr/bcrypt/test/CMakeLists.txt create mode 100644 winpr/libwinpr/bcrypt/test/TestBCryptDefine.c diff --git a/winpr/libwinpr/bcrypt/CMakeLists.txt b/winpr/libwinpr/bcrypt/CMakeLists.txt index 0c4ffdb8a..037ce1842 100644 --- a/winpr/libwinpr/bcrypt/CMakeLists.txt +++ b/winpr/libwinpr/bcrypt/CMakeLists.txt @@ -16,3 +16,7 @@ # limitations under the License. winpr_module_add(bcrypt.c) + +if(BUILD_TESTING_INTERNAL OR BUILD_TESTING) + add_subdirectory(test) +endif() diff --git a/winpr/libwinpr/bcrypt/test/CMakeLists.txt b/winpr/libwinpr/bcrypt/test/CMakeLists.txt new file mode 100644 index 000000000..6915b2dd7 --- /dev/null +++ b/winpr/libwinpr/bcrypt/test/CMakeLists.txt @@ -0,0 +1,21 @@ +set(MODULE_NAME "TestBCrypt") + +disable_warnings_for_directory(${CMAKE_CURRENT_BINARY_DIR}) + +set(DRIVER ${MODULE_NAME}.c) + +set(TESTS TestBCryptDefine.c) + +create_test_sourcelist(SRCS ${DRIVER} ${TESTS}) +add_executable(${MODULE_NAME} ${SRCS}) + +target_link_libraries(${MODULE_NAME} winpr) + +set_target_properties(${MODULE_NAME} PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${TESTING_OUTPUT_DIRECTORY}") + +foreach(test ${TESTS}) + get_filename_component(TestName ${test} NAME_WE) + add_test(${TestName} ${TESTING_OUTPUT_DIRECTORY}/${MODULE_NAME} ${TestName}) +endforeach() + +set_property(TARGET ${MODULE_NAME} PROPERTY FOLDER "WinPR/Test") diff --git a/winpr/libwinpr/bcrypt/test/TestBCryptDefine.c b/winpr/libwinpr/bcrypt/test/TestBCryptDefine.c new file mode 100644 index 000000000..778db572e --- /dev/null +++ b/winpr/libwinpr/bcrypt/test/TestBCryptDefine.c @@ -0,0 +1,129 @@ +#include + +#include +#include + +#define STR(x) #x + +static BOOL test_wchar_len(void) +{ + struct test_case + { + size_t bytelen; + const char* name; + const WCHAR* value; + }; + + const struct test_case test_cases[] = { + { sizeof(BCRYPT_RSA_ALGORITHM), STR(BCRYPT_RSA_ALGORITHM), BCRYPT_RSA_ALGORITHM }, + { sizeof(BCRYPT_RSA_SIGN_ALGORITHM), STR(BCRYPT_RSA_SIGN_ALGORITHM), + BCRYPT_RSA_SIGN_ALGORITHM }, + { sizeof(BCRYPT_DH_ALGORITHM), STR(BCRYPT_DH_ALGORITHM), BCRYPT_DH_ALGORITHM }, + { sizeof(BCRYPT_DSA_ALGORITHM), STR(BCRYPT_DSA_ALGORITHM), BCRYPT_DSA_ALGORITHM }, + { sizeof(BCRYPT_RC2_ALGORITHM), STR(BCRYPT_RC2_ALGORITHM), BCRYPT_RC2_ALGORITHM }, + { sizeof(BCRYPT_RC4_ALGORITHM), STR(BCRYPT_RC4_ALGORITHM), BCRYPT_RC4_ALGORITHM }, + { sizeof(BCRYPT_AES_ALGORITHM), STR(BCRYPT_AES_ALGORITHM), BCRYPT_AES_ALGORITHM }, + { sizeof(BCRYPT_DES_ALGORITHM), STR(BCRYPT_DES_ALGORITHM), BCRYPT_DES_ALGORITHM }, + { sizeof(BCRYPT_DESX_ALGORITHM), STR(BCRYPT_DESX_ALGORITHM), BCRYPT_DESX_ALGORITHM }, + { sizeof(BCRYPT_3DES_ALGORITHM), STR(BCRYPT_3DES_ALGORITHM), BCRYPT_3DES_ALGORITHM }, + { sizeof(BCRYPT_3DES_112_ALGORITHM), STR(BCRYPT_3DES_112_ALGORITHM), + BCRYPT_3DES_112_ALGORITHM }, + { sizeof(BCRYPT_MD2_ALGORITHM), STR(BCRYPT_MD2_ALGORITHM), BCRYPT_MD2_ALGORITHM }, + { sizeof(BCRYPT_MD4_ALGORITHM), STR(BCRYPT_MD4_ALGORITHM), BCRYPT_MD4_ALGORITHM }, + { sizeof(BCRYPT_MD5_ALGORITHM), STR(BCRYPT_MD5_ALGORITHM), BCRYPT_MD5_ALGORITHM }, + { sizeof(BCRYPT_SHA1_ALGORITHM), STR(BCRYPT_SHA1_ALGORITHM), BCRYPT_SHA1_ALGORITHM }, + { sizeof(BCRYPT_SHA256_ALGORITHM), STR(BCRYPT_SHA256_ALGORITHM), BCRYPT_SHA256_ALGORITHM }, + { sizeof(BCRYPT_SHA384_ALGORITHM), STR(BCRYPT_SHA384_ALGORITHM), BCRYPT_SHA384_ALGORITHM }, + { sizeof(BCRYPT_SHA512_ALGORITHM), STR(BCRYPT_SHA512_ALGORITHM), BCRYPT_SHA512_ALGORITHM }, + { sizeof(BCRYPT_AES_GMAC_ALGORITHM), STR(BCRYPT_AES_GMAC_ALGORITHM), + BCRYPT_AES_GMAC_ALGORITHM }, + { sizeof(BCRYPT_AES_CMAC_ALGORITHM), STR(BCRYPT_AES_CMAC_ALGORITHM), + BCRYPT_AES_CMAC_ALGORITHM }, + { sizeof(BCRYPT_ECDSA_P256_ALGORITHM), STR(BCRYPT_ECDSA_P256_ALGORITHM), + BCRYPT_ECDSA_P256_ALGORITHM }, + { sizeof(BCRYPT_ECDSA_P384_ALGORITHM), STR(BCRYPT_ECDSA_P384_ALGORITHM), + BCRYPT_ECDSA_P384_ALGORITHM }, + { sizeof(BCRYPT_ECDSA_P521_ALGORITHM), STR(BCRYPT_ECDSA_P521_ALGORITHM), + BCRYPT_ECDSA_P521_ALGORITHM }, + { sizeof(BCRYPT_ECDH_P256_ALGORITHM), STR(BCRYPT_ECDH_P256_ALGORITHM), + BCRYPT_ECDH_P256_ALGORITHM }, + { sizeof(BCRYPT_ECDH_P384_ALGORITHM), STR(BCRYPT_ECDH_P384_ALGORITHM), + BCRYPT_ECDH_P384_ALGORITHM }, + { sizeof(BCRYPT_ECDH_P521_ALGORITHM), STR(BCRYPT_ECDH_P521_ALGORITHM), + BCRYPT_ECDH_P521_ALGORITHM }, + { sizeof(BCRYPT_RNG_ALGORITHM), STR(BCRYPT_RNG_ALGORITHM), BCRYPT_RNG_ALGORITHM }, + { sizeof(BCRYPT_RNG_FIPS186_DSA_ALGORITHM), STR(BCRYPT_RNG_FIPS186_DSA_ALGORITHM), + BCRYPT_RNG_FIPS186_DSA_ALGORITHM }, + { sizeof(BCRYPT_RNG_DUAL_EC_ALGORITHM), STR(BCRYPT_RNG_DUAL_EC_ALGORITHM), + BCRYPT_RNG_DUAL_EC_ALGORITHM }, +// The following algorithms are only supported on windows 10 onward. +#if !defined(_WIN32) || _WIN32_WINNT >= 0x0A00 + { sizeof(BCRYPT_ECDSA_ALGORITHM), STR(BCRYPT_ECDSA_ALGORITHM), BCRYPT_ECDSA_ALGORITHM }, + { sizeof(BCRYPT_ECDH_ALGORITHM), STR(BCRYPT_ECDH_ALGORITHM), BCRYPT_ECDH_ALGORITHM }, + { sizeof(BCRYPT_XTS_AES_ALGORITHM), STR(BCRYPT_XTS_AES_ALGORITHM), + BCRYPT_XTS_AES_ALGORITHM }, +#endif + + { sizeof(MS_PRIMITIVE_PROVIDER), STR(MS_PRIMITIVE_PROVIDER), MS_PRIMITIVE_PROVIDER }, + { sizeof(MS_PLATFORM_CRYPTO_PROVIDER), STR(MS_PLATFORM_CRYPTO_PROVIDER), + MS_PLATFORM_CRYPTO_PROVIDER }, + { sizeof(BCRYPT_OBJECT_LENGTH), STR(BCRYPT_OBJECT_LENGTH), BCRYPT_OBJECT_LENGTH }, + { sizeof(BCRYPT_ALGORITHM_NAME), STR(BCRYPT_ALGORITHM_NAME), BCRYPT_ALGORITHM_NAME }, + { sizeof(BCRYPT_PROVIDER_HANDLE), STR(BCRYPT_PROVIDER_HANDLE), BCRYPT_PROVIDER_HANDLE }, + { sizeof(BCRYPT_CHAINING_MODE), STR(BCRYPT_CHAINING_MODE), BCRYPT_CHAINING_MODE }, + { sizeof(BCRYPT_BLOCK_LENGTH), STR(BCRYPT_BLOCK_LENGTH), BCRYPT_BLOCK_LENGTH }, + { sizeof(BCRYPT_KEY_LENGTH), STR(BCRYPT_KEY_LENGTH), BCRYPT_KEY_LENGTH }, + { sizeof(BCRYPT_KEY_OBJECT_LENGTH), STR(BCRYPT_KEY_OBJECT_LENGTH), + BCRYPT_KEY_OBJECT_LENGTH }, + { sizeof(BCRYPT_KEY_STRENGTH), STR(BCRYPT_KEY_STRENGTH), BCRYPT_KEY_STRENGTH }, + { sizeof(BCRYPT_KEY_LENGTHS), STR(BCRYPT_KEY_LENGTHS), BCRYPT_KEY_LENGTHS }, + { sizeof(BCRYPT_BLOCK_SIZE_LIST), STR(BCRYPT_BLOCK_SIZE_LIST), BCRYPT_BLOCK_SIZE_LIST }, + { sizeof(BCRYPT_EFFECTIVE_KEY_LENGTH), STR(BCRYPT_EFFECTIVE_KEY_LENGTH), + BCRYPT_EFFECTIVE_KEY_LENGTH }, + { sizeof(BCRYPT_HASH_LENGTH), STR(BCRYPT_HASH_LENGTH), BCRYPT_HASH_LENGTH }, + { sizeof(BCRYPT_HASH_OID_LIST), STR(BCRYPT_HASH_OID_LIST), BCRYPT_HASH_OID_LIST }, + { sizeof(BCRYPT_PADDING_SCHEMES), STR(BCRYPT_PADDING_SCHEMES), BCRYPT_PADDING_SCHEMES }, + { sizeof(BCRYPT_SIGNATURE_LENGTH), STR(BCRYPT_SIGNATURE_LENGTH), BCRYPT_SIGNATURE_LENGTH }, + { sizeof(BCRYPT_HASH_BLOCK_LENGTH), STR(BCRYPT_HASH_BLOCK_LENGTH), + BCRYPT_HASH_BLOCK_LENGTH }, + { sizeof(BCRYPT_AUTH_TAG_LENGTH), STR(BCRYPT_AUTH_TAG_LENGTH), BCRYPT_AUTH_TAG_LENGTH }, + { sizeof(BCRYPT_PRIMITIVE_TYPE), STR(BCRYPT_PRIMITIVE_TYPE), BCRYPT_PRIMITIVE_TYPE }, + { sizeof(BCRYPT_IS_KEYED_HASH), STR(BCRYPT_IS_KEYED_HASH), BCRYPT_IS_KEYED_HASH }, + { sizeof(BCRYPT_KEY_DATA_BLOB), STR(BCRYPT_KEY_DATA_BLOB), BCRYPT_KEY_DATA_BLOB } + }; + + BOOL rc = TRUE; + for (size_t x = 0; x < ARRAYSIZE(test_cases); x++) + { + const struct test_case* cur = &test_cases[x]; + + // sizeof(WCHAR) == 2, so all strings must have even byte length + if (cur->bytelen % 2 != 0) + { + (void)fprintf(stderr, "[%s] invalid bytelength %" PRIuz, cur->name, cur->bytelen); + rc = FALSE; + continue; + } + + // each string must be '\0' terminated + const size_t len = _wcsnlen(cur->value, cur->bytelen / sizeof(WCHAR)); + if (len == cur->bytelen / sizeof(WCHAR)) + { + (void)fprintf(stderr, "[%s] missing '\0' termination", cur->name); + rc = FALSE; + continue; + } + } + + return rc; +} + +int TestBCryptDefine(int argc, char* argv[]) +{ + WINPR_UNUSED(argc); + WINPR_UNUSED(argv); + + if (!test_wchar_len()) + return -1; + return 0; +}