From 485ebe03bf633569383d2e567d7cf806b43eed32 Mon Sep 17 00:00:00 2001
From: akallabeth <akallabeth@posteo.net>
Date: Mon, 30 Sep 2024 18:04:37 +0200
Subject: [PATCH] [*printf] cast return to void

---
 channels/rdpecam/client/v4l/camera_v4l.c |  4 ++--
 client/common/file.c                     | 22 +++++++++++++---------
 server/proxy/cli/freerdp_proxy.c         |  1 -
 3 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/channels/rdpecam/client/v4l/camera_v4l.c b/channels/rdpecam/client/v4l/camera_v4l.c
index ea2e3687f..59094281b 100644
--- a/channels/rdpecam/client/v4l/camera_v4l.c
+++ b/channels/rdpecam/client/v4l/camera_v4l.c
@@ -155,7 +155,7 @@ static int cam_v4l_open_device(const char* deviceId, int flags)
 
 	for (UINT n = 0; n < 64; n++)
 	{
-		snprintf(device, sizeof(device), "/dev/video%d", n);
+		(void)_snprintf(device, sizeof(device), "/dev/video%d", n);
 		if ((fd = open(device, flags)) == -1)
 			continue;
 
@@ -287,7 +287,7 @@ static UINT cam_v4l_enumerate(ICamHal* ihal, ICamHalEnumCallback callback, Camer
 	{
 		char device[20] = { 0 };
 		struct v4l2_capability cap = { 0 };
-		snprintf(device, sizeof(device), "/dev/video%d", n);
+		(void)_snprintf(device, sizeof(device), "/dev/video%d", n);
 		int fd = open(device, O_RDONLY);
 		if (fd == -1)
 			continue;
diff --git a/client/common/file.c b/client/common/file.c
index 5ddeb0c3b..9bb5744ad 100644
--- a/client/common/file.c
+++ b/client/common/file.c
@@ -2375,23 +2375,27 @@ BOOL freerdp_client_populate_settings_from_rdp_file(const rdpFile* file, rdpSett
 		if (!args)
 			return FALSE;
 
+		BOOL status = TRUE;
 		if (~file->EncodeRedirectedVideoCapture)
 		{
-			char encode[64];
-			_snprintf(encode, sizeof(encode), "encode:%" PRIu32,
-			          file->EncodeRedirectedVideoCapture);
-			freerdp_addin_argv_add_argument(args, encode);
+			char encode[64] = { 0 };
+			(void)_snprintf(encode, sizeof(encode), "encode:%" PRIu32,
+			                file->EncodeRedirectedVideoCapture);
+			if (!freerdp_addin_argv_add_argument(args, encode))
+				status = FALSE;
 		}
 		if (~file->RedirectedVideoCaptureEncodingQuality)
 		{
-			char quality[64];
-			_snprintf(quality, sizeof(quality), "quality:%" PRIu32,
-			          file->RedirectedVideoCaptureEncodingQuality);
-			freerdp_addin_argv_add_argument(args, quality);
+			char quality[64] = { 0 };
+			(void)_snprintf(quality, sizeof(quality), "quality:%" PRIu32,
+			                file->RedirectedVideoCaptureEncodingQuality);
+			if (!freerdp_addin_argv_add_argument(args, quality))
+				status = FALSE;
 		}
 
 		cnv.c = args->argv;
-		const BOOL status = freerdp_client_add_dynamic_channel(settings, args->argc, cnv.cc);
+		if (status)
+			status = freerdp_client_add_dynamic_channel(settings, args->argc, cnv.cc);
 		freerdp_addin_argv_free(args);
 		if (!status)
 			return FALSE;
diff --git a/server/proxy/cli/freerdp_proxy.c b/server/proxy/cli/freerdp_proxy.c
index 4977f8d20..66212f6a6 100644
--- a/server/proxy/cli/freerdp_proxy.c
+++ b/server/proxy/cli/freerdp_proxy.c
@@ -51,7 +51,6 @@ static const char* strsignal(int signum)
 
 static void cleanup_handler(int signum)
 {
-	(void)printf("\n");
 	WLog_INFO(TAG, "caught signal %s [%d], starting cleanup...", strsignal(signum), signum);
 
 	WLog_INFO(TAG, "stopping all connections.");