From 3e0e0c868ebf4dbbf84a248c11e0b6be977f41cf Mon Sep 17 00:00:00 2001 From: Bernhard Miklautz Date: Tue, 11 Nov 2014 20:34:52 +0100 Subject: [PATCH] Revert a bug introduced in PR #2134 FREERDP_CHANNELS_SERVER_SRCS need to be added to server/common that the symbols get added and exported with libfreerdp-server. Also remove duplicated version information. --- channels/server/CMakeLists.txt | 17 ----------------- server/common/CMakeLists.txt | 5 +++++ 2 files changed, 5 insertions(+), 17 deletions(-) diff --git a/channels/server/CMakeLists.txt b/channels/server/CMakeLists.txt index 84a34effe..1f49c3bd4 100644 --- a/channels/server/CMakeLists.txt +++ b/channels/server/CMakeLists.txt @@ -28,23 +28,6 @@ foreach(STATIC_MODULE ${CHANNEL_STATIC_SERVER_MODULES}) set(${MODULE_PREFIX}_LIBS ${${MODULE_PREFIX}_LIBS} ${STATIC_MODULE_NAME}) endforeach() -# On windows create dll version information. -# Vendor, product and year are already set in top level CMakeLists.txt -if (WIN32) - set (RC_VERSION_MAJOR ${FREERDP_VERSION_MAJOR}) - set (RC_VERSION_MINOR ${FREERDP_VERSION_MINOR}) - set (RC_VERSION_BUILD ${FREERDP_VERSION_REVISION}) - set (RC_VERSION_FILE "${CMAKE_SHARED_LIBRARY_PREFIX}${MODULE_NAME}${CMAKE_SHARED_LIBRARY_SUFFIX}" ) - - configure_file( - ${CMAKE_SOURCE_DIR}/cmake/WindowsDLLVersion.rc.in - ${CMAKE_CURRENT_BINARY_DIR}/version.rc - @ONLY) - - set ( ${MODULE_PREFIX}_SRCS ${${MODULE_PREFIX}_SRCS} ${CMAKE_CURRENT_BINARY_DIR}/version.rc) -endif() - - add_library(${MODULE_NAME} STATIC ${${MODULE_PREFIX}_SRCS}) if (WITH_LIBRARY_VERSIONING) diff --git a/server/common/CMakeLists.txt b/server/common/CMakeLists.txt index d81b64479..c8f2c81a3 100644 --- a/server/common/CMakeLists.txt +++ b/server/common/CMakeLists.txt @@ -25,6 +25,11 @@ if(MSVC) set(${MODULE_PREFIX}_SRCS ${${MODULE_PREFIX}_SRCS} module.def) endif() +foreach(FREERDP_CHANNELS_SERVER_SRC ${FREERDP_CHANNELS_SERVER_SRCS}) + set(${MODULE_PREFIX}_SRCS ${${MODULE_PREFIX}_SRCS} + "${FREERDP_CHANNELS_SERVER_SRC}") +endforeach() + # On windows create dll version information. # Vendor, product and year are already set in top level CMakeLists.txt if (WIN32)