From 3d8cb485f4c73ba6fb225cb6d580ab32ab9fb3fc Mon Sep 17 00:00:00 2001 From: Armin Novak Date: Mon, 6 Mar 2023 09:06:19 +0100 Subject: [PATCH] [warnings] Fixed strict-prototypes warnings --- channels/urbdrc/common/msusb.c | 2 +- client/X11/xf_client.c | 4 ++-- libfreerdp/crypto/certificate.c | 1 - libfreerdp/emu/scard/smartcard_virtual_gids.c | 2 +- rdtk/librdtk/rdtk_engine.c | 2 +- winpr/libwinpr/comm/comm.c | 2 +- winpr/libwinpr/crypto/test/TestCryptoCipher.c | 6 +++--- winpr/libwinpr/file/generic.c | 2 +- winpr/libwinpr/file/namedPipeClient.c | 2 +- winpr/libwinpr/pipe/pipe.c | 2 +- winpr/libwinpr/rpc/rpc.c | 6 +++--- winpr/libwinpr/sspi/Schannel/schannel_openssl.c | 2 +- winpr/libwinpr/utils/collections/MessagePipe.c | 2 +- winpr/libwinpr/utils/test/TestStream.c | 2 +- winpr/libwinpr/wtsapi/wtsapi.c | 4 ++-- 15 files changed, 20 insertions(+), 21 deletions(-) diff --git a/channels/urbdrc/common/msusb.c b/channels/urbdrc/common/msusb.c index a0be420c9..73bde87dd 100644 --- a/channels/urbdrc/common/msusb.c +++ b/channels/urbdrc/common/msusb.c @@ -27,7 +27,7 @@ #define TAG FREERDP_TAG("utils") -static MSUSB_PIPE_DESCRIPTOR* msusb_mspipe_new() +static MSUSB_PIPE_DESCRIPTOR* msusb_mspipe_new(void) { return (MSUSB_PIPE_DESCRIPTOR*)calloc(1, sizeof(MSUSB_PIPE_DESCRIPTOR)); } diff --git a/client/X11/xf_client.c b/client/X11/xf_client.c index a44fdf75f..11cc2f7e7 100644 --- a/client/X11/xf_client.c +++ b/client/X11/xf_client.c @@ -1647,7 +1647,7 @@ static void xf_PanningChangeEventHandler(void* context, const PanningChangeEvent * Client Interface */ -static BOOL xfreerdp_client_global_init() +static BOOL xfreerdp_client_global_init(void) { setlocale(LC_ALL, ""); @@ -1657,7 +1657,7 @@ static BOOL xfreerdp_client_global_init() return TRUE; } -static void xfreerdp_client_global_uninit() +static void xfreerdp_client_global_uninit(void) { } diff --git a/libfreerdp/crypto/certificate.c b/libfreerdp/crypto/certificate.c index d48370194..0e383b563 100644 --- a/libfreerdp/crypto/certificate.c +++ b/libfreerdp/crypto/certificate.c @@ -1315,7 +1315,6 @@ char* freerdp_certificate_get_pem(const rdpCertificate* cert, size_t* pLength) BIO* bio; int status; - BOOL rc = FALSE; /** * Don't manage certificates internally, leave it up entirely to the external client diff --git a/libfreerdp/emu/scard/smartcard_virtual_gids.c b/libfreerdp/emu/scard/smartcard_virtual_gids.c index c5fdb0a27..d6713ae7b 100644 --- a/libfreerdp/emu/scard/smartcard_virtual_gids.c +++ b/libfreerdp/emu/scard/smartcard_virtual_gids.c @@ -1411,7 +1411,7 @@ create_response: return vgids_create_response(status, NULL, 0, response, responseSize); } -vgidsContext* vgids_new() +vgidsContext* vgids_new(void) { wObject* obj; vgidsContext* ctx = calloc(1, sizeof(vgidsContext)); diff --git a/rdtk/librdtk/rdtk_engine.c b/rdtk/librdtk/rdtk_engine.c index 41aad72f6..dd7d46351 100644 --- a/rdtk/librdtk/rdtk_engine.c +++ b/rdtk/librdtk/rdtk_engine.c @@ -25,7 +25,7 @@ #include "rdtk_engine.h" -rdtkEngine* rdtk_engine_new() +rdtkEngine* rdtk_engine_new(void) { rdtkEngine* engine; diff --git a/winpr/libwinpr/comm/comm.c b/winpr/libwinpr/comm/comm.c index 18386776e..fdfa2e938 100644 --- a/winpr/libwinpr/comm/comm.c +++ b/winpr/libwinpr/comm/comm.c @@ -112,7 +112,7 @@ static void _CommInit(void) * Returns TRUE when the comm module is correctly intialized, FALSE otherwise * with ERROR_DLL_INIT_FAILED set as the last error. */ -static BOOL CommInitialized() +static BOOL CommInitialized(void) { if (pthread_once(&_CommInitialized, _CommInit) != 0) { diff --git a/winpr/libwinpr/crypto/test/TestCryptoCipher.c b/winpr/libwinpr/crypto/test/TestCryptoCipher.c index f20de689a..bf11db30a 100644 --- a/winpr/libwinpr/crypto/test/TestCryptoCipher.c +++ b/winpr/libwinpr/crypto/test/TestCryptoCipher.c @@ -4,7 +4,7 @@ #include #include -static BOOL test_crypto_cipher_aes_128_cbc() +static BOOL test_crypto_cipher_aes_128_cbc(void) { WINPR_CIPHER_CTX* ctx; BOOL result = FALSE; @@ -110,7 +110,7 @@ static const BYTE* TEST_RC4_KEY = (BYTE*)"Key"; static const char* TEST_RC4_PLAINTEXT = "Plaintext"; static const BYTE* TEST_RC4_CIPHERTEXT = (BYTE*)"\xBB\xF3\x16\xE8\xD9\x40\xAF\x0A\xD3"; -static BOOL test_crypto_cipher_rc4() +static BOOL test_crypto_cipher_rc4(void) { size_t len; BOOL rc = FALSE; @@ -175,7 +175,7 @@ static const BYTE* TEST_CIPHER_KEY = static const BYTE* TEST_CIPHER_IV = (BYTE*)"\xFE\xE3\x9F\xF0\xD1\x5E\x37\x0C\xAB\xAB\x9B\x04\xF3\xDB\x99\x15"; -static BOOL test_crypto_cipher_key() +static BOOL test_crypto_cipher_key(void) { int status; BYTE key[32] = { 0 }; diff --git a/winpr/libwinpr/file/generic.c b/winpr/libwinpr/file/generic.c index becc1eb2a..fe24040a7 100644 --- a/winpr/libwinpr/file/generic.c +++ b/winpr/libwinpr/file/generic.c @@ -184,7 +184,7 @@ extern HANDLE_CREATOR* GetNamedPipeClientHandleCreator(void); #include "../comm/comm.h" #endif /* __linux__ && !defined ANDROID */ -static void _HandleCreatorsInit() +static void _HandleCreatorsInit(void) { WINPR_ASSERT(_HandleCreators == NULL); _HandleCreators = ArrayList_New(TRUE); diff --git a/winpr/libwinpr/file/namedPipeClient.c b/winpr/libwinpr/file/namedPipeClient.c index 3c56f04ee..7447ae30d 100644 --- a/winpr/libwinpr/file/namedPipeClient.c +++ b/winpr/libwinpr/file/namedPipeClient.c @@ -261,7 +261,7 @@ char* GetNamedPipeNameWithoutPrefixA(LPCSTR lpName) return lpFileName; } -char* GetNamedPipeUnixDomainSocketBaseFilePathA() +char* GetNamedPipeUnixDomainSocketBaseFilePathA(void) { char* lpTempPath; char* lpPipePath; diff --git a/winpr/libwinpr/pipe/pipe.c b/winpr/libwinpr/pipe/pipe.c index 9424568f1..34548e909 100644 --- a/winpr/libwinpr/pipe/pipe.c +++ b/winpr/libwinpr/pipe/pipe.c @@ -456,7 +456,7 @@ static HANDLE_OPS namedOps = { NamedPipeIsHandled, NULL, NULL }; -static BOOL InitWinPRPipeModule() +static BOOL InitWinPRPipeModule(void) { if (g_NamedPipeServerSockets) return TRUE; diff --git a/winpr/libwinpr/rpc/rpc.c b/winpr/libwinpr/rpc/rpc.c index 075bb159b..e031106d8 100644 --- a/winpr/libwinpr/rpc/rpc.c +++ b/winpr/libwinpr/rpc/rpc.c @@ -402,7 +402,7 @@ RPC_STATUS RpcServerUseProtseqIfExW(RPC_WSTR Protseq, unsigned int MaxCalls, RPC return 0; } -void RpcServerYield() +void RpcServerYield(void) { WLog_ERR(TAG, "Not implemented"); } @@ -524,7 +524,7 @@ RPC_STATUS RpcRevertToSelfEx(RPC_BINDING_HANDLE BindingHandle) return 0; } -RPC_STATUS RpcRevertToSelf() +RPC_STATUS RpcRevertToSelf(void) { WLog_ERR(TAG, "Not implemented"); return 0; @@ -659,7 +659,7 @@ void RpcRaiseException(RPC_STATUS exception) exit((int)exception); } -RPC_STATUS RpcTestCancel() +RPC_STATUS RpcTestCancel(void) { WLog_ERR(TAG, "Not implemented"); return 0; diff --git a/winpr/libwinpr/sspi/Schannel/schannel_openssl.c b/winpr/libwinpr/sspi/Schannel/schannel_openssl.c index 31d1cc66e..464c5be43 100644 --- a/winpr/libwinpr/sspi/Schannel/schannel_openssl.c +++ b/winpr/libwinpr/sspi/Schannel/schannel_openssl.c @@ -555,7 +555,7 @@ SECURITY_STATUS schannel_openssl_decrypt_message(SCHANNEL_OPENSSL* context, PSec return SEC_E_OK; } -SCHANNEL_OPENSSL* schannel_openssl_new() +SCHANNEL_OPENSSL* schannel_openssl_new(void) { SCHANNEL_OPENSSL* context; context = (SCHANNEL_OPENSSL*)calloc(1, sizeof(SCHANNEL_OPENSSL)); diff --git a/winpr/libwinpr/utils/collections/MessagePipe.c b/winpr/libwinpr/utils/collections/MessagePipe.c index 5427eda3d..98adfe753 100644 --- a/winpr/libwinpr/utils/collections/MessagePipe.c +++ b/winpr/libwinpr/utils/collections/MessagePipe.c @@ -42,7 +42,7 @@ void MessagePipe_PostQuit(wMessagePipe* pipe, int nExitCode) * Construction, Destruction */ -wMessagePipe* MessagePipe_New() +wMessagePipe* MessagePipe_New(void) { wMessagePipe* pipe = NULL; diff --git a/winpr/libwinpr/utils/test/TestStream.c b/winpr/libwinpr/utils/test/TestStream.c index 43fa1de8c..e4713ae15 100644 --- a/winpr/libwinpr/utils/test/TestStream.c +++ b/winpr/libwinpr/utils/test/TestStream.c @@ -87,7 +87,7 @@ static BOOL TestStream_New(void) return TRUE; } -static BOOL TestStream_Static() +static BOOL TestStream_Static(void) { BYTE buffer[20]; wStream staticStream, *s = &staticStream; diff --git a/winpr/libwinpr/wtsapi/wtsapi.c b/winpr/libwinpr/wtsapi/wtsapi.c index d5272b11d..c33c5be8f 100644 --- a/winpr/libwinpr/wtsapi/wtsapi.c +++ b/winpr/libwinpr/wtsapi/wtsapi.c @@ -712,7 +712,7 @@ static BOOL LoadAndInitialize(char* library) return TRUE; } -static void InitializeWtsApiStubs_Env() +static void InitializeWtsApiStubs_Env(void) { DWORD nSize; char* env = NULL; @@ -737,7 +737,7 @@ static void InitializeWtsApiStubs_Env() #define FREERDS_LIBRARY_NAME "libfreerds-fdsapi.so" -static void InitializeWtsApiStubs_FreeRDS() +static void InitializeWtsApiStubs_FreeRDS(void) { wIniFile* ini; const char* prefix;