From 315f79307899514aa84fcf99d76eb50a96211489 Mon Sep 17 00:00:00 2001 From: akallabeth Date: Wed, 25 Sep 2024 05:17:32 +0200 Subject: [PATCH] [common,settings] fix integer narrowing --- libfreerdp/common/settings.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/libfreerdp/common/settings.c b/libfreerdp/common/settings.c index 6e483942e..8cc575d4c 100644 --- a/libfreerdp/common/settings.c +++ b/libfreerdp/common/settings.c @@ -1212,26 +1212,30 @@ BOOL freerdp_settings_set_value_for_name(rdpSettings* settings, const char* name case RDP_SETTINGS_TYPE_UINT16: if (!value_to_uint(value, &uval, 0, UINT16_MAX)) return parsing_fail(name, "UINT16", value); - if (!freerdp_settings_set_uint16(settings, (FreeRDP_Settings_Keys_UInt16)index, uval)) + if (!freerdp_settings_set_uint16(settings, (FreeRDP_Settings_Keys_UInt16)index, + (UINT16)uval)) return parsing_fail(name, "UINT16", value); return TRUE; case RDP_SETTINGS_TYPE_INT16: if (!value_to_int(value, &ival, INT16_MIN, INT16_MAX)) return parsing_fail(name, "INT16", value); - if (!freerdp_settings_set_int16(settings, (FreeRDP_Settings_Keys_Int16)index, ival)) + if (!freerdp_settings_set_int16(settings, (FreeRDP_Settings_Keys_Int16)index, + (INT16)ival)) return parsing_fail(name, "INT16", value); return TRUE; case RDP_SETTINGS_TYPE_UINT32: if (!value_to_uint(value, &uval, 0, UINT32_MAX)) return parsing_fail(name, "UINT32", value); - if (!freerdp_settings_set_uint32(settings, (FreeRDP_Settings_Keys_UInt32)index, uval)) + if (!freerdp_settings_set_uint32(settings, (FreeRDP_Settings_Keys_UInt32)index, + (UINT32)uval)) return parsing_fail(name, "UINT32", value); return TRUE; case RDP_SETTINGS_TYPE_INT32: if (!value_to_int(value, &ival, INT32_MIN, INT32_MAX)) return parsing_fail(name, "INT32", value); - if (!freerdp_settings_set_int32(settings, (FreeRDP_Settings_Keys_Int32)index, ival)) + if (!freerdp_settings_set_int32(settings, (FreeRDP_Settings_Keys_Int32)index, + (INT32)ival)) return parsing_fail(name, "INT32", value); return TRUE; case RDP_SETTINGS_TYPE_UINT64: