From 2b7d7356c121416edf493a473c11d88edf0f15fe Mon Sep 17 00:00:00 2001 From: akallabeth Date: Thu, 13 Feb 2025 15:29:35 +0100 Subject: [PATCH] [channels,warnings] fix -Wunused-parameter --- channels/ainput/client/ainput_main.c | 3 +- channels/audin/client/audin_main.c | 6 +- channels/audin/server/audin.c | 9 ++- channels/client/addin.c | 9 ++- channels/client/generic_dynvc.c | 5 +- channels/cliprdr/client/cliprdr_format.c | 4 +- channels/cliprdr/client/cliprdr_main.c | 14 ++-- channels/disp/client/disp_main.c | 5 +- channels/drdynvc/client/drdynvc_main.c | 4 +- channels/drdynvc/server/drdynvc_main.c | 2 +- channels/encomsp/client/encomsp_main.c | 5 +- channels/geometry/client/geometry_main.c | 3 +- channels/location/client/location_main.c | 3 +- channels/parallel/client/parallel_main.c | 4 +- channels/printer/client/printer_main.c | 3 +- channels/rail/client/rail_main.c | 3 +- channels/rdp2tcp/client/rdp2tcp_main.c | 6 +- channels/rdpdr/client/rdpdr_capabilities.c | 8 +- channels/rdpdr/server/rdpdr_main.c | 75 +++++++++++-------- .../rdpecam/client/camera_device_enum_main.c | 12 +-- channels/rdpecam/client/camera_device_main.c | 19 +++-- channels/rdpecam/client/v4l/camera_v4l.c | 7 +- .../server/camera_device_enumerator_main.c | 2 +- channels/rdpecam/server/camera_device_main.c | 27 ++++--- channels/rdpgfx/client/rdpgfx_codec.c | 3 +- channels/rdpgfx/client/rdpgfx_main.c | 3 +- channels/rdpsnd/client/alsa/rdpsnd_alsa.c | 3 +- channels/rdpsnd/client/fake/rdpsnd_fake.c | 15 ++-- channels/rdpsnd/client/pulse/rdpsnd_pulse.c | 10 ++- channels/remdesk/client/remdesk_main.c | 21 ++++-- channels/remdesk/server/remdesk_main.c | 9 ++- channels/urbdrc/client/data_transfer.c | 18 +++-- .../urbdrc/client/libusb/libusb_udevice.c | 22 +++--- channels/urbdrc/client/urbdrc_main.c | 8 +- channels/urbdrc/common/urbdrc_helpers.c | 4 +- 35 files changed, 211 insertions(+), 143 deletions(-) diff --git a/channels/ainput/client/ainput_main.c b/channels/ainput/client/ainput_main.c index 51d912ad3..c291bd727 100644 --- a/channels/ainput/client/ainput_main.c +++ b/channels/ainput/client/ainput_main.c @@ -145,7 +145,8 @@ static UINT ainput_on_close(IWTSVirtualChannelCallback* pChannelCallback) return CHANNEL_RC_OK; } -static UINT init_plugin_cb(GENERIC_DYNVC_PLUGIN* base, rdpContext* rcontext, rdpSettings* settings) +static UINT init_plugin_cb(GENERIC_DYNVC_PLUGIN* base, WINPR_ATTR_UNUSED rdpContext* rcontext, + WINPR_ATTR_UNUSED rdpSettings* settings) { AINPUT_PLUGIN* ainput = (AINPUT_PLUGIN*)base; AInputClientContext* context = (AInputClientContext*)calloc(1, sizeof(AInputClientContext)); diff --git a/channels/audin/client/audin_main.c b/channels/audin/client/audin_main.c index 35d4d89fd..6f7306d00 100644 --- a/channels/audin/client/audin_main.c +++ b/channels/audin/client/audin_main.c @@ -639,8 +639,10 @@ static UINT audin_on_close(IWTSVirtualChannelCallback* pChannelCallback) * @return 0 on success, otherwise a Win32 error code */ static UINT audin_on_new_channel_connection(IWTSListenerCallback* pListenerCallback, - IWTSVirtualChannel* pChannel, BYTE* Data, - BOOL* pbAccept, IWTSVirtualChannelCallback** ppCallback) + IWTSVirtualChannel* pChannel, + WINPR_ATTR_UNUSED BYTE* Data, + WINPR_ATTR_UNUSED BOOL* pbAccept, + IWTSVirtualChannelCallback** ppCallback) { GENERIC_LISTENER_CALLBACK* listener_callback = (GENERIC_LISTENER_CALLBACK*)pListenerCallback; diff --git a/channels/audin/server/audin.c b/channels/audin/server/audin.c index 142e198fd..10ee23b7b 100644 --- a/channels/audin/server/audin.c +++ b/channels/audin/server/audin.c @@ -191,8 +191,8 @@ static UINT audin_server_recv_open_reply(audin_server_context* context, wStream* return error; } -static UINT audin_server_recv_data_incoming(audin_server_context* context, wStream* s, - const SNDIN_PDU* header) +static UINT audin_server_recv_data_incoming(audin_server_context* context, + WINPR_ATTR_UNUSED wStream* s, const SNDIN_PDU* header) { audin_server* audin = (audin_server*)context; SNDIN_DATA_INCOMING pdu = { 0 }; @@ -794,8 +794,9 @@ static UINT audin_server_receive_format_change_default(audin_server_context* con return CHANNEL_RC_OK; } -static UINT audin_server_incoming_data_default(audin_server_context* context, - const SNDIN_DATA_INCOMING* data_incoming) +static UINT +audin_server_incoming_data_default(audin_server_context* context, + WINPR_ATTR_UNUSED const SNDIN_DATA_INCOMING* data_incoming) { audin_server* audin = (audin_server*)context; WINPR_ASSERT(audin); diff --git a/channels/client/addin.c b/channels/client/addin.c index ee354d61f..a1fdd55b8 100644 --- a/channels/client/addin.c +++ b/channels/client/addin.c @@ -82,9 +82,9 @@ void* freerdp_channels_client_find_static_entry(const char* name, const char* id extern const STATIC_ADDIN_TABLE CLIENT_STATIC_ADDIN_TABLE[]; -static FREERDP_ADDIN** freerdp_channels_list_client_static_addins(LPCSTR pszName, - LPCSTR pszSubsystem, - LPCSTR pszType, DWORD dwFlags) +static FREERDP_ADDIN** freerdp_channels_list_client_static_addins( + WINPR_ATTR_UNUSED LPCSTR pszName, WINPR_ATTR_UNUSED LPCSTR pszSubsystem, + WINPR_ATTR_UNUSED LPCSTR pszType, WINPR_ATTR_UNUSED DWORD dwFlags) { DWORD nAddins = 0; FREERDP_ADDIN** ppAddins = NULL; @@ -160,7 +160,8 @@ static HANDLE FindFirstFileUTF8(LPCSTR pszSearchPath, WIN32_FIND_DATAW* FindData } static FREERDP_ADDIN** freerdp_channels_list_dynamic_addins(LPCSTR pszName, LPCSTR pszSubsystem, - LPCSTR pszType, DWORD dwFlags) + LPCSTR pszType, + WINPR_ATTR_UNUSED DWORD dwFlags) { int nDashes = 0; HANDLE hFind = NULL; diff --git a/channels/client/generic_dynvc.c b/channels/client/generic_dynvc.c index 6221470c4..af6a7a891 100644 --- a/channels/client/generic_dynvc.c +++ b/channels/client/generic_dynvc.c @@ -24,8 +24,9 @@ #define TAG FREERDP_TAG("genericdynvc") static UINT generic_on_new_channel_connection(IWTSListenerCallback* pListenerCallback, - IWTSVirtualChannel* pChannel, BYTE* Data, - BOOL* pbAccept, + IWTSVirtualChannel* pChannel, + WINPR_ATTR_UNUSED BYTE* Data, + WINPR_ATTR_UNUSED BOOL* pbAccept, IWTSVirtualChannelCallback** ppCallback) { GENERIC_CHANNEL_CALLBACK* callback = NULL; diff --git a/channels/cliprdr/client/cliprdr_format.c b/channels/cliprdr/client/cliprdr_format.c index 41978d988..d1d956205 100644 --- a/channels/cliprdr/client/cliprdr_format.c +++ b/channels/cliprdr/client/cliprdr_format.c @@ -150,8 +150,8 @@ error_out: * * @return 0 on success, otherwise a Win32 error code */ -UINT cliprdr_process_format_list_response(cliprdrPlugin* cliprdr, wStream* s, UINT32 dataLen, - UINT16 msgFlags) +UINT cliprdr_process_format_list_response(cliprdrPlugin* cliprdr, WINPR_ATTR_UNUSED wStream* s, + UINT32 dataLen, UINT16 msgFlags) { CLIPRDR_FORMAT_LIST_RESPONSE formatListResponse = { 0 }; CliprdrClientContext* context = cliprdr_get_client_interface(cliprdr); diff --git a/channels/cliprdr/client/cliprdr_main.c b/channels/cliprdr/client/cliprdr_main.c index f0476fc99..e4b9ebf26 100644 --- a/channels/cliprdr/client/cliprdr_main.c +++ b/channels/cliprdr/client/cliprdr_main.c @@ -189,8 +189,9 @@ static UINT cliprdr_process_general_capability(cliprdrPlugin* cliprdr, wStream* * * @return 0 on success, otherwise a Win32 error code */ -static UINT cliprdr_process_clip_caps(cliprdrPlugin* cliprdr, wStream* s, UINT32 length, - UINT16 flags) +static UINT cliprdr_process_clip_caps(cliprdrPlugin* cliprdr, wStream* s, + WINPR_ATTR_UNUSED UINT32 length, + WINPR_ATTR_UNUSED UINT16 flags) { UINT16 lengthCapability = 0; UINT16 cCapabilitiesSets = 0; @@ -246,8 +247,8 @@ static UINT cliprdr_process_clip_caps(cliprdrPlugin* cliprdr, wStream* s, UINT32 * * @return 0 on success, otherwise a Win32 error code */ -static UINT cliprdr_process_monitor_ready(cliprdrPlugin* cliprdr, wStream* s, UINT32 length, - UINT16 flags) +static UINT cliprdr_process_monitor_ready(cliprdrPlugin* cliprdr, WINPR_ATTR_UNUSED wStream* s, + UINT32 length, UINT16 flags) { CLIPRDR_MONITOR_READY monitorReady = { 0 }; CliprdrClientContext* context = cliprdr_get_client_interface(cliprdr); @@ -981,8 +982,9 @@ static VOID VCAPITYPE cliprdr_virtual_channel_open_event_ex(LPVOID lpUserParam, * * @return 0 on success, otherwise a Win32 error code */ -static UINT cliprdr_virtual_channel_event_connected(cliprdrPlugin* cliprdr, LPVOID pData, - UINT32 dataLength) +static UINT cliprdr_virtual_channel_event_connected(cliprdrPlugin* cliprdr, + WINPR_ATTR_UNUSED LPVOID pData, + WINPR_ATTR_UNUSED UINT32 dataLength) { DWORD status = 0; WINPR_ASSERT(cliprdr); diff --git a/channels/disp/client/disp_main.c b/channels/disp/client/disp_main.c index 0f8a11567..d6952c69d 100644 --- a/channels/disp/client/disp_main.c +++ b/channels/disp/client/disp_main.c @@ -271,8 +271,9 @@ static UINT disp_send_monitor_layout(DispClientContext* context, UINT32 NumMonit * * @return 0 on success, otherwise a Win32 error code */ -static UINT disp_plugin_initialize(GENERIC_DYNVC_PLUGIN* base, rdpContext* rcontext, - rdpSettings* settings) +static UINT disp_plugin_initialize(GENERIC_DYNVC_PLUGIN* base, + WINPR_ATTR_UNUSED rdpContext* rcontext, + WINPR_ATTR_UNUSED rdpSettings* settings) { DispClientContext* context = NULL; DISP_PLUGIN* disp = (DISP_PLUGIN*)base; diff --git a/channels/drdynvc/client/drdynvc_main.c b/channels/drdynvc/client/drdynvc_main.c index d4df8435c..4e068729e 100644 --- a/channels/drdynvc/client/drdynvc_main.c +++ b/channels/drdynvc/client/drdynvc_main.c @@ -517,7 +517,7 @@ static UINT dvcman_channel_close(DVCMAN_CHANNEL* channel, BOOL perRequest, BOOL return error; } -static DVCMAN_CHANNEL* dvcman_channel_new(drdynvcPlugin* drdynvc, +static DVCMAN_CHANNEL* dvcman_channel_new(WINPR_ATTR_UNUSED drdynvcPlugin* drdynvc, IWTSVirtualChannelManager* pChannelMgr, UINT32 ChannelId, const char* ChannelName) { @@ -828,7 +828,7 @@ static UINT dvcman_receive_channel_data_first(DVCMAN_CHANNEL* channel, UINT32 le * @return 0 on success, otherwise a Win32 error code */ static UINT dvcman_receive_channel_data(DVCMAN_CHANNEL* channel, wStream* data, - UINT32 ThreadingFlags) + WINPR_ATTR_UNUSED UINT32 ThreadingFlags) { UINT status = CHANNEL_RC_OK; size_t dataSize = Stream_GetRemainingLength(data); diff --git a/channels/drdynvc/server/drdynvc_main.c b/channels/drdynvc/server/drdynvc_main.c index aa089c4a4..c5f2435dd 100644 --- a/channels/drdynvc/server/drdynvc_main.c +++ b/channels/drdynvc/server/drdynvc_main.c @@ -31,7 +31,7 @@ #define TAG CHANNELS_TAG("drdynvc.server") -static DWORD WINAPI drdynvc_server_thread(LPVOID arg) +static DWORD WINAPI drdynvc_server_thread(WINPR_ATTR_UNUSED LPVOID arg) { #if 0 wStream* s; diff --git a/channels/encomsp/client/encomsp_main.c b/channels/encomsp/client/encomsp_main.c index 54a25149e..4bd7d84af 100644 --- a/channels/encomsp/client/encomsp_main.c +++ b/channels/encomsp/client/encomsp_main.c @@ -1090,8 +1090,9 @@ static DWORD WINAPI encomsp_virtual_channel_client_thread(LPVOID arg) * * @return 0 on success, otherwise a Win32 error code */ -static UINT encomsp_virtual_channel_event_connected(encomspPlugin* encomsp, LPVOID pData, - UINT32 dataLength) +static UINT encomsp_virtual_channel_event_connected(encomspPlugin* encomsp, + WINPR_ATTR_UNUSED LPVOID pData, + WINPR_ATTR_UNUSED UINT32 dataLength) { WINPR_ASSERT(encomsp); diff --git a/channels/geometry/client/geometry_main.c b/channels/geometry/client/geometry_main.c index d86007592..b002f7a52 100644 --- a/channels/geometry/client/geometry_main.c +++ b/channels/geometry/client/geometry_main.c @@ -340,7 +340,8 @@ static const IWTSVirtualChannelCallback geometry_callbacks = { geometry_on_data_ NULL, /* Open */ geometry_on_close, NULL }; -static UINT init_plugin_cb(GENERIC_DYNVC_PLUGIN* base, rdpContext* rcontext, rdpSettings* settings) +static UINT init_plugin_cb(GENERIC_DYNVC_PLUGIN* base, WINPR_ATTR_UNUSED rdpContext* rcontext, + rdpSettings* settings) { GeometryClientContext* context = NULL; GEOMETRY_PLUGIN* geometry = (GEOMETRY_PLUGIN*)base; diff --git a/channels/location/client/location_main.c b/channels/location/client/location_main.c index 5abdb7c06..97384fc60 100644 --- a/channels/location/client/location_main.c +++ b/channels/location/client/location_main.c @@ -449,7 +449,8 @@ static UINT location_on_close(IWTSVirtualChannelCallback* pChannelCallback) return res; } -static UINT location_init(GENERIC_DYNVC_PLUGIN* plugin, rdpContext* context, rdpSettings* settings) +static UINT location_init(GENERIC_DYNVC_PLUGIN* plugin, WINPR_ATTR_UNUSED rdpContext* context, + WINPR_ATTR_UNUSED rdpSettings* settings) { LOCATION_PLUGIN* loc = (LOCATION_PLUGIN*)plugin; diff --git a/channels/parallel/client/parallel_main.c b/channels/parallel/client/parallel_main.c index f449f88b1..df8d26ff7 100644 --- a/channels/parallel/client/parallel_main.c +++ b/channels/parallel/client/parallel_main.c @@ -252,12 +252,14 @@ static UINT parallel_process_irp_write(PARALLEL_DEVICE* parallel, IRP* irp) * * @return 0 on success, otherwise a Win32 error code */ -static UINT parallel_process_irp_device_control(PARALLEL_DEVICE* parallel, IRP* irp) +static UINT parallel_process_irp_device_control(WINPR_ATTR_UNUSED PARALLEL_DEVICE* parallel, + IRP* irp) { WINPR_ASSERT(parallel); WINPR_ASSERT(irp); Stream_Write_UINT32(irp->output, 0); /* OutputBufferLength */ + WINPR_ASSERT(irp->Complete); return irp->Complete(irp); } diff --git a/channels/printer/client/printer_main.c b/channels/printer/client/printer_main.c index 01c572ee1..c9516e93b 100644 --- a/channels/printer/client/printer_main.c +++ b/channels/printer/client/printer_main.c @@ -562,7 +562,8 @@ static UINT printer_process_irp_write(PRINTER_DEVICE* printer_dev, IRP* irp) * * @return 0 on success, otherwise a Win32 error code */ -static UINT printer_process_irp_device_control(PRINTER_DEVICE* printer_dev, IRP* irp) +static UINT printer_process_irp_device_control(WINPR_ATTR_UNUSED PRINTER_DEVICE* printer_dev, + IRP* irp) { WINPR_ASSERT(printer_dev); WINPR_ASSERT(irp); diff --git a/channels/rail/client/rail_main.c b/channels/rail/client/rail_main.c index abca0005f..256336481 100644 --- a/channels/rail/client/rail_main.c +++ b/channels/rail/client/rail_main.c @@ -568,7 +568,8 @@ static VOID VCAPITYPE rail_virtual_channel_open_event_ex(LPVOID lpUserParam, DWO * * @return 0 on success, otherwise a Win32 error code */ -static UINT rail_virtual_channel_event_connected(railPlugin* rail, LPVOID pData, UINT32 dataLength) +static UINT rail_virtual_channel_event_connected(railPlugin* rail, WINPR_ATTR_UNUSED LPVOID pData, + WINPR_ATTR_UNUSED UINT32 dataLength) { RailClientContext* context = rail_get_client_interface(rail); UINT status = CHANNEL_RC_OK; diff --git a/channels/rdp2tcp/client/rdp2tcp_main.c b/channels/rdp2tcp/client/rdp2tcp_main.c index 17238c6bb..e0c612984 100644 --- a/channels/rdp2tcp/client/rdp2tcp_main.c +++ b/channels/rdp2tcp/client/rdp2tcp_main.c @@ -189,7 +189,8 @@ static void dataReceived(Plugin* plugin, void* pData, UINT32 dataLength, UINT32 closeChannel(plugin); } -static void VCAPITYPE VirtualChannelOpenEventEx(LPVOID lpUserParam, DWORD openHandle, UINT event, +static void VCAPITYPE VirtualChannelOpenEventEx(LPVOID lpUserParam, + WINPR_ATTR_UNUSED DWORD openHandle, UINT event, LPVOID pData, UINT32 dataLength, UINT32 totalLength, UINT32 dataFlags) { @@ -240,7 +241,8 @@ static void channel_initialized(Plugin* plugin) } static VOID VCAPITYPE VirtualChannelInitEventEx(LPVOID lpUserParam, LPVOID pInitHandle, UINT event, - LPVOID pData, UINT dataLength) + WINPR_ATTR_UNUSED LPVOID pData, + WINPR_ATTR_UNUSED UINT dataLength) { Plugin* plugin = (Plugin*)lpUserParam; diff --git a/channels/rdpdr/client/rdpdr_capabilities.c b/channels/rdpdr/client/rdpdr_capabilities.c index 7d763c1a8..769973215 100644 --- a/channels/rdpdr/client/rdpdr_capabilities.c +++ b/channels/rdpdr/client/rdpdr_capabilities.c @@ -115,7 +115,7 @@ static BOOL rdpdr_write_printer_capset(rdpdrPlugin* rdpdr, wStream* s) } /* Process printer direction capability set */ -static UINT rdpdr_process_printer_capset(rdpdrPlugin* rdpdr, wStream* s, +static UINT rdpdr_process_printer_capset(WINPR_ATTR_UNUSED rdpdrPlugin* rdpdr, wStream* s, const RDPDR_CAPABILITY_HEADER* header) { WINPR_ASSERT(header); @@ -133,7 +133,7 @@ static BOOL rdpdr_write_port_capset(rdpdrPlugin* rdpdr, wStream* s) } /* Process port redirection capability set */ -static UINT rdpdr_process_port_capset(rdpdrPlugin* rdpdr, wStream* s, +static UINT rdpdr_process_port_capset(WINPR_ATTR_UNUSED rdpdrPlugin* rdpdr, wStream* s, const RDPDR_CAPABILITY_HEADER* header) { WINPR_ASSERT(header); @@ -151,7 +151,7 @@ static BOOL rdpdr_write_drive_capset(rdpdrPlugin* rdpdr, wStream* s) } /* Process drive redirection capability set */ -static UINT rdpdr_process_drive_capset(rdpdrPlugin* rdpdr, wStream* s, +static UINT rdpdr_process_drive_capset(WINPR_ATTR_UNUSED rdpdrPlugin* rdpdr, wStream* s, const RDPDR_CAPABILITY_HEADER* header) { WINPR_ASSERT(header); @@ -169,7 +169,7 @@ static BOOL rdpdr_write_smartcard_capset(rdpdrPlugin* rdpdr, wStream* s) } /* Process smartcard redirection capability set */ -static UINT rdpdr_process_smartcard_capset(rdpdrPlugin* rdpdr, wStream* s, +static UINT rdpdr_process_smartcard_capset(WINPR_ATTR_UNUSED rdpdrPlugin* rdpdr, wStream* s, const RDPDR_CAPABILITY_HEADER* header) { WINPR_ASSERT(header); diff --git a/channels/rdpdr/server/rdpdr_main.c b/channels/rdpdr/server/rdpdr_main.c index 1ded8e22e..e4b4bad1c 100644 --- a/channels/rdpdr/server/rdpdr_main.c +++ b/channels/rdpdr/server/rdpdr_main.c @@ -1165,8 +1165,9 @@ static UINT rdpdr_server_receive_device_list_remove_request(RdpdrServerContext* } static UINT rdpdr_server_receive_io_create_request(RdpdrServerContext* context, wStream* s, - UINT32 DeviceId, UINT32 FileId, - UINT32 CompletionId) + WINPR_ATTR_UNUSED UINT32 DeviceId, + WINPR_ATTR_UNUSED UINT32 FileId, + WINPR_ATTR_UNUSED UINT32 CompletionId) { const WCHAR* path = NULL; UINT32 DesiredAccess = 0; @@ -1201,8 +1202,9 @@ static UINT rdpdr_server_receive_io_create_request(RdpdrServerContext* context, } static UINT rdpdr_server_receive_io_close_request(RdpdrServerContext* context, wStream* s, - UINT32 DeviceId, UINT32 FileId, - UINT32 CompletionId) + WINPR_ATTR_UNUSED UINT32 DeviceId, + WINPR_ATTR_UNUSED UINT32 FileId, + WINPR_ATTR_UNUSED UINT32 CompletionId) { WINPR_ASSERT(context); WINPR_ASSERT(context->priv); @@ -1220,8 +1222,9 @@ static UINT rdpdr_server_receive_io_close_request(RdpdrServerContext* context, w } static UINT rdpdr_server_receive_io_read_request(RdpdrServerContext* context, wStream* s, - UINT32 DeviceId, UINT32 FileId, - UINT32 CompletionId) + WINPR_ATTR_UNUSED UINT32 DeviceId, + WINPR_ATTR_UNUSED UINT32 FileId, + WINPR_ATTR_UNUSED UINT32 CompletionId) { UINT32 Length = 0; UINT64 Offset = 0; @@ -1243,8 +1246,9 @@ static UINT rdpdr_server_receive_io_read_request(RdpdrServerContext* context, wS } static UINT rdpdr_server_receive_io_write_request(RdpdrServerContext* context, wStream* s, - UINT32 DeviceId, UINT32 FileId, - UINT32 CompletionId) + WINPR_ATTR_UNUSED UINT32 DeviceId, + WINPR_ATTR_UNUSED UINT32 FileId, + WINPR_ATTR_UNUSED UINT32 CompletionId) { UINT32 Length = 0; UINT64 Offset = 0; @@ -1272,8 +1276,9 @@ static UINT rdpdr_server_receive_io_write_request(RdpdrServerContext* context, w } static UINT rdpdr_server_receive_io_device_control_request(RdpdrServerContext* context, wStream* s, - UINT32 DeviceId, UINT32 FileId, - UINT32 CompletionId) + WINPR_ATTR_UNUSED UINT32 DeviceId, + WINPR_ATTR_UNUSED UINT32 FileId, + WINPR_ATTR_UNUSED UINT32 CompletionId) { UINT32 OutputBufferLength = 0; UINT32 InputBufferLength = 0; @@ -1302,10 +1307,9 @@ static UINT rdpdr_server_receive_io_device_control_request(RdpdrServerContext* c return CHANNEL_RC_OK; } -static UINT rdpdr_server_receive_io_query_volume_information_request(RdpdrServerContext* context, - wStream* s, UINT32 DeviceId, - UINT32 FileId, - UINT32 CompletionId) +static UINT rdpdr_server_receive_io_query_volume_information_request( + RdpdrServerContext* context, wStream* s, WINPR_ATTR_UNUSED UINT32 DeviceId, + WINPR_ATTR_UNUSED UINT32 FileId, WINPR_ATTR_UNUSED UINT32 CompletionId) { UINT32 FsInformationClass = 0; UINT32 Length = 0; @@ -1331,10 +1335,9 @@ static UINT rdpdr_server_receive_io_query_volume_information_request(RdpdrServer return CHANNEL_RC_OK; } -static UINT rdpdr_server_receive_io_set_volume_information_request(RdpdrServerContext* context, - wStream* s, UINT32 DeviceId, - UINT32 FileId, - UINT32 CompletionId) +static UINT rdpdr_server_receive_io_set_volume_information_request( + RdpdrServerContext* context, wStream* s, WINPR_ATTR_UNUSED UINT32 DeviceId, + WINPR_ATTR_UNUSED UINT32 FileId, WINPR_ATTR_UNUSED UINT32 CompletionId) { UINT32 FsInformationClass = 0; UINT32 Length = 0; @@ -1363,8 +1366,10 @@ static UINT rdpdr_server_receive_io_set_volume_information_request(RdpdrServerCo } static UINT rdpdr_server_receive_io_query_information_request(RdpdrServerContext* context, - wStream* s, UINT32 DeviceId, - UINT32 FileId, UINT32 CompletionId) + wStream* s, + WINPR_ATTR_UNUSED UINT32 DeviceId, + WINPR_ATTR_UNUSED UINT32 FileId, + WINPR_ATTR_UNUSED UINT32 CompletionId) { UINT32 FsInformationClass = 0; UINT32 Length = 0; @@ -1393,8 +1398,9 @@ static UINT rdpdr_server_receive_io_query_information_request(RdpdrServerContext } static UINT rdpdr_server_receive_io_set_information_request(RdpdrServerContext* context, wStream* s, - UINT32 DeviceId, UINT32 FileId, - UINT32 CompletionId) + WINPR_ATTR_UNUSED UINT32 DeviceId, + WINPR_ATTR_UNUSED UINT32 FileId, + WINPR_ATTR_UNUSED UINT32 CompletionId) { UINT32 FsInformationClass = 0; UINT32 Length = 0; @@ -1423,8 +1429,9 @@ static UINT rdpdr_server_receive_io_set_information_request(RdpdrServerContext* } static UINT rdpdr_server_receive_io_query_directory_request(RdpdrServerContext* context, wStream* s, - UINT32 DeviceId, UINT32 FileId, - UINT32 CompletionId) + WINPR_ATTR_UNUSED UINT32 DeviceId, + WINPR_ATTR_UNUSED UINT32 FileId, + WINPR_ATTR_UNUSED UINT32 CompletionId) { BYTE InitialQuery = 0; UINT32 FsInformationClass = 0; @@ -1455,8 +1462,10 @@ static UINT rdpdr_server_receive_io_query_directory_request(RdpdrServerContext* } static UINT rdpdr_server_receive_io_change_directory_request(RdpdrServerContext* context, - wStream* s, UINT32 DeviceId, - UINT32 FileId, UINT32 CompletionId) + wStream* s, + WINPR_ATTR_UNUSED UINT32 DeviceId, + WINPR_ATTR_UNUSED UINT32 FileId, + WINPR_ATTR_UNUSED UINT32 CompletionId) { BYTE WatchTree = 0; UINT32 CompletionFilter = 0; @@ -1505,8 +1514,9 @@ static UINT rdpdr_server_receive_io_directory_control_request(RdpdrServerContext } static UINT rdpdr_server_receive_io_lock_control_request(RdpdrServerContext* context, wStream* s, - UINT32 DeviceId, UINT32 FileId, - UINT32 CompletionId) + WINPR_ATTR_UNUSED UINT32 DeviceId, + WINPR_ATTR_UNUSED UINT32 FileId, + WINPR_ATTR_UNUSED UINT32 CompletionId) { UINT32 Operation = 0; UINT32 Lock = 0; @@ -1548,7 +1558,7 @@ static UINT rdpdr_server_receive_io_lock_control_request(RdpdrServerContext* con } static UINT rdpdr_server_receive_device_io_request(RdpdrServerContext* context, wStream* s, - const RDPDR_HEADER* header) + WINPR_ATTR_UNUSED const RDPDR_HEADER* header) { UINT32 DeviceId = 0; UINT32 FileId = 0; @@ -1820,8 +1830,9 @@ static UINT rdpdr_server_receive_prn_cache_rename_cachedata(RdpdrServerContext* return CHANNEL_RC_OK; } -static UINT rdpdr_server_receive_prn_cache_data_request(RdpdrServerContext* context, wStream* s, - const RDPDR_HEADER* header) +static UINT +rdpdr_server_receive_prn_cache_data_request(RdpdrServerContext* context, wStream* s, + WINPR_ATTR_UNUSED const RDPDR_HEADER* header) { UINT32 EventId = 0; @@ -1851,7 +1862,7 @@ static UINT rdpdr_server_receive_prn_cache_data_request(RdpdrServerContext* cont } static UINT rdpdr_server_receive_prn_using_xps_request(RdpdrServerContext* context, wStream* s, - const RDPDR_HEADER* header) + WINPR_ATTR_UNUSED const RDPDR_HEADER* header) { UINT32 PrinterId = 0; UINT32 Flags = 0; diff --git a/channels/rdpecam/client/camera_device_enum_main.c b/channels/rdpecam/client/camera_device_enum_main.c index b60522169..4c8f061af 100644 --- a/channels/rdpecam/client/camera_device_enum_main.c +++ b/channels/rdpecam/client/camera_device_enum_main.c @@ -78,8 +78,8 @@ UINT ecam_channel_send_generic_msg(CameraPlugin* ecam, GENERIC_CHANNEL_CALLBACK* * * @return 0 on success, otherwise a Win32 error code */ -UINT ecam_channel_write(CameraPlugin* ecam, GENERIC_CHANNEL_CALLBACK* hchannel, CAM_MSG_ID msg, - wStream* out, BOOL freeStream) +UINT ecam_channel_write(WINPR_ATTR_UNUSED CameraPlugin* ecam, GENERIC_CHANNEL_CALLBACK* hchannel, + CAM_MSG_ID msg, wStream* out, BOOL freeStream) { if (!hchannel || !out) return ERROR_INVALID_PARAMETER; @@ -180,8 +180,8 @@ static UINT ecam_enumerate_devices(CameraPlugin* ecam, GENERIC_CHANNEL_CALLBACK* * @return 0 on success, otherwise a Win32 error code */ static UINT ecam_process_select_version_response(CameraPlugin* ecam, - GENERIC_CHANNEL_CALLBACK* hchannel, wStream* s, - BYTE serverVersion) + GENERIC_CHANNEL_CALLBACK* hchannel, + WINPR_ATTR_UNUSED wStream* s, BYTE serverVersion) { const BYTE clientVersion = ECAM_PROTO_VERSION; @@ -289,7 +289,9 @@ static UINT ecam_on_close(IWTSVirtualChannelCallback* pChannelCallback) * @return 0 on success, otherwise a Win32 error code */ static UINT ecam_on_new_channel_connection(IWTSListenerCallback* pListenerCallback, - IWTSVirtualChannel* pChannel, BYTE* Data, BOOL* pbAccept, + IWTSVirtualChannel* pChannel, + WINPR_ATTR_UNUSED BYTE* Data, + WINPR_ATTR_UNUSED BOOL* pbAccept, IWTSVirtualChannelCallback** ppCallback) { GENERIC_LISTENER_CALLBACK* hlistener = (GENERIC_LISTENER_CALLBACK*)pListenerCallback; diff --git a/channels/rdpecam/client/camera_device_main.c b/channels/rdpecam/client/camera_device_main.c index 5c6dbb7fd..463214b41 100644 --- a/channels/rdpecam/client/camera_device_main.c +++ b/channels/rdpecam/client/camera_device_main.c @@ -289,7 +289,8 @@ static UINT ecam_dev_process_start_streams_request(CameraDevice* dev, * @return 0 on success, otherwise a Win32 error code */ static UINT ecam_dev_process_property_list_request(CameraDevice* dev, - GENERIC_CHANNEL_CALLBACK* hchannel, wStream* s) + GENERIC_CHANNEL_CALLBACK* hchannel, + WINPR_ATTR_UNUSED wStream* s) { WINPR_ASSERT(dev); // TODO: supported properties implementation @@ -538,7 +539,8 @@ static UINT ecam_dev_send_stream_list_response(CameraDevice* dev, * @return 0 on success, otherwise a Win32 error code */ static UINT ecam_dev_process_stream_list_request(CameraDevice* dev, - GENERIC_CHANNEL_CALLBACK* hchannel, wStream* s) + GENERIC_CHANNEL_CALLBACK* hchannel, + WINPR_ATTR_UNUSED wStream* s) { return ecam_dev_send_stream_list_response(dev, hchannel); } @@ -549,7 +551,8 @@ static UINT ecam_dev_process_stream_list_request(CameraDevice* dev, * @return 0 on success, otherwise a Win32 error code */ static UINT ecam_dev_process_activate_device_request(CameraDevice* dev, - GENERIC_CHANNEL_CALLBACK* hchannel, wStream* s) + GENERIC_CHANNEL_CALLBACK* hchannel, + WINPR_ATTR_UNUSED wStream* s) { WINPR_ASSERT(dev); @@ -657,7 +660,7 @@ static UINT ecam_dev_on_data_received(IWTSVirtualChannelCallback* pChannelCallba * * @return 0 on success, otherwise a Win32 error code */ -static UINT ecam_dev_on_open(IWTSVirtualChannelCallback* pChannelCallback) +static UINT ecam_dev_on_open(WINPR_ATTR_UNUSED IWTSVirtualChannelCallback* pChannelCallback) { WLog_DBG(TAG, "entered"); return CHANNEL_RC_OK; @@ -693,8 +696,9 @@ static UINT ecam_dev_on_close(IWTSVirtualChannelCallback* pChannelCallback) * @return 0 on success, otherwise a Win32 error code */ static UINT ecam_dev_on_new_channel_connection(IWTSListenerCallback* pListenerCallback, - IWTSVirtualChannel* pChannel, BYTE* Data, - BOOL* pbAccept, + IWTSVirtualChannel* pChannel, + WINPR_ATTR_UNUSED BYTE* Data, + WINPR_ATTR_UNUSED BOOL* pbAccept, IWTSVirtualChannelCallback** ppCallback) { GENERIC_LISTENER_CALLBACK* hlistener = (GENERIC_LISTENER_CALLBACK*)pListenerCallback; @@ -727,7 +731,8 @@ static UINT ecam_dev_on_new_channel_connection(IWTSListenerCallback* pListenerCa * * @return CameraDevice pointer or NULL in case of error */ -CameraDevice* ecam_dev_create(CameraPlugin* ecam, const char* deviceId, const char* deviceName) +CameraDevice* ecam_dev_create(CameraPlugin* ecam, const char* deviceId, + WINPR_ATTR_UNUSED const char* deviceName) { WINPR_ASSERT(ecam); WINPR_ASSERT(ecam->hlistener); diff --git a/channels/rdpecam/client/v4l/camera_v4l.c b/channels/rdpecam/client/v4l/camera_v4l.c index c2b7a6960..d5219d1a5 100644 --- a/channels/rdpecam/client/v4l/camera_v4l.c +++ b/channels/rdpecam/client/v4l/camera_v4l.c @@ -287,8 +287,8 @@ error: * * @return number of video capture devices */ -static UINT cam_v4l_enumerate(ICamHal* ihal, ICamHalEnumCallback callback, CameraPlugin* ecam, - GENERIC_CHANNEL_CALLBACK* hchannel) +static UINT cam_v4l_enumerate(WINPR_ATTR_UNUSED ICamHal* ihal, ICamHalEnumCallback callback, + CameraPlugin* ecam, GENERIC_CHANNEL_CALLBACK* hchannel) { UINT count = 0; @@ -693,7 +693,8 @@ static UINT cam_v4l_stream_start(ICamHal* ihal, CameraDevice* dev, int streamInd * * @return 0 on success, otherwise a Win32 error code */ -static UINT cam_v4l_stream_stop_by_device_id(ICamHal* ihal, const char* deviceId, int streamIndex) +static UINT cam_v4l_stream_stop_by_device_id(ICamHal* ihal, const char* deviceId, + WINPR_ATTR_UNUSED int streamIndex) { CamV4lHal* hal = (CamV4lHal*)ihal; diff --git a/channels/rdpecam/server/camera_device_enumerator_main.c b/channels/rdpecam/server/camera_device_enumerator_main.c index 02c34200d..8b99fac10 100644 --- a/channels/rdpecam/server/camera_device_enumerator_main.c +++ b/channels/rdpecam/server/camera_device_enumerator_main.c @@ -124,7 +124,7 @@ static UINT enumerator_server_open_channel(enumerator_server* enumerator) } static UINT enumerator_server_handle_select_version_request(CamDevEnumServerContext* context, - wStream* s, + WINPR_ATTR_UNUSED wStream* s, const CAM_SHARED_MSG_HEADER* header) { CAM_SELECT_VERSION_REQUEST pdu = { 0 }; diff --git a/channels/rdpecam/server/camera_device_main.c b/channels/rdpecam/server/camera_device_main.c index 3591a382f..0741eb094 100644 --- a/channels/rdpecam/server/camera_device_main.c +++ b/channels/rdpecam/server/camera_device_main.c @@ -123,7 +123,8 @@ static UINT device_server_open_channel(device_server* device) return Error; } -static UINT device_server_handle_success_response(CameraDeviceServerContext* context, wStream* s, +static UINT device_server_handle_success_response(CameraDeviceServerContext* context, + WINPR_ATTR_UNUSED wStream* s, const CAM_SHARED_MSG_HEADER* header) { CAM_SUCCESS_RESPONSE pdu = { 0 }; @@ -747,9 +748,9 @@ static UINT device_server_write_and_send_header(CameraDeviceServerContext* conte return device_server_packet_send(context, s); } -static UINT -device_send_activate_device_request_pdu(CameraDeviceServerContext* context, - const CAM_ACTIVATE_DEVICE_REQUEST* activateDeviceRequest) +static UINT device_send_activate_device_request_pdu( + CameraDeviceServerContext* context, + WINPR_ATTR_UNUSED const CAM_ACTIVATE_DEVICE_REQUEST* activateDeviceRequest) { WINPR_ASSERT(context); @@ -758,15 +759,16 @@ device_send_activate_device_request_pdu(CameraDeviceServerContext* context, static UINT device_send_deactivate_device_request_pdu( CameraDeviceServerContext* context, - const CAM_DEACTIVATE_DEVICE_REQUEST* deactivateDeviceRequest) + WINPR_ATTR_UNUSED const CAM_DEACTIVATE_DEVICE_REQUEST* deactivateDeviceRequest) { WINPR_ASSERT(context); return device_server_write_and_send_header(context, CAM_MSG_ID_DeactivateDeviceRequest); } -static UINT device_send_stream_list_request_pdu(CameraDeviceServerContext* context, - const CAM_STREAM_LIST_REQUEST* streamListRequest) +static UINT device_send_stream_list_request_pdu( + CameraDeviceServerContext* context, + WINPR_ATTR_UNUSED const CAM_STREAM_LIST_REQUEST* streamListRequest) { WINPR_ASSERT(context); @@ -843,8 +845,9 @@ device_send_start_streams_request_pdu(CameraDeviceServerContext* context, return device_server_packet_send(context, s); } -static UINT device_send_stop_streams_request_pdu(CameraDeviceServerContext* context, - const CAM_STOP_STREAMS_REQUEST* stopStreamsRequest) +static UINT device_send_stop_streams_request_pdu( + CameraDeviceServerContext* context, + WINPR_ATTR_UNUSED const CAM_STOP_STREAMS_REQUEST* stopStreamsRequest) { WINPR_ASSERT(context); @@ -868,9 +871,9 @@ static UINT device_send_sample_request_pdu(CameraDeviceServerContext* context, return device_server_packet_send(context, s); } -static UINT -device_send_property_list_request_pdu(CameraDeviceServerContext* context, - const CAM_PROPERTY_LIST_REQUEST* propertyListRequest) +static UINT device_send_property_list_request_pdu( + CameraDeviceServerContext* context, + WINPR_ATTR_UNUSED const CAM_PROPERTY_LIST_REQUEST* propertyListRequest) { WINPR_ASSERT(context); diff --git a/channels/rdpgfx/client/rdpgfx_codec.c b/channels/rdpgfx/client/rdpgfx_codec.c index b08aa0149..7d2a2d99e 100644 --- a/channels/rdpgfx/client/rdpgfx_codec.c +++ b/channels/rdpgfx/client/rdpgfx_codec.c @@ -37,7 +37,8 @@ * * @return 0 on success, otherwise a Win32 error code */ -static UINT rdpgfx_read_h264_metablock(RDPGFX_PLUGIN* gfx, wStream* s, RDPGFX_H264_METABLOCK* meta) +static UINT rdpgfx_read_h264_metablock(WINPR_ATTR_UNUSED RDPGFX_PLUGIN* gfx, wStream* s, + RDPGFX_H264_METABLOCK* meta) { RECTANGLE_16* regionRect = NULL; RDPGFX_H264_QUANT_QUALITY* quantQualityVal = NULL; diff --git a/channels/rdpgfx/client/rdpgfx_main.c b/channels/rdpgfx/client/rdpgfx_main.c index 553a2fc0e..ea0b6eb62 100644 --- a/channels/rdpgfx/client/rdpgfx_main.c +++ b/channels/rdpgfx/client/rdpgfx_main.c @@ -2341,7 +2341,8 @@ static void* rdpgfx_get_cache_slot_data(RdpgfxClientContext* context, UINT16 cac return pData; } -static UINT init_plugin_cb(GENERIC_DYNVC_PLUGIN* base, rdpContext* rcontext, rdpSettings* settings) +static UINT init_plugin_cb(GENERIC_DYNVC_PLUGIN* base, rdpContext* rcontext, + WINPR_ATTR_UNUSED rdpSettings* settings) { RdpgfxClientContext* context = NULL; RDPGFX_PLUGIN* gfx = (RDPGFX_PLUGIN*)base; diff --git a/channels/rdpsnd/client/alsa/rdpsnd_alsa.c b/channels/rdpsnd/client/alsa/rdpsnd_alsa.c index 003dcab87..142065228 100644 --- a/channels/rdpsnd/client/alsa/rdpsnd_alsa.c +++ b/channels/rdpsnd/client/alsa/rdpsnd_alsa.c @@ -326,7 +326,8 @@ static void rdpsnd_alsa_free(rdpsndDevicePlugin* device) free(alsa); } -static BOOL rdpsnd_alsa_format_supported(rdpsndDevicePlugin* device, const AUDIO_FORMAT* format) +static BOOL rdpsnd_alsa_format_supported(WINPR_ATTR_UNUSED rdpsndDevicePlugin* device, + const AUDIO_FORMAT* format) { switch (format->wFormatTag) { diff --git a/channels/rdpsnd/client/fake/rdpsnd_fake.c b/channels/rdpsnd/client/fake/rdpsnd_fake.c index 9e06f4c11..803ee9544 100644 --- a/channels/rdpsnd/client/fake/rdpsnd_fake.c +++ b/channels/rdpsnd/client/fake/rdpsnd_fake.c @@ -38,16 +38,19 @@ typedef struct rdpsndDevicePlugin device; } rdpsndFakePlugin; -static BOOL rdpsnd_fake_open(rdpsndDevicePlugin* device, const AUDIO_FORMAT* format, UINT32 latency) +static BOOL rdpsnd_fake_open(WINPR_ATTR_UNUSED rdpsndDevicePlugin* device, + WINPR_ATTR_UNUSED const AUDIO_FORMAT* format, + WINPR_ATTR_UNUSED UINT32 latency) { return TRUE; } -static void rdpsnd_fake_close(rdpsndDevicePlugin* device) +static void rdpsnd_fake_close(WINPR_ATTR_UNUSED rdpsndDevicePlugin* device) { } -static BOOL rdpsnd_fake_set_volume(rdpsndDevicePlugin* device, UINT32 value) +static BOOL rdpsnd_fake_set_volume(WINPR_ATTR_UNUSED rdpsndDevicePlugin* device, + WINPR_ATTR_UNUSED UINT32 value) { return TRUE; } @@ -62,12 +65,14 @@ static void rdpsnd_fake_free(rdpsndDevicePlugin* device) free(fake); } -static BOOL rdpsnd_fake_format_supported(rdpsndDevicePlugin* device, const AUDIO_FORMAT* format) +static BOOL rdpsnd_fake_format_supported(WINPR_ATTR_UNUSED rdpsndDevicePlugin* device, + WINPR_ATTR_UNUSED const AUDIO_FORMAT* format) { return TRUE; } -static UINT rdpsnd_fake_play(rdpsndDevicePlugin* device, const BYTE* data, size_t size) +static UINT rdpsnd_fake_play(WINPR_ATTR_UNUSED rdpsndDevicePlugin* device, + WINPR_ATTR_UNUSED const BYTE* data, WINPR_ATTR_UNUSED size_t size) { return CHANNEL_RC_OK; } diff --git a/channels/rdpsnd/client/pulse/rdpsnd_pulse.c b/channels/rdpsnd/client/pulse/rdpsnd_pulse.c index e3591cb65..8c22d5ed9 100644 --- a/channels/rdpsnd/client/pulse/rdpsnd_pulse.c +++ b/channels/rdpsnd/client/pulse/rdpsnd_pulse.c @@ -87,8 +87,8 @@ static BOOL rdpsnd_check_pulse(rdpsndPulsePlugin* pulse, BOOL haveStream) static BOOL rdpsnd_pulse_format_supported(rdpsndDevicePlugin* device, const AUDIO_FORMAT* format); -static void rdpsnd_pulse_get_sink_info(pa_context* c, const pa_sink_info* i, int eol, - void* userdata) +static void rdpsnd_pulse_get_sink_info(pa_context* c, const pa_sink_info* i, + WINPR_ATTR_UNUSED int eol, void* userdata) { UINT16 dwVolumeLeft = ((50 * 0xFFFF) / 100); /* 50% */ UINT16 dwVolumeRight = ((50 * 0xFFFF) / 100); /* 50% */ @@ -208,7 +208,8 @@ static BOOL rdpsnd_pulse_connect(rdpsndDevicePlugin* device) return rc; } -static void rdpsnd_pulse_stream_success_callback(pa_stream* stream, int success, void* userdata) +static void rdpsnd_pulse_stream_success_callback(WINPR_ATTR_UNUSED pa_stream* stream, + WINPR_ATTR_UNUSED int success, void* userdata) { rdpsndPulsePlugin* pulse = (rdpsndPulsePlugin*)userdata; @@ -262,7 +263,8 @@ static void rdpsnd_pulse_stream_state_callback(pa_stream* stream, void* userdata } } -static void rdpsnd_pulse_stream_request_callback(pa_stream* stream, size_t length, void* userdata) +static void rdpsnd_pulse_stream_request_callback(pa_stream* stream, WINPR_ATTR_UNUSED size_t length, + void* userdata) { rdpsndPulsePlugin* pulse = (rdpsndPulsePlugin*)userdata; diff --git a/channels/remdesk/client/remdesk_main.c b/channels/remdesk/client/remdesk_main.c index 8cfb27027..62f27bfce 100644 --- a/channels/remdesk/client/remdesk_main.c +++ b/channels/remdesk/client/remdesk_main.c @@ -135,13 +135,15 @@ static UINT remdesk_generate_expert_blob(remdeskPlugin* remdesk) * * @return 0 on success, otherwise a Win32 error code */ -static UINT remdesk_recv_ctl_server_announce_pdu(remdeskPlugin* remdesk, wStream* s, - REMDESK_CHANNEL_HEADER* header) +static UINT remdesk_recv_ctl_server_announce_pdu(WINPR_ATTR_UNUSED remdeskPlugin* remdesk, + WINPR_ATTR_UNUSED wStream* s, + WINPR_ATTR_UNUSED REMDESK_CHANNEL_HEADER* header) { WINPR_ASSERT(remdesk); WINPR_ASSERT(s); WINPR_ASSERT(header); + WLog_ERR("TODO", "TODO: implement"); return CHANNEL_RC_OK; } @@ -151,7 +153,7 @@ static UINT remdesk_recv_ctl_server_announce_pdu(remdeskPlugin* remdesk, wStream * @return 0 on success, otherwise a Win32 error code */ static UINT remdesk_recv_ctl_version_info_pdu(remdeskPlugin* remdesk, wStream* s, - REMDESK_CHANNEL_HEADER* header) + WINPR_ATTR_UNUSED REMDESK_CHANNEL_HEADER* header) { UINT32 versionMajor = 0; UINT32 versionMinor = 0; @@ -222,8 +224,9 @@ static UINT remdesk_send_ctl_version_info_pdu(remdeskPlugin* remdesk) * * @return 0 on success, otherwise a Win32 error code */ -static UINT remdesk_recv_ctl_result_pdu(remdeskPlugin* remdesk, wStream* s, - REMDESK_CHANNEL_HEADER* header, UINT32* pResult) +static UINT remdesk_recv_ctl_result_pdu(WINPR_ATTR_UNUSED remdeskPlugin* remdesk, wStream* s, + WINPR_ATTR_UNUSED REMDESK_CHANNEL_HEADER* header, + UINT32* pResult) { UINT32 result = 0; @@ -666,9 +669,10 @@ static UINT remdesk_process_receive(remdeskPlugin* remdesk, wStream* s) return status; } -static void remdesk_process_connect(remdeskPlugin* remdesk) +static void remdesk_process_connect(WINPR_ATTR_UNUSED remdeskPlugin* remdesk) { WINPR_ASSERT(remdesk); + WLog_ERR("TODO", "TODO: implement"); } /** @@ -843,8 +847,9 @@ static DWORD WINAPI remdesk_virtual_channel_client_thread(LPVOID arg) * * @return 0 on success, otherwise a Win32 error code */ -static UINT remdesk_virtual_channel_event_connected(remdeskPlugin* remdesk, LPVOID pData, - UINT32 dataLength) +static UINT remdesk_virtual_channel_event_connected(remdeskPlugin* remdesk, + WINPR_ATTR_UNUSED LPVOID pData, + WINPR_ATTR_UNUSED UINT32 dataLength) { UINT error = 0; diff --git a/channels/remdesk/server/remdesk_main.c b/channels/remdesk/server/remdesk_main.c index 82ef3663e..b843d1249 100644 --- a/channels/remdesk/server/remdesk_main.c +++ b/channels/remdesk/server/remdesk_main.c @@ -138,8 +138,9 @@ out: * * @return 0 on success, otherwise a Win32 error code */ -static UINT remdesk_recv_ctl_version_info_pdu(RemdeskServerContext* context, wStream* s, - REMDESK_CHANNEL_HEADER* header) +static UINT remdesk_recv_ctl_version_info_pdu(WINPR_ATTR_UNUSED RemdeskServerContext* context, + wStream* s, + WINPR_ATTR_UNUSED REMDESK_CHANNEL_HEADER* header) { UINT32 versionMajor = 0; UINT32 versionMinor = 0; @@ -204,8 +205,8 @@ static UINT remdesk_recv_ctl_remote_control_desktop_pdu(RemdeskServerContext* co * * @return 0 on success, otherwise a Win32 error code */ -static UINT remdesk_recv_ctl_authenticate_pdu(RemdeskServerContext* context, wStream* s, - REMDESK_CHANNEL_HEADER* header) +static UINT remdesk_recv_ctl_authenticate_pdu(WINPR_ATTR_UNUSED RemdeskServerContext* context, + wStream* s, REMDESK_CHANNEL_HEADER* header) { size_t cchTmpStringW = 0; const WCHAR* expertBlobW = NULL; diff --git a/channels/urbdrc/client/data_transfer.c b/channels/urbdrc/client/data_transfer.c index 5a04ffce2..e4c4c2a3a 100644 --- a/channels/urbdrc/client/data_transfer.c +++ b/channels/urbdrc/client/data_transfer.c @@ -51,9 +51,10 @@ static void usb_process_get_port_status(IUDEVICE* pdev, wStream* out) } } -static UINT urb_write_completion(IUDEVICE* pdev, GENERIC_CHANNEL_CALLBACK* callback, BOOL noAck, - wStream* out, UINT32 InterfaceId, UINT32 MessageId, - UINT32 RequestId, UINT32 usbd_status, UINT32 OutputBufferSize) +static UINT urb_write_completion(WINPR_ATTR_UNUSED IUDEVICE* pdev, + GENERIC_CHANNEL_CALLBACK* callback, BOOL noAck, wStream* out, + UINT32 InterfaceId, UINT32 MessageId, UINT32 RequestId, + UINT32 usbd_status, UINT32 OutputBufferSize) { if (!out) return ERROR_INVALID_PARAMETER; @@ -176,7 +177,8 @@ static UINT urbdrc_process_cancel_request(IUDEVICE* pdev, wStream* s, IUDEVMAN* return ERROR_SUCCESS; } -static UINT urbdrc_process_retract_device_request(IUDEVICE* pdev, wStream* s, IUDEVMAN* udevman) +static UINT urbdrc_process_retract_device_request(WINPR_ATTR_UNUSED IUDEVICE* pdev, wStream* s, + IUDEVMAN* udevman) { UINT32 Reason = 0; URBDRC_PLUGIN* urbdrc = NULL; @@ -727,8 +729,9 @@ static UINT urb_control_transfer(IUDEVICE* pdev, GENERIC_CHANNEL_CALLBACK* callb static void urb_bulk_transfer_cb(IUDEVICE* pdev, GENERIC_CHANNEL_CALLBACK* callback, wStream* out, UINT32 InterfaceId, BOOL noAck, UINT32 MessageId, UINT32 RequestId, - UINT32 NumberOfPackets, UINT32 status, UINT32 StartFrame, - UINT32 ErrorCount, UINT32 OutputBufferSize) + WINPR_ATTR_UNUSED UINT32 NumberOfPackets, UINT32 status, + WINPR_ATTR_UNUSED UINT32 StartFrame, + WINPR_ATTR_UNUSED UINT32 ErrorCount, UINT32 OutputBufferSize) { if (!pdev->isChannelClosed(pdev)) urb_write_completion(pdev, callback, noAck, out, InterfaceId, MessageId, RequestId, status, @@ -776,7 +779,8 @@ static UINT urb_bulk_or_interrupt_transfer(IUDEVICE* pdev, GENERIC_CHANNEL_CALLB return (uint32_t)rc; } -static void urb_isoch_transfer_cb(IUDEVICE* pdev, GENERIC_CHANNEL_CALLBACK* callback, wStream* out, +static void urb_isoch_transfer_cb(WINPR_ATTR_UNUSED IUDEVICE* pdev, + GENERIC_CHANNEL_CALLBACK* callback, wStream* out, UINT32 InterfaceId, BOOL noAck, UINT32 MessageId, UINT32 RequestId, UINT32 NumberOfPackets, UINT32 status, UINT32 StartFrame, UINT32 ErrorCount, UINT32 OutputBufferSize) diff --git a/channels/urbdrc/client/libusb/libusb_udevice.c b/channels/urbdrc/client/libusb/libusb_udevice.c index b153a22b7..923da31a9 100644 --- a/channels/urbdrc/client/libusb/libusb_udevice.c +++ b/channels/urbdrc/client/libusb/libusb_udevice.c @@ -787,7 +787,7 @@ static int libusb_udev_select_configuration(IUDEVICE* idev, UINT32 bConfiguratio return 0; } -static int libusb_udev_control_pipe_request(IUDEVICE* idev, UINT32 RequestId, +static int libusb_udev_control_pipe_request(IUDEVICE* idev, WINPR_ATTR_UNUSED UINT32 RequestId, UINT32 EndpointAddress, UINT32* UsbdStatus, int command) { int error = 0; @@ -931,7 +931,8 @@ static UINT32 libusb_udev_control_query_device_text(IUDEVICE* idev, UINT32 TextT return S_OK; } -static int libusb_udev_os_feature_descriptor_request(IUDEVICE* idev, UINT32 RequestId, +static int libusb_udev_os_feature_descriptor_request(IUDEVICE* idev, + WINPR_ATTR_UNUSED UINT32 RequestId, BYTE Recipient, BYTE InterfaceNumber, BYTE Ms_PageIndex, UINT16 Ms_featureDescIndex, UINT32* UsbdStatus, UINT32* BufferSize, @@ -1221,8 +1222,9 @@ static int libusb_udev_query_device_port_status(IUDEVICE* idev, UINT32* UsbdStat static int libusb_udev_isoch_transfer(IUDEVICE* idev, GENERIC_CHANNEL_CALLBACK* callback, UINT32 MessageId, UINT32 RequestId, UINT32 EndpointAddress, - UINT32 TransferFlags, UINT32 StartFrame, UINT32 ErrorCount, - BOOL NoAck, const BYTE* packetDescriptorData, + WINPR_ATTR_UNUSED UINT32 TransferFlags, UINT32 StartFrame, + UINT32 ErrorCount, BOOL NoAck, + WINPR_ATTR_UNUSED const BYTE* packetDescriptorData, UINT32 NumberOfPackets, UINT32 BufferSize, const BYTE* Buffer, t_isoch_transfer_cb cb, UINT32 Timeout) { @@ -1289,10 +1291,12 @@ static int libusb_udev_isoch_transfer(IUDEVICE* idev, GENERIC_CHANNEL_CALLBACK* return rc; } -static BOOL libusb_udev_control_transfer(IUDEVICE* idev, UINT32 RequestId, UINT32 EndpointAddress, - UINT32 TransferFlags, BYTE bmRequestType, BYTE Request, - UINT16 Value, UINT16 Index, UINT32* UrbdStatus, - UINT32* BufferSize, BYTE* Buffer, UINT32 Timeout) +static BOOL libusb_udev_control_transfer(IUDEVICE* idev, WINPR_ATTR_UNUSED UINT32 RequestId, + WINPR_ATTR_UNUSED UINT32 EndpointAddress, + WINPR_ATTR_UNUSED UINT32 TransferFlags, BYTE bmRequestType, + BYTE Request, UINT16 Value, UINT16 Index, + UINT32* UrbdStatus, UINT32* BufferSize, BYTE* Buffer, + UINT32 Timeout) { int status = 0; UDEVICE* pdev = (UDEVICE*)idev; @@ -1644,7 +1648,7 @@ static int udev_get_device_handle(URBDRC_PLUGIN* urbdrc, libusb_context* ctx, UD } static int udev_get_hub_handle(URBDRC_PLUGIN* urbdrc, libusb_context* ctx, UDEVICE* pdev, - UINT16 bus_number, UINT16 dev_number) + UINT16 bus_number, WINPR_ATTR_UNUSED UINT16 dev_number) { int error = -1; LIBUSB_DEVICE** libusb_list = NULL; diff --git a/channels/urbdrc/client/urbdrc_main.c b/channels/urbdrc/client/urbdrc_main.c index d03c2a557..ffd539fe0 100644 --- a/channels/urbdrc/client/urbdrc_main.c +++ b/channels/urbdrc/client/urbdrc_main.c @@ -444,7 +444,8 @@ static BOOL urbdrc_announce_devices(IUDEVMAN* udevman) return error == ERROR_SUCCESS; } -static UINT urbdrc_device_control_channel(GENERIC_CHANNEL_CALLBACK* callback, wStream* s) +static UINT urbdrc_device_control_channel(GENERIC_CHANNEL_CALLBACK* callback, + WINPR_ATTR_UNUSED wStream* s) { URBDRC_PLUGIN* urbdrc = (URBDRC_PLUGIN*)callback->plugin; IUDEVMAN* udevman = urbdrc->udevman; @@ -647,8 +648,9 @@ static UINT urbdrc_on_close(IWTSVirtualChannelCallback* pChannelCallback) * @return 0 on success, otherwise a Win32 error code */ static UINT urbdrc_on_new_channel_connection(IWTSListenerCallback* pListenerCallback, - IWTSVirtualChannel* pChannel, BYTE* pData, - BOOL* pbAccept, + IWTSVirtualChannel* pChannel, + WINPR_ATTR_UNUSED BYTE* pData, + WINPR_ATTR_UNUSED BOOL* pbAccept, IWTSVirtualChannelCallback** ppCallback) { GENERIC_LISTENER_CALLBACK* listener_callback = (GENERIC_LISTENER_CALLBACK*)pListenerCallback; diff --git a/channels/urbdrc/common/urbdrc_helpers.c b/channels/urbdrc/common/urbdrc_helpers.c index 9d6bb2431..290b5c56f 100644 --- a/channels/urbdrc/common/urbdrc_helpers.c +++ b/channels/urbdrc/common/urbdrc_helpers.c @@ -195,7 +195,9 @@ static const char* call_to_string_proxy(BOOL client, UINT32 interfaceId, UINT32 } } -static const char* call_to_string_stub(BOOL client, UINT32 interfaceNr, UINT32 functionId) +static const char* call_to_string_stub(WINPR_ATTR_UNUSED BOOL client, + WINPR_ATTR_UNUSED UINT32 interfaceNr, + WINPR_ATTR_UNUSED UINT32 functionId) { return "QUERY_DEVICE_TEXT_RSP [stub |client]"; }