morgan/FreeRDP
1
0
Fork 0
mirror of https://github.com/morgan9e/FreeRDP synced 2026-04-15 00:44:19 +09:00
Code Issues Packages Projects Releases Wiki Activity

[channels,drive] fix missing return checks

Browse Source
This commit is contained in:
Armin Novak
2026-03-03 12:40:07 +01:00
parent 1220c7af1c
commit 1fb02134e6
1 changed files with 25 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
channels/drive/client/drive_main.c
View File

@@ -256,7 +256,7 @@ static UINT drive_process_irp_close(DRIVE_DEVICE* drive, IRP* irp)
irp->IoStatus = STATUS_UNSUCCESSFUL; irp->IoStatus = STATUS_UNSUCCESSFUL;
else else
{ {
ListDictionary_Take(drive->files, key); ListDictionary_Remove(drive->files, key);
if (drive_file_free(file)) if (drive_file_free(file))
irp->IoStatus = STATUS_SUCCESS; irp->IoStatus = STATUS_SUCCESS;
@@ -470,8 +470,18 @@ static UINT drive_process_irp_query_volume_information(DRIVE_DEVICE* drive, IRP*
return ERROR_INVALID_DATA; return ERROR_INVALID_DATA;
Stream_Read_UINT32(irp->input, FsInformationClass); Stream_Read_UINT32(irp->input, FsInformationClass);
GetDiskFreeSpaceW(drive->path, &lpSectorsPerCluster, &lpBytesPerSector, &lpNumberOfFreeClusters, if (!GetDiskFreeSpaceW(drive->path, &lpSectorsPerCluster, &lpBytesPerSector,
&lpTotalNumberOfClusters); &lpNumberOfFreeClusters, &lpTotalNumberOfClusters))
{
const UINT32 err = GetLastError();
const HRESULT herr = HRESULT_FROM_WIN32(err);
WLog_WARN(TAG, "GetDiskFreeSpaceW failed: %s [%" PRId32 "], win32=%s [%" PRIu32 "]",
NtStatus2Tag(herr), herr, Win32ErrorCode2Tag(err & 0xFFFF), err);
lpSectorsPerCluster = 0;
lpBytesPerSector = 0;
lpNumberOfFreeClusters = 0;
lpTotalNumberOfClusters = 0;
}
switch (FsInformationClass) switch (FsInformationClass)
{ {
@@ -493,7 +503,18 @@ static UINT drive_process_irp_query_volume_information(DRIVE_DEVICE* drive, IRP*
return CHANNEL_RC_NO_MEMORY; return CHANNEL_RC_NO_MEMORY;
} }
GetFileAttributesExW(drive->path, GetFileExInfoStandard, &wfad); if (!GetFileAttributesExW(drive->path, GetFileExInfoStandard, &wfad))
{
const UINT32 err = GetLastError();
const HRESULT herr = HRESULT_FROM_WIN32(err);
WLog_WARN(TAG,
"GetFileAttributesExW failed: %s [%" PRId32 "], win32=%s [%" PRIu32 "]",
NtStatus2Tag(herr), herr, Win32ErrorCode2Tag(err & 0xFFFF), err);
const WIN32_FILE_ATTRIBUTE_DATA empty = WINPR_C_ARRAY_INIT;
wfad = empty;
}
Stream_Write_UINT32(output, wfad.ftCreationTime.dwLowDateTime); /* VolumeCreationTime */ Stream_Write_UINT32(output, wfad.ftCreationTime.dwLowDateTime); /* VolumeCreationTime */
Stream_Write_UINT32(output, Stream_Write_UINT32(output,
wfad.ftCreationTime.dwHighDateTime); /* VolumeCreationTime */ wfad.ftCreationTime.dwHighDateTime); /* VolumeCreationTime */