From 60ed73552ffdb499dddf06c119be9437da7f9261 Mon Sep 17 00:00:00 2001 From: akallabeth Date: Sun, 29 Dec 2024 10:22:56 +0100 Subject: [PATCH 1/2] [core,connection] print SSL warnings after init --- libfreerdp/core/connection.c | 1 + libfreerdp/core/freerdp.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/libfreerdp/core/connection.c b/libfreerdp/core/connection.c index 979ccdf60..001b56944 100644 --- a/libfreerdp/core/connection.c +++ b/libfreerdp/core/connection.c @@ -319,6 +319,7 @@ BOOL rdp_client_connect(rdpRdp* rdp) flags |= WINPR_SSL_INIT_ENABLE_FIPS; winpr_InitializeSSL(flags); + rdp_log_build_warnings(rdp); /* FIPS Mode forces the following and overrides the following(by happening later */ /* in the command line processing): */ diff --git a/libfreerdp/core/freerdp.c b/libfreerdp/core/freerdp.c index 94dad20a0..715da31d9 100644 --- a/libfreerdp/core/freerdp.c +++ b/libfreerdp/core/freerdp.c @@ -802,7 +802,6 @@ BOOL freerdp_context_new_ex(freerdp* instance, rdpSettings* settings) if (!rdp) goto fail; - rdp_log_build_warnings(rdp); context->rdp = rdp; context->pubSub = rdp->pubSub; From 4030eafd152c538dc2fe6b0f63a28c1f048db6c7 Mon Sep 17 00:00:00 2001 From: akallabeth Date: Sun, 29 Dec 2024 10:22:43 +0100 Subject: [PATCH 2/2] [channels,rdpdr] fix stream_write sign --- channels/rdpdr/client/irp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/channels/rdpdr/client/irp.c b/channels/rdpdr/client/irp.c index 554b087e4..eeba80d3e 100644 --- a/channels/rdpdr/client/irp.c +++ b/channels/rdpdr/client/irp.c @@ -74,7 +74,7 @@ static UINT irp_complete(IRP* irp) pos = Stream_GetPosition(irp->output); Stream_SetPosition(irp->output, RDPDR_DEVICE_IO_RESPONSE_LENGTH - 4); - Stream_Write_INT32(irp->output, irp->IoStatus); /* IoStatus (4 bytes) */ + Stream_Write_UINT32(irp->output, irp->IoStatus); /* IoStatus (4 bytes) */ Stream_SetPosition(irp->output, pos); error = rdpdr_send(rdpdr, irp->output);